[GitHub] [kafka] aglicacha commented on pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

2022-10-19 Thread GitBox
aglicacha commented on PR #12729: URL: https://github.com/apache/kafka/pull/12729#issuecomment-1284844573 @soarez Ready to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (KAFKA-14274) Implement fetching logic

2022-10-19 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-14274: -- Assignee: Kirk True > Implement fetching logic > > >

[jira] [Resolved] (KAFKA-14252) Create background thread skeleton

2022-10-19 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-14252. Resolution: Fixed > Create background thread skeleton > - > >

[GitHub] [kafka] vvcephei merged pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-19 Thread GitBox
vvcephei merged PR #12672: URL: https://github.com/apache/kafka/pull/12672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee commented on pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-19 Thread GitBox
philipnee commented on PR #12672: URL: https://github.com/apache/kafka/pull/12672#issuecomment-1284796542 Thanks @vvcephei Will be better at the basic styling requirements in the future... -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-19 Thread GitBox
vvcephei commented on PR #12672: URL: https://github.com/apache/kafka/pull/12672#issuecomment-1284795639 Unrelated test failure: `[Build / JDK 17 and Scala 2.13 /

[jira] [Created] (KAFKA-14324) [CVE-2018-25032] introduced by rocksdbjni:6.29.4.1

2022-10-19 Thread VZhang (Jira)
VZhang created KAFKA-14324: -- Summary: [CVE-2018-25032] introduced by rocksdbjni:6.29.4.1 Key: KAFKA-14324 URL: https://issues.apache.org/jira/browse/KAFKA-14324 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-13435) Static membership protocol should let the leader skip assignment (KIP-814)

2022-10-19 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620653#comment-17620653 ] Travis Bischel commented on KAFKA-13435: KIP-814 doesn't have a solution to KAFKA-12759

[GitHub] [kafka] vvcephei commented on pull request #12672: KAFKA-14247: Consumer background thread base implementation

2022-10-19 Thread GitBox
vvcephei commented on PR #12672: URL: https://github.com/apache/kafka/pull/12672#issuecomment-1284700265 Hey, @philipnee, @guozhangwang isn't available for reviews right now, so I'll pick it up. I reviewed it, and it all looks good to me. I had a large number of code convention

[GitHub] [kafka] kirktrue commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-10-19 Thread GitBox
kirktrue commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r89762 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,44 @@ private ClusterResourceListeners

[GitHub] [kafka] asasvari closed pull request #6040: KAFKA-7691; Encypt-then-MAC Delegation token metadata

2022-10-19 Thread GitBox
asasvari closed pull request #6040: KAFKA-7691; Encypt-then-MAC Delegation token metadata URL: https://github.com/apache/kafka/pull/6040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (KAFKA-14302) Infinite probing rebalance if a changelog topic got emptied

2022-10-19 Thread Damien Gasparina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damien Gasparina updated KAFKA-14302: - Attachment: logs.tar.gz2 > Infinite probing rebalance if a changelog topic got emptied

[jira] [Created] (KAFKA-14323) KRaft broker time based snapshots

2022-10-19 Thread Jira
José Armando García Sancio created KAFKA-14323: -- Summary: KRaft broker time based snapshots Key: KAFKA-14323 URL: https://issues.apache.org/jira/browse/KAFKA-14323 Project: Kafka

[GitHub] [kafka] jsancio merged pull request #12770: MINOR; Add accessor methods to OffsetAndEpoch

2022-10-19 Thread GitBox
jsancio merged PR #12770: URL: https://github.com/apache/kafka/pull/12770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio merged pull request #12767: MINOR: Delete jqwik database

2022-10-19 Thread GitBox
jsancio merged PR #12767: URL: https://github.com/apache/kafka/pull/12767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-10-19 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r999705130 ## raft/src/main/java/org/apache/kafka/raft/OffsetAndEpoch.java: ## @@ -25,6 +25,14 @@ public OffsetAndEpoch(long offset, int epoch) { this.epoch = epoch;

[GitHub] [kafka] jsancio opened a new pull request, #12770: MINOR; Add accessor methods to OffsetAndEpoch

2022-10-19 Thread GitBox
jsancio opened a new pull request, #12770: URL: https://github.com/apache/kafka/pull/12770 Accessor are preferred over fields because they compose better with Java's lambda syntax. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[GitHub] [kafka] jsancio commented on a diff in pull request #12761: KAFKA-14307; Controller time-based snapshots

2022-10-19 Thread GitBox
jsancio commented on code in PR #12761: URL: https://github.com/apache/kafka/pull/12761#discussion_r999563515 ## raft/src/main/java/org/apache/kafka/raft/OffsetAndEpoch.java: ## @@ -25,6 +25,14 @@ public OffsetAndEpoch(long offset, int epoch) { this.epoch = epoch;

[jira] [Commented] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

2022-10-19 Thread John Krupka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620385#comment-17620385 ] John Krupka commented on KAFKA-14314: - I'm not sure exactly how your project manages these tickets

[GitHub] [kafka] omkreddy commented on pull request #11579: KAFKA-13518: Update gson dependency

2022-10-19 Thread GitBox
omkreddy commented on PR #11579: URL: https://github.com/apache/kafka/pull/11579#issuecomment-1284088323 @dongjinleekr I have not seen this PR. I have raised draft PR https://github.com/apache/kafka/pull/12768 to upgrade spotbugs. Can we update to spotbugs 4.7.3? -- This is an automated

[jira] [Commented] (KAFKA-13467) Clients never refresh cached bootstrap IPs

2022-10-19 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620366#comment-17620366 ] Ismael Juma commented on KAFKA-13467: - See KAFKA-3068 an KAFKA-12480. > Clients never refresh

[GitHub] [kafka] ijuma commented on pull request #12768: MINOR: Upgrade spotbugs dependency

2022-10-19 Thread GitBox
ijuma commented on PR #12768: URL: https://github.com/apache/kafka/pull/12768#issuecomment-1284027186 Also see #11579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] cowlike opened a new pull request, #12769: add check for null upstreamTopic and matching unit test

2022-10-19 Thread GitBox
cowlike opened a new pull request, #12769: URL: https://github.com/apache/kafka/pull/12769 This fixes the case where `MirrorSourceConnector.isCycle()` could throw a NullPointerException if the upstreamTopic evaluates as null. The test for this condition creates a dummy `ReplicationPolicy`

[jira] [Updated] (KAFKA-14322) Kafka node eating Disk continuously

2022-10-19 Thread Abhijit Patil (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Patil updated KAFKA-14322: -- Description: We have 2.8.1 Kafka cluster in our Production environment. It has it

[jira] [Created] (KAFKA-14322) Kafka node eating Disk continuously

2022-10-19 Thread Abhijit Patil (Jira)
Abhijit Patil created KAFKA-14322: - Summary: Kafka node eating Disk continuously Key: KAFKA-14322 URL: https://issues.apache.org/jira/browse/KAFKA-14322 Project: Kafka Issue Type: Bug

[GitHub] [kafka] omkreddy opened a new pull request, #12768: MINOR: Upgrade spotbugs dependency

2022-10-19 Thread GitBox
omkreddy opened a new pull request, #12768: URL: https://github.com/apache/kafka/pull/12768 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] cadonna merged pull request #12762: KAFKA-14299: Never transition to UpdateStandby twice

2022-10-19 Thread GitBox
cadonna merged PR #12762: URL: https://github.com/apache/kafka/pull/12762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cadonna commented on pull request #12762: KAFKA-14299: Never transition to UpdateStandby twice

2022-10-19 Thread GitBox
cadonna commented on PR #12762: URL: https://github.com/apache/kafka/pull/12762#issuecomment-1283548280 Build failures are unrelated ``` Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=kraft ``` -- This is

[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription

2022-10-19 Thread GitBox
showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1283533387 @dajac , sorry for delay. It's good for review now. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the