[
https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shivakumar updated KAFKA-13805:
---
Reviewer: Abhishek
> Upgrade vulnerable dependencies march 2022
>
aglicacha commented on PR #12729:
URL: https://github.com/apache/kafka/pull/12729#issuecomment-1299420427
@mimaison @showuon could you review this, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hachikuji merged PR #12810:
URL: https://github.com/apache/kafka/pull/12810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627365#comment-17627365
]
Vincent Jiang commented on KAFKA-14347:
---
Related issue:
Vincent Jiang created KAFKA-14347:
-
Summary: deleted records may be kept unexpectedly when leader
changes while adding a new replica
Key: KAFKA-14347
URL: https://issues.apache.org/jira/browse/KAFKA-14347
philipnee commented on code in PR #12810:
URL: https://github.com/apache/kafka/pull/12810#discussion_r1010923689
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -864,7 +864,6 @@ public void handle(SyncGroupResponse
hachikuji commented on code in PR #12810:
URL: https://github.com/apache/kafka/pull/12810#discussion_r1010899428
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -864,7 +864,6 @@ public void handle(SyncGroupResponse
gharris1727 commented on PR #12806:
URL: https://github.com/apache/kafka/pull/12806#issuecomment-1299120891
@divijvaidya Thanks for pointing me to that PR with a similar flakey test. I
tried applying this bound to the situation in that test and it didn't hold, and
managed to replicate the
[
https://issues.apache.org/jira/browse/KAFKA-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-14346:
---
Assignee: Greg Harris
> Remove static methods from internal Connect APIs for easier
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1299089574
I've updated the PR to not use a custom `SecurityManager`, and drop support
for catching direct calls to `System::exit`.
@divijvaidya @ijuma If you have time, let me know what you
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1298996874
@dajac @showuon thanks for the review. i have addressed the feedback.
the biggest change is to only complete the purgatory when there is a change
in HWM
--
This is an
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1010806354
##
core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala:
##
@@ -1100,6 +1100,64 @@ class ReplicaFetcherThreadTest {
jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1010804179
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation
philipnee opened a new pull request, #12810:
URL: https://github.com/apache/kafka/pull/12810
This is an outdated comment about the metadata request from the old
implementation. The name of the RPC was changed from GroupMetadata to
FindCoordinator, but the comment was not updated.
lucasbru commented on PR #12795:
URL: https://github.com/apache/kafka/pull/12795#issuecomment-1298912142
If that is the case, especially if it takes a long time to init rocksdb,
maybe it would be the br see to initialize the state in the state updater
instead?
Bruno Cadonna
cadonna commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1010735950
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -395,8 +395,10 @@ private void createNewTasks(final Map> activeTasksTo
cadonna commented on code in PR #12795:
URL: https://github.com/apache/kafka/pull/12795#discussion_r1010735950
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -395,8 +395,10 @@ private void createNewTasks(final Map> activeTasksTo
cadonna commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298874505
I also like option 1 best.
I also agree that option 2 somehow breaks backward compatibility but at
least it does not break compilation of user code.
We could move to RocksDB
cadonna merged PR #12771:
URL: https://github.com/apache/kafka/pull/12771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12771:
URL: https://github.com/apache/kafka/pull/12771#issuecomment-1298862747
Build failures are unrelated:
```
Build / JDK 8 and Scala 2.12 /
kafka.network.DynamicConnectionQuotaTest.testDynamicIpConnectionRateQuota()
```
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-14346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627259#comment-17627259
]
Chris Egerton commented on KAFKA-14346:
---
Although the examples in the description are probably the
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1010676688
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -123,91 +134,91 @@ private enum SourceSink {
Chris Egerton created KAFKA-14346:
-
Summary: Remove static methods from internal Connect APIs for
easier testing
Key: KAFKA-14346
URL: https://issues.apache.org/jira/browse/KAFKA-14346
Project: Kafka
mumrah commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1010479679
##
metadata/src/main/java/org/apache/kafka/image/publisher/SnapshotGenerator.java:
##
@@ -0,0 +1,262 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298605281
I need to check how Gradle handles dependencies, but maybe taking a direct
dependency on `zlib 1.2.12` will overwrite the version used by rocksdb?
--
This is an automated message from
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298601942
Hello @cadonna! In my opinion 1 is a clean solution and it is probably
something we can contribute ourselves - I can try doing it in the upcoming
days. I think 2 is similar to 3 in
cadonna commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298534383
@clolov Thank you for the PR!
That seems a tricky one. Actually, we cannot simply remove methods from that
class. It is true that they are not used within our code base. However,
clolov commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1298495188
Hello @ableegoldman! I am tagging you since I saw you are the release
manager for 3.4.0 and this addresses
https://issues.apache.org/jira/browse/KAFKA-14324 which is listed as a blocker
[
https://issues.apache.org/jira/browse/KAFKA-14324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627156#comment-17627156
]
Christo Lolov commented on KAFKA-14324:
---
Hello [~vinsonZhang]! I prepared a pull request for this
[
https://issues.apache.org/jira/browse/KAFKA-14324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-14324:
-
Assignee: Christo Lolov
> [CVE-2018-25032] introduced by rocksdbjni:6.29.4.1
>
clolov opened a new pull request, #12809:
URL: https://github.com/apache/kafka/pull/12809
I upgraded RocksDB from 6.29.4.1 to 7.1.2. In the process some methods in
the Kafka code base could no longer be found. I inspected where they are used
and they were not used anywhere so I deleted
lucasbru commented on PR #12808:
URL: https://github.com/apache/kafka/pull/12808#issuecomment-1298317767
@cadonna Could you have a look, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lucasbru opened a new pull request, #12808:
URL: https://github.com/apache/kafka/pull/12808
The state updater code path introduced allocation and synchronization
overhead by
performing relatively heavy operations in every iteration of the
`StreamThread` loop. This
includes various
divijvaidya commented on PR #12806:
URL: https://github.com/apache/kafka/pull/12806#issuecomment-1298231397
Hey @gharris1727
Since you are familiar with the windowing algorithm for throttling, please
look at https://github.com/apache/kafka/pull/12045 too. You will find
similarities
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1298085160
@C0urante Due to a conflict I rebased this test off of `origin/trunk` and
there was a merge conflict due to the `StandaloneHerderTest` being updated,
just make sure you check the
[
https://issues.apache.org/jira/browse/KAFKA-14337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626972#comment-17626972
]
thanhnd96 commented on KAFKA-14337:
---
thank you [~showuon] !!!
> topic name with "." cannot be created
36 matches
Mail list logo
