showuon commented on PR #12912:
URL: https://github.com/apache/kafka/pull/12912#issuecomment-1330156517
@tinaselenge , thanks for the PR. So, which compiler warnings are you trying
to fix here? Could you add some more info in PR description? Thanks.
--
This is an automated message from th
[
https://issues.apache.org/jira/browse/KAFKA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640417#comment-17640417
]
Luke Chen commented on KAFKA-13560:
---
https://github.com/apache/kafka/pull/11390#discus
[
https://issues.apache.org/jira/browse/KAFKA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-13560:
---
Description:
https://github.com/apache/kafka/pull/11390#discussion_r762366976
https://githu
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1034345639
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -0,0 +1,238 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
showuon commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1034345625
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
satishd commented on PR #11390:
URL: https://github.com/apache/kafka/pull/11390#issuecomment-1330147705
Thanks @junrao for your comments. Addressed most of them, working on a few
of the remaining comments.
--
This is an automated message from the Apache Git Service.
To respond to the mess
satishd commented on PR #11390:
URL: https://github.com/apache/kafka/pull/11390#issuecomment-1330147549
Thanks @divijvaidya for your comments. Addressed them inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
satishd commented on PR #11390:
URL: https://github.com/apache/kafka/pull/11390#issuecomment-1330143560
Thanks @showuon for your latest comments. Addressed them inline, let me know
if you have any comments.
--
This is an automated message from the Apache Git Service.
To respond to the me
satishd commented on PR #11390:
URL: https://github.com/apache/kafka/pull/11390#issuecomment-1330143107
Thanks @junrao for your comments. Addressed most of them, working on a few
of the remaining comments.
--
This is an automated message from the Apache Git Service.
To respond to the mes
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1034340498
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
showuon commented on code in PR #12916:
URL: https://github.com/apache/kafka/pull/12916#discussion_r1034332922
##
clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java:
##
@@ -118,7 +118,6 @@ public static RequestHeader parse(ByteBuffer buffer) {
showuon commented on code in PR #12916:
URL: https://github.com/apache/kafka/pull/12916#discussion_r1034332922
##
clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java:
##
@@ -118,7 +118,6 @@ public static RequestHeader parse(ByteBuffer buffer) {
showuon commented on code in PR #12916:
URL: https://github.com/apache/kafka/pull/12916#discussion_r1034332922
##
clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java:
##
@@ -118,7 +118,6 @@ public static RequestHeader parse(ByteBuffer buffer) {
showuon commented on code in PR #12916:
URL: https://github.com/apache/kafka/pull/12916#discussion_r1034332922
##
clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java:
##
@@ -118,7 +118,6 @@ public static RequestHeader parse(ByteBuffer buffer) {
showuon commented on PR #12916:
URL: https://github.com/apache/kafka/pull/12916#issuecomment-1330131275
@divijvaidya @mimaison , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
showuon commented on code in PR #12916:
URL: https://github.com/apache/kafka/pull/12916#discussion_r1034332922
##
clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java:
##
@@ -118,7 +118,6 @@ public static RequestHeader parse(ByteBuffer buffer) {
showuon opened a new pull request, #12916:
URL: https://github.com/apache/kafka/pull/12916
In https://github.com/apache/kafka/pull/12890/ , we have an improvement for
the ObjectSerializationCache in request/response header, but the header size is
not correct calculated. Fix it and add size
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640344#comment-17640344
]
Luke Chen commented on KAFKA-7739:
--
Thanks for the update and all the work for this feat
[
https://issues.apache.org/jira/browse/KAFKA-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640342#comment-17640342
]
yws commented on KAFKA-14421:
-
[~showuon] well, what a pity...
> OffsetFetchRequest throws
jolshan opened a new pull request, #12915:
URL: https://github.com/apache/kafka/pull/12915
There were a few options here. Originally we should have bumped the client
request version and only sent the response if the client could handle it (since
this protocol is actually gated on IBP and no
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640324#comment-17640324
]
Satish Duggana commented on KAFKA-7739:
---
The plan is to finish major part of this f
[
https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640278#comment-17640278
]
Jeff Kim commented on KAFKA-14379:
--
updated from draft to open PR.
> consumer should
rajinisivaram commented on code in PR #12914:
URL: https://github.com/apache/kafka/pull/12914#discussion_r1034094654
##
clients/src/main/resources/common/message/ConsumerProtocolSubscription.json:
##
@@ -21,7 +21,10 @@
// The current implementation assumes that future version
rajinisivaram opened a new pull request, #12914:
URL: https://github.com/apache/kafka/pull/12914
This PR adds consumer group protocol changes for supporting rack-aware
assignment for consumers. It also enables rack-aware assignment in the range
assignor and sticky assignors so that default
[
https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640271#comment-17640271
]
Mehrdad Karami commented on KAFKA-14415:
Hi [~lbrutschy] can you tell me which
hachikuji commented on code in PR #12910:
URL: https://github.com/apache/kafka/pull/12910#discussion_r1033987364
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -546,9 +546,16 @@ private[group] class GroupMetadata(val groupId: String,
initialState: Gro
[
https://issues.apache.org/jira/browse/KAFKA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14422.
-
Fix Version/s: 3.4.0
3.3.2
3.2.4
Resolution: Fixed
dajac commented on PR #12909:
URL: https://github.com/apache/kafka/pull/12909#issuecomment-1329635006
Merged to trunk, 3.3 and 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dajac commented on code in PR #12910:
URL: https://github.com/apache/kafka/pull/12910#discussion_r1033965897
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -546,9 +546,16 @@ private[group] class GroupMetadata(val groupId: String,
initialState: GroupSt
[
https://issues.apache.org/jira/browse/KAFKA-14303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-14303.
-
Fix Version/s: 3.4.0
3.3.2
Resolution: Fixed
Merged the PR to 3.3 and trunk.
dajac commented on code in PR #12910:
URL: https://github.com/apache/kafka/pull/12910#discussion_r1033962116
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -546,9 +546,16 @@ private[group] class GroupMetadata(val groupId: String,
initialState: GroupSt
dajac merged PR #12909:
URL: https://github.com/apache/kafka/pull/12909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640207#comment-17640207
]
Kirk True commented on KAFKA-7205:
--
[~streamesk] - thanks for the PR! Per [~omkreddy]'s
[
https://issues.apache.org/jira/browse/KAFKA-14393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-14393.
Resolution: Fixed
> Change default size based retention for the cl
jsancio merged PR #12884:
URL: https://github.com/apache/kafka/pull/12884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jsancio commented on PR #12884:
URL: https://github.com/apache/kafka/pull/12884#issuecomment-1329572351
Unrelated test failures. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
hachikuji commented on code in PR #12910:
URL: https://github.com/apache/kafka/pull/12910#discussion_r1033867871
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -546,9 +546,16 @@ private[group] class GroupMetadata(val groupId: String,
initialState: Gro
[
https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640158#comment-17640158
]
Jeff Kim commented on KAFKA-14379:
--
[~showuon] yes, that is the current plan. can you s
jeffkbkim commented on code in PR #12897:
URL: https://github.com/apache/kafka/pull/12897#discussion_r1033847041
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -5157,11 +5225,6 @@ private void buildFetcher(MetricConfig
metricConfig
divijvaidya commented on code in PR #12908:
URL: https://github.com/apache/kafka/pull/12908#discussion_r1033816997
##
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##
@@ -470,6 +461,18 @@ public static VerificationResult verify(final String kafka,
lucasbru commented on code in PR #12908:
URL: https://github.com/apache/kafka/pull/12908#discussion_r1033809187
##
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##
@@ -470,6 +461,18 @@ public static VerificationResult verify(final String kafka,
[
https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640125#comment-17640125
]
Lucas Brutschy commented on KAFKA-12679:
I addressed this in the new state resto
cadonna merged PR #12875:
URL: https://github.com/apache/kafka/pull/12875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12875:
URL: https://github.com/apache/kafka/pull/12875#issuecomment-1329368142
Build failures are not related:
```
Build / JDK 17 and Scala 2.13 /
kafka.network.SocketServerTest.processNewResponseException()
Build / JDK 17 and Scala 2.13 /
org.apache.kafka.
tinaselenge opened a new pull request, #12912:
URL: https://github.com/apache/kafka/pull/12912
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
mumrah commented on PR #12871:
URL: https://github.com/apache/kafka/pull/12871#issuecomment-1329333039
@dengziming please feel free to review this change in this PR. I needed to
merge to the integration branch since some other work depends on it. Once the
code has stabilized a bit, we'll do
mumrah merged PR #12871:
URL: https://github.com/apache/kafka/pull/12871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1033492033
##
core/src/main/scala/kafka/log/AbstractIndex.scala:
##
@@ -36,7 +36,7 @@ import org.apache.kafka.common.utils.{ByteBufferUnmapper,
OperatingSystem, Utils
* @param
mimaison commented on PR #10838:
URL: https://github.com/apache/kafka/pull/10838#issuecomment-1329291414
@showuon Is this still something you want to do? If so can you rebase it?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
[
https://issues.apache.org/jira/browse/KAFKA-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14423:
-
Attachment: Screenshot 2022-11-28 at 15.26.30.png
> Optimize CPU bottleneck caused by metrics ca
[
https://issues.apache.org/jira/browse/KAFKA-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14423:
-
Attachment: flamegraph1.html
> Optimize CPU bottleneck caused by metrics capture
> -
divijvaidya opened a new pull request, #12911:
URL: https://github.com/apache/kafka/pull/12911
Today a user can change the number of partitions of `__consumer_offsets`
topic by changing the configuration value for `offsets.topic.num.partitions` or
manually by using `./bin/kafka-topics.sh`.
mimaison commented on PR #11509:
URL: https://github.com/apache/kafka/pull/11509#issuecomment-1329190796
Thanks @showuon for the PR. It looks good, can you rebase it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mimaison merged PR #12890:
URL: https://github.com/apache/kafka/pull/12890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy resolved KAFKA-14299.
Assignee: Lucas Brutschy
Resolution: Fixed
> Benchmark and stabilize state updater
>
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1033516642
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -289,13 +296,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
@volatile var partitionMetadataFil
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1033515905
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
sudeshwasnik closed pull request #12784: KAFKA-14339 : Do not perform
prodcuerCommit on serializationError when trying offsetWriter flush
URL: https://github.com/apache/kafka/pull/12784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
sudeshwasnik commented on PR #12784:
URL: https://github.com/apache/kafka/pull/12784#issuecomment-1329023764
Closing this PR. Can reassign this ticket. Shouldn't block on my
prioritizations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1033493533
##
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##
@@ -0,0 +1,284 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1033492033
##
core/src/main/scala/kafka/log/AbstractIndex.scala:
##
@@ -36,7 +36,7 @@ import org.apache.kafka.common.utils.{ByteBufferUnmapper,
OperatingSystem, Utils
* @param
cadonna commented on PR #12875:
URL: https://github.com/apache/kafka/pull/12875#issuecomment-1328982847
@lucasbru Could you please resolve the merge conflicts that I introduces by
merging your PR #12904?
--
This is an automated message from the Apache Git Service.
To respond to the messag
cadonna merged PR #12904:
URL: https://github.com/apache/kafka/pull/12904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12904:
URL: https://github.com/apache/kafka/pull/12904#issuecomment-1328978349
Build failures are unrelated:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.clients.consumer.StickyAssignorTest.testLargeAssignmentAndGroupWithNonEqualSubscription()
Build
Divij Vaidya created KAFKA-14423:
Summary: Optimize CPU bottleneck caused by metrics capture
Key: KAFKA-14423
URL: https://issues.apache.org/jira/browse/KAFKA-14423
Project: Kafka
Issue Type:
dajac commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1033405223
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -162,6 +162,28 @@ private boolean allSubscriptionsEqual(Set
allTo
mimaison commented on PR #12899:
URL: https://github.com/apache/kafka/pull/12899#issuecomment-1328885642
@showuon Thanks for the review and good catch! I double checked and all
tests should be there now.
--
This is an automated message from the Apache Git Service.
To respond to the messag
dajac opened a new pull request, #12910:
URL: https://github.com/apache/kafka/pull/12910
We recently had a bug causing the JoinGroup callback to thrown an exception
(https://github.com/apache/kafka/pull/12909). When it happens, the exception is
propagated to the caller and the JoinGroup cal
divijvaidya commented on PR #12890:
URL: https://github.com/apache/kafka/pull/12890#issuecomment-1328810024
Test failures are unrelated.
```
Build / JDK 17 and Scala 2.13 /
org.apache.kafka.clients.consumer.internals.CooperativeConsumerCoordinatorTest.testOutdatedCoordinatorAssignment(
dajac opened a new pull request, #12909:
URL: https://github.com/apache/kafka/pull/12909
When a consumer group on a version prior to 2.3 is rolled upgraded to a
newer version and static membership is enabled in the meantime, the consumer
group remains stuck, iff the leader is still on the o
divijvaidya opened a new pull request, #12908:
URL: https://github.com/apache/kafka/pull/12908
`SmokeTestDriverIntegrationTest.java` can be flaky because a
NullPointerException prevents [the retry
mechanism](https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/s
[
https://issues.apache.org/jira/browse/KAFKA-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yws reassigned KAFKA-14421:
---
Assignee: yws
> OffsetFetchRequest throws NPE Exception
> ---
>
>
David Jacot created KAFKA-14422:
---
Summary: Consumer rebalance stuck after new static member joins a
group with members not supporting static members
Key: KAFKA-14422
URL: https://issues.apache.org/jira/browse/KAFKA-
73 matches
Mail list logo
