[GitHub] [kafka] showuon commented on pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)

2022-12-02 Thread GitBox
showuon commented on PR #12908: URL: https://github.com/apache/kafka/pull/12908#issuecomment-1336108293 Failed with some `MemoryRecordsBuilderTest` tests. Re-run jenkins: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12908/4/ ``` Build / JDK 8 and Scala 2.12 /

[GitHub] [kafka] showuon commented on pull request #12940: MINOR: Remove lock contention while adding sensors

2022-12-02 Thread GitBox
showuon commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1336107162 Re-run the jenkins: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12940/4/ -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mumrah opened a new pull request, #12946: KAFKA-14427 ZK client support for migrations

2022-12-02 Thread GitBox
mumrah opened a new pull request, #12946: URL: https://github.com/apache/kafka/pull/12946 TODO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah merged pull request #12928: KAFKA-14304 Add RPC changes, records, and config from KIP-866

2022-12-02 Thread GitBox
mumrah merged PR #12928: URL: https://github.com/apache/kafka/pull/12928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kirktrue opened a new pull request, #12945: KAFKA-14365: Refactor Fetcher to allow different implementations

2022-12-02 Thread GitBox
kirktrue opened a new pull request, #12945: URL: https://github.com/apache/kafka/pull/12945 This change refactors the existing `Fetcher` by splitting out the parts related to offset listing into a dedicated class named `OffsetsFinder`. This allows the `Fetcher` implementation to be more

[jira] [Comment Edited] (KAFKA-14439) Specify returned errors for various APIs and versions

2022-12-02 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642726#comment-17642726 ] Jason Gustafson edited comment on KAFKA-14439 at 12/2/22 11:52 PM: ---

[jira] [Commented] (KAFKA-14439) Specify returned errors for various APIs and versions

2022-12-02 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642735#comment-17642735 ] Ismael Juma commented on KAFKA-14439: - I think it would also be useful for the server to indicate

[jira] [Updated] (KAFKA-14438) Stop supporting empty consumer groupId

2022-12-02 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14438: Priority: Blocker (was: Major) > Stop supporting empty consumer groupId >

[jira] [Comment Edited] (KAFKA-14439) Specify returned errors for various APIs and versions

2022-12-02 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642726#comment-17642726 ] Jason Gustafson edited comment on KAFKA-14439 at 12/2/22 11:44 PM: ---

[jira] [Commented] (KAFKA-14439) Specify returned errors for various APIs and versions

2022-12-02 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642726#comment-17642726 ] Jason Gustafson commented on KAFKA-14439: - Yeah, we've had so many compatibility breaks due to

[jira] [Created] (KAFKA-14439) Specify returned errors for various APIs and versions

2022-12-02 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14439: -- Summary: Specify returned errors for various APIs and versions Key: KAFKA-14439 URL: https://issues.apache.org/jira/browse/KAFKA-14439 Project: Kafka

[jira] [Assigned] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant reassigned KAFKA-14437: Assignee: Andrew Grant > Enhance StripedReplicaPlacer to account for existing partition

[jira] [Created] (KAFKA-14438) Stop supporting empty consumer groupId

2022-12-02 Thread Philip Nee (Jira)
Philip Nee created KAFKA-14438: -- Summary: Stop supporting empty consumer groupId Key: KAFKA-14438 URL: https://issues.apache.org/jira/browse/KAFKA-14438 Project: Kafka Issue Type: Task

[GitHub] [kafka] lihaosky opened a new pull request, #12944: [KAFKA-14395] add config to configure client supplier

2022-12-02 Thread GitBox
lihaosky opened a new pull request, #12944: URL: https://github.com/apache/kafka/pull/12944 ## Description This PR is for https://cwiki.apache.org/confluence/display/KAFKA/KIP-884%3A+Add+config+to+configure+KafkaClientSupplier+in+Kafka+Streams. It adds a new `default.client.supplier`

[GitHub] [kafka] hachikuji commented on a diff in pull request #12897: KAFKA-14379: consumer should refresh preferred read replica on update metadata

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12897: URL: https://github.com/apache/kafka/pull/12897#discussion_r1038530374 ## clients/src/test/java/org/apache/kafka/common/requests/RequestTestUtils.java: ## @@ -208,10 +209,10 @@ public static MetadataResponse metadataUpdateWith(final

[jira] [Resolved] (KAFKA-6643) Warm up new replicas from scratch when changelog topic has LIMITED retention time

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-6643. Resolution: Won't Fix > Warm up new replicas from scratch when changelog topic has LIMITED

[jira] [Updated] (KAFKA-14379) consumer should refresh preferred read replica on update metadata

2022-12-02 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14379: Priority: Critical (was: Major) > consumer should refresh preferred read replica on

[jira] [Updated] (KAFKA-14379) consumer should refresh preferred read replica on update metadata

2022-12-02 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14379: Fix Version/s: 3.4.0 > consumer should refresh preferred read replica on update metadata

[jira] [Resolved] (KAFKA-6542) Tables should trigger joins too, not just streams

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-6542. Resolution: Invalid This will be fixed via versioned stores and "delayed table lookups".

[jira] [Resolved] (KAFKA-6509) Add additional tests for validating store restoration completes before Topology is intitalized

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-6509. Resolution: Not A Problem > Add additional tests for validating store restoration

[jira] [Resolved] (KAFKA-5245) KStream builder should capture serdes

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-5245. Resolution: Fixed > KStream builder should capture serdes >

[jira] [Resolved] (KAFKA-5085) Add test for rebalance exceptions

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-5085. Resolution: Abandoned Might no be necessary any longer given all the changes we did over

[jira] [Updated] (KAFKA-5493) Optimize calls to flush for tasks and standby tasks

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-5493: --- Labels: eos (was: ) > Optimize calls to flush for tasks and standby tasks >

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038429334 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038427640 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038427945 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038427640 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038423837 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038423520 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038423837 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038423520 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] belugabehr commented on pull request #8066: KAFKA-4090: Validate SSL connection in client

2022-12-02 Thread GitBox
belugabehr commented on PR #8066: URL: https://github.com/apache/kafka/pull/8066#issuecomment-1335664538 I documented my work on the ticket as well. It got very little attention from the Kafka Dev Team and seems to be pretty out of date now (merge conflicts). Will need someone internal

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038422365 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038423837 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038418696 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038418696 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038418696 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-14436) Initialize KRaft with arbitrary epoch

2022-12-02 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang reassigned KAFKA-14436: Assignee: Alyssa Huang > Initialize KRaft with arbitrary epoch >

[GitHub] [kafka] jolshan commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

2022-12-02 Thread GitBox
jolshan commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1038385341 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1678,6 +1680,62 @@ public void

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1038378151 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

2022-12-02 Thread GitBox
jolshan commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1038368961 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1678,6 +1680,62 @@ public void

[GitHub] [kafka] hachikuji commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1038367059 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1678,6 +1680,62 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

2022-12-02 Thread GitBox
jolshan commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1038365461 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1678,6 +1680,62 @@ public void

[GitHub] [kafka] hachikuji commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1038362105 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1678,6 +1680,62 @@ public void

[GitHub] [kafka] hachikuji commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

2022-12-02 Thread GitBox
hachikuji commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1038362105 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1678,6 +1680,62 @@ public void

[GitHub] [kafka] jonathan-albrecht-ibm commented on pull request #12343: MINOR: Update unit/integration tests to work with the IBM Semeru JDK

2022-12-02 Thread GitBox
jonathan-albrecht-ibm commented on PR #12343: URL: https://github.com/apache/kafka/pull/12343#issuecomment-1335553986 Thanks @mimaison! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14437: - Description: Currently, in StripedReplicaPlacer we don’t take existing partition assignments

[jira] [Updated] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14437: - Description: Currently, in StripedReplicaPlacer we don’t take existing partition assignments

[jira] [Updated] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14437: - Description: Currently, in StripedReplicaPlacer we don’t take existing partition assignments

[jira] [Updated] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14437: - Description: Currently, in StripedReplicaPlacer we don’t take existing partition assignments

[jira] [Updated] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-14437: - Description: Currently, in StripedReplicaPlacer we don’t take existing partition assignments

[jira] [Commented] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642602#comment-17642602 ] Andrew Grant commented on KAFKA-14437: -- I created a draft PR,

[GitHub] [kafka] andymg3 opened a new pull request, #12943: KAFKA-14437: Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread GitBox
andymg3 opened a new pull request, #12943: URL: https://github.com/apache/kafka/pull/12943 ### Details This is a draft PR showing a potential solution to https://issues.apache.org/jira/browse/KAFKA-14437. The idea is to enhance StripedReplicaPlacer to use previous partition assignments

[jira] [Created] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-02 Thread Andrew Grant (Jira)
Andrew Grant created KAFKA-14437: Summary: Enhance StripedReplicaPlacer to account for existing partition assignments Key: KAFKA-14437 URL: https://issues.apache.org/jira/browse/KAFKA-14437 Project:

[jira] [Resolved] (KAFKA-14358) Users should not be able to create a regular topic name __cluster_metadata

2022-12-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14358. Resolution: Fixed > Users should not be able to create a regular

[GitHub] [kafka] dajac merged pull request #12847: KAFKA-14367; Add `SyncGroup` to the new `GroupCoordinator` interface

2022-12-02 Thread GitBox
dajac merged PR #12847: URL: https://github.com/apache/kafka/pull/12847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

2022-12-02 Thread GitBox
zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r1038293918 ## core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala: ## @@ -488,6 +488,31 @@ class ConsoleConsumerTest {

[GitHub] [kafka] zigarn commented on pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

2022-12-02 Thread GitBox
zigarn commented on PR #12175: URL: https://github.com/apache/kafka/pull/12175#issuecomment-1335472177 No problem, thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac merged pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

2022-12-02 Thread GitBox
dajac merged PR #12175: URL: https://github.com/apache/kafka/pull/12175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] omkreddy merged pull request #12896: KAFKA-14398: Update EndToEndAuthorizationTest to test both ZK and KRAFT quorum servers

2022-12-02 Thread GitBox
omkreddy merged PR #12896: URL: https://github.com/apache/kafka/pull/12896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

2022-12-02 Thread GitBox
dajac commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r1038279577 ## core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala: ## @@ -488,6 +488,31 @@ class ConsoleConsumerTest {

[jira] [Created] (KAFKA-14436) Initialize KRaft with arbitrary epoch

2022-12-02 Thread David Arthur (Jira)
David Arthur created KAFKA-14436: Summary: Initialize KRaft with arbitrary epoch Key: KAFKA-14436 URL: https://issues.apache.org/jira/browse/KAFKA-14436 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-14429) Move OffsetStorageReader from storage package to source package

2022-12-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642565#comment-17642565 ] Chris Egerton commented on KAFKA-14429: --- Although I agree that the package name isn't ideal and

[jira] [Updated] (KAFKA-14429) Move OffsetStorageReader from storage package to source package

2022-12-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14429: -- Labels: needs-kip (was: ) > Move OffsetStorageReader from storage package to source package

[jira] [Updated] (KAFKA-14427) Add support for ZK migration multi-ops transaction

2022-12-02 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14427: - Summary: Add support for ZK migration multi-ops transaction (was: Add support for ZK migration

[jira] [Resolved] (KAFKA-14433) Clear all yammer metrics when test harnesses clean up

2022-12-02 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14433. -- Resolution: Fixed > Clear all yammer metrics when test harnesses clean up >

[jira] [Assigned] (KAFKA-14433) Clear all yammer metrics when test harnesses clean up

2022-12-02 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-14433: Assignee: David Arthur > Clear all yammer metrics when test harnesses clean up >

[GitHub] [kafka] mumrah merged pull request #12942: KAFKA-14433 Clear Yammer metrics in QuorumTestHarness#tearDown

2022-12-02 Thread GitBox
mumrah merged PR #12942: URL: https://github.com/apache/kafka/pull/12942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a diff in pull request #12914: KAFKA-14352: Rack-aware consumer partition assignment (KIP-881)

2022-12-02 Thread GitBox
dajac commented on code in PR #12914: URL: https://github.com/apache/kafka/pull/12914#discussion_r1037881208 ## clients/src/main/resources/common/message/ConsumerProtocolAssignment.json: ## @@ -23,6 +23,7 @@ // that new versions cannot remove or reorder any of the existing

[GitHub] [kafka] pprovenzano commented on pull request #12896: KAFKA-14398: Update EndToEndAuthorizationTest to test both ZK and KRAFT quorum servers

2022-12-02 Thread GitBox
pprovenzano commented on PR #12896: URL: https://github.com/apache/kafka/pull/12896#issuecomment-1335323936 I have validated that the failing tests work by manually running them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-14435) Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled

2022-12-02 Thread Purshotam Chauhan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Purshotam Chauhan updated KAFKA-14435: -- Affects Version/s: 3.2.3 3.2.2 3.2.1

[jira] [Comment Edited] (KAFKA-14435) Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled

2022-12-02 Thread Purshotam Chauhan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642497#comment-17642497 ] Purshotam Chauhan edited comment on KAFKA-14435 at 12/2/22 2:12 PM:

[jira] [Assigned] (KAFKA-14435) Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled

2022-12-02 Thread Purshotam Chauhan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Purshotam Chauhan reassigned KAFKA-14435: - Assignee: Purshotam Chauhan > Kraft: StandardAuthorizer allowing a

[GitHub] [kafka] lucasbru commented on pull request #12935: KAFKA-14432: RocksDBStore relies on finalizers to not leak memory

2022-12-02 Thread GitBox
lucasbru commented on PR #12935: URL: https://github.com/apache/kafka/pull/12935#issuecomment-1335257553 @cadonna Could you have a look? I ran this for a few hours in the soak and the native memory is stable. So I think this was the main leak -- This is an automated message from the

[GitHub] [kafka] divijvaidya commented on pull request #12940: MINOR: Remove lock contention while adding sensors

2022-12-02 Thread GitBox
divijvaidya commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1335252064 @mimaison please take a look when you get a chance! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] divijvaidya commented on pull request #12940: MINOR: Remove lock contention while adding sensors

2022-12-02 Thread GitBox
divijvaidya commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1335251627 Rebased from trunk. Test failures are unrelated. ``` Build / JDK 11 and Scala 2.13 / testFailureToFenceEpoch(String).quorum=kraft – kafka.api.TransactionsTest Build / JDK

[jira] [Commented] (KAFKA-12679) Rebalancing a restoring or running task may cause directory livelocking with newly created task

2022-12-02 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642502#comment-17642502 ] Lucas Brutschy commented on KAFKA-12679: I referenced this ticket in the PR > Rebalancing a

[jira] [Comment Edited] (KAFKA-14435) Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled

2022-12-02 Thread Purshotam Chauhan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642497#comment-17642497 ] Purshotam Chauhan edited comment on KAFKA-14435 at 12/2/22 1:21 PM:

[jira] [Comment Edited] (KAFKA-14435) Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled

2022-12-02 Thread Purshotam Chauhan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642497#comment-17642497 ] Purshotam Chauhan edited comment on KAFKA-14435 at 12/2/22 1:20 PM:

[jira] [Commented] (KAFKA-14435) Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled

2022-12-02 Thread Purshotam Chauhan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642497#comment-17642497 ] Purshotam Chauhan commented on KAFKA-14435: --- This can be fixed by adding a flag

[jira] [Created] (KAFKA-14435) Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled

2022-12-02 Thread Purshotam Chauhan (Jira)
Purshotam Chauhan created KAFKA-14435: - Summary: Kraft: StandardAuthorizer allowing a non-authorized user when `allow.everyone.if.no.acl.found` is enabled Key: KAFKA-14435 URL:

[jira] [Updated] (KAFKA-14278) Convert INVALID_PRODUCER_EPOCH into PRODUCER_FENCED TxnOffsetCommit

2022-12-02 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14278: --- Component/s: producer streams > Convert INVALID_PRODUCER_EPOCH into

[jira] [Assigned] (KAFKA-14278) Convert INVALID_PRODUCER_EPOCH into PRODUCER_FENCED TxnOffsetCommit

2022-12-02 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-14278: -- Assignee: Lucas Brutschy > Convert INVALID_PRODUCER_EPOCH into PRODUCER_FENCED

[jira] [Updated] (KAFKA-14309) Kafka Streams upgrade tests do not cover for FK-joins

2022-12-02 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-14309: --- Component/s: streams > Kafka Streams upgrade tests do not cover for FK-joins >

[GitHub] [kafka] divijvaidya commented on pull request #12940: MINOR: Remove lock contention while adding sensors

2022-12-02 Thread GitBox
divijvaidya commented on PR #12940: URL: https://github.com/apache/kafka/pull/12940#issuecomment-1335028608 The build is failing with: ``` [2022-12-01T20:35:07.343Z] FAILURE: Build completed with 2 failures. [2022-12-01T20:35:07.343Z] [2022-12-01T20:35:07.343Z] 1: Task

[GitHub] [kafka] divijvaidya commented on pull request #12933: MINOR: Optimize metric recording when quota check not required

2022-12-02 Thread GitBox
divijvaidya commented on PR #12933: URL: https://github.com/apache/kafka/pull/12933#issuecomment-1335021913 @mimaison please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-14374) Kafka streams losing messages in State Store during first launch of app

2022-12-02 Thread Youcef Sebiat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642374#comment-17642374 ] Youcef Sebiat commented on KAFKA-14374: --- Thanks for the response. 1. {quote}Did you check the

[jira] [Resolved] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-12-02 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victor van den Hoven resolved KAFKA-14400. -- Resolution: Not A Bug It behaves differently because stream-stram-leftjoin

[jira] [Commented] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-12-02 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642366#comment-17642366 ] Victor van den Hoven commented on KAFKA-14400: -- Thank you for answering my questions. :)

[jira] [Commented] (KAFKA-14400) KStream - KStream - LeftJoin() does not call ValueJoiner with null value

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642353#comment-17642353 ] Matthias J. Sax commented on KAFKA-14400: - {quote}Am I correct that when one +LAST+ input record

[GitHub] [kafka] cmccabe merged pull request #12837: MINOR: extract jointly owned parts of BrokerServer and ControllerServer

2022-12-02 Thread GitBox
cmccabe merged PR #12837: URL: https://github.com/apache/kafka/pull/12837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14184) Kafka streams application crashes due to "UnsupportedOperationException: this should not happen: timestamp() is not supported in standby tasks."

2022-12-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642351#comment-17642351 ] Matthias J. Sax commented on KAFKA-14184: - Thanks for the update. – It's hard to say what might