PhantomMaa commented on PR #12997:
URL: https://github.com/apache/kafka/pull/12997#issuecomment-1356095914
Thanks for your reply.
I agree that the `KafkaServer` is not designed for extend, attempt to
replace the `LogManager` by override a `createLogManager`, maybe not a
permanently m
ijuma commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1356058365
@cadonna Can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
ijuma commented on code in PR #13001:
URL: https://github.com/apache/kafka/pull/13001#discussion_r1051321610
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -703,8 +703,8 @@ class KafkaServer(
case None =>
info(s"Broker registrati
dengziming commented on PR #12797:
URL: https://github.com/apache/kafka/pull/12797#issuecomment-1356056291
> What are your thoughts on my error state and the the way the CLI reacts
without bootstrap.server?
I think it's OK to avoid adding explicit error handling since the output is
a
dengziming commented on code in PR #12993:
URL: https://github.com/apache/kafka/pull/12993#discussion_r1051318941
##
storage/src/main/java/org/apache/kafka/server/log/internals/OffsetPosition.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ijuma commented on PR #12989:
URL: https://github.com/apache/kafka/pull/12989#issuecomment-1356016457
Hmm, the naming scheme is pretty confusing. If we made changes to the KIP,
we should send an email to the mailing list with a summary so people can
provide feedback.
--
This is an automa
ijuma commented on PR #12997:
URL: https://github.com/apache/kafka/pull/12997#issuecomment-1356015550
Yes, a KIP would be required to turn this into a public API. For non public
APIs, the code can change at any time.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642602#comment-17642602
]
Andrew Grant edited comment on KAFKA-14437 at 12/17/22 1:21 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642602#comment-17642602
]
Andrew Grant edited comment on KAFKA-14437 at 12/17/22 1:21 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642602#comment-17642602
]
Andrew Grant edited comment on KAFKA-14437 at 12/17/22 1:21 AM:
--
ijuma opened a new pull request, #13006:
URL: https://github.com/apache/kafka/pull/13006
`TRACE` is too noisy and makes the build slower.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
[
https://issues.apache.org/jira/browse/KAFKA-14457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14457:
---
Fix Version/s: 3.4.0
> Inconsistent in quorum controller fenced brok
junrao commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1051118349
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -574,6 +594,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
explicitMetricName(pkgStr, "Log", na
dajac commented on PR #12997:
URL: https://github.com/apache/kafka/pull/12997#issuecomment-1355137463
Thanks for the PR. It is important to note that `KafkaServer` is not
considered as a public interface in Kafka. Hence, there is not guarantee that
the interface will remain like this in the
bbejeck commented on PR #13002:
URL: https://github.com/apache/kafka/pull/13002#issuecomment-1354974903
Failures unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
omkreddy merged PR #13000:
URL: https://github.com/apache/kafka/pull/13000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
yashmayya commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1050765139
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -712,8 +733,16 @@ KafkaBasedLog
setupAndCreateKafkaBasedLog(Str
yashmayya commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1050765139
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -712,8 +733,16 @@ KafkaBasedLog
setupAndCreateKafkaBasedLog(Str
vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1050723088
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection
mimaison opened a new pull request, #13005:
URL: https://github.com/apache/kafka/pull/13005
Currently MirrorMaker throws a few exceptions at startup if its internal
topics already exists.
For example:
```
Scheduler for MirrorHeartbeatConnector caught exception in scheduled task:
dajac commented on PR #12865:
URL: https://github.com/apache/kafka/pull/12865#issuecomment-1354559213
@mimaison Could you take a look at the last commit? I had to fix a few more
tests when merging trunk.
--
This is an automated message from the Apache Git Service.
To respond to the messag
satishd commented on PR #11390:
URL: https://github.com/apache/kafka/pull/11390#issuecomment-1354541220
Thanks @junrao for your updated review. Addressed them with inline comments
and updated with the latest commits.
--
This is an automated message from the Apache Git Service.
To respond
showuon opened a new pull request, #13004:
URL: https://github.com/apache/kafka/pull/13004
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
David Jacot created KAFKA-14519:
---
Summary: Add metrics to the new coordinator
Key: KAFKA-14519
URL: https://issues.apache.org/jira/browse/KAFKA-14519
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14517:
---
Summary: Implement regex subscriptions
Key: KAFKA-14517
URL: https://issues.apache.org/jira/browse/KAFKA-14517
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14516:
---
Summary: Implement static membeship
Key: KAFKA-14516
URL: https://issues.apache.org/jira/browse/KAFKA-14516
Project: Kafka
Issue Type: Sub-task
Rep
David Jacot created KAFKA-14518:
---
Summary: Rebalance on topic/partition metadata changes
Key: KAFKA-14518
URL: https://issues.apache.org/jira/browse/KAFKA-14518
Project: Kafka
Issue Type: Sub-t
[
https://issues.apache.org/jira/browse/KAFKA-14506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14506:
Summary: Implement OffsetDelete API (was: Add OffsetDelete API to new
coordinator)
> Implement O
[
https://issues.apache.org/jira/browse/KAFKA-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14505:
Summary: Implement TnxOffsetCommit API (was: Add TnxOffsetCommit API to
new coordinator)
> Imple
[
https://issues.apache.org/jira/browse/KAFKA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14504:
Summary: Implement DescribeGroups API (was: Add DescribeGroups to new
coordinator)
> Implement D
[
https://issues.apache.org/jira/browse/KAFKA-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14502:
Summary: Implement LeaveGroup API (was: Add LeaveGroup API to new
coordinator)
> Implement Leave
[
https://issues.apache.org/jira/browse/KAFKA-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14499:
Summary: Implement OffsetFetch/OffsetCommit APIs (was: Add
OffsetFetch/OffsetCommit to new coordi
[
https://issues.apache.org/jira/browse/KAFKA-14501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14501:
Summary: Implement Heartbeat API (was: Add Heartbeat API to new
coordinator)
> Implement Heartbe
[
https://issues.apache.org/jira/browse/KAFKA-14500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14500:
Summary: Implement JoinGroup/SyncGroup APIs (was: Add JoinGroup/SyncGroup
APIs to new coordinator
[
https://issues.apache.org/jira/browse/KAFKA-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-14503:
Summary: Implement ListGroups (was: Add ListGroups to new coordinator)
> Implement ListGroups
> -
David Jacot created KAFKA-14515:
---
Summary: Implement uniform broker side assignor
Key: KAFKA-14515
URL: https://issues.apache.org/jira/browse/KAFKA-14515
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14514:
---
Summary: Implement range broker side assignor
Key: KAFKA-14514
URL: https://issues.apache.org/jira/browse/KAFKA-14514
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14513:
---
Summary: Add broker side PartitionAssignor interface
Key: KAFKA-14513
URL: https://issues.apache.org/jira/browse/KAFKA-14513
Project: Kafka
Issue Type: Sub-tas
David Jacot created KAFKA-14511:
---
Summary: Extend AlterIncrementalConfigs API to support group config
Key: KAFKA-14511
URL: https://issues.apache.org/jira/browse/KAFKA-14511
Project: Kafka
Issu
David Jacot created KAFKA-14512:
---
Summary: Extend OffsetCommit/OffsetFetch APIs to support topic ids
Key: KAFKA-14512
URL: https://issues.apache.org/jira/browse/KAFKA-14512
Project: Kafka
Issue
David Jacot created KAFKA-14510:
---
Summary: Extend DescribeConfigs API to support group configs
Key: KAFKA-14510
URL: https://issues.apache.org/jira/browse/KAFKA-14510
Project: Kafka
Issue Type:
David Jacot created KAFKA-14508:
---
Summary: Add ConsumerGroupInstallAssignment API
Key: KAFKA-14508
URL: https://issues.apache.org/jira/browse/KAFKA-14508
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14507:
---
Summary: Add ConsumerGroupPrepareAssignment API
Key: KAFKA-14507
URL: https://issues.apache.org/jira/browse/KAFKA-14507
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14509:
---
Summary: Add ConsumerGroupDescribe API
Key: KAFKA-14509
URL: https://issues.apache.org/jira/browse/KAFKA-14509
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14505:
---
Summary: Add TnxOffsetCommit API to new coordinator
Key: KAFKA-14505
URL: https://issues.apache.org/jira/browse/KAFKA-14505
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14506:
---
Summary: Add OffsetDelete API to new coordinator
Key: KAFKA-14506
URL: https://issues.apache.org/jira/browse/KAFKA-14506
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14500:
---
Summary: Add JoinGroup/SyncGroup APIs to new coordinator
Key: KAFKA-14500
URL: https://issues.apache.org/jira/browse/KAFKA-14500
Project: Kafka
Issue Type: Sub
David Jacot created KAFKA-14501:
---
Summary: Add Heartbeat API to new coordinator
Key: KAFKA-14501
URL: https://issues.apache.org/jira/browse/KAFKA-14501
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14504:
---
Summary: Add DescribeGroups to new coordinator
Key: KAFKA-14504
URL: https://issues.apache.org/jira/browse/KAFKA-14504
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14502:
---
Summary: Add LeaveGroup API to new coordinator
Key: KAFKA-14502
URL: https://issues.apache.org/jira/browse/KAFKA-14502
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14503:
---
Summary: Add ListGroups to new coordinator
Key: KAFKA-14503
URL: https://issues.apache.org/jira/browse/KAFKA-14503
Project: Kafka
Issue Type: Sub-task
David Jacot created KAFKA-14499:
---
Summary: Add OffsetFetch/OffsetCommit to new coordinator
Key: KAFKA-14499
URL: https://issues.apache.org/jira/browse/KAFKA-14499
Project: Kafka
Issue Type: Sub
Luke Chen created KAFKA-14498:
-
Summary: flaky org.apache.kafka.tools.MetadataQuorumCommandTest
Key: KAFKA-14498
URL: https://issues.apache.org/jira/browse/KAFKA-14498
Project: Kafka
Issue Type:
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1050537960
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -192,4 +204,140 @@ class ReplicaFetcherThread(name: String,
partition.truncateFullyAndStartAt
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1050536942
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -0,0 +1,229 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1050536434
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -574,6 +594,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
explicitMetricName(pkgStr, "Log", n
satishd commented on code in PR #11390:
URL: https://github.com/apache/kafka/pull/11390#discussion_r1050536097
##
clients/src/main/java/org/apache/kafka/common/record/RemoteLogInputStream.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
showuon merged PR #12753:
URL: https://github.com/apache/kafka/pull/12753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #12753:
URL: https://github.com/apache/kafka/pull/12753#issuecomment-1354425171
Failed tests are unrelated and also fail in trunk build:
```
[Build / JDK 8 and Scala 2.12 /
org.apache.kafka.clients.consumer.StickyAssignorTest.testLargeAssignmentAndGroupWithNonEq
59 matches
Mail list logo