[GitHub] [kafka] PhantomMaa commented on pull request #12997: KAFKA-14492: Extract a method to create LogManager, in order to be overrided by subclass of KafkaServer

2022-12-16 Thread GitBox
PhantomMaa commented on PR #12997: URL: https://github.com/apache/kafka/pull/12997#issuecomment-1356095914 Thanks for your reply. I agree that the `KafkaServer` is not designed for extend, attempt to replace the `LogManager` by override a `createLogManager`, maybe not a permanently m

[GitHub] [kafka] ijuma commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2

2022-12-16 Thread GitBox
ijuma commented on PR #12301: URL: https://github.com/apache/kafka/pull/12301#issuecomment-1356058365 @cadonna Can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] ijuma commented on a diff in pull request #13001: KAFKA-14446: code style improvements for broker-to-controller forwarding

2022-12-16 Thread GitBox
ijuma commented on code in PR #13001: URL: https://github.com/apache/kafka/pull/13001#discussion_r1051321610 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -703,8 +703,8 @@ class KafkaServer( case None => info(s"Broker registrati

[GitHub] [kafka] dengziming commented on pull request #12797: MINOR: Remove requirement to specify --bootstrap-server in utility scripts if specified in property file

2022-12-16 Thread GitBox
dengziming commented on PR #12797: URL: https://github.com/apache/kafka/pull/12797#issuecomment-1356056291 > What are your thoughts on my error state and the the way the CLI reacts without bootstrap.server? I think it's OK to avoid adding explicit error handling since the output is a

[GitHub] [kafka] dengziming commented on a diff in pull request #12993: KAFKA-14471: Move IndexEntry and related to storage module

2022-12-16 Thread GitBox
dengziming commented on code in PR #12993: URL: https://github.com/apache/kafka/pull/12993#discussion_r1051318941 ## storage/src/main/java/org/apache/kafka/server/log/internals/OffsetPosition.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] ijuma commented on pull request #12989: KAFKA-14469: Fix remote tiered related topic configuration

2022-12-16 Thread GitBox
ijuma commented on PR #12989: URL: https://github.com/apache/kafka/pull/12989#issuecomment-1356016457 Hmm, the naming scheme is pretty confusing. If we made changes to the KIP, we should send an email to the mailing list with a summary so people can provide feedback. -- This is an automa

[GitHub] [kafka] ijuma commented on pull request #12997: KAFKA-14492: Extract a method to create LogManager, in order to be overrided by subclass of KafkaServer

2022-12-16 Thread GitBox
ijuma commented on PR #12997: URL: https://github.com/apache/kafka/pull/12997#issuecomment-1356015550 Yes, a KIP would be required to turn this into a public API. For non public APIs, the code can change at any time. -- This is an automated message from the Apache Git Service. To respond

[jira] [Comment Edited] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-16 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642602#comment-17642602 ] Andrew Grant edited comment on KAFKA-14437 at 12/17/22 1:21 AM: --

[jira] [Comment Edited] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-16 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642602#comment-17642602 ] Andrew Grant edited comment on KAFKA-14437 at 12/17/22 1:21 AM: --

[jira] [Comment Edited] (KAFKA-14437) Enhance StripedReplicaPlacer to account for existing partition assignments

2022-12-16 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642602#comment-17642602 ] Andrew Grant edited comment on KAFKA-14437 at 12/17/22 1:21 AM: --

[GitHub] [kafka] ijuma opened a new pull request, #13006: MINOR: Use INFO logging for tools and trogdor tests

2022-12-16 Thread GitBox
ijuma opened a new pull request, #13006: URL: https://github.com/apache/kafka/pull/13006 `TRACE` is too noisy and makes the build slower. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

[jira] [Updated] (KAFKA-14457) Inconsistent in quorum controller fenced broker metric

2022-12-16 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14457: --- Fix Version/s: 3.4.0 > Inconsistent in quorum controller fenced brok

[GitHub] [kafka] junrao commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-16 Thread GitBox
junrao commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1051118349 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -574,6 +594,12 @@ class UnifiedLog(@volatile var logStartOffset: Long, explicitMetricName(pkgStr, "Log", na

[GitHub] [kafka] dajac commented on pull request #12997: KAFKA-14492: Extract a method to create LogManager, in order to be overrided by subclass of KafkaServer

2022-12-16 Thread GitBox
dajac commented on PR #12997: URL: https://github.com/apache/kafka/pull/12997#issuecomment-1355137463 Thanks for the PR. It is important to note that `KafkaServer` is not considered as a public interface in Kafka. Hence, there is not guarantee that the interface will remain like this in the

[GitHub] [kafka] bbejeck commented on pull request #13002: MINOR: No error with zero results state query

2022-12-16 Thread GitBox
bbejeck commented on PR #13002: URL: https://github.com/apache/kafka/pull/13002#issuecomment-1354974903 Failures unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [kafka] omkreddy merged pull request #13000: KAFKA-14496: Wrong Base64 encoder used by OIDC OAuthBearerLoginCallbackHandler

2022-12-16 Thread GitBox
omkreddy merged PR #13000: URL: https://github.com/apache/kafka/pull/13000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2022-12-16 Thread GitBox
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1050765139 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -712,8 +733,16 @@ KafkaBasedLog setupAndCreateKafkaBasedLog(Str

[GitHub] [kafka] yashmayya commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2022-12-16 Thread GitBox
yashmayya commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1050765139 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -712,8 +733,16 @@ KafkaBasedLog setupAndCreateKafkaBasedLog(Str

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

2022-12-16 Thread GitBox
vamossagar12 commented on code in PR #12802: URL: https://github.com/apache/kafka/pull/12802#discussion_r1050723088 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1645,6 +1646,8 @@ private void startAndStop(Collection

[GitHub] [kafka] mimaison opened a new pull request, #13005: MINOR: Don't throw if MirrorMaker topics already exist

2022-12-16 Thread GitBox
mimaison opened a new pull request, #13005: URL: https://github.com/apache/kafka/pull/13005 Currently MirrorMaker throws a few exceptions at startup if its internal topics already exists. For example: ``` Scheduler for MirrorHeartbeatConnector caught exception in scheduled task:

[GitHub] [kafka] dajac commented on pull request #12865: MINOR: Serialize response in KafkaApisTest

2022-12-16 Thread GitBox
dajac commented on PR #12865: URL: https://github.com/apache/kafka/pull/12865#issuecomment-1354559213 @mimaison Could you take a look at the last commit? I had to fix a few more tests when merging trunk. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] satishd commented on pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-16 Thread GitBox
satishd commented on PR #11390: URL: https://github.com/apache/kafka/pull/11390#issuecomment-1354541220 Thanks @junrao for your updated review. Addressed them with inline comments and updated with the latest commits. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] showuon opened a new pull request, #13004: [WIP] KAFKA-14498: investigate flaky

2022-12-16 Thread GitBox
showuon opened a new pull request, #13004: URL: https://github.com/apache/kafka/pull/13004 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Created] (KAFKA-14519) Add metrics to the new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14519: --- Summary: Add metrics to the new coordinator Key: KAFKA-14519 URL: https://issues.apache.org/jira/browse/KAFKA-14519 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14517) Implement regex subscriptions

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14517: --- Summary: Implement regex subscriptions Key: KAFKA-14517 URL: https://issues.apache.org/jira/browse/KAFKA-14517 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14516) Implement static membeship

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14516: --- Summary: Implement static membeship Key: KAFKA-14516 URL: https://issues.apache.org/jira/browse/KAFKA-14516 Project: Kafka Issue Type: Sub-task Rep

[jira] [Created] (KAFKA-14518) Rebalance on topic/partition metadata changes

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14518: --- Summary: Rebalance on topic/partition metadata changes Key: KAFKA-14518 URL: https://issues.apache.org/jira/browse/KAFKA-14518 Project: Kafka Issue Type: Sub-t

[jira] [Updated] (KAFKA-14506) Implement OffsetDelete API

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14506: Summary: Implement OffsetDelete API (was: Add OffsetDelete API to new coordinator) > Implement O

[jira] [Updated] (KAFKA-14505) Implement TnxOffsetCommit API

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14505: Summary: Implement TnxOffsetCommit API (was: Add TnxOffsetCommit API to new coordinator) > Imple

[jira] [Updated] (KAFKA-14504) Implement DescribeGroups API

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14504: Summary: Implement DescribeGroups API (was: Add DescribeGroups to new coordinator) > Implement D

[jira] [Updated] (KAFKA-14502) Implement LeaveGroup API

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14502: Summary: Implement LeaveGroup API (was: Add LeaveGroup API to new coordinator) > Implement Leave

[jira] [Updated] (KAFKA-14499) Implement OffsetFetch/OffsetCommit APIs

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14499: Summary: Implement OffsetFetch/OffsetCommit APIs (was: Add OffsetFetch/OffsetCommit to new coordi

[jira] [Updated] (KAFKA-14501) Implement Heartbeat API

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14501: Summary: Implement Heartbeat API (was: Add Heartbeat API to new coordinator) > Implement Heartbe

[jira] [Updated] (KAFKA-14500) Implement JoinGroup/SyncGroup APIs

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14500: Summary: Implement JoinGroup/SyncGroup APIs (was: Add JoinGroup/SyncGroup APIs to new coordinator

[jira] [Updated] (KAFKA-14503) Implement ListGroups

2022-12-16 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14503: Summary: Implement ListGroups (was: Add ListGroups to new coordinator) > Implement ListGroups > -

[jira] [Created] (KAFKA-14515) Implement uniform broker side assignor

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14515: --- Summary: Implement uniform broker side assignor Key: KAFKA-14515 URL: https://issues.apache.org/jira/browse/KAFKA-14515 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14514) Implement range broker side assignor

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14514: --- Summary: Implement range broker side assignor Key: KAFKA-14514 URL: https://issues.apache.org/jira/browse/KAFKA-14514 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14513) Add broker side PartitionAssignor interface

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14513: --- Summary: Add broker side PartitionAssignor interface Key: KAFKA-14513 URL: https://issues.apache.org/jira/browse/KAFKA-14513 Project: Kafka Issue Type: Sub-tas

[jira] [Created] (KAFKA-14511) Extend AlterIncrementalConfigs API to support group config

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14511: --- Summary: Extend AlterIncrementalConfigs API to support group config Key: KAFKA-14511 URL: https://issues.apache.org/jira/browse/KAFKA-14511 Project: Kafka Issu

[jira] [Created] (KAFKA-14512) Extend OffsetCommit/OffsetFetch APIs to support topic ids

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14512: --- Summary: Extend OffsetCommit/OffsetFetch APIs to support topic ids Key: KAFKA-14512 URL: https://issues.apache.org/jira/browse/KAFKA-14512 Project: Kafka Issue

[jira] [Created] (KAFKA-14510) Extend DescribeConfigs API to support group configs

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14510: --- Summary: Extend DescribeConfigs API to support group configs Key: KAFKA-14510 URL: https://issues.apache.org/jira/browse/KAFKA-14510 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-14508) Add ConsumerGroupInstallAssignment API

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14508: --- Summary: Add ConsumerGroupInstallAssignment API Key: KAFKA-14508 URL: https://issues.apache.org/jira/browse/KAFKA-14508 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14507) Add ConsumerGroupPrepareAssignment API

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14507: --- Summary: Add ConsumerGroupPrepareAssignment API Key: KAFKA-14507 URL: https://issues.apache.org/jira/browse/KAFKA-14507 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14509) Add ConsumerGroupDescribe API

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14509: --- Summary: Add ConsumerGroupDescribe API Key: KAFKA-14509 URL: https://issues.apache.org/jira/browse/KAFKA-14509 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14505) Add TnxOffsetCommit API to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14505: --- Summary: Add TnxOffsetCommit API to new coordinator Key: KAFKA-14505 URL: https://issues.apache.org/jira/browse/KAFKA-14505 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14506) Add OffsetDelete API to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14506: --- Summary: Add OffsetDelete API to new coordinator Key: KAFKA-14506 URL: https://issues.apache.org/jira/browse/KAFKA-14506 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14500) Add JoinGroup/SyncGroup APIs to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14500: --- Summary: Add JoinGroup/SyncGroup APIs to new coordinator Key: KAFKA-14500 URL: https://issues.apache.org/jira/browse/KAFKA-14500 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-14501) Add Heartbeat API to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14501: --- Summary: Add Heartbeat API to new coordinator Key: KAFKA-14501 URL: https://issues.apache.org/jira/browse/KAFKA-14501 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14504) Add DescribeGroups to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14504: --- Summary: Add DescribeGroups to new coordinator Key: KAFKA-14504 URL: https://issues.apache.org/jira/browse/KAFKA-14504 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14502) Add LeaveGroup API to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14502: --- Summary: Add LeaveGroup API to new coordinator Key: KAFKA-14502 URL: https://issues.apache.org/jira/browse/KAFKA-14502 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14503) Add ListGroups to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14503: --- Summary: Add ListGroups to new coordinator Key: KAFKA-14503 URL: https://issues.apache.org/jira/browse/KAFKA-14503 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-14499) Add OffsetFetch/OffsetCommit to new coordinator

2022-12-16 Thread David Jacot (Jira)
David Jacot created KAFKA-14499: --- Summary: Add OffsetFetch/OffsetCommit to new coordinator Key: KAFKA-14499 URL: https://issues.apache.org/jira/browse/KAFKA-14499 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-14498) flaky org.apache.kafka.tools.MetadataQuorumCommandTest

2022-12-16 Thread Luke Chen (Jira)
Luke Chen created KAFKA-14498: - Summary: flaky org.apache.kafka.tools.MetadataQuorumCommandTest Key: KAFKA-14498 URL: https://issues.apache.org/jira/browse/KAFKA-14498 Project: Kafka Issue Type:

[GitHub] [kafka] satishd commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-16 Thread GitBox
satishd commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1050537960 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -192,4 +204,140 @@ class ReplicaFetcherThread(name: String, partition.truncateFullyAndStartAt

[GitHub] [kafka] satishd commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-16 Thread GitBox
satishd commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1050536942 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -0,0 +1,229 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [kafka] satishd commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-16 Thread GitBox
satishd commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1050536434 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -574,6 +594,12 @@ class UnifiedLog(@volatile var logStartOffset: Long, explicitMetricName(pkgStr, "Log", n

[GitHub] [kafka] satishd commented on a diff in pull request #11390: [KAFKA-13369] Follower fetch protocol changes for tiered storage.

2022-12-16 Thread GitBox
satishd commented on code in PR #11390: URL: https://github.com/apache/kafka/pull/11390#discussion_r1050536097 ## clients/src/main/java/org/apache/kafka/common/record/RemoteLogInputStream.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] showuon merged pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-12-16 Thread GitBox
showuon merged PR #12753: URL: https://github.com/apache/kafka/pull/12753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

2022-12-16 Thread GitBox
showuon commented on PR #12753: URL: https://github.com/apache/kafka/pull/12753#issuecomment-1354425171 Failed tests are unrelated and also fail in trunk build: ``` [Build / JDK 8 and Scala 2.12 / org.apache.kafka.clients.consumer.StickyAssignorTest.testLargeAssignmentAndGroupWithNonEq