lucasbru commented on PR #13017:
URL: https://github.com/apache/kafka/pull/13017#issuecomment-1368785082
Test failures are unrelated.
```
Build / JDK 17 and Scala 2.13 / testSeparateOffsetsTopic –
org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest
1m 40s
Bu
satishd commented on code in PR #13039:
URL: https://github.com/apache/kafka/pull/13039#discussion_r1059994296
##
storage/src/main/java/org/apache/kafka/server/log/internals/SnapshotFile.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on PR #13039:
URL: https://github.com/apache/kafka/pull/13039#issuecomment-1368892291
@ijuma Sorry, Brave browser had some issues in refreshing the github PR page
and missed your update.
--
This is an automated message from the Apache Git Service.
To respond to the mess
[
https://issues.apache.org/jira/browse/KAFKA-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Yurchenko updated KAFKA-8206:
--
Component/s: clients
> A consumer can't discover new group coordinator when the cluster was par
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653624#comment-17653624
]
Travis Bischel commented on KAFKA-7739:
---
Hi there, this work looks excellent. Can t
ijuma commented on PR #13039:
URL: https://github.com/apache/kafka/pull/13039#issuecomment-1369037998
The build for all 3 JDK versions passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma merged PR #13039:
URL: https://github.com/apache/kafka/pull/13039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-14489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653641#comment-17653641
]
Ismael Juma commented on KAFKA-14489:
-
TxnMetadata should be made package private.
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1060101460
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -686,7 +687,9 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private[log] def lastRecordsOfActiveProd
ijuma commented on code in PR #13043:
URL: https://github.com/apache/kafka/pull/13043#discussion_r1060102030
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -686,7 +687,9 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private[log] def lastRecordsOfActiveProd
ijuma commented on PR #13049:
URL: https://github.com/apache/kafka/pull/13049#issuecomment-1369088571
@satishd If you have cycles, this PR is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/KAFKA-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653658#comment-17653658
]
Ivan Yurchenko commented on KAFKA-14526:
[~ijuma] I can take this if you don't m
[
https://issues.apache.org/jira/browse/KAFKA-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653663#comment-17653663
]
Ismael Juma commented on KAFKA-14526:
-
Hi [~ivanyu]. You're welcome to take it. Two
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Yurchenko reassigned KAFKA-14482:
--
Assignee: Ivan Yurchenko
> Move LogLoader to storage module
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653665#comment-17653665
]
Ivan Yurchenko commented on KAFKA-14526:
Good point, thank you. I'll focus on su
mimaison merged PR #13053:
URL: https://github.com/apache/kafka/pull/13053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
yashmayya commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1060149266
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -712,8 +733,16 @@ KafkaBasedLog
setupAndCreateKafkaBasedLog(Str
ivanyu opened a new pull request, #13065:
URL: https://github.com/apache/kafka/pull/13065
This is a relatively independent change in the context of KAFKA-14482.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test covera
ivanyu commented on PR #13065:
URL: https://github.com/apache/kafka/pull/13065#issuecomment-1369155807
@ijuma @satishd if you happen to have a minute, please have a look (tagging
you since you're active on similar/related tickets).
--
This is an automated message from the Apache Git Servi
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Yurchenko reassigned KAFKA-14482:
--
Assignee: (was: Ivan Yurchenko)
> Move LogLoader to storage module
>
[
https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653766#comment-17653766
]
Ivan Yurchenko commented on KAFKA-14482:
Pausing this for a while, this is block
ivanyu opened a new pull request, #13066:
URL: https://github.com/apache/kafka/pull/13066
This commit moves `Throttler` to the `storage` module. It also creates a
Java counterpart of `KafkaMetricsGroup`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
ivanyu commented on code in PR #13066:
URL: https://github.com/apache/kafka/pull/13066#discussion_r1060293729
##
storage/src/main/java/org/apache/kafka/server/log/internals/KafkaMetricsGroup.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu commented on code in PR #13066:
URL: https://github.com/apache/kafka/pull/13066#discussion_r1060293729
##
storage/src/main/java/org/apache/kafka/server/log/internals/KafkaMetricsGroup.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
ivanyu closed pull request #13066: KAFKA-14485: Move Throttler to storage module
URL: https://github.com/apache/kafka/pull/13066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ivanyu opened a new pull request, #13067:
URL: https://github.com/apache/kafka/pull/13067
`KafkaMetricsGroup` is used by many classes. To facilitate the migration to
Java, this commit adds the Java implementation of this class. The Java
implementation is not supposed to be used as a base cl
ivanyu commented on PR #13067:
URL: https://github.com/apache/kafka/pull/13067#issuecomment-1369441609
@ijuma @satishd what do you think about this approach to rewriting
`KafkaMetricsGroup` in Java? Currently, classes-users of the
`KafkaMetricsGroup` trait sometimes override its methods to
clolov commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1369472092
Hello @cadonna, I have rebased the pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
28 matches
Mail list logo
