[GitHub] [kafka] mimaison merged pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-04 Thread GitBox
mimaison merged PR #13052: URL: https://github.com/apache/kafka/pull/13052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ijuma commented on pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-04 Thread GitBox
ijuma commented on PR #13049: URL: https://github.com/apache/kafka/pull/13049#issuecomment-1370775605 I went ahead and merged this to unblock other PRs, but happy to follow up if @mimaison or @junrao have additional comments. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-14569) Migrate EmbeddedKafkaCluster used by Connect integration tests from EmbeddedZookeeper to KRaft

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654391#comment-17654391 ] Ismael Juma commented on KAFKA-14569: - Thanks for the JIRA. +1 for migrating the Con

[GitHub] [kafka] ijuma merged pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-04 Thread GitBox
ijuma merged PR #13049: URL: https://github.com/apache/kafka/pull/13049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mimaison commented on pull request #13052: KAFKA-14545: Make MirrorCheckpointTask.checkpoint handle null offsetAndMetadata more gracefully

2023-01-04 Thread GitBox
mimaison commented on PR #13052: URL: https://github.com/apache/kafka/pull/13052#issuecomment-1370753786 I agree, I don't think this qualifies as a blocker for 3.3.2 or 3.4.0. I'll merge in trunk only for now. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module

2023-01-04 Thread GitBox
divijvaidya commented on code in PR #13065: URL: https://github.com/apache/kafka/pull/13065#discussion_r1061339081 ## storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Updated] (KAFKA-14569) Migrate EmbeddedKafkaCluster used by Connect integration tests from EmbeddedZookeeper to KRaft

2023-01-04 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-14569: --- Description: ZooKeeper mode is going to be deprecated in Apache Kafka 4.0. Connect currently uses a

[jira] [Created] (KAFKA-14569) Migrate EmbeddedKafkaCluster used by Connect integration tests from EmbeddedZookeeper to KRaft

2023-01-04 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-14569: -- Summary: Migrate EmbeddedKafkaCluster used by Connect integration tests from EmbeddedZookeeper to KRaft Key: KAFKA-14569 URL: https://issues.apache.org/jira/browse/KAFKA-14569

[GitHub] [kafka] ijuma commented on a diff in pull request #13064: MINOR: bump streams quickstart pom versions and add to list in gradle.properties

2023-01-04 Thread GitBox
ijuma commented on code in PR #13064: URL: https://github.com/apache/kafka/pull/13064#discussion_r1061309874 ## gradle.properties: ## @@ -20,6 +20,9 @@ group=org.apache.kafka # - tests/kafkatest/__init__.py # - tests/kafkatest/version.py (variable DEV_VERSION) # - kafka-me

[GitHub] [kafka] ijuma commented on pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-01-04 Thread GitBox
ijuma commented on PR #13067: URL: https://github.com/apache/kafka/pull/13067#issuecomment-1370707620 @ivanyu Does this add value over the approach used by `QuorumControllerMetrics`? I haven't compared the approaches closely yet, but interested in your thoughts. -- This is an automated m

[GitHub] [kafka] ijuma commented on a diff in pull request #13065: KAFKA-14482: Move LoadedLogOffsets to storage module

2023-01-04 Thread GitBox
ijuma commented on code in PR #13065: URL: https://github.com/apache/kafka/pull/13065#discussion_r1061302703 ## storage/src/main/java/org/apache/kafka/server/log/internals/LoadedLogOffsets.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Comment Edited] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654358#comment-17654358 ] Ismael Juma edited comment on KAFKA-14524 at 1/4/23 9:08 AM: -

[jira] [Commented] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654358#comment-17654358 ] Ismael Juma commented on KAFKA-14524: - I disagree that the risk is high. We have alr

[jira] [Commented] (KAFKA-14524) Modularize `core` monolith

2023-01-04 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654356#comment-17654356 ] Josep Prat commented on KAFKA-14524: Hi [~ijuma], I'm 100% agreeing with splitting

[jira] [Commented] (KAFKA-14564) Upgrade Netty to 4.1.86.Final to fix CVEs

2023-01-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654353#comment-17654353 ] Luke Chen commented on KAFKA-14564: --- [~ableegoldman] , do we want to include this into

[jira] [Updated] (KAFKA-14564) Upgrade Netty to 4.1.86.Final to fix CVEs

2023-01-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14564: -- Fix Version/s: 3.5.0 > Upgrade Netty to 4.1.86.Final to fix CVEs > ---

[jira] [Assigned] (KAFKA-14568) Move FetchDataInfo and related to storage module

2023-01-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-14568: --- Assignee: Federico Valeri > Move FetchDataInfo and related to storage module >

[GitHub] [kafka] showuon merged pull request #13070: KAFKA-14564: Upgrade netty to 4.1.86 to address CVEs

2023-01-04 Thread GitBox
showuon merged PR #13070: URL: https://github.com/apache/kafka/pull/13070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-14568) Move FetchDataInfo and related to storage module

2023-01-04 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14568: --- Summary: Move FetchDataInfo and related to storage module Key: KAFKA-14568 URL: https://issues.apache.org/jira/browse/KAFKA-14568 Project: Kafka Issue

[GitHub] [kafka] satishd commented on a diff in pull request #13049: KAFKA-14478: Move LogConfig/CleanerConfig and related to storage module

2023-01-04 Thread GitBox
satishd commented on code in PR #13049: URL: https://github.com/apache/kafka/pull/13049#discussion_r1061238797 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -544,7 +544,7 @@ case class MetadataLogConfig(logSegmentBytes: Int, retent

<    1   2