[GitHub] [kafka] fvaleri commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-21 Thread via GitHub
fvaleri commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083319516 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] fvaleri commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-21 Thread via GitHub
fvaleri commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1399304541 @clolov @vamossagar12 I took your suggestions. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] fvaleri commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-21 Thread via GitHub
fvaleri commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083318714 ## core/src/main/scala/kafka/admin/ConfigCommand.scala: ## @@ -771,8 +772,8 @@ object ConfigCommand extends Logging { .withRequiredArg .describedAs("comma

[GitHub] [kafka] ijuma merged pull request #13121: MINOR: Remove some connect tests from Java 17 block list

2023-01-21 Thread via GitHub
ijuma merged PR #13121: URL: https://github.com/apache/kafka/pull/13121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on pull request #13121: MINOR: Remove some connect tests from Java 17 block list

2023-01-21 Thread via GitHub
ijuma commented on PR #13121: URL: https://github.com/apache/kafka/pull/13121#issuecomment-1399275209 The JDK 17 failed tests are not one of the ones I unblocked in this PR: > Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.[1] true

[jira] [Resolved] (KAFKA-10652) Raft leader should flush accumulated writes after a min size is reached

2023-01-21 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-10652. --- Resolution: Won't Fix Not sure this is needed anymore. > Raft leader should flush accumulated write

[GitHub] [kafka] vamossagar12 closed pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2023-01-21 Thread via GitHub
vamossagar12 closed pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata URL: https://github.com/apache/kafka/pull/9756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Resolved] (KAFKA-13296) Verify old assignment within StreamsPartitionAssignor

2023-01-21 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-13296. --- Resolution: Fixed > Verify old assignment within StreamsPartitionAssignor >

[GitHub] [kafka] vamossagar12 commented on pull request #11592: KAFKA-13501: Avoid state restore via rebalance if standbys are enabled

2023-01-21 Thread via GitHub
vamossagar12 commented on PR #11592: URL: https://github.com/apache/kafka/pull/11592#issuecomment-1399237152 @mjsax , This is a very old PR of mine which didn't get merged. On the ticket I see `new-streams-runtime-should-fix` added as a label. Is this fix needed anymore or should I close it

[jira] [Assigned] (KAFKA-14153) UnknownTopicOrPartitionException should include the topic/partition in the returned exception message

2023-01-21 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14153: - Assignee: (was: Sagar Rao) > UnknownTopicOrPartitionException should include the topic/part

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-21 Thread via GitHub
vamossagar12 commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083271427 ## core/src/main/scala/kafka/admin/ConfigCommand.scala: ## @@ -771,8 +772,8 @@ object ConfigCommand extends Logging { .withRequiredArg .describedAs("

[jira] [Assigned] (KAFKA-14599) MirrorMaker pluggable interfaces missing from public API

2023-01-21 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-14599: --- Assignee: Nikolay Izhikov > MirrorMaker pluggable interfaces missing from public AP

[jira] [Commented] (KAFKA-14463) ConnectorClientConfigOverridePolicy is not closed at worker shutdown

2023-01-21 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679436#comment-17679436 ] Nikolay Izhikov commented on KAFKA-14463: - Hello, [~gharris1727] , [~ChrisEgerto

[GitHub] [kafka] nizhikov opened a new pull request, #13144: KAFKA-14463 Invoke of ConnectorClientConfigOverridePolicy#close

2023-01-21 Thread via GitHub
nizhikov opened a new pull request, #13144: URL: https://github.com/apache/kafka/pull/13144 `ConnectorClientConfigOverridePolicy` implements `AutoCloseable` but close method not called. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[jira] [Assigned] (KAFKA-14463) ConnectorClientConfigOverridePolicy is not closed at worker shutdown

2023-01-21 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-14463: --- Assignee: Nikolay Izhikov > ConnectorClientConfigOverridePolicy is not closed at wo

[jira] [Resolved] (KAFKA-10637) KafkaProducer: IllegalMonitorStateException

2023-01-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-10637. - Resolution: Duplicate Marking as duplicate of KAFKA-10902 since that has a reference to the JDK

[jira] [Resolved] (KAFKA-13663) IllegalMonitorStateException in ProducerMetadata.awaitUpdate

2023-01-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-13663. - Resolution: Duplicate Marking as duplicate of KAFKA-10902 since that has a reference to the JDK

[GitHub] [kafka] yufeiyan1220 commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

2023-01-21 Thread via GitHub
yufeiyan1220 commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1399206848 > Seems like we aren't particularly consistent at removing these metrics and sensors, fetcher would be another example. Mind making the clean up more comprehensive? I have mad