[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

2023-01-22 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[GitHub] [kafka] clolov commented on pull request #12818: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2023-01-22 Thread via GitHub
clolov commented on PR #12818: URL: https://github.com/apache/kafka/pull/12818#issuecomment-1399926748 Thank you very much for the review and merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] fvaleri commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-22 Thread via GitHub
fvaleri commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083709872 ## core/src/main/scala/kafka/utils/ToolsUtils.scala: ## @@ -64,4 +65,18 @@ object ToolsUtils { println(s"%-${maxLengthOfDisplayName}s : $specifier".format(met

[GitHub] [kafka] abbccdda closed pull request #8725: KAFKA-9608: Transaction Event Simulation Test

2023-01-22 Thread via GitHub
abbccdda closed pull request #8725: KAFKA-9608: Transaction Event Simulation Test URL: https://github.com/apache/kafka/pull/8725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] sgn2607 commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2023-01-22 Thread via GitHub
sgn2607 commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r1083630069 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -169,6 +172,7 @@ public String version() { return listConsumer

[GitHub] [kafka] sgn2607 commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2023-01-22 Thread via GitHub
sgn2607 commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r1083630069 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -169,6 +172,7 @@ public String version() { return listConsumer

[GitHub] [kafka] sgn2607 commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2023-01-22 Thread via GitHub
sgn2607 commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r1083630069 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -169,6 +172,7 @@ public String version() { return listConsumer

[GitHub] [kafka] ableegoldman merged pull request #13141: MINOR: fix flaky integrations tests by using 60s default timeout for startup

2023-01-22 Thread via GitHub
ableegoldman merged PR #13141: URL: https://github.com/apache/kafka/pull/13141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] ableegoldman commented on pull request #13141: MINOR: fix flaky integrations tests by using 60s default timeout for startup

2023-01-22 Thread via GitHub
ableegoldman commented on PR #13141: URL: https://github.com/apache/kafka/pull/13141#issuecomment-1399645849 test failures are unrelated, will merge to trunk and cherrypick to 3.4 to help stabilize the release -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] hgeraldino opened a new pull request, #13146: KIP-991 Add deletedConnector flag when stopping tasks

2023-01-22 Thread via GitHub
hgeraldino opened a new pull request, #13146: URL: https://github.com/apache/kafka/pull/13146 Companion PR for [KIP-901: Add flag connectorDeleted flag when stopping task](https://cwiki.apache.org/confluence/display/KAFKA/KIP-901%3A+Add+flag+connectorDeleted+flag+when+stopping+task) This

[jira] [Comment Edited] (KAFKA-14583) Move ReplicaVerificationTool to tools

2023-01-22 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679555#comment-17679555 ] Sagar Rao edited comment on KAFKA-14583 at 1/22/23 1:20 PM:

[jira] [Commented] (KAFKA-14583) Move ReplicaVerificationTool to tools

2023-01-22 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679555#comment-17679555 ] Sagar Rao commented on KAFKA-14583: ---  This class has a dependency on `TopicFilter` whi

[jira] [Updated] (KAFKA-13571) Enabling MirrorMaker 2.0 with TLS

2023-01-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13571: --- Priority: Major (was: Blocker) > Enabling MirrorMaker 2.0 with TLS > --

[GitHub] [kafka] mimaison merged pull request #13080: KAFKA-14575: Move ClusterTool to tools module

2023-01-22 Thread via GitHub
mimaison merged PR #13080: URL: https://github.com/apache/kafka/pull/13080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison commented on a diff in pull request #13094: MINOR: Various cleanups in client tests

2023-01-22 Thread via GitHub
mimaison commented on code in PR #13094: URL: https://github.com/apache/kafka/pull/13094#discussion_r1083436604 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -331,17 +331,15 @@ public void testStressfulSituation() throws E

[GitHub] [kafka] mimaison opened a new pull request, #13145: MINOR: Remove duplicate empty string check

2023-01-22 Thread via GitHub
mimaison opened a new pull request, #13145: URL: https://github.com/apache/kafka/pull/13145 `Values.parseString()` handles empty strings and returns the same `SchemaAndValue` [[0]](https://github.com/apache/kafka/blob/trunk/connect/api/src/main/java/org/apache/kafka/connect/data/Values.java

[GitHub] [kafka] vamossagar12 commented on pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2023-01-22 Thread via GitHub
vamossagar12 commented on PR #12561: URL: https://github.com/apache/kafka/pull/12561#issuecomment-1399432804 hwy @C0urante , I was thinking should the exponential backoff thing that we have introduced as part of this PR should go somewhere in the docs? I am saying this since this is a devia

[GitHub] [kafka] vamossagar12 commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-22 Thread via GitHub
vamossagar12 commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1399432431 > @clolov @vamossagar12 took your suggestions. Thanks. Thanks @fvaleri ! Couple of minor comments. This should be good to go after that! -- This is an automated message from

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-22 Thread via GitHub
vamossagar12 commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083413458 ## core/src/main/scala/kafka/utils/ToolsUtils.scala: ## @@ -64,4 +65,18 @@ object ToolsUtils { println(s"%-${maxLengthOfDisplayName}s : $specifier".forma

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-22 Thread via GitHub
vamossagar12 commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083413458 ## core/src/main/scala/kafka/utils/ToolsUtils.scala: ## @@ -64,4 +65,18 @@ object ToolsUtils { println(s"%-${maxLengthOfDisplayName}s : $specifier".forma