mjsax commented on PR #13143:
URL: https://github.com/apache/kafka/pull/13143#issuecomment-1405948413
Checkstyle error:
```
> Task :streams:checkstyleTest
[2023-01-26T23:03:19.137Z] [ant:checkstyle] [ERROR]
mjsax commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1405947882
Checkstyle error:
```
> Task :streams:checkstyleTest
[2023-01-26T22:45:54.179Z] [ant:checkstyle] [ERROR]
vcrfxia commented on PR #13143:
URL: https://github.com/apache/kafka/pull/13143#issuecomment-1405780466
Thanks. Needed to update the test for the latest changes which now set
`isOpen = true` always. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the
vcrfxia commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1405766435
Thanks @mjsax , fixed now. Wasn't sure whether it'd be better to add a dummy
close callback just for the single test or for all tests (even the ones which
do not call close(), and
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681123#comment-17681123
]
Terry Beard commented on KAFKA-14565:
-
[~ChrisEgerton] I created the PR
h1. Kafka 14565:
beardt opened a new pull request, #13168:
URL: https://github.com/apache/kafka/pull/13168
Added try/catch within Abstract::getConfigInstances to enable clean up any
available instances (interceptors in this case) resources.
### Committer Checklist (excluded from commit message)
-
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Summary: Interceptor Resource Leakage (was: Fix Interceptor Resource
Leakage)
> Interceptor
[
https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Terry Beard updated KAFKA-14565:
Summary: Interceptor Resource Leak (was: Interceptor Resource Leakage)
> Interceptor Resource
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681096#comment-17681096
]
Alexandre Dupriez edited comment on KAFKA-14139 at 1/26/23 7:36 PM:
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681096#comment-17681096
]
Alexandre Dupriez edited comment on KAFKA-14139 at 1/26/23 7:35 PM:
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681096#comment-17681096
]
Alexandre Dupriez commented on KAFKA-14139:
---
Started to look at this JIRA. Please let me know
[
https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Dupriez reassigned KAFKA-14139:
-
Assignee: Alexandre Dupriez
> Replaced disk can lead to loss of committed data
mimaison merged PR #13131:
URL: https://github.com/apache/kafka/pull/13131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
big-andy-coates commented on PR #7414:
URL: https://github.com/apache/kafka/pull/7414#issuecomment-1405439947
FYI, this is probably being fixed because of this:
[
https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14623:
--
Fix Version/s: 3.4.1
3.3.3
> OAuth's HttpAccessTokenRetriever potentially leaks
vamossagar12 commented on PR #13095:
URL: https://github.com/apache/kafka/pull/13095#issuecomment-1405382219
> Sorry for the delay. Thanks for the PR, I left a few minor suggestions.
No problem! I addressed the comments. Thanks for the review.
--
This is an automated message from
vamossagar12 commented on code in PR #13095:
URL: https://github.com/apache/kafka/pull/13095#discussion_r1088168895
##
tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
vamossagar12 commented on code in PR #13095:
URL: https://github.com/apache/kafka/pull/13095#discussion_r1088161412
##
tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
guozhangwang commented on PR #12654:
URL: https://github.com/apache/kafka/pull/12654#issuecomment-1405370976
This PR is now ready for review @cadonna @lucasbru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681058#comment-17681058
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on PR #410:
URL:
mimaison commented on code in PR #13095:
URL: https://github.com/apache/kafka/pull/13095#discussion_r1088121137
##
tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
rondagostino commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1088113461
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -392,14 +394,36 @@ class ControllerApis(val requestChannel: RequestChannel,
val
viktorsomogyi commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1087986328
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java:
##
@@ -119,7 +126,16 @@ public class MirrorMaker {
public
David Arthur created KAFKA-14656:
Summary: Brokers rejecting LISR during ZK migration
Key: KAFKA-14656
URL: https://issues.apache.org/jira/browse/KAFKA-14656
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681022#comment-17681022
]
Omnia Ibrahim commented on KAFKA-14525:
---
[~fvaleri] I had a look into the PR, I think Mickael and
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087838897
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087826981
##
server-common/src/test/java/org/apache/kafka/server/util/TopicFilterTest.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lucasbru commented on code in PR #13164:
URL: https://github.com/apache/kafka/pull/13164#discussion_r1087656183
##
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Consumed.scala:
##
@@ -43,7 +43,7 @@ object Consumed {
ConsumedJ.`with`(keySerde,
rajinisivaram merged PR #13166:
URL: https://github.com/apache/kafka/pull/13166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #13143:
URL: https://github.com/apache/kafka/pull/13143#issuecomment-1404747240
Seems some of you newly added tests fail. Can you have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mjsax commented on PR #13142:
URL: https://github.com/apache/kafka/pull/13142#issuecomment-1404744058
There is a test failure -- seems you need to update `shouldCloseIterator()`
test and set a callback via `onClose()`?
--
This is an automated message from the Apache Git Service.
To
Romain Quinio created KAFKA-14655:
-
Summary: Case-insensitive header key operations in Java client
Key: KAFKA-14655
URL: https://issues.apache.org/jira/browse/KAFKA-14655
Project: Kafka
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087551664
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087550486
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087550486
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087550310
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
vamossagar12 commented on PR #13158:
URL: https://github.com/apache/kafka/pull/13158#issuecomment-1404671786
> TopicPartitionFilter
@fvaleri , sorry about the build failures. I hadn't run the checkstyle for
core on my local before pushing. I will work on the TopicPartitionFilter
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087521793
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
vamossagar12 commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1087521073
##
server-common/src/main/java/org/apache/kafka/server/util/TopicFilter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
39 matches
Mail list logo
