[GitHub] [kafka] mjsax commented on pull request #7414: MINOR: Fixed a division by 0 scenario

mjsax commented on PR #7414: URL: https://github.com/apache/kafka/pull/7414#issuecomment-1416593923 Addressed via https://github.com/apache/kafka/pull/13175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] mjsax merged pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax merged PR #13143: URL: https://github.com/apache/kafka/pull/13143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13021: KAFKA-14468: Implement CommitRequestManager to manage the commit and autocommit requests

guozhangwang commented on code in PR #13021: URL: https://github.com/apache/kafka/pull/13021#discussion_r1096346374 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/GroupStateManager.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] rondagostino opened a new pull request, #13198: MINOR: Rename IBP_3_4_IV1 as added for KIP-405 to IBP_3_5_IV0

rondagostino opened a new pull request, #13198: URL: https://github.com/apache/kafka/pull/13198 https://github.com/apache/kafka/pull/11390/ will be released as part of AK 3.5 but it added the MetadataVersion `IBP_3_4_IV1`. It should have been `IBP_3_5_IV0`. This change causes no incompati

[jira] [Commented] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684045#comment-17684045 ] Calvin Liu commented on KAFKA-14139: Hi Alex, just posted the KIP. Let me know if yo

[GitHub] [kafka] mumrah opened a new pull request, #13197: Minor: Decode the envelope requests for the request log

mumrah opened a new pull request, #13197: URL: https://github.com/apache/kafka/pull/13197 When looking at the request log for anything forwarded to the controller, all we see is ENVELOPE and the base64 encoded bytes of the request body. This patch decodes the envelope request so it c

[GitHub] [kafka] dajac commented on a diff in pull request #13195: Minor: Add JmxTool note to 3.5.0 notable changes

dajac commented on code in PR #13195: URL: https://github.com/apache/kafka/pull/13195#discussion_r1096238301 ## docs/upgrade.html: ## @@ -19,6 +19,16 @@

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

vcrfxia commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1096168089 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] Hangleton commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

Hangleton commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1095665461 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] hachikuji commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

hachikuji commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1096118406 ## clients/src/main/java/org/apache/kafka/common/protocol/Errors.java: ## @@ -372,7 +375,10 @@ public enum Errors { FETCH_SESSION_TOPIC_ID_ERROR(106, "The fetch

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1096112947 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -501,13 +501,16 @@ boolean joinGroupIfNeeded(final Timer timer

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096076032 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096074802 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096069586 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[GitHub] [kafka] jeqo commented on a diff in pull request #13177: [KAFKA-14441] Benchmark performance impact of metrics library

jeqo commented on code in PR #13177: URL: https://github.com/apache/kafka/pull/13177#discussion_r1096068517 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java: ## @@ -0,0 +1,145 @@ +package org.apache.kafka.jmh.common.metrics; + +import org.

[jira] [Assigned] (KAFKA-7735) StateChangeLogMerger tool can not work due to incorrect topic regular matches

[ https://issues.apache.org/jira/browse/KAFKA-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-7735: -- Assignee: Federico Valeri > StateChangeLogMerger tool can not work due to incorrect to

[GitHub] [kafka] fvaleri commented on pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

fvaleri commented on PR #13171: URL: https://github.com/apache/kafka/pull/13171#issuecomment-1416167959 @mimaison thanks for spotting this! I saw that ticket, but I started to test with an old log file for testing purpose, and then forgot to also test it on a recent log version. I ag

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[GitHub] [kafka] clolov commented on pull request #12777: Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest

clolov commented on PR #12777: URL: https://github.com/apache/kafka/pull/12777#issuecomment-1416159492 Great, thank you very much @guozhangwang! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1096043542 ## tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java: ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683961#comment-17683961 ] Hector Geraldino commented on KAFKA-14132: -- Hey [~divijvaidya], I'm putting to

[jira] [Comment Edited] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683951#comment-17683951 ] Matthias J. Sax edited comment on KAFKA-14660 at 2/3/23 4:52 PM: -

[jira] [Commented] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683951#comment-17683951 ] Matthias J. Sax commented on KAFKA-14660: - Not sure why the PR was not auto-link

[GitHub] [kafka] mimaison commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

mimaison commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1094648508 ## tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java: ## @@ -0,0 +1,320 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Updated] (KAFKA-14673) Add high watermark listener to Partition/Log layers

[ https://issues.apache.org/jira/browse/KAFKA-14673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14673: Summary: Add high watermark listener to Partition/Log layers (was: High watermark listener) > Ad

[GitHub] [kafka] dajac opened a new pull request, #13196: KAFKA-14673; Add high watermark listener to Partition/Log layers

dajac opened a new pull request, #13196: URL: https://github.com/apache/kafka/pull/13196 In the context of KIP-848, we implements are new group coordinator in Java. This new coordinator follows the architecture of the new quorum controller. It is basically a replicated state machine that wr

[jira] [Commented] (KAFKA-5756) Synchronization issue on flush

[ https://issues.apache.org/jira/browse/KAFKA-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683888#comment-17683888 ] Mickael Maison commented on KAFKA-5756: --- As far as I can tell this is still an issu

[jira] [Assigned] (KAFKA-14577) Move ConsoleProducer to tools

[ https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez reassigned KAFKA-14577: - Assignee: Alexandre Dupriez > Move ConsoleProducer to tools > -

[GitHub] [kafka] C0urante merged pull request #13194: MINOR: Update incorrect / misleading comment regarding rebalance exceptions in WorkerSinkTask

C0urante merged PR #13194: URL: https://github.com/apache/kafka/pull/13194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-14577) Move ConsoleProducer to tools

[ https://issues.apache.org/jira/browse/KAFKA-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14577: - Assignee: (was: Omnia Ibrahim) > Move ConsoleProducer to tools > --

[jira] [Assigned] (KAFKA-14579) Move DumpLogSegments to tools

[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim reassigned KAFKA-14579: - Assignee: (was: Omnia Ibrahim) > Move DumpLogSegments to tools > --

[GitHub] [kafka] Hangleton commented on a diff in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

Hangleton commented on code in PR #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r1095735143 ## clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java: ## @@ -32,7 +32,16 @@ private final double expMax; private final long initia

[GitHub] [kafka] clolov commented on a diff in pull request #13182: KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes

clolov commented on code in PR #13182: URL: https://github.com/apache/kafka/pull/13182#discussion_r1095729055 ## connect/runtime/src/test/resources/test-plugins/fail-to-initialize/test/plugins/OuterClass.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] Hangleton commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

Hangleton commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1095665461 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] clolov commented on pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

clolov commented on PR #13193: URL: https://github.com/apache/kafka/pull/13193#issuecomment-1415746102 Thank you for spotting this behaviour and contributing a fix! The proposed solution makes sense to me, I will just add @C0urante to put the appropriate tags for "connect" to this pull requ

[jira] [Commented] (KAFKA-14582) Move JmxTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683838#comment-17683838 ] Federico Valeri commented on KAFKA-14582: - https://github.com/apache/kafka/pull/

[GitHub] [kafka] clolov commented on pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

clolov commented on PR #13184: URL: https://github.com/apache/kafka/pull/13184#issuecomment-1415734118 I see what you mean. Okay, I am happy with it. Could you just rename the variable names from transformation to transformationStage as well? -- This is an automated message from the Apach

[GitHub] [kafka] Hangleton commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

Hangleton commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1095665461 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Commented] (KAFKA-14582) Move JmxTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683796#comment-17683796 ] Mickael Maison commented on KAFKA-14582: Can you open a small PR to add this to

[jira] [Commented] (KAFKA-14593) Move LeaderElectionCommand to tools

[ https://issues.apache.org/jira/browse/KAFKA-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683783#comment-17683783 ] Alexandre Dupriez commented on KAFKA-14593: --- Hello [~omnia_h_ibrahim], Is thi

[GitHub] [kafka] nizhikov commented on pull request #13157: KAFKA-14599 Enable javadoc for :connect:mirror module

nizhikov commented on PR #13157: URL: https://github.com/apache/kafka/pull/13157#issuecomment-1415407654 Hello @mimaison Do we still want to fix javadoc for public interfaces? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] Hangleton commented on a diff in pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

Hangleton commented on code in PR #13040: URL: https://github.com/apache/kafka/pull/13040#discussion_r1095498625 ## storage/src/main/java/org/apache/kafka/server/log/internals/ProducerStateManager.java: ## @@ -0,0 +1,671 @@ +/* + * Licensed to the Apache Software Foundation (ASF