[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-11 Thread via GitHub
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1426964876 Sorry for missed adding the reviewers section in the merge commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] satishd merged pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-11 Thread via GitHub
satishd merged PR #13040: URL: https://github.com/apache/kafka/pull/13040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-11 Thread via GitHub
satishd commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1426961566 All the tests are passed, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

2023-02-11 Thread via GitHub
ijuma commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1103748681 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ijuma commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-11 Thread via GitHub
ijuma commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1426949004 @satishd the latest CI run is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [kafka] chia7712 opened a new pull request, #13233: MINOR: the package of JmxTool is incorrect when running quota_test.py

2023-02-11 Thread via GitHub
chia7712 opened a new pull request, #13233: URL: https://github.com/apache/kafka/pull/13233 related to #13136 `JmxTool` was moved from `kafka.tools.JmxTool` to `org.apache.kafka.tools.JmxTool`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and im

[GitHub] [kafka] ijuma commented on pull request #13136: KAFKA-14582: Move JmxTool to tools

2023-02-11 Thread via GitHub
ijuma commented on PR #13136: URL: https://github.com/apache/kafka/pull/13136#issuecomment-1426833220 Looks like this caused some system test failures: http://confluent-kafka-system-test-results.s3-us-west-2.amazonaws.com/trunk/2023-02-11--001.system-test-kafka-trunk--1676126329--confluentin

[GitHub] [kafka] ijuma commented on pull request #13040: KAFKA-14480 Move/Rewrite ProducerStateManager to storage module.

2023-02-11 Thread via GitHub
ijuma commented on PR #13040: URL: https://github.com/apache/kafka/pull/13040#issuecomment-1426831625 Looks like the last commit caused a number of test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

2023-02-11 Thread via GitHub
dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1426787247 @ijuma yes, somehow build on Jenkins fails to start, I will rebase and then test on my local box (with Windows/Linux). -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] anshuman35 opened a new pull request, #13232: Update WordCountDemo.java

2023-02-11 Thread via GitHub
anshuman35 opened a new pull request, #13232: URL: https://github.com/apache/kafka/pull/13232 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

[GitHub] [kafka] dajac commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

2023-02-11 Thread via GitHub
dajac commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1426658835 Would it make sense to decouple the switch to a ConcurrentHashMap from adding this metric? Given that there is no consensus, we could tackle this larger change separately if we want to. The