hudeqi commented on PR #13348:
URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471416257
>
In fact, I also have this question. The variables in stats are all
thread-unsafe at present, but the printed data looks fine😂, and this is a
probabilistic problem for the version
chia7712 commented on PR #13348:
URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471410292
@robobario thanks for feedback. According to your nice catch `Stats` is
shared between all producer thread. Not only `iteration` but also other mutable
variables should be thread-safe, o
[ https://issues.apache.org/jira/browse/KAFKA-14786 ]
Yash Mayya deleted comment on KAFKA-14786:
was (Author: yash.mayya):
Hi [~ChrisEgerton], I'm assigning this ticket to myself if that's alright with
you. I'm planning to work on this together
hudeqi commented on PR #13348:
URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471374895
> Hi, I think this introduced a race condition that can cause the
producer-perf-test to log a lot of exceptions to console if num records >
50. Since the `iteration` is incremented fro
showuon commented on PR #13348:
URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471333242
@robobario , nice catch! Welcome to submit a PR to fix it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garyparrot opened a new pull request, #13398:
URL: https://github.com/apache/kafka/pull/13398
Fix the following typos in Kafka connect configs:
[send.buffer.bytes](https://kafka.apache.org/documentation/#connectconfigs_send.buffer.bytes)
and
[receive.buffer.bytes](https://kafka.apache.org/
robobario commented on PR #13348:
URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471191098
Hi, I think this introduced a race condition that can cause the
producer-perf-test to log a lot of exceptions to console if num records >
50. Since the `iteration` is incremented fr
[
https://issues.apache.org/jira/browse/KAFKA-13884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-13884.
Fix Version/s: 3.5.0
Resolution: Fixed
> KRaft Obsever are
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1137901882
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,164 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1137856849
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,164 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
cmccabe merged PR #13384:
URL: https://github.com/apache/kafka/pull/13384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
dajac commented on PR #13323:
URL: https://github.com/apache/kafka/pull/13323#issuecomment-1470710416
@CalvinConfluent Could you rebase as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jsancio merged PR #13396:
URL: https://github.com/apache/kafka/pull/13396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
CalvinConfluent commented on code in PR #13323:
URL: https://github.com/apache/kafka/pull/13323#discussion_r1137608147
##
clients/src/test/java/org/apache/kafka/common/requests/FetchRequestTest.java:
##
@@ -198,6 +204,35 @@ public void testForgottenTopics(short version) {
guozhangwang commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1137588681
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -235,4 +373,105 @@ public void ack(final long currentTimeMs)
guozhangwang commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1137549960
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -235,4 +373,105 @@ public void ack(final long currentTimeMs)
guozhangwang commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1137547234
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -207,6 +266,85 @@ public NetworkClientDelegate.UnsentRequest
cmccabe commented on code in PR #13368:
URL: https://github.com/apache/kafka/pull/13368#discussion_r1137526482
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -211,12 +214,38 @@ class ZkMigrationClient(zkClient: KafkaZkClient) extends
MigrationClient with Lo
cmccabe commented on PR #13372:
URL: https://github.com/apache/kafka/pull/13372#issuecomment-1470482252
@mumrah : `KRaftMigrationDriverTest.testMigrationWithClientException` is
failing for me with this PR. Can you take a look?
```
Gradle Test Run :metadata:test > Gradle Test Execut
Chia-Ping Tsai created KAFKA-14811:
--
Summary: The forwarding requests are discarded when network client
is changed to/from zk/Kraft
Key: KAFKA-14811
URL: https://issues.apache.org/jira/browse/KAFKA-14811
[
https://issues.apache.org/jira/browse/KAFKA-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700698#comment-17700698
]
Divij Vaidya commented on KAFKA-14802:
--
Have you checked the value of the setting
hudeqi commented on PR #13348:
URL: https://github.com/apache/kafka/pull/13348#issuecomment-1470060354
Thx, Is this
[KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-842%3A+Add+richer+group+offset+reset+mechanisms)
interested in understanding and discussing? @chia7712 @showuon
chia7712 merged PR #13348:
URL: https://github.com/apache/kafka/pull/13348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1469956438
Many thanks David. I will try to get to this in the next couple of days.
Apologies for the delay, I wish i could get to this sooner.
--
This is an automated message from the Apache Gi
Hangleton commented on PR #13378:
URL: https://github.com/apache/kafka/pull/13378#issuecomment-1469954905
Thanks for the merge David.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1469825143
@Hangleton I just merge https://github.com/apache/kafka/pull/13378. We can
update this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
dajac merged PR #13378:
URL: https://github.com/apache/kafka/pull/13378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #13378:
URL: https://github.com/apache/kafka/pull/13378#issuecomment-1469817830
That's weird. The build is still reported `in progress` in the PR but the
build has completed. The last build results are here:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka
dajac commented on code in PR #13323:
URL: https://github.com/apache/kafka/pull/13323#discussion_r1136820680
##
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java:
##
@@ -130,10 +131,35 @@ private static Optional optionalEpoch(int
rawEpochValue) {
sionsmith commented on PR #10233:
URL: https://github.com/apache/kafka/pull/10233#issuecomment-1469564517
It would be great to consider this as more companies are requiring an audit
functionality
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
30 matches
Mail list logo
