[GitHub] [kafka] rayokota commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
rayokota commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148316785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -306,10 +297,10 @@ ConsumerRecord parseRecord(TopicPartition partition,

[GitHub] [kafka] rayokota commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
rayokota commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148316785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -306,10 +297,10 @@ ConsumerRecord parseRecord(TopicPartition partition,

[jira] [Comment Edited] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704864#comment-17704864 ] Philip Nee edited comment on KAFKA-14639 at 3/25/23 5:26 AM: -

[jira] [Comment Edited] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704864#comment-17704864 ] Philip Nee edited comment on KAFKA-14639 at 3/25/23 3:54 AM: -

[jira] [Comment Edited] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704864#comment-17704864 ] Philip Nee edited comment on KAFKA-14639 at 3/25/23 3:50 AM: -

[jira] [Commented] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704864#comment-17704864 ] Philip Nee commented on KAFKA-14639: Two issues I see... # why did consumer-4 revok

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

2023-03-24 Thread tony mancill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704843#comment-17704843 ] tony mancill commented on KAFKA-14016: -- Yes - thank you for the redirect [~pnee] !

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

2023-03-24 Thread via GitHub
jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1146805063 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -37,29 +39,28 @@ public class AssignmentMemberSpec {

[jira] [Resolved] (KAFKA-14365) Extract common logic from Fetcher

2023-03-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-14365. --- Fix Version/s: 3.5.0 Reviewer: Guozhang Wang Resolution: Fixed > Extract common logi

[GitHub] [kafka] kirktrue closed pull request #13152: KAFKA-14365 refactor fetcher, take 4

2023-03-24 Thread via GitHub
kirktrue closed pull request #13152: KAFKA-14365 refactor fetcher, take 4 URL: https://github.com/apache/kafka/pull/13152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] kirktrue closed pull request #13293: KAFKA-14365: Extract common logic from Fetcher into FetcherUtils

2023-03-24 Thread via GitHub
kirktrue closed pull request #13293: KAFKA-14365: Extract common logic from Fetcher into FetcherUtils URL: https://github.com/apache/kafka/pull/13293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-24 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1148140557 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -113,15 +112,45 @@ private void maybeAutoCommit(final long curre

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-24 Thread via GitHub
guozhangwang commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1148127234 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -113,15 +112,45 @@ private void maybeAutoCommit(final long cu

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704833#comment-17704833 ] Philip Nee commented on KAFKA-14016: Hey [~showuon] - It doesn't seem like the issue

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

2023-03-24 Thread via GitHub
CalvinConfluent commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148108087 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -449,7 +450,8 @@ public void testBalancePartitionLeaders() throws Throwab

[jira] [Created] (KAFKA-14847) Separate the callers of commitAllTasks v.s. commitTasks for EOS(-v2) and ALOS

2023-03-24 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-14847: - Summary: Separate the callers of commitAllTasks v.s. commitTasks for EOS(-v2) and ALOS Key: KAFKA-14847 URL: https://issues.apache.org/jira/browse/KAFKA-14847 Proje

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1148084290 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1148082243 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -481,6 +493,11 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = reque

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1148081688 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] guozhangwang merged pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
guozhangwang merged PR #13425: URL: https://github.com/apache/kafka/pull/13425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] guozhangwang commented on pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
guozhangwang commented on PR #13425: URL: https://github.com/apache/kafka/pull/13425#issuecomment-1483427964 LGTM, merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] guozhangwang commented on pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
guozhangwang commented on PR #13425: URL: https://github.com/apache/kafka/pull/13425#issuecomment-1483427747 I've checked the failed tests, which are irrelevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-14639: -- Assignee: Philip Nee > Kafka CooperativeStickyAssignor revokes/assigns partition in one rebal

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
guozhangwang commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148071896 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -0,0 +1,791 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704819#comment-17704819 ] Philip Nee commented on KAFKA-14016: Actually [~tmancill] - I think this is similar

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
artemlivshits commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1148060963 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] junrao commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

2023-03-24 Thread via GitHub
junrao commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148021906 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -596,6 +596,11 @@ public void checkBrokerEpoch(int brokerId, long brokerEpoch) {

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

2023-03-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704805#comment-17704805 ] Philip Nee commented on KAFKA-14016: Hey [~tmancill] - Thanks for chipping in, I thi

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-24 Thread via GitHub
guozhangwang commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148026726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -172,606 +69,41 @@ public boolean hasAvailableFetches() { * @return

[GitHub] [kafka] vcrfxia opened a new pull request, #13449: KAFKA-14491: [22/N] Add test for manual upgrade to versioned store

2023-03-24 Thread via GitHub
vcrfxia opened a new pull request, #13449: URL: https://github.com/apache/kafka/pull/13449 (This PR is stacked on https://github.com/apache/kafka/pull/13442. The first commit does not need to be reviewed separately.) This PR adds an integration test for the manual upgrade scenario to

[GitHub] [kafka] cmccabe merged pull request #13438: KAFKA-14835: Create ControllerMetadataMetricsPublisher

2023-03-24 Thread via GitHub
cmccabe merged PR #13438: URL: https://github.com/apache/kafka/pull/13438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] mumrah commented on a diff in pull request #13438: KAFKA-14835: Create ControllerMetadataMetricsPublisher

2023-03-24 Thread via GitHub
mumrah commented on code in PR #13438: URL: https://github.com/apache/kafka/pull/13438#discussion_r1147915745 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] mumrah commented on a diff in pull request #13438: KAFKA-14835: Create ControllerMetadataMetricsPublisher

2023-03-24 Thread via GitHub
mumrah commented on code in PR #13438: URL: https://github.com/apache/kafka/pull/13438#discussion_r1147915381 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -366,6 +376,8 @@ class ControllerServer( // Ensure that we're not the Raft leader prior to shutt

[GitHub] [kafka] cmccabe commented on a diff in pull request #13368: KAFKA-14796 Migrate ACLs from AclAuthorizor to KRaft

2023-03-24 Thread via GitHub
cmccabe commented on code in PR #13368: URL: https://github.com/apache/kafka/pull/13368#discussion_r1147904638 ## core/src/main/scala/kafka/zk/ZkMigrationClient.scala: ## @@ -211,12 +214,38 @@ class ZkMigrationClient(zkClient: KafkaZkClient) extends MigrationClient with Lo

[GitHub] [kafka] cmccabe commented on pull request #13368: KAFKA-14796 Migrate ACLs from AclAuthorizor to KRaft

2023-03-24 Thread via GitHub
cmccabe commented on PR #13368: URL: https://github.com/apache/kafka/pull/13368#issuecomment-1483198582 It looks good overall. I filed a separate issue to handle the batching thing. I didn't completely understand why we couldn't have a `ZkMigrationClientTest` for this, can you explain

[jira] [Commented] (KAFKA-14436) Initialize KRaft with arbitrary epoch

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704734#comment-17704734 ] Colin McCabe commented on KAFKA-14436: -- We decided to preserve and continue to use

[GitHub] [kafka] cmccabe merged pull request #13448: MINOR: Rename remote_controller_quorum to isolated_controller_quorum

2023-03-24 Thread via GitHub
cmccabe merged PR #13448: URL: https://github.com/apache/kafka/pull/13448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-14436) Initialize KRaft with arbitrary epoch

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14436. -- Fix Version/s: 3.4.0 Resolution: Won't Fix > Initialize KRaft with arbitrary epoch > --

[GitHub] [kafka] shayelkin opened a new pull request, #13448: MINOR: Rename remote_controller_quorum to isolated_controller_quorum

2023-03-24 Thread via GitHub
shayelkin opened a new pull request, #13448: URL: https://github.com/apache/kafka/pull/13448 Similar to https://github.com/apache/kafka/pull/13439: ddd652c standardized on "isolated" as the name for all the isolated modes, and renamed remote_controller_quorum to kafkatest.services.

[GitHub] [kafka] cmccabe commented on a diff in pull request #13368: KAFKA-14796 Migrate ACLs from AclAuthorizor to KRaft

2023-03-24 Thread via GitHub
cmccabe commented on code in PR #13368: URL: https://github.com/apache/kafka/pull/13368#discussion_r1147881142 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -597,6 +629,13 @@ public void run() throws Exception { compl

[jira] [Created] (KAFKA-14846) Fix overly large record batches in ZkMigrationClient

2023-03-24 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-14846: Summary: Fix overly large record batches in ZkMigrationClient Key: KAFKA-14846 URL: https://issues.apache.org/jira/browse/KAFKA-14846 Project: Kafka Issue Ty

[jira] [Resolved] (KAFKA-14493) Zk to KRaft migration state machine in KRaft controller

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14493. -- Fix Version/s: 3.4.0 Resolution: Fixed > Zk to KRaft migration state machine in KRaft c

[jira] [Commented] (KAFKA-14458) RPC Handler to ZkBrokers from KRaft Controller

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704723#comment-17704723 ] Colin McCabe commented on KAFKA-14458: -- [~showuon]: that's right. I'll close this.

[jira] [Commented] (KAFKA-14493) Zk to KRaft migration state machine in KRaft controller

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704724#comment-17704724 ] Colin McCabe commented on KAFKA-14493: -- [~showuon]: yes, this was completed in 3.4.

[jira] [Resolved] (KAFKA-14458) RPC Handler to ZkBrokers from KRaft Controller

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14458. -- Fix Version/s: 3.4.0 Resolution: Fixed > RPC Handler to ZkBrokers from KRaft Controller

[jira] [Resolved] (KAFKA-14446) API forwarding support in ZkBrokers

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14446. -- Fix Version/s: 3.4.0 Resolution: Fixed > API forwarding support in ZkBrokers >

[jira] [Commented] (KAFKA-14446) API forwarding support in ZkBrokers

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704721#comment-17704721 ] Colin McCabe commented on KAFKA-14446: -- [~showuon], yes, this was already completed

[jira] [Updated] (KAFKA-14446) API forwarding support in ZkBrokers during KRaft migration

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14446: - Summary: API forwarding support in ZkBrokers during KRaft migration (was: API forwarding suppor

[jira] [Resolved] (KAFKA-14447) Controlled shutdown for ZK brokers during migration

2023-03-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14447. -- Fix Version/s: 3.4.0 (was: 3.4.1) Resolution: Fixed > Controlled

[GitHub] [kafka] C0urante commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

2023-03-24 Thread via GitHub
C0urante commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1147779547 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1133,6 +1139,105 @@ public void setTargetState(String connName, TargetState stat

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147857120 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = requ

[GitHub] [kafka] mimaison commented on a diff in pull request #13325: KAFKA-14771: Include threads info in ConcurrentModificationException message

2023-03-24 Thread via GitHub
mimaison commented on code in PR #13325: URL: https://github.com/apache/kafka/pull/13325#discussion_r1147836371 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2547,9 +2547,10 @@ private void acquireAndEnsureOpen() { * @throws Concurre

[GitHub] [kafka] jolshan commented on pull request #13447: MINOR: Change log level for reseting epoch when topic ID is null

2023-03-24 Thread via GitHub
jolshan commented on PR #13447: URL: https://github.com/apache/kafka/pull/13447#issuecomment-1483108202 alternative to: https://github.com/apache/kafka/pull/12541 and https://github.com/apache/kafka/pull/12378 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] jolshan opened a new pull request, #13447: MINOR: Change log level for reseting epoch when topic ID is null

2023-03-24 Thread via GitHub
jolshan opened a new pull request, #13447: URL: https://github.com/apache/kafka/pull/13447 On startup, we go from topic id null to defined. We will lower the log level so folks with info level logs are not spammed. ### Committer Checklist (excluded from commit message) - [ ] Verif

[GitHub] [kafka] C0urante commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

2023-03-24 Thread via GitHub
C0urante commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1147773784 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1133,6 +1139,105 @@ public void setTargetState(String connName, TargetState stat

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147813111 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = reque

[jira] [Assigned] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-24 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez reassigned KAFKA-14845: - Assignee: Alexandre Dupriez > Broker ZNode creation can fail due to a session I

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147804661 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = requ

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147794328 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = reque

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147789029 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -481,6 +493,11 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = reque

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147787658 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = requ

[GitHub] [kafka] viktorsomogyi commented on pull request #13441: KAFKA-14836: Fix log DateTime format unit test

2023-03-24 Thread via GitHub
viktorsomogyi commented on PR #13441: URL: https://github.com/apache/kafka/pull/13441#issuecomment-1483048870 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] viktorsomogyi commented on pull request #13441: KAFKA-14836: Fix log DateTime format unit test

2023-03-24 Thread via GitHub
viktorsomogyi commented on PR #13441: URL: https://github.com/apache/kafka/pull/13441#issuecomment-1483025821 retest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [kafka] mimaison commented on a diff in pull request #13326: KAFKA-14774 the removed listeners should not be reconfigurable

2023-03-24 Thread via GitHub
mimaison commented on code in PR #13326: URL: https://github.com/apache/kafka/pull/13326#discussion_r1147752608 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -1167,6 +1168,35 @@ class DynamicBrokerReconfigurationTest extends Quoru

[GitHub] [kafka] wcarlson5 merged pull request #13382: KAFKA-14722: Make BooleanSerde public

2023-03-24 Thread via GitHub
wcarlson5 merged PR #13382: URL: https://github.com/apache/kafka/pull/13382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Assigned] (KAFKA-14800) Upgrade snappy-java Version to 1.1.9.1

2023-03-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14800: -- Assignee: Juan Ramos > Upgrade snappy-java Version to 1.1.9.1 > -

[GitHub] [kafka] mimaison merged pull request #13385: KAFKA-14800: Bump snappy-java version to 1.1.9.1

2023-03-24 Thread via GitHub
mimaison merged PR #13385: URL: https://github.com/apache/kafka/pull/13385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison merged pull request #13428: MINOR: Refactor Mirror integration tests to reduce duplication

2023-03-24 Thread via GitHub
mimaison merged PR #13428: URL: https://github.com/apache/kafka/pull/13428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-24 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Description: Our production environment faced a use case where registration of a broke

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-24 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Description: Our production environment faced a use case where registration of a broke

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-24 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Attachment: broker-registration.drawio.png > Broker ZNode creation can fail due to a s

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-24 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Attachment: (was: broker-registration.drawio) > Broker ZNode creation can fail due

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

2023-03-24 Thread via GitHub
junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1147689005 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -483,14 +493,10 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit = reque

[GitHub] [kafka] mimaison commented on pull request #13257: MINOR: Add ZK migration docs to the packaged docs

2023-03-24 Thread via GitHub
mimaison commented on PR #13257: URL: https://github.com/apache/kafka/pull/13257#issuecomment-1482926158 ping @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[jira] [Commented] (KAFKA-14751) Official website CONTACT page IRC channel link change

2023-03-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704647#comment-17704647 ] ASF GitHub Bot commented on KAFKA-14751: mimaison merged PR #494: URL: https://g

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-24 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Description: Our production environment faced a use case where registration of a broke

[jira] [Resolved] (KAFKA-14751) Official website CONTACT page IRC channel link change

2023-03-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14751. Resolution: Fixed > Official website CONTACT page IRC channel link change > -

[GitHub] [kafka] hudeqi commented on pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

2023-03-24 Thread via GitHub
hudeqi commented on PR #13446: URL: https://github.com/apache/kafka/pull/13446#issuecomment-1482923618 ![1](https://user-images.githubusercontent.com/16536770/227557713-45c967ad-9519-4de3-97d3-4714a4405050.png) -- This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-24 Thread Alexandre Dupriez (Jira)
Alexandre Dupriez created KAFKA-14845: - Summary: Broker ZNode creation can fail due to a session ID unknown to the broker Key: KAFKA-14845 URL: https://issues.apache.org/jira/browse/KAFKA-14845 Pr

[GitHub] [kafka] mimaison commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-03-24 Thread via GitHub
mimaison commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1482901060 Yes moving some of these tools is not trivial. In this case: - `kafka.tools.TerseFailure` can be replaced with `org.apache.kafka.tools.TerseException` - For `KafkaConfig` I don't

[GitHub] [kafka] mimaison commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

2023-03-24 Thread via GitHub
mimaison commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1482811940 Is this KIP complete? This has been merged but the associated [JIRA](https://issues.apache.org/jira/browse/KAFKA-13999) is not marked as resolved. -- This is an automated message from

[GitHub] [kafka] chia7712 commented on pull request #13393: KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'

2023-03-24 Thread via GitHub
chia7712 commented on PR #13393: URL: https://github.com/apache/kafka/pull/13393#issuecomment-1482717404 ``` [2023-03-23T20:27:39.266Z] Gradle Test Run :core:integrationTest > Gradle Test Executor 182 > PlaintextAdminIntegrationTest > testReplicaCanFetchFromLogStartOffsetAfterDeleteR

[jira] [Commented] (KAFKA-13922) Unable to generate coverage reports for the whole project

2023-03-24 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704565#comment-17704565 ] Andras Katona commented on KAFKA-13922: --- I have a jacoco related PR, which i want

[jira] [Assigned] (KAFKA-13922) Unable to generate coverage reports for the whole project

2023-03-24 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona reassigned KAFKA-13922: - Assignee: Andras Katona > Unable to generate coverage reports for the whole project > -

[jira] [Updated] (KAFKA-14823) Clean up ConfigProvider API

2023-03-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14823: --- Labels: nee (was: ) > Clean up ConfigProvider API > --- > >

[jira] [Updated] (KAFKA-14823) Clean up ConfigProvider API

2023-03-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14823: --- Labels: (was: nee) > Clean up ConfigProvider API > --- > >

[jira] [Updated] (KAFKA-14822) Allow restricting File and Directory ConfigProviders to specific paths

2023-03-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14822: --- Labels: need-kip (was: ) > Allow restricting File and Directory ConfigProviders to specific

[jira] [Assigned] (KAFKA-14843) Connector plugins config endpoint does not include Common configs

2023-03-24 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14843: - Assignee: Jorge Esteban Quilcate Otoya > Connector plugins config endpoint does not include Com

[GitHub] [kafka] yashmayya commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

2023-03-24 Thread via GitHub
yashmayya commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1147332613 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1133,6 +1139,106 @@ public void setTargetState(String connName, TargetState sta

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

2023-03-24 Thread via GitHub
dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1147319995 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiHandler.java: ## @@ -70,6 +71,22 @@ */ ApiResult handleResponse(Node broker, Set

[jira] [Created] (KAFKA-14844) Kafka Connect's OffsetBackingStore interface should handle (de)serialization and connector namespacing

2023-03-24 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-14844: -- Summary: Kafka Connect's OffsetBackingStore interface should handle (de)serialization and connector namespacing Key: KAFKA-14844 URL: https://issues.apache.org/jira/browse/KAFKA-14844

[GitHub] [kafka] vamossagar12 commented on pull request #13361: KAFKA-14401: Resume WorkThread if Connector/Tasks reading offsets get stuck when underneath WorkThread dies

2023-03-24 Thread via GitHub
vamossagar12 commented on PR #13361: URL: https://github.com/apache/kafka/pull/13361#issuecomment-1482497859 > > I don't think that we should add retries when we already know that the exceptions that would be caught here are non-retriable. Additionally, it may be unsafe or incorrect to retr

[GitHub] [kafka] rohits64 commented on pull request #13361: KAFKA-14401: Resume WorkThread if Connector/Tasks reading offsets get stuck when underneath WorkThread dies

2023-03-24 Thread via GitHub
rohits64 commented on PR #13361: URL: https://github.com/apache/kafka/pull/13361#issuecomment-1482493926 Thanks @mukkachaitanya, @gharris1727 and @vamossagar12 for looking into this. As pointed out it should be fair to fail instead of retrying. As there might be unexpected behaviour with un

[GitHub] [kafka] vamossagar12 commented on pull request #13361: KAFKA-14401: Resume WorkThread if Connector/Tasks reading offsets get stuck when underneath WorkThread dies

2023-03-24 Thread via GitHub
vamossagar12 commented on PR #13361: URL: https://github.com/apache/kafka/pull/13361#issuecomment-1482487641 Thanks for the PR @rohits64 . I would agree with @gharris1727 and @mukkachaitanya in this case that we shouldn't add the overhead of retries in this case. Also, as pointed out, the o

[GitHub] [kafka] Stephan14 closed pull request #13435: KAFKA-14832:fix thread unsafe for GroupMetadata when persisting metadata

2023-03-24 Thread via GitHub
Stephan14 closed pull request #13435: KAFKA-14832:fix thread unsafe for GroupMetadata when persisting metadata URL: https://github.com/apache/kafka/pull/13435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] Stephan14 commented on pull request #13435: KAFKA-14832:fix thread unsafe for GroupMetadata when persisting metadata

2023-03-24 Thread via GitHub
Stephan14 commented on PR #13435: URL: https://github.com/apache/kafka/pull/13435#issuecomment-1482444228 Oh, you are right! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] hudeqi opened a new pull request, #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion o…

2023-03-24 Thread via GitHub
hudeqi opened a new pull request, #13446: URL: https://github.com/apache/kafka/pull/13446 In practice, I found that when I configure a mirror checkpoint connector, because the source cluster has a large number of group or the number of group under a topic changes frequently, the connector w

[GitHub] [kafka] yashmayya commented on a diff in pull request #13445: [KAFKA-14843] fix(connect): include base connector config to return

2023-03-24 Thread via GitHub
yashmayya commented on code in PR #13445: URL: https://github.com/apache/kafka/pull/13445#discussion_r1147220918 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -836,10 +836,19 @@ public List connectorPluginConfig(String pluginName)

[GitHub] [kafka] yashmayya commented on a diff in pull request #13375: KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode

2023-03-24 Thread via GitHub
yashmayya commented on code in PR #13375: URL: https://github.com/apache/kafka/pull/13375#discussion_r1147214226 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -195,7 +197,22 @@ public void testRestartFailedTask() t

[GitHub] [kafka] yashmayya commented on a diff in pull request #13375: KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode

2023-03-24 Thread via GitHub
yashmayya commented on code in PR #13375: URL: https://github.com/apache/kafka/pull/13375#discussion_r1147210852 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -656,6 +567,19 @@ public KafkaProducer createProducer(Map pr

  1   2   >