[GitHub] [kafka] yashmayya commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

yashmayya commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1152720712 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1133,6 +1137,111 @@ public void setTargetState(String connName, TargetState sta

[jira] [Updated] (KAFKA-14807) MirrorMaker2 config source.consumer.auto.offset.reset=latest leading to the pause of replication of consumer groups

[ https://issues.apache.org/jira/browse/KAFKA-14807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhaoli updated KAFKA-14807: --- Description: We use MirrorMaker2 to replicate messages and consumer group offsets from the Kafka cluster `s

[GitHub] [kafka] mjsax commented on pull request #13449: KAFKA-14491: [22/N] Add test for manual upgrade to versioned store

mjsax commented on PR #13449: URL: https://github.com/apache/kafka/pull/13449#issuecomment-1489704546 ``` FAILURE: Build failed with an exception. [2023-03-28T21:07:13.365Z] [2023-03-28T21:07:13.365Z] * What went wrong: [2023-03-28T21:07:13.365Z] A problem was found with the conf

[GitHub] [kafka] mjsax commented on pull request #13431: KAFKA-14491: [19/N] Combine versioned store RocksDB instances into one

mjsax commented on PR #13431: URL: https://github.com/apache/kafka/pull/13431#issuecomment-1489702228 Same compile error as on the other PR. Re-triggered Jenkins. Let's see what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax commented on a diff in pull request #13431: KAFKA-14491: [19/N] Combine versioned store RocksDB instances into one

mjsax commented on code in PR #13431: URL: https://github.com/apache/kafka/pull/13431#discussion_r1152739483 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -176,7 +184,7 @@ public synchronized KeyValueIterator range(final By

[GitHub] [kafka] mjsax commented on a diff in pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

mjsax commented on code in PR #13364: URL: https://github.com/apache/kafka/pull/13364#discussion_r1152738492 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -495,6 +501,41 @@ private boolean isLastIndex(fin

[GitHub] [kafka] mjsax commented on a diff in pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

mjsax commented on code in PR #13364: URL: https://github.com/apache/kafka/pull/13364#discussion_r1152737975 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -495,6 +501,41 @@ private boolean isLastIndex(fin

[GitHub] [kafka] mjsax commented on pull request #13470: KAFKA-14864: Close iterator in KStream windowed aggregation emit on window close

mjsax commented on PR #13470: URL: https://github.com/apache/kafka/pull/13470#issuecomment-1489686431 > Execution failed for task ':core:compileTestScala' Not sure what happened -- re-triggered Jenkins. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1489661155 Thanks @guozhangwang , I addressed the comments. Let me know how the changes are looking now. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1152708260 ## streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java: ## @@ -1291,7 +1291,6 @@ private static List> readRecords(final St

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1152707931 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +379,18 @@ public void handleAssignment(final Map> activeTasks

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1152707427 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -298,6 +299,42 @@ private void closeDirtyAndRevive(final Collection

[jira] (KAFKA-14858) Standalone herder does not handle exceptions thrown from connector taskConfigs method

[ https://issues.apache.org/jira/browse/KAFKA-14858 ] Chris Egerton deleted comment on KAFKA-14858: --- was (Author: chrisegerton): These tickets cover bugs with the same scenario but in different modes (standalone vs. distributed). > Standalon

[jira] [Commented] (KAFKA-14858) Standalone herder does not handle exceptions thrown from connector taskConfigs method

[ https://issues.apache.org/jira/browse/KAFKA-14858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706676#comment-17706676 ] Chris Egerton commented on KAFKA-14858: --- These tickets cover bugs with the same sc

[jira] [Updated] (KAFKA-14746) Throwing in Connector.taskConfigs in distributed mode generates a lot of logs

[ https://issues.apache.org/jira/browse/KAFKA-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14746: -- Summary: Throwing in Connector.taskConfigs in distributed mode generates a lot of logs (was:

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

artemlivshits commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1152665868 ## core/src/main/scala/kafka/common/InterBrokerSendThread.scala: ## @@ -28,12 +26,14 @@ import org.apache.kafka.common.requests.AbstractRequest import org.apache

[GitHub] [kafka] jsancio merged pull request #13468: MINOR: Create only one FeatureControlManager instance in ReplicationControlManagerTest

jsancio merged PR #13468: URL: https://github.com/apache/kafka/pull/13468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

artemlivshits commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1152624055 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,170 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] guozhangwang merged pull request #13380: KAFKA-14468: Committed API

guozhangwang merged PR #13380: URL: https://github.com/apache/kafka/pull/13380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] guozhangwang commented on pull request #13380: KAFKA-14468: Committed API

guozhangwang commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1489456338 Made another pass, do not have further comments. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (KAFKA-14870) KerberosLogin reLogin does not persist the login CallbackHandler

[ https://issues.apache.org/jira/browse/KAFKA-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Popa reassigned KAFKA-14870: - Assignee: Alex Popa PR - [https://github.com/apache/kafka/pull/13478] > KerberosLogin reLogin

[GitHub] [kafka] alexovidiupopa opened a new pull request, #13478: KAFKA-14870: Fix KerberosLogin#relogin to invoke super#login when cre…

alexovidiupopa opened a new pull request, #13478: URL: https://github.com/apache/kafka/pull/13478 …ating the LoginContext Refer to https://issues.apache.org/jira/browse/KAFKA-14870 for the problem description. ### Committer Checklist (excluded from commit message) - [ ] Veri

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1152543409 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] C0urante commented on a diff in pull request #13475: KAFKA-14652: Add the flow to the log context and the Connect-managed …

C0urante commented on code in PR #13475: URL: https://github.com/apache/kafka/pull/13475#discussion_r1152519227 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/LoggingContext.java: ## @@ -181,11 +187,16 @@ public static LoggingContext forOffsets(ConnectorTaskId i

[GitHub] [kafka] C0urante commented on pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

C0urante commented on PR #13433: URL: https://github.com/apache/kafka/pull/13433#issuecomment-1489363243 Thanks @gharris1727 and @urbandan for the review. I've tried to address all outstanding comments in my latest commit (including even the "wildly impractical" use case that I previously w

[GitHub] [kafka] C0urante commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

C0urante commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1152509016 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public boo

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1152509597 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -247,6 +248,10 @@ class BrokerServer( ) alterPartitionManager.start() + val addPartit

[GitHub] [kafka] C0urante commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

C0urante commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1152509083 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public boo

[GitHub] [kafka] C0urante commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

C0urante commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1152508079 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public boo

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13341: MINOR: add comment that timestamp unit is milliseconds

divijvaidya commented on code in PR #13341: URL: https://github.com/apache/kafka/pull/13341#discussion_r1152496735 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java: ## @@ -258,7 +258,8 @@ public long offset() { } /** - * The timestam

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1152485888 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] hudeqi commented on a diff in pull request #13471: KAFKA-14868:Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed

hudeqi commented on code in PR #13471: URL: https://github.com/apache/kafka/pull/13471#discussion_r1152485189 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4485,6 +4485,25 @@ class ReplicaManagerTest { assertTrue(response.usableBytes >= 0)

[GitHub] [kafka] jolshan merged pull request #13469: MINOR: Remove addOne to fix build

jolshan merged PR #13469: URL: https://github.com/apache/kafka/pull/13469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

artemlivshits commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1152479391 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13471: KAFKA-14868:Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is clo

divijvaidya commented on code in PR #13471: URL: https://github.com/apache/kafka/pull/13471#discussion_r1152474907 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4485,6 +4485,25 @@ class ReplicaManagerTest { assertTrue(response.usableBytes >= 0)

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13431: KAFKA-14491: [19/N] Combine versioned store RocksDB instances into one

vcrfxia commented on code in PR #13431: URL: https://github.com/apache/kafka/pull/13431#discussion_r1152471732 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -176,7 +184,7 @@ public synchronized KeyValueIterator range(final

[GitHub] [kafka] divijvaidya commented on pull request #13382: KAFKA-14722: Make BooleanSerde public

divijvaidya commented on PR #13382: URL: https://github.com/apache/kafka/pull/13382#issuecomment-1489271868 @SpacRocket Walker is mentioning upgrade notes for 3.5 similar to https://kafka.apache.org/documentation.html#upgrade_340_notable You can modify them at https://github.com/apache/kafk

[GitHub] [kafka] hudeqi commented on a diff in pull request #13471: KAFKA-14868:Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed

hudeqi commented on code in PR #13471: URL: https://github.com/apache/kafka/pull/13471#discussion_r1152449837 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4485,6 +4485,25 @@ class ReplicaManagerTest { assertTrue(response.usableBytes >= 0)

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13471: KAFKA-14868:Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is clo

divijvaidya commented on code in PR #13471: URL: https://github.com/apache/kafka/pull/13471#discussion_r1152441640 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4485,6 +4485,25 @@ class ReplicaManagerTest { assertTrue(response.usableBytes >= 0)

[GitHub] [kafka] philipnee commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

philipnee commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152440653 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] SpacRocket commented on pull request #13382: KAFKA-14722: Make BooleanSerde public

SpacRocket commented on PR #13382: URL: https://github.com/apache/kafka/pull/13382#issuecomment-1489249233 @wcarlson5 Thank you for your time, a question what do you mean exactly by upgrade notes? I've searched for it in wiki and couldn't find it: The KIP is currently in this table

[jira] [Commented] (KAFKA-14722) Make BooleanSerde public

[ https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706590#comment-17706590 ] Spacrocket commented on KAFKA-14722: Hello a question, the pull request has been suc

[GitHub] [kafka] philipnee commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

philipnee commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152434986 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-7499) Extend ProductionExceptionHandler to cover serialization exceptions

[ https://issues.apache.org/jira/browse/KAFKA-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706589#comment-17706589 ] Philip Nee commented on KAFKA-7499: --- I reopen a separated PR and pick up what was left

[jira] [Assigned] (KAFKA-7499) Extend ProductionExceptionHandler to cover serialization exceptions

[ https://issues.apache.org/jira/browse/KAFKA-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-7499: - Assignee: Philip Nee (was: Bangarraju Vadapalli) > Extend ProductionExceptionHandler to cover s

[GitHub] [kafka] philipnee commented on pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

philipnee commented on PR #13477: URL: https://github.com/apache/kafka/pull/13477#issuecomment-1489238181 @mjsax @vvcephei - Can I tag your names here to ask for a review? You reviewed the original PR, so I picked it up from there. -- This is an automated message from the Apache Git Servi

[GitHub] [kafka] philipnee opened a new pull request, #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

philipnee opened a new pull request, #13477: URL: https://github.com/apache/kafka/pull/13477 We want to allow ProductionExceptionHandler to handle serialization errors. In the PR, I modified the `handleSerializationError` in `DefaultProductionExceptionHandler` and the `AlwaysContinueProduc

[jira] [Assigned] (KAFKA-14746) Throwing in Connector.taskConfigs generates a lot of logs

[ https://issues.apache.org/jira/browse/KAFKA-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spacrocket reassigned KAFKA-14746: -- Assignee: (was: Spacrocket) > Throwing in Connector.taskConfigs generates a lot of logs >

[GitHub] [kafka] cmccabe merged pull request #13462: KAFKA-14857: Fix some MetadataLoader bugs

cmccabe merged PR #13462: URL: https://github.com/apache/kafka/pull/13462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

vcrfxia commented on code in PR #13364: URL: https://github.com/apache/kafka/pull/13364#discussion_r1152370089 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -495,6 +501,41 @@ private boolean isLastIndex(f

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

vcrfxia commented on code in PR #13364: URL: https://github.com/apache/kafka/pull/13364#discussion_r1152358984 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -495,6 +501,41 @@ private boolean isLastIndex(f

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

vcrfxia commented on code in PR #13364: URL: https://github.com/apache/kafka/pull/13364#discussion_r1152358196 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -495,6 +501,41 @@ private boolean isLastIndex(f

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

vcrfxia commented on code in PR #13364: URL: https://github.com/apache/kafka/pull/13364#discussion_r1152353341 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -341,8 +345,10 @@ public void insertAsLatest(fi

[GitHub] [kafka] andymg3 commented on pull request #13468: MINOR: Create only one FeatureControlManager instance in ReplicationControlManagerTest

andymg3 commented on PR #13468: URL: https://github.com/apache/kafka/pull/13468#issuecomment-1489108293 > Restarted the Jenkins build. @andymg3 you may need to merge the latest `trunk` to remove the compilation error. Thanks @jsancio. I just merged from `trunk` and have updated the PR

[GitHub] [kafka] C0urante commented on a diff in pull request #13458: KAFKA-14838: Add flow/connector/task/role information to MM2 Kafka cl…

C0urante commented on code in PR #13458: URL: https://github.com/apache/kafka/pull/13458#discussion_r1152299630 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java: ## @@ -223,6 +231,15 @@ ForwardingAdmin forwardingAdmin(Map config) {

[GitHub] [kafka] jsancio commented on pull request #13468: MINOR: Create only one FeatureControlManager instance in ReplicationControlManagerTest

jsancio commented on PR #13468: URL: https://github.com/apache/kafka/pull/13468#issuecomment-1489094237 Restarted the Jenkins build. @andymg3 you may need to merge the latest `trunk` to remove the compilation error. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152318162 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152314761 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152313744 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152306205 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152305874 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

C0urante commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1152216232 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152285443 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152284259 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152276204 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152275571 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152272541 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152265456 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149659044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152261139 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (KAFKA-14829) Consolidate reassignment logic in PartitionReassignmentReplicas

[ https://issues.apache.org/jira/browse/KAFKA-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14829. Fix Version/s: 3.5.0 Resolution: Fixed > Consolidate reassi

[GitHub] [kafka] jsancio merged pull request #13440: KAFKA-14829: Consolidate reassignment logic into PartitionReassignmentReplicas

jsancio merged PR #13440: URL: https://github.com/apache/kafka/pull/13440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-14870) KerberosLogin reLogin does not persist the login CallbackHandler

Alex Popa created KAFKA-14870: - Summary: KerberosLogin reLogin does not persist the login CallbackHandler Key: KAFKA-14870 URL: https://issues.apache.org/jira/browse/KAFKA-14870 Project: Kafka I

[GitHub] [kafka] dajac opened a new pull request, #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

dajac opened a new pull request, #13476: URL: https://github.com/apache/kafka/pull/13476 This PR adds the GroupMetadataManager to the group-coordinator module. This manager is responsible for handling the groups management, the members management and the entire reconciliation process. At th

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152217710 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152204557 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152199939 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152198768 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1152197788 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -37,29 +39,28 @@ public class AssignmentMemberSpec {

[GitHub] [kafka] jolshan commented on a diff in pull request #13469: MINOR: Remove addOne to fix build

jolshan commented on code in PR #13469: URL: https://github.com/apache/kafka/pull/13469#discussion_r1152191775 ## core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala: ## @@ -433,7 +433,7 @@ class ZkMigrationClientTest extends QuorumTestHarness { def migrateAclsAndVe

[GitHub] [kafka] mumrah commented on a diff in pull request #13469: MINOR: Remove addOne to fix build

mumrah commented on code in PR #13469: URL: https://github.com/apache/kafka/pull/13469#discussion_r1152189688 ## core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala: ## @@ -433,7 +433,7 @@ class ZkMigrationClientTest extends QuorumTestHarness { def migrateAclsAndVer

[GitHub] [kafka] C0urante commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

C0urante commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1152188561 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetUtils.java: ## @@ -53,4 +63,64 @@ public static void validateFormat(Map offsetData) {

[GitHub] [kafka] C0urante commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

C0urante commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1152074240 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1133,6 +1137,111 @@ public void setTargetState(String connName, TargetState stat

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706496#comment-17706496 ] Travis Bischel commented on KAFKA-7739: --- [~showuon] thanks. How does that affect th

[GitHub] [kafka] philipnee commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1488874445 Not entirely sure what this is: `[2023-03-29T05:12:47.884Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-13269/core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala:436:50:

[GitHub] [kafka] hudeqi commented on pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

hudeqi commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1488811902 > Hi, thanks for your attention to this issue. I think there is a difference between this problem and the LogDirectory scenario you mentioned: this is when a partition is balancing

[GitHub] [kafka] urbandan commented on pull request #13475: KAFKA-14652: Add the flow to the log context and the Connect-managed …

urbandan commented on PR #13475: URL: https://github.com/apache/kafka/pull/13475#issuecomment-1488799331 @viktorsomogyi @C0urante @mimaison You had some changes/review in this part of the code lately, could you please review? This is loosely related to KAFKA-14838 -- This is an automated

[GitHub] [kafka] urbandan opened a new pull request, #13475: KAFKA-14652: Add the flow to the log context and the Connect-managed …

urbandan opened a new pull request, #13475: URL: https://github.com/apache/kafka/pull/13475 …client.ids in MM2 dedicated mode MM2 runs multiple Connect workers in a single process, and the Connectors inside each worker have identical names. This means that the current logging generat

[GitHub] [kafka] hudeqi commented on pull request #13471: KAFKA-14868:Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed

hudeqi commented on PR #13471: URL: https://github.com/apache/kafka/pull/13471#issuecomment-1488790111 Hello, I added a count attribute to the KafkaMetricsGroup class to facilitate unit testing for all such situations. So a [jira](https://issues.apache.org/jira/browse/KAFKA-14868) was raise

[jira] [Updated] (KAFKA-14868) Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed

[ https://issues.apache.org/jira/browse/KAFKA-14868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-14868: --- Description: In some current classes, some metrics are always registered when loading, but it often occurs

[jira] [Updated] (KAFKA-14868) Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed

[ https://issues.apache.org/jira/browse/KAFKA-14868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-14868: --- Description: In some current classes, some metrics are always registered when loading, but it often occurs t

[jira] [Created] (KAFKA-14869) txn and group coordinator downgrade foundation

Jeff Kim created KAFKA-14869: Summary: txn and group coordinator downgrade foundation Key: KAFKA-14869 URL: https://issues.apache.org/jira/browse/KAFKA-14869 Project: Kafka Issue Type: Task

[jira] [Assigned] (KAFKA-14868) Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed

[ https://issues.apache.org/jira/browse/KAFKA-14868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi reassigned KAFKA-14868: -- Assignee: hudeqi > Add metric counting capability to KafkaMetricsGroup to facilitate checking > that

[jira] [Created] (KAFKA-14868) Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed

hudeqi created KAFKA-14868: -- Summary: Add metric counting capability to KafkaMetricsGroup to facilitate checking that the metric is missed when it is closed Key: KAFKA-14868 URL: https://issues.apache.org/jira/browse/KAF

[GitHub] [kafka] C0urante commented on pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on PR #13373: URL: https://github.com/apache/kafka/pull/13373#issuecomment-1488710656 @tinaselenge I owe you a big apology! I think the API you had for the `ConfigPropertyFilter` interface was correct the first time around. The double-check logic is necessary

[jira] [Updated] (KAFKA-14774) the removed listeners should not be reconfigurable

[ https://issues.apache.org/jira/browse/KAFKA-14774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-14774: --- Fix Version/s: 3.4.1 > the removed listeners should not be reconfigurable >

[GitHub] [kafka] chia7712 merged pull request #13472: KAFKA-14774 the removed listeners should not be reconfigurable

chia7712 merged PR #13472: URL: https://github.com/apache/kafka/pull/13472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] chia7712 commented on pull request #13472: KAFKA-14774 the removed listeners should not be reconfigurable

chia7712 commented on PR #13472: URL: https://github.com/apache/kafka/pull/13472#issuecomment-1488690607 `JDK 8 and Scala 2.12`, `JDK 17 and Scala 2.13`, and `JDK 11 and Scala 2.13` pass. will merge it. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] divijvaidya commented on pull request #13437: KAFKA-14828: Remove R/W locks using persistent data structures

divijvaidya commented on PR #13437: URL: https://github.com/apache/kafka/pull/13437#issuecomment-1488637379 Very interesting change! We can follow this pattern in many other places in the code base. However, I would like to understand first why we didn't consider usage of native Java

[GitHub] [kafka] divijvaidya commented on pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

divijvaidya commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1488620100 Hi @hudeqi If I understand the motivation correctly, in the current behaviour, we pause log cleaners for offline partitions. Since these logs are never cleaned up, they will remai

  1   2   >