rohits64 commented on code in PR #13361:
URL: https://github.com/apache/kafka/pull/13361#discussion_r1182075901
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##
@@ -316,6 +316,9 @@ public Map convert(Void result) {
//
mjsax commented on code in PR #13656:
URL: https://github.com/apache/kafka/pull/13656#discussion_r1182064796
##
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##
@@ -106,7 +106,11 @@ private static class ValueList {
}
int next() {
mjsax opened a new pull request, #13656:
URL: https://github.com/apache/kafka/pull/13656
Co-Author: @vcrfxia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530817064
Timeout:
```
16:34:05 An error occurred while executing multiple actions in parallel.
16:34:05 Any errors that occurred are shown below.
16:34:05
16:34:05 An error occurred
showuon merged PR #13648:
URL: https://github.com/apache/kafka/pull/13648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #13648:
URL: https://github.com/apache/kafka/pull/13648#issuecomment-1530760022
Failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 /
splett2 commented on code in PR #13655:
URL: https://github.com/apache/kafka/pull/13655#discussion_r1182012620
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -150,17 +150,6 @@ public static String randomString(final int len) {
public static File
splett2 opened a new pull request, #13655:
URL: https://github.com/apache/kafka/pull/13655
The integration tests seem to create an unnecessarily large number of
threads. This reduces the number of threads created per integration test
harness broker.
### Committer Checklist (excluded
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530538551
\cc @mimaison as RM for 3.5.0 -- I hope we did not introduce any issues
without noticing it... 爛 -- but if we find anything, it could block/delay
3.5.0...
--
This is an automated
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530533230
> Nice catch
Well, rather embarrassing... I reviewed and merge the PR introducing the
issue...
--
This is an automated message from the Apache Git Service.
To respond to the
mjsax commented on PR #13654:
URL: https://github.com/apache/kafka/pull/13654#issuecomment-1530523163
Triggered a system test run:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5653/
--
This is an automated message from the Apache Git Service.
To respond to the
mjsax opened a new pull request, #13654:
URL: https://github.com/apache/kafka/pull/13654
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181948021
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3405,6 +3406,52 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181945985
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -968,13 +1035,23 @@ private void transitionTo(State target) {
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181943662
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -424,6 +477,11 @@ ProducerIdAndEpoch producerIdAndEpoch() {
}
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181940044
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -384,14 +436,19 @@ synchronized boolean isAborting() {
}
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181939941
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -384,14 +436,19 @@ synchronized boolean isAborting() {
}
jolshan commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181933587
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -263,7 +263,14 @@ public void run() {
while (!forceClose &&
kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181929278
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -968,13 +1035,23 @@ private void transitionTo(State target) {
jolshan commented on code in PR #13607:
URL: https://github.com/apache/kafka/pull/13607#discussion_r1181887737
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -744,6 +751,7 @@ class ReplicaManager(val config: KafkaConfig,
}
// map not yet
jolshan commented on code in PR #13607:
URL: https://github.com/apache/kafka/pull/13607#discussion_r1181887737
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -744,6 +751,7 @@ class ReplicaManager(val config: KafkaConfig,
}
// map not yet
jolshan commented on code in PR #13607:
URL: https://github.com/apache/kafka/pull/13607#discussion_r1181887737
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -744,6 +751,7 @@ class ReplicaManager(val config: KafkaConfig,
}
// map not yet
[
https://issues.apache.org/jira/browse/KAFKA-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718338#comment-17718338
]
Manasvi Gupta commented on KAFKA-10859:
---
This issue appears to have been resolved already in
hachikuji commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1181734242
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -968,13 +1035,23 @@ private void transitionTo(State target) {
C0urante merged PR #13635:
URL: https://github.com/apache/kafka/pull/13635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718258#comment-17718258
]
Chris Egerton commented on KAFKA-14876:
---
[~yash.mayya] I think it's worth documenting the stop API
mumrah closed pull request #13027: MINOR Send ZK broker epoch in registration
URL: https://github.com/apache/kafka/pull/13027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mumrah commented on PR #13027:
URL: https://github.com/apache/kafka/pull/13027#issuecomment-1529838802
Closing this old PR. We ended up going back to the boolean field for
IsMigratingZkBroker
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lianetm commented on code in PR #13605:
URL: https://github.com/apache/kafka/pull/13605#discussion_r1181594901
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -157,9 +161,39 @@ public void testCommitted() {
}
mumrah merged PR #13628:
URL: https://github.com/apache/kafka/pull/13628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah commented on PR #13628:
URL: https://github.com/apache/kafka/pull/13628#issuecomment-1529733999
Two test failures look unrelated
* kafka.api.PlaintextConsumerTest.testSubsequentPatternSubscription()
*
showuon commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181545427
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -942,13 +974,19 @@ class UnifiedLog(@volatile var logStartOffset: Long,
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181520975
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -581,11 +588,18 @@ public void run() {
if (isLeader()) {
//
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181532348
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -595,6 +609,193 @@ public void run() {
}
}
+public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181529149
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -595,6 +609,193 @@ public void run() {
}
}
+public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181528820
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -595,6 +609,193 @@ public void run() {
}
}
+public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181527119
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -595,6 +609,193 @@ public void run() {
}
}
+public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181526976
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -595,6 +609,193 @@ public void run() {
}
}
+public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1181520975
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -581,11 +588,18 @@ public void run() {
if (isLeader()) {
//
satishd commented on PR #13535:
URL: https://github.com/apache/kafka/pull/13535#issuecomment-1529600204
>LGTM! @satishd , will there be other tests added as in the PR description
said, or there will be follow-up PRs to add them?
@showuon Those will be added as followups.
--
This
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1181519032
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -600,25 +622,208 @@ public String toString() {
}
}
-long
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1181518738
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -600,25 +622,208 @@ public String toString() {
}
}
-long
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1181518576
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1160,48 +1171,100 @@ class ReplicaManager(val config: KafkaConfig,
fetchPartitionStatus +=
showuon commented on PR #13653:
URL: https://github.com/apache/kafka/pull/13653#issuecomment-1529412878
@niket-goel @cmccabe @mumrah , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon opened a new pull request, #13653:
URL: https://github.com/apache/kafka/pull/13653
Fix NPE while merging the deltatable. Because it's possible that hashTier is
not null but deltatable is null (ex: removing data), we should have null check
while merging for `deltatable` like other
vamossagar12 commented on PR #13594:
URL: https://github.com/apache/kafka/pull/13594#issuecomment-1529384725
i think this PR. has a few more test errors. I would debug those and push a
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
46 matches
Mail list logo
