[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-09 Thread via GitHub
dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1188385263 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,523 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-09 Thread via GitHub
dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1188378752 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dengziming commented on pull request #13691: MINOR: remove kraft readme link

2023-05-09 Thread via GitHub
dengziming commented on PR #13691: URL: https://github.com/apache/kafka/pull/13691#issuecomment-1539736425 We are still mentioning it in `upgrade.html` that says "See the config/kraft/README.md file for details." , I think we should also change it to `See the README.md#Running a Kafka

[GitHub] [kafka] dengziming commented on pull request #12318: MINOR: Support --release in FeatureCommand

2023-05-09 Thread via GitHub
dengziming commented on PR #12318: URL: https://github.com/apache/kafka/pull/12318#issuecomment-1539714488 Closing this since we are using --metadata instead of --release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dengziming closed pull request #12318: MINOR: Support --release in FeatureCommand

2023-05-09 Thread via GitHub
dengziming closed pull request #12318: MINOR: Support --release in FeatureCommand URL: https://github.com/apache/kafka/pull/12318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-09 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1188323433 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] showuon opened a new pull request, #13691: MINOR: remove kraft readme link

2023-05-09 Thread via GitHub
showuon opened a new pull request, #13691: URL: https://github.com/apache/kafka/pull/13691 The `config/kraft/README.md` is already removed. We should also remove the link. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-09 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1188284004 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,258 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-09 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1188283174 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,574 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cadonna commented on pull request #12809: KAFKA-14324: Upgrade RocksDB to 7.1.2

2023-05-09 Thread via GitHub
cadonna commented on PR #12809: URL: https://github.com/apache/kafka/pull/12809#issuecomment-1539552693 @vepo The memory leaks are fixed in the following PRs: https://github.com/apache/kafka/pull/12935 https://github.com/apache/kafka/pull/12959 Without those fixes we would have

[GitHub] [kafka] urbandan commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics

2023-05-09 Thread via GitHub
urbandan commented on PR #13690: URL: https://github.com/apache/kafka/pull/13690#issuecomment-1539486889 @viktorsomogyi can you please take a look at this small fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] urbandan opened a new pull request, #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics

2023-05-09 Thread via GitHub
urbandan opened a new pull request, #13690: URL: https://github.com/apache/kafka/pull/13690 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Created] (KAFKA-14978) ExactlyOnceWorkerSourceTask does not remove parent metrics

2023-05-09 Thread Daniel Urban (Jira)
Daniel Urban created KAFKA-14978: Summary: ExactlyOnceWorkerSourceTask does not remove parent metrics Key: KAFKA-14978 URL: https://issues.apache.org/jira/browse/KAFKA-14978 Project: Kafka

<    1   2