atu-sharm commented on PR #13717:
URL: https://github.com/apache/kafka/pull/13717#issuecomment-1546504574
@mjsax @machi1990 can you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-14994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722317#comment-17722317
]
Atul Sharma commented on KAFKA-14994:
-
PR: https://github.com/apache/kafka/pull/13717
> jose4j is
atu-sharm opened a new pull request, #13717:
URL: https://github.com/apache/kafka/pull/13717
Upgraded jose4j to remove vulnerability,
CVE-Improper Cryptographic Algorithm
Severity: HIGH
CVSS: 7.1
Disclosure Date: 07 Feb 2023 19:00PM EST
Vulnerability Info:
[
https://issues.apache.org/jira/browse/KAFKA-14994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Atul Sharma reassigned KAFKA-14994:
---
Assignee: Atul Sharma
> jose4j is vulnerable to CVE- Improper Cryptographic Algorithm
>
mjsax commented on PR #13633:
URL: https://github.com/apache/kafka/pull/13633#issuecomment-1546485661
Thanks for the PR! Merged to `trunk` and cherry-picked to `3.5` branch. \cc
@mimaison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax merged PR #13633:
URL: https://github.com/apache/kafka/pull/13633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mehbey commented on PR #13681:
URL: https://github.com/apache/kafka/pull/13681#issuecomment-1546424538
addressed all comments from @clolov.
@cadonna - when you get a chance would you be able to review?
--
This is an automated message from the Apache Git Service.
To respond to the
mehbey commented on code in PR #13681:
URL: https://github.com/apache/kafka/pull/13681#discussion_r1192860199
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -845,17 +847,16 @@ public void
mehbey commented on code in PR #13681:
URL: https://github.com/apache/kafka/pull/13681#discussion_r1192859892
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -767,20 +770,19 @@ public void
mehbey commented on code in PR #13681:
URL: https://github.com/apache/kafka/pull/13681#discussion_r1192858937
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -845,17 +847,16 @@ public void
hachikuji commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192841324
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -461,6 +507,10 @@ public void close(Duration timeout) {
hachikuji commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192840218
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -319,27 +324,53 @@ public Map
committed(final Set
+ * If
hachikuji commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192838927
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -98,8 +97,7 @@
private final Metrics metrics;
machi1990 commented on code in PR #13712:
URL: https://github.com/apache/kafka/pull/13712#discussion_r1192833578
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -3816,8 +3811,6 @@ public Map purgeableOffsets() {
// so
machi1990 commented on code in PR #13712:
URL: https://github.com/apache/kafka/pull/13712#discussion_r1192833508
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -3778,17 +3777,13 @@ public Map purgeableOffsets() {
philipnee commented on PR #13490:
URL: https://github.com/apache/kafka/pull/13490#issuecomment-1546362095
Thanks, @hachikuji - I addressed your comment. I took a glance at the code
again, I realized there's no lock in place. Giving it a second thought, I
think we might not need it as of
philipnee commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192778418
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -96,6 +98,11 @@
private final Metrics metrics;
hachikuji commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192768691
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -546,6 +619,22 @@ public ConsumerRecords poll(long timeout) {
philipnee commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192767321
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -546,6 +619,22 @@ public ConsumerRecords poll(long timeout) {
philipnee commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192765363
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -546,6 +619,22 @@ public ConsumerRecords poll(long timeout) {
hachikuji commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1192760639
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -96,6 +98,11 @@
private final Metrics metrics;
philipnee closed pull request #13715: consumer refactor PR testing branch
URL: https://github.com/apache/kafka/pull/13715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
philipnee opened a new pull request, #13716:
URL: https://github.com/apache/kafka/pull/13716
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
dajac commented on PR #13708:
URL: https://github.com/apache/kafka/pull/13708#issuecomment-1546156904
@jeffkbkim Could you update the interface as we discussed offline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1546140859
@ijuma thank you for the comment, I'll update this pull PR and make another
one for clean-ups
--
This is an automated message from the Apache Git Service.
To respond to the message,
mjsax closed pull request #13578: MINOR: update .asf.yaml
URL: https://github.com/apache/kafka/pull/13578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
mehbey commented on PR #13709:
URL: https://github.com/apache/kafka/pull/13709#issuecomment-1546133742
@showuon and @clolov - Thank you for your suggestion to create a small KIP.
I will update this thread once the KIP is ready.
@kirktrue, I agree that we can make the allowable skew a
[
https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edoardo Comar reassigned KAFKA-14996:
-
Assignee: Edoardo Comar
> CreateTopic falis with UnknownServerException if num
Edoardo Comar created KAFKA-14996:
-
Summary: CreateTopic falis with UnknownServerException if num
partitions >= QuorumController.MAX_RECORDS_PER_BATCH
Key: KAFKA-14996
URL:
philipnee opened a new pull request, #13715:
URL: https://github.com/apache/kafka/pull/13715
Opeing this draft PR for the purpose of running the jenkins' test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mehbey commented on code in PR #13709:
URL: https://github.com/apache/kafka/pull/13709#discussion_r1192680413
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -590,18 +593,25 @@ private static Optional
validateTimestamp(RecordBatch
philipnee closed pull request #13714: Consumer Refactor Draft PR
URL: https://github.com/apache/kafka/pull/13714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
omkreddy merged PR #13670:
URL: https://github.com/apache/kafka/pull/13670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on code in PR #13689:
URL: https://github.com/apache/kafka/pull/13689#discussion_r1192604258
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##
@@ -489,14 +498,28 @@ public boolean
[
https://issues.apache.org/jira/browse/KAFKA-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722238#comment-17722238
]
Mehari Beyene commented on KAFKA-14991:
---
Related PR: https://github.com/apache/kafka/pull/13709
>
junrao commented on PR #13535:
URL: https://github.com/apache/kafka/pull/13535#issuecomment-1546009306
@satishd : Thanks for the updated PR. Are the test failures related to this
PR especially the following ones related to remote store?
```
[Build / JDK 11 and Scala 2.13 /
kirktrue commented on PR #13708:
URL: https://github.com/apache/kafka/pull/13708#issuecomment-1545958006
Thanks @jeffkbkim!
Any chance you could add `@see` annotations to the class-level Javadoc that
points to where this is used? I see the GitHub PR description states that it's
used
kirktrue commented on PR #13709:
URL: https://github.com/apache/kafka/pull/13709#issuecomment-1545953842
Rather than hard-code the allowable skew, should it be a configuration
option that defaults to 24 hours?
--
This is an automated message from the Apache Git Service.
To respond to the
kirktrue commented on code in PR #13709:
URL: https://github.com/apache/kafka/pull/13709#discussion_r1192539289
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -590,18 +593,25 @@ private static Optional
validateTimestamp(RecordBatch
[
https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-14995:
-
Labels: newbie (was: )
> Automate asf.yaml collaborators refresh
>
vvcephei commented on PR #13713:
URL: https://github.com/apache/kafka/pull/13713#issuecomment-1545941637
Note: I've created a ticket to automate this process:
https://issues.apache.org/jira/browse/KAFKA-14995
--
This is an automated message from the Apache Git Service.
To respond to the
John Roesler created KAFKA-14995:
Summary: Automate asf.yaml collaborators refresh
Key: KAFKA-14995
URL: https://issues.apache.org/jira/browse/KAFKA-14995
Project: Kafka
Issue Type:
vvcephei commented on PR #13713:
URL: https://github.com/apache/kafka/pull/13713#issuecomment-1545913632
Here's how I generated the list:
jroesler:/home/apache/kafka$ git shortlog --numbered --summary
--since=2022-04-28 | vim -
jroesler:/home/apache/kafka$ cat
dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1192506160
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -357,6 +366,94 @@ public static Record
vvcephei opened a new pull request, #13713:
URL: https://github.com/apache/kafka/pull/13713
Updating the Collaborators and Jenkins PR Whitelist in accordance with
https://github.com/apache/kafka-site/pull/510 .
### Committer Checklist (excluded from commit message)
- [ ] Verify
clolov opened a new pull request, #13712:
URL: https://github.com/apache/kafka/pull/13712
Similar to:
https://github.com/apache/kafka/pull/13529
https://github.com/apache/kafka/pull/13621
https://github.com/apache/kafka/pull/13681
https://github.com/apache/kafka/pull/13711
jeffkbkim commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1192476699
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -357,6 +366,94 @@ public static Record
Gaurav Jetly created KAFKA-14994:
Summary: jose4j is vulnerable to CVE- Improper Cryptographic
Algorithm
Key: KAFKA-14994
URL: https://issues.apache.org/jira/browse/KAFKA-14994
Project: Kafka
clolov commented on PR #13709:
URL: https://github.com/apache/kafka/pull/13709#issuecomment-1545742076
On a separate note, if you prefix the PR name with the JIRA ticket, in this
case KAFKA-14991 (i.e. KAFKA-14991: Added a validation to check if the record
timestamp is in the future
clolov commented on PR #13709:
URL: https://github.com/apache/kafka/pull/13709#issuecomment-1545738266
I second Luke on this. I also have a slight preference to explore if we can
make the check determine whether the timestamp is in nano- or milliseconds or
change the client to explicitly
dajac commented on PR #13704:
URL: https://github.com/apache/kafka/pull/13704#issuecomment-1545714546
> i'm seeing
>
> ```
> Class Data Abstraction Coupling is 31 (max allowed is 25) classes
[ApiMessageAndVersion, ClientAssignor, ConsumerGroupCurrentMemberAssignmentKey,
dajac commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1192324622
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -357,6 +366,94 @@ public static Record
ijuma commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1545692385
It would be better to have a separate PR for clean-ups unrelated to the
Jackson dependency update.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1545689888
> @ijuma, requesting your thoughts about merging this in.
Looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jeffkbkim commented on code in PR #13704:
URL: https://github.com/apache/kafka/pull/13704#discussion_r1192291029
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -357,6 +366,94 @@ public static Record
showuon commented on PR #13709:
URL: https://github.com/apache/kafka/pull/13709#issuecomment-1545649144
@mehbey , thanks for the PR. I think the motivation of this change makes
sense. But since it makes the validator more strict than before, I'm thinking
we might need to propose a small
[
https://issues.apache.org/jira/browse/KAFKA-14980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14980:
-
Assignee: Chris Egerton
> MirrorMaker consumers don't get configs prefixed with
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192184441
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722129#comment-17722129
]
Luke Chen commented on KAFKA-7739:
--
Good catch! Thanks all!
> Kafka Tiered Storage
>
[
https://issues.apache.org/jira/browse/KAFKA-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-14954:
--
Assignee: Satish Duggana
> Use BufferPools to optimize allocation in
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana reassigned KAFKA-14953:
--
Assignee: Satish Duggana
> Add metrics for expiration of delayed remote fetch
>
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722119#comment-17722119
]
Satish Duggana commented on KAFKA-7739:
---
[~jeqo]
Good point, we can improve the javadoc about the
[
https://issues.apache.org/jira/browse/KAFKA-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-14993:
---
Description: RSM should throw a ResourceNotFoundException if it does not
have
Satish Duggana created KAFKA-14993:
--
Summary: Improve TransactionIndex instance handling while copying
to and fetching from RSM.
Key: KAFKA-14993
URL: https://issues.apache.org/jira/browse/KAFKA-14993
clolov opened a new pull request, #13711:
URL: https://github.com/apache/kafka/pull/13711
Similar to:
https://github.com/apache/kafka/pull/13529
https://github.com/apache/kafka/pull/13621
https://github.com/apache/kafka/pull/13681
**This needs to be rebased on top of
[
https://issues.apache.org/jira/browse/KAFKA-14839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722116#comment-17722116
]
Atul Sharma commented on KAFKA-14839:
-
[~mjsax] edited PR to apply this configuration in whole
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1192195822
##
core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1192210616
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -600,25 +623,210 @@ public String toString() {
}
}
-long
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192204200
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192198495
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1192196398
##
core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1192195822
##
core/src/test/scala/integration/kafka/server/DelayedRemoteFetchTest.scala:
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192195549
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192194658
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192188074
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192184441
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
satishd commented on code in PR #13535:
URL: https://github.com/apache/kafka/pull/13535#discussion_r1192183587
##
core/src/test/java/kafka/log/remote/RemoteLogReaderTest.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192182531
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192180723
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192180394
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192179523
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192174161
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192173471
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192170321
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
clolov commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192164806
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software
clolov commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192164806
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software
showuon commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1545485819
backport to v3.5 and v3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon commented on PR #13673:
URL: https://github.com/apache/kafka/pull/13673#issuecomment-1545477018
Failed tests are unrelated:
```
Build / JDK 11 and Scala 2.13 /
showuon merged PR #13673:
URL: https://github.com/apache/kafka/pull/13673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vamossagar12 commented on PR #13701:
URL: https://github.com/apache/kafka/pull/13701#issuecomment-1545470522
Aah ok. sorry I missed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
clolov commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1192144074
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac merged PR #13663:
URL: https://github.com/apache/kafka/pull/13663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1192103413
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,998 @@
+/*
+ * Licensed to the Apache Software Foundation
clolov commented on code in PR #13663:
URL: https://github.com/apache/kafka/pull/13663#discussion_r1192091604
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -0,0 +1,998 @@
+/*
+ * Licensed to the Apache Software Foundation
Nayana-ibm commented on PR #11929:
URL: https://github.com/apache/kafka/pull/11929#issuecomment-1545303272
Any update on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lanshiqin commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1191984789
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -65,6 +68,32 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ *
hudeqi commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1191942365
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1586,11 +1578,6 @@ private void resetToEmptyState() {
*/
private final
dengziming merged PR #13697:
URL: https://github.com/apache/kafka/pull/13697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dengziming commented on code in PR #13697:
URL: https://github.com/apache/kafka/pull/13697#discussion_r1191937851
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1586,11 +1578,6 @@ private void resetToEmptyState() {
*/
private
99 matches
Mail list logo
