[
https://issues.apache.org/jira/browse/KAFKA-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723002#comment-17723002
]
Chaitanya Mukka commented on KAFKA-14627:
-
Hi [~gharris1727]! Thanks a lot for t
hudeqi commented on PR #13719:
URL: https://github.com/apache/kafka/pull/13719#issuecomment-1548893409
Does anyone have a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
showuon merged PR #13720:
URL: https://github.com/apache/kafka/pull/13720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #13720:
URL: https://github.com/apache/kafka/pull/13720#issuecomment-1548878693
Reviewers: Luke Chen , vamossagar12
, Kamal Chandraprakash
, hudeqi <16120...@bjtu.edu.cn>, Christo Lolov
--
This is an automated message from the Apache Git Service.
To respond to t
showuon commented on PR #13720:
URL: https://github.com/apache/kafka/pull/13720#issuecomment-1548876268
Failed tests are unrelated:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehind
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194479029
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194477394
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194465375
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Founda
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194464178
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,868 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194463847
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194459578
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundati
C0urante opened a new pull request, #13723:
URL: https://github.com/apache/kafka/pull/13723
[Jira](https://issues.apache.org/jira/browse/KAFKA-14980)
Fixes a typo introduced in https://github.com/apache/kafka/pull/12366 that
breaks how the consumer for the source cluster is configured
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194397156
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2080 @@
+/*
+ * Licensed to the Apache Software Found
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194394856
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2080 @@
+/*
+ * Licensed to the Apache Software Found
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194394856
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2080 @@
+/*
+ * Licensed to the Apache Software Found
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194380191
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -0,0 +1,2080 @@
+/*
+ * Licensed to the Apache Software Found
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194368824
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
vvcephei merged PR #13722:
URL: https://github.com/apache/kafka/pull/13722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194252036
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194251237
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194250502
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194249412
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194246241
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194225263
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -0,0 +1,535 @@
+/*
+ * Licensed to the Apache Software Foundati
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194218869
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,868 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194211307
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,868 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194201125
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,868 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194198701
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,868 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194198701
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,868 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194188439
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundation
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194151379
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194145192
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194141365
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundati
jeffkbkim commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1194138883
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,865 @@
+/*
+ * Licensed to the Apache Software Foundati
ruslankrivoshein commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1548242140
@dengziming, could you help me in this situation?
I use `ClusterTestExtensions`, but it creates "__consumers_offset " with 5
partitions. This number doesn't fit in this tests,
mehbey commented on PR #13681:
URL: https://github.com/apache/kafka/pull/13681#issuecomment-1548206878
@machi1990, thank you for the review. I have addressed your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
divijvaidya commented on code in PR #13705:
URL: https://github.com/apache/kafka/pull/13705#discussion_r1194033848
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -369,9 +369,9 @@ class ReplicaManagerTest {
// Use the second instance of metrics gr
vvcephei commented on PR #13722:
URL: https://github.com/apache/kafka/pull/13722#issuecomment-1548065050
Hey @jlprat , do you mind reviewing this update as well? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vvcephei opened a new pull request, #13722:
URL: https://github.com/apache/kafka/pull/13722
After merging https://github.com/apache/kafka/pull/13713, I got a
notification that the github_whitelist is capped at 10.
--
This is an automated message from the Apache Git Service.
To respond
vvcephei merged PR #13713:
URL: https://github.com/apache/kafka/pull/13713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
vamossagar12 commented on PR #13646:
URL: https://github.com/apache/kafka/pull/13646#issuecomment-1548015263
Thanks @sambhav-jain-16 , @kirktrue , just to give more context, there are
ITs in connect for EOS which rely upon the position() API to assert some
messages ebing read. But they seem
jeffkbkim commented on PR #13708:
URL: https://github.com/apache/kafka/pull/13708#issuecomment-1547929984
@kirktrue thanks for the comment. I will do so when GroupMetadataManager is
merged to trunk.
@dajac updated the interface.
--
This is an automated message from the Apache Git
jeffkbkim commented on PR #13704:
URL: https://github.com/apache/kafka/pull/13704#issuecomment-1547931013
@dajac this is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
WhitEyesX opened a new pull request, #13721:
URL: https://github.com/apache/kafka/pull/13721
…ivery.timeout.ms)
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
fvaleri commented on code in PR #13720:
URL: https://github.com/apache/kafka/pull/13720#discussion_r1193803195
##
tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java:
##
@@ -325,11 +327,15 @@ public void dateFormat() {
}
private static JMXConnectorServer star
[
https://issues.apache.org/jira/browse/KAFKA-14962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya resolved KAFKA-14962.
--
Reviewer: Manikumar
Resolution: Fixed
> Whitespace in ACL configuration causes Kafka sta
divijvaidya commented on PR #13670:
URL: https://github.com/apache/kafka/pull/13670#issuecomment-1547776798
@omkreddy Thank you for your review bandwidth to merge this in 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
[
https://issues.apache.org/jira/browse/KAFKA-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14988:
-
Fix Version/s: 3.5.0
3.4.1
Reviewer: Luke Chen
> Upgrade scalaCollec
[
https://issues.apache.org/jira/browse/KAFKA-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-14988:
Assignee: Divij Vaidya
Resolution: Fixed
> Upgrade scalaCollectionCompact to v2.9 f
vamossagar12 commented on code in PR #13720:
URL: https://github.com/apache/kafka/pull/13720#discussion_r1193755075
##
tools/src/test/java/org/apache/kafka/tools/JmxToolTest.java:
##
@@ -325,11 +327,15 @@ public void dateFormat() {
}
private static JMXConnectorServer
sambhav-jain-16 commented on PR #13646:
URL: https://github.com/apache/kafka/pull/13646#issuecomment-1547732780
Hi @kirktrue
I have looked upon the changes from your refactoring PR
[here](https://github.com/apache/kafka/pull/13425/files#diff-4d70ec8fc84ee669e88d436de64d66f0d621596d98e6a3
fvaleri commented on PR #13720:
URL: https://github.com/apache/kafka/pull/13720#issuecomment-1547718210
CI job completed successfully. Failing tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722747#comment-17722747
]
Jorge Esteban Quilcate Otoya commented on KAFKA-7739:
-
Thanks all!
A
sambhav-jain-16 commented on PR #13646:
URL: https://github.com/apache/kafka/pull/13646#issuecomment-1547640800
I was able to know the reason why the position reported by
`consumer.position()` is more than the actual records consumed.
Transactional producer produces commit messages in
machi1990 commented on code in PR #13712:
URL: https://github.com/apache/kafka/pull/13712#discussion_r1193642239
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -3778,17 +3777,13 @@ public Map purgeableOffsets() {
purg
clolov commented on code in PR #13681:
URL: https://github.com/apache/kafka/pull/13681#discussion_r1193602799
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -767,20 +770,19 @@ public void
shouldAssignMultipleTasksInTasksRegistr
[
https://issues.apache.org/jira/browse/KAFKA-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722683#comment-17722683
]
Federico Valeri edited comment on KAFKA-14997 at 5/15/23 9:13 AM:
tamama commented on PR #12447:
URL: https://github.com/apache/kafka/pull/12447#issuecomment-1547473512
@showuon Thanks for your update!
@ijuma Will raise a JIRA ticket if problem remains in 3.5.0 :)
--
This is an automated message from the Apache Git Service.
To respond to the me
clolov commented on code in PR #13712:
URL: https://github.com/apache/kafka/pull/13712#discussion_r1193529399
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -3778,17 +3777,13 @@ public Map purgeableOffsets() {
purgabl
machi1990 commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1547431713
> I'll try to have a look this week. Thanks.
Thanks @showuon I appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
showuon commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1547418289
I'll try to have a look this week. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fvaleri opened a new pull request, #13720:
URL: https://github.com/apache/kafka/pull/13720
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
[
https://issues.apache.org/jira/browse/KAFKA-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722683#comment-17722683
]
Federico Valeri commented on KAFKA-14997:
-
Hi [~sagarrao], thanks for letting me
[
https://issues.apache.org/jira/browse/KAFKA-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-14983.
---
Resolution: Fixed
> Upgrade jetty-server to 9.4.51
> --
>
>
64 matches
Mail list logo