[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

erikvanoosten commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1198570974 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -600,6 +602,30 @@ public void

[GitHub] [kafka] showuon merged pull request #13710: MINOR: Fix the outdated comments of ConfigDef

showuon merged PR #13710: URL: https://github.com/apache/kafka/pull/13710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on a diff in pull request #13710: MINOR: Fix the outdated comments of ConfigDef

showuon commented on code in PR #13710: URL: https://github.com/apache/kafka/pull/13710#discussion_r1198513990 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -68,8 +68,8 @@ * int anotherConfig = (Integer) configs.get(config_with_validator); *

[GitHub] [kafka] Lucent-Wong commented on a diff in pull request #13453: KAFKA-12525: Ignoring Stale status statuses when reading from Status …

Lucent-Wong commented on code in PR #13453: URL: https://github.com/apache/kafka/pull/13453#discussion_r1198479120 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java: ## @@ -608,6 +608,20 @@ private void readTaskStatus(String key,

[jira] [Comment Edited] (KAFKA-15005) Status of KafkaConnect task not correct

[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724071#comment-17724071 ] Yu Wang edited comment on KAFKA-15005 at 5/19/23 1:48 AM: -- [~sagarrao] I

[jira] [Commented] (KAFKA-15005) Status of KafkaConnect task not correct

[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724071#comment-17724071 ] Yu Wang commented on KAFKA-15005: - [~sagarrao] I check the PR in

[jira] [Commented] (KAFKA-15005) Status of KafkaConnect task not correct

[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724070#comment-17724070 ] Yu Wang commented on KAFKA-15005: - Thanks, [~sagarrao] . Yes, looks like the this ticket is duplicated.

[GitHub] [kafka] Hangleton commented on pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on PR #13558: URL: https://github.com/apache/kafka/pull/13558#issuecomment-1553450467 (note: I will update the PR tomorrow to use Mockito stubs instead of subclasses). -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] Hangleton commented on pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on PR #13558: URL: https://github.com/apache/kafka/pull/13558#issuecomment-1553446542 Hi, Igor, Thanks for spending the time reviewing the PR and providing detailed comments. At a high-level, the problem this PR attempts to solve comes from two behaviours

[jira] [Updated] (KAFKA-15004) Topic config changes are not synced during zk to kraft migration (dual-write)

[ https://issues.apache.org/jira/browse/KAFKA-15004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15004: - Affects Version/s: 3.5.0 > Topic config changes are not synced during zk to kraft migration

[jira] [Updated] (KAFKA-15007) MV is not set correctly in the MetadataPropagator in migration.

[ https://issues.apache.org/jira/browse/KAFKA-15007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15007: - Affects Version/s: 3.5.0 > MV is not set correctly in the MetadataPropagator in migration. >

[jira] [Created] (KAFKA-15007) MV is not set correctly in the MetadataPropagator in migration.

Akhilesh Chaganti created KAFKA-15007: - Summary: MV is not set correctly in the MetadataPropagator in migration. Key: KAFKA-15007 URL: https://issues.apache.org/jira/browse/KAFKA-15007 Project:

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1198005710 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -2113,7 +2113,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo }

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1198026691 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,19 @@ public void handleAssignment(final Map>

[GitHub] [kafka] Hangleton commented on pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1553290938 Thanks Christo (@clolov) for your help on the PR, I will take a look at the changes tomorrow. Thanks! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1198005710 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -2113,7 +2113,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo }

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197924320 ## core/src/test/java/kafka/zk/ReceiptEvent.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1198005710 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -2113,7 +2113,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo }

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1198005710 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -2113,7 +2113,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo }

[GitHub] [kafka] vamossagar12 commented on pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

vamossagar12 commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1553271619 Sorry I completely missed this. Thanks @fvaleri . @ijuma do you agree with the reasoning provided by Federico? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] clolov commented on pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

clolov commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1553270438 Heya @dajac! I hope I have addressed your comments on all files except `ConsumerCoordinatorTest` and the `OffsetCommitRequestTest`, could you review everything except those two and

[GitHub] [kafka] vamossagar12 commented on pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

vamossagar12 commented on PR #13608: URL: https://github.com/apache/kafka/pull/13608#issuecomment-1553261622 @jolshan , no problem at all! Thanks for confirming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1197989841 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -104,27 +122,63 @@ public boolean maybeUpdateProducerEpoch(short

[GitHub] [kafka] clolov commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

clolov commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1197988726 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -3981,23 +4348,13 @@ private void

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1197988031 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -104,27 +122,63 @@ public boolean maybeUpdateProducerEpoch(short

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1197986988 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -183,6 +184,19 @@ private void clearProducerIds() {

[GitHub] [kafka] jolshan commented on pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on PR #13608: URL: https://github.com/apache/kafka/pull/13608#issuecomment-1553256614 @[vamossagar12](https://github.com/vamossagar12) The link might have been a mistake -- I may have previously used the wrong jira number in the title and caused confusion. That ticket

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1197985175 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -600,6 +602,30 @@ public void testCoordinatorNotAvailable()

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1197984489 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateEntry.java: ## @@ -104,27 +122,63 @@ public boolean maybeUpdateProducerEpoch(short

[GitHub] [kafka] clolov commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

clolov commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1197974839 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197924320 ## core/src/test/java/kafka/zk/ReceiptEvent.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197911485 ## core/src/test/java/kafka/zk/ReceiptEvent.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Commented] (KAFKA-15002) Vulnerability in org.bitbucket.b_c_jose4j

[ https://issues.apache.org/jira/browse/KAFKA-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723925#comment-17723925 ] Arushi Rai commented on KAFKA-15002: Hi [~mimaison],  3.5.0 is upcoming release, can this

[jira] [Commented] (KAFKA-15001) CVE vulnerabilities in Jetty

[ https://issues.apache.org/jira/browse/KAFKA-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723924#comment-17723924 ] Arushi Rai commented on KAFKA-15001: Hi [~mimaison],  3.5.0 is upcoming release, can these

[jira] [Updated] (KAFKA-15001) CVE vulnerabilities in Jetty

[ https://issues.apache.org/jira/browse/KAFKA-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arushi Rai updated KAFKA-15001: --- Summary: CVE vulnerabilities in Jetty (was: CVEs vulnerabilities in Jetty ) > CVE

[jira] [Updated] (KAFKA-15002) Vulnerability in org.bitbucket.b_c_jose4j

[ https://issues.apache.org/jira/browse/KAFKA-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arushi Rai updated KAFKA-15002: --- Summary: Vulnerability in org.bitbucket.b_c_jose4j (was: Moderate vulnerability in

[jira] [Updated] (KAFKA-15001) CVEs vulnerabilities in Jetty

[ https://issues.apache.org/jira/browse/KAFKA-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arushi Rai updated KAFKA-15001: --- Summary: CVEs vulnerabilities in Jetty (was: CVE vulnerabilities in Jetty ) > CVEs

[GitHub] [kafka] dengziming commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

dengziming commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1197869315 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-15001) CVE vulnerabilities in Jetty

[ https://issues.apache.org/jira/browse/KAFKA-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arushi Rai updated KAFKA-15001: --- Summary: CVE vulnerabilities in Jetty (was: Medium vulnerabilities in Jetty ) > CVE

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197761299 ## core/src/test/java/kafka/zk/ZkBrokerRegistrationTest.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197761016 ## core/src/test/java/kafka/zk/ZkBrokerRegistrationTest.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197760645 ## core/src/test/java/kafka/zk/ZkBrokerRegistrationTest.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197760360 ## core/src/test/resources/log4j.properties: ## @@ -20,7 +20,8 @@ log4j.appender.stdout.layout.ConversionPattern=[%d] %p %m (%c:%L)%n log4j.logger.kafka=WARN

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197756841 ## core/src/test/java/kafka/zk/ZkBrokerRegistrationTest.java: ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] Hangleton commented on pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on PR #13558: URL: https://github.com/apache/kafka/pull/13558#issuecomment-1552906809 > Thank you for this PR. > > Despite the detailed information in the PR description and JIRA (thank you!), I'm still unsure as to how this happens, and whether if it's a

[GitHub] [kafka] Hangleton commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

Hangleton commented on code in PR #13719: URL: https://github.com/apache/kafka/pull/13719#discussion_r1197663944 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String, */ val

[jira] [Commented] (KAFKA-15005) Status of KafkaConnect task not correct

[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723885#comment-17723885 ] Sagar Rao commented on KAFKA-15005: --- hey [~LucentWong] thanks for reporting this. This looks very

[GitHub] [kafka] Hangleton commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

Hangleton commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1197648143 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -595,6 +609,193 @@ public void run() { } } +public void

[GitHub] [kafka] showuon commented on a diff in pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

showuon commented on code in PR #13665: URL: https://github.com/apache/kafka/pull/13665#discussion_r1197604865 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -123,6 +124,8 @@ public final class ConsumerCoordinator extends

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1197598893 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Comment Edited] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723867#comment-17723867 ] Luke Chen edited comment on KAFKA-15000 at 5/18/23 9:20 AM: [~arushir] ,

[jira] [Commented] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17723867#comment-17723867 ] Luke Chen commented on KAFKA-15000: --- [~arushir] , where do you see this is a "high vulnerability"?

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1197583887 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1197583887 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1197583887 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] soarez commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

soarez commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1197495849 ## core/src/test/resources/log4j.properties: ## @@ -20,7 +20,8 @@ log4j.appender.stdout.layout.ConversionPattern=[%d] %p %m (%c:%L)%n log4j.logger.kafka=WARN

[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

erikvanoosten commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1197514992 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -668,6 +695,7 @@ public void onFailure(RuntimeException

[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

erikvanoosten commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1197512217 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1075,6 +1078,7 @@ void

[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

erikvanoosten commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1197512217 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1075,6 +1078,7 @@ void

[GitHub] [kafka] sjzghw123 opened a new pull request, #13731: 3.4

sjzghw123 opened a new pull request, #13731: URL: https://github.com/apache/kafka/pull/13731 *Kafka3.4 Kraft for Kerberos* Kafka3.4 uses kraft to build clusters. Can SASL_Kerberos support kraft mode? If yes, how to configure it and if no, why not?* -- This is an automated

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13682: MINOR: improved exception/warn logging for stream-stream join store settings

vamossagar12 commented on code in PR #13682: URL: https://github.com/apache/kafka/pull/13682#discussion_r1197482096 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java: ## @@ -242,13 +249,21 @@ public KStream join(final KStream lhs,