[GitHub] [kafka] akatona84 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

akatona84 commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1558629671 > Is there any way to decide if a specific file/dir is meant to be a plugin? currently the code is only checking whether it is a dir or the extension is zip, jar or class. Yet for an

[GitHub] [kafka] dajac commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

dajac commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1558604752 @satishd `testResponseIncludesLeaderEpoch` fails locally. Does it pass for you? It does not seem to be related to slow CI. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-15015) Binaries contain 2 versions of reload4j

[ https://issues.apache.org/jira/browse/KAFKA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725226#comment-17725226 ] Luke Chen commented on KAFKA-15015: --- [~atusharm] , yes, you can take it. But since we'

[jira] [Commented] (KAFKA-15012) JsonConverter fails when there are leading Zeros in a field

[ https://issues.apache.org/jira/browse/KAFKA-15012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725223#comment-17725223 ] Yash Mayya commented on KAFKA-15012: Thanks for filing this Jira [~ranjanrao]. Simpl

[jira] [Commented] (KAFKA-15015) Binaries contain 2 versions of reload4j

[ https://issues.apache.org/jira/browse/KAFKA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725207#comment-17725207 ] Atul Sharma commented on KAFKA-15015: - Hi, [~mimaison] can i take this? > Binaries

[GitHub] [kafka] dajac commented on pull request #12348: KAFKA-14016: Revoke more partitions than expected in Cooperative rebalance

dajac commented on PR #12348: URL: https://github.com/apache/kafka/pull/12348#issuecomment-1558452652 Fixed by https://github.com/apache/kafka/commit/c6ad151ac3bac0d8d1d6985d230eacaa170b8984. Closing it. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] dajac closed pull request #12348: KAFKA-14016: Revoke more partitions than expected in Cooperative rebalance

dajac closed pull request #12348: KAFKA-14016: Revoke more partitions than expected in Cooperative rebalance URL: https://github.com/apache/kafka/pull/12348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] satishd commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1558447525 @dajac They do not seem to be related to this PR. Please take a look at the [comment](https://github.com/apache/kafka/pull/13535#issuecomment-1549993361). -- This is an automated messa

[jira] [Commented] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725159#comment-17725159 ] Luke Chen commented on KAFKA-15000: --- If there's a CVE, it will give us more info about

[GitHub] [kafka] dependabot[bot] opened a new pull request, #13743: Bump requests from 2.24.0 to 2.31.0 in /tests

dependabot[bot] opened a new pull request, #13743: URL: https://github.com/apache/kafka/pull/13743 Bumps [requests](https://github.com/psf/requests) from 2.24.0 to 2.31.0. Release notes Sourced from https://github.com/psf/requests/releases";>requests's releases. v2.31.0 2

[GitHub] [kafka] cmccabe opened a new pull request, #13742: KAFKA-14996: Handle overly large user operations on the kcontroller

cmccabe opened a new pull request, #13742: URL: https://github.com/apache/kafka/pull/13742 Previously, if a user tried to perform an overly large batch operation on the KRaft controller (such as creating a million topics), we would create a very large number of records in memory. Our attemp

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13735: KAFKA-15003: When partitions are partition assignments change we do n…

akhileshchg commented on code in PR #13735: URL: https://github.com/apache/kafka/pull/13735#discussion_r1201206830 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -184,11 +232,36 @@ void handleTopicsDelta(Function deletedTopicNam

[GitHub] [kafka] akhileshchg commented on pull request #13741: KAFKA-15009: Handle errors while migrating ACL metadata from snapshot to Zk during DUAL_WRITE mode.

akhileshchg commented on PR #13741: URL: https://github.com/apache/kafka/pull/13741#issuecomment-1558073482 > The jira talks about ACLs and ClientQuotas. > > Were you planning on fixing ClientQuotas in this PR as well? If not, we can go ahead and merge the ACLs fix and work on ClientQ

[jira] [Commented] (KAFKA-15000) High vulnerability PRISMA-2023-0067 reported in jackson-core

[ https://issues.apache.org/jira/browse/KAFKA-15000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725111#comment-17725111 ] Arushi Rai commented on KAFKA-15000: Thanks for the update [~showuon]. We use TwistL

[jira] [Commented] (KAFKA-15001) CVE vulnerabilities in Jetty

[ https://issues.apache.org/jira/browse/KAFKA-15001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725113#comment-17725113 ] Arushi Rai commented on KAFKA-15001: Hi team,  Any update on this?  > CVE vulnerabi

[jira] [Commented] (KAFKA-15002) Vulnerability in org.bitbucket.b_c_jose4j

[ https://issues.apache.org/jira/browse/KAFKA-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725112#comment-17725112 ] Arushi Rai commented on KAFKA-15002: Hi team,  Any update on this?  > Vulnerability

[GitHub] [kafka] mumrah commented on a diff in pull request #13735: KAFKA-15003: When partitions are partition assignments change we do n…

mumrah commented on code in PR #13735: URL: https://github.com/apache/kafka/pull/13735#discussion_r1200917708 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -128,23 +133,55 @@ public void visitPartition(TopicIdPartition topicIdP

[GitHub] [kafka] mumrah merged pull request #13732: KAFKA-15007: Always update the MetadataPropagator with correct MV.

mumrah merged PR #13732: URL: https://github.com/apache/kafka/pull/13732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13732: KAFKA-15007: Always update the MetadataPropagator with correct MV.

akhileshchg commented on code in PR #13732: URL: https://github.com/apache/kafka/pull/13732#discussion_r1200876893 ## core/src/main/scala/kafka/migration/MigrationPropagator.scala: ## @@ -70,7 +68,7 @@ class MigrationPropagator( val requestBatch = new MigrationPropagatorBatch

[GitHub] [kafka] mumrah commented on a diff in pull request #13732: KAFKA-15007: Always update the MetadataPropagator with correct MV.

mumrah commented on code in PR #13732: URL: https://github.com/apache/kafka/pull/13732#discussion_r1200868934 ## core/src/main/scala/kafka/migration/MigrationPropagator.scala: ## @@ -70,7 +68,7 @@ class MigrationPropagator( val requestBatch = new MigrationPropagatorBatch(

[GitHub] [kafka] sambhav-jain-16 commented on pull request #13646: KAFKA-14938: Fixing flaky test testConnectorBoundary

sambhav-jain-16 commented on PR #13646: URL: https://github.com/apache/kafka/pull/13646#issuecomment-1557655038 Hi @C0urante @kirktrue Can you PTAL at the above comments when available. TIA -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] erikvanoosten commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

erikvanoosten commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1200842817 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -600,6 +601,30 @@ public void testCoordinatorNotAvailable

[GitHub] [kafka] C0urante commented on a diff in pull request #13475: KAFKA-14652: Add the flow to the log context and the Connect-managed …

C0urante commented on code in PR #13475: URL: https://github.com/apache/kafka/pull/13475#discussion_r1200807046 ## config/connect-mirror-maker.properties: ## @@ -57,3 +57,6 @@ config.storage.replication.factor=1 # replication.policy.separator = _ # sync.topic.acls.enabled = fa

[GitHub] [kafka] akhileshchg opened a new pull request, #13741: KAFKA-15009: Handle errors while migrating ACL metadata from snapshot to Zk during DUAL_WRITE mode.

akhileshchg opened a new pull request, #13741: URL: https://github.com/apache/kafka/pull/13741 KAFKA-15009: Handle errors while migrating ACL metadata from snapshot to Zk during DUAL_WRITE mode. We're missing updating new resourcePatterns while migrating ACL metadata from snapshot

[GitHub] [kafka] dajac commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

dajac commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1557543152 @satishd I see many failed tests [here](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13535/33/tests). Are they related to changes made in this PR? --

[jira] [Updated] (KAFKA-15013) KIP-934: Add DeleteTopicPolicy

[ https://issues.apache.org/jira/browse/KAFKA-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya updated KAFKA-15013: - Labels: kip (was: ) > KIP-934: Add DeleteTopicPolicy >

[jira] [Updated] (KAFKA-15014) KIP-935: Extend AlterConfigPolicy with existing configurations

[ https://issues.apache.org/jira/browse/KAFKA-15014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya updated KAFKA-15014: - Labels: kip (was: ) > KIP-935: Extend AlterConfigPolicy with e

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13708: KAFKA-14500; [4/N] Add Timer interface

jeffkbkim commented on code in PR #13708: URL: https://github.com/apache/kafka/pull/13708#discussion_r1200748252 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/Timer.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mdedetrich commented on a diff in pull request #13689: KAFKA-14975: Wait for TopicBasedRemoteLogMetadataManager.ensureInitializedAndNotClosed to initialize rather than throwing

mdedetrich commented on code in PR #13689: URL: https://github.com/apache/kafka/pull/13689#discussion_r1200746117 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -489,14 +498,28 @@ public boolean isIniti

[GitHub] [kafka] mojh7 opened a new pull request, #13739: MINOR: Fix some typos

mojh7 opened a new pull request, #13739: URL: https://github.com/apache/kafka/pull/13739 Minor typos - `curent` -> `current` ( MockLog.java, PlaintextAdminIntegrationTest.scala ) - `ConcurentHashMap` -> `ConcurrentHashMap` ( Microbenchmarks.java ) ### Committer Checklist (excl

[GitHub] [kafka] dajac commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

dajac commented on PR #13678: URL: https://github.com/apache/kafka/pull/13678#issuecomment-1557527598 @philipnee I will try to review it this week. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] dajac commented on a diff in pull request #13708: KAFKA-14500; [4/N] Add Timer interface

dajac commented on code in PR #13708: URL: https://github.com/apache/kafka/pull/13708#discussion_r1200740552 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/Timer.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] philipnee commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on PR #13678: URL: https://github.com/apache/kafka/pull/13678#issuecomment-1557511754 @dajac - Would you have some time to review and help Erik to merge this? I've done a pass and I think it's okay. -- This is an automated message from the Apache Git Service. To respon

[jira] [Created] (KAFKA-15016) LICENSE-binary file contains dependencies not included anymore

Mickael Maison created KAFKA-15016: -- Summary: LICENSE-binary file contains dependencies not included anymore Key: KAFKA-15016 URL: https://issues.apache.org/jira/browse/KAFKA-15016 Project: Kafka

[jira] [Created] (KAFKA-15015) Binaries contain 2 versions of reload4j

Mickael Maison created KAFKA-15015: -- Summary: Binaries contain 2 versions of reload4j Key: KAFKA-15015 URL: https://issues.apache.org/jira/browse/KAFKA-15015 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-15014) KIP-935: Extend AlterConfigPolicy with existing configurations

Jorge Esteban Quilcate Otoya created KAFKA-15014: Summary: KIP-935: Extend AlterConfigPolicy with existing configurations Key: KAFKA-15014 URL: https://issues.apache.org/jira/browse/KAFKA-15014

[jira] [Created] (KAFKA-15013) KIP-934: Add DeleteTopicPolicy

Jorge Esteban Quilcate Otoya created KAFKA-15013: Summary: KIP-934: Add DeleteTopicPolicy Key: KAFKA-15013 URL: https://issues.apache.org/jira/browse/KAFKA-15013 Project: Kafka

[GitHub] [kafka] urbandan commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

urbandan commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1557329915 @akatona84 Is there any way to decide if a specific file/dir is meant to be a plugin? For the scenario you described, I understand that ".pki" was not an actual plugin, and in that ca

[jira] [Created] (KAFKA-15012) JsonConverter fails when there are leading Zeros in a field

Ranjan Rao created KAFKA-15012: -- Summary: JsonConverter fails when there are leading Zeros in a field Key: KAFKA-15012 URL: https://issues.apache.org/jira/browse/KAFKA-15012 Project: Kafka Issu

[jira] [Updated] (KAFKA-14469) Fix inconsistency in config name between code and KIP-405

[ https://issues.apache.org/jira/browse/KAFKA-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14469: --- Fix Version/s: (was: 3.5.0) > Fix inconsistency in config name between code and KIP-405

[jira] [Updated] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10228: --- Fix Version/s: (was: 3.5.0) > producer: NETWORK_EXCEPTION is thrown instead of a request

[jira] [Updated] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14698: --- Fix Version/s: (was: 3.5.0) > Received request api key LEADER_AND_ISR which is not enabl

[jira] [Comment Edited] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724946#comment-17724946 ] Edoardo Comar edited comment on KAFKA-14996 at 5/22/23 2:15 PM: --

[jira] [Commented] (KAFKA-14970) Dual write mode testing for SCRAM and Quota

[ https://issues.apache.org/jira/browse/KAFKA-14970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724964#comment-17724964 ] Mickael Maison commented on KAFKA-14970: Removing this from 3.5.0 (at least for

[jira] [Commented] (KAFKA-15003) TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic

[ https://issues.apache.org/jira/browse/KAFKA-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724965#comment-17724965 ] Mickael Maison commented on KAFKA-15003: Removing this from 3.5.0 (at least for

[jira] [Updated] (KAFKA-14970) Dual write mode testing for SCRAM and Quota

[ https://issues.apache.org/jira/browse/KAFKA-14970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14970: --- Fix Version/s: (was: 3.5.0) > Dual write mode testing for SCRAM and Quota >

[jira] [Updated] (KAFKA-15003) TopicIdReplicaAssignment is not updated in migration (dual-write) when partitions are changed for topic

[ https://issues.apache.org/jira/browse/KAFKA-15003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15003: --- Fix Version/s: (was: 3.5.0) > TopicIdReplicaAssignment is not updated in migration (dual

[jira] [Commented] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724963#comment-17724963 ] Mickael Maison commented on KAFKA-14692: Removing this from 3.5.0 (at least for

[jira] [Updated] (KAFKA-14692) Issues in Zookeeper to KRaft migration docs

[ https://issues.apache.org/jira/browse/KAFKA-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14692: --- Fix Version/s: (was: 3.5.0) > Issues in Zookeeper to KRaft migration docs >

[GitHub] [kafka] dajac commented on a diff in pull request #13708: KAFKA-14500; [4/N] Add purgatory interface

dajac commented on code in PR #13708: URL: https://github.com/apache/kafka/pull/13708#discussion_r1200520298 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/Timer.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] dajac commented on a diff in pull request #13704: KAFKA-14500; [3/N] add GroupMetadataKey/Value record helpers

dajac commented on code in PR #13704: URL: https://github.com/apache/kafka/pull/13704#discussion_r1200514722 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordHelpersTest.java: ## @@ -383,4 +401,203 @@ public void testNewCurrentAssignmentTombstoneRecord

[jira] [Commented] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724948#comment-17724948 ] Edoardo Comar commented on KAFKA-14996: --- is the state the controller gets in simil

[GitHub] [kafka] mjsax commented on pull request #13728: Add default configs for internal topics to docs

mjsax commented on PR #13728: URL: https://github.com/apache/kafka/pull/13728#issuecomment-1557201376 Thanks @JimGalasyn! -- Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] mjsax merged pull request #13728: Add default configs for internal topics to docs

mjsax merged PR #13728: URL: https://github.com/apache/kafka/pull/13728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Comment Edited] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724946#comment-17724946 ] Edoardo Comar edited comment on KAFKA-14996 at 5/22/23 1:10 PM: --

[jira] [Commented] (KAFKA-14996) CreateTopic falis with UnknownServerException if num partitions >= QuorumController.MAX_RECORDS_PER_BATCH

[ https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724946#comment-17724946 ] Edoardo Comar commented on KAFKA-14996: --- The controller instability is not reprodu

[GitHub] [kafka] dajac commented on pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on PR #13639: URL: https://github.com/apache/kafka/pull/13639#issuecomment-1557159854 @jeffkbkim @jolshan Thanks for your reviews. I think that I have addressed all your comments. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200467372 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200462722 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] mjsax commented on pull request #13734: KAFKA-14862 (HOTFIX): Fix ConcurrentModificationException

mjsax commented on PR #13734: URL: https://github.com/apache/kafka/pull/13734#issuecomment-1557134360 @showuon cherry-picked to `3.4` branch and will roll a new RC fro 3.4.1. Thanks Luke! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1200434460 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java: ## @@ -356,164 +346,100 @@ private static DefaultRecord readFrom(ByteBuffer buffer,

[GitHub] [kafka] Hangleton commented on a diff in pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on code in PR #13558: URL: https://github.com/apache/kafka/pull/13558#discussion_r1200432343 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -2113,7 +2113,12 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo }

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200415899 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] Hangleton commented on pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

Hangleton commented on PR #13558: URL: https://github.com/apache/kafka/pull/13558#issuecomment-1557081175 Hi Igor, thanks for the follow-up. Just added three commits which: 1) Replace `InstrumentedRequestProcessor` and `MutedServerCnxn` with spies stubbing only the necessary methods.

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1200402627 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200402995 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1200358594 ## clients/src/test/java/org/apache/kafka/common/record/DefaultRecordBatchTest.java: ## @@ -367,32 +403,164 @@ public void testStreamingIteratorConsistency() {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1200356934 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1200353574 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1200352336 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java: ## @@ -356,164 +346,100 @@ private static DefaultRecord readFrom(ByteBuffer buffer,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1200351208 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] fvaleri commented on a diff in pull request #13738: KAFKA-14982: Improve the kafka-metadata-quorum output

fvaleri commented on code in PR #13738: URL: https://github.com/apache/kafka/pull/13738#discussion_r1200336786 ## tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java: ## @@ -172,4 +173,34 @@ public void testDescribeQuorumInZkMode() { ); } +

[GitHub] [kafka] fvaleri commented on a diff in pull request #13738: KAFKA-14982: Improve the kafka-metadata-quorum output

fvaleri commented on code in PR #13738: URL: https://github.com/apache/kafka/pull/13738#discussion_r1200336739 ## tools/src/main/java/org/apache/kafka/tools/MetadataQuorumCommand.java: ## @@ -136,17 +143,21 @@ private static void addDescribeParser(Subparsers subparsers) {

[jira] [Updated] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14901: --- Priority: Major (was: Blocker) > Flaky test ExactlyOnceSourceIntegrationTest.testConnectorR

[jira] [Updated] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14901: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Flaky test ExactlyOnceSourceInteg

[jira] [Commented] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724871#comment-17724871 ] Mickael Maison commented on KAFKA-14901: Reducing severity and moving to the nex

[jira] [Updated] (KAFKA-14970) Dual write mode testing for SCRAM and Quota

[ https://issues.apache.org/jira/browse/KAFKA-14970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14970: --- Priority: Blocker (was: Major) > Dual write mode testing for SCRAM and Quota >

[jira] [Commented] (KAFKA-14970) Dual write mode testing for SCRAM and Quota

[ https://issues.apache.org/jira/browse/KAFKA-14970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724869#comment-17724869 ] Mickael Maison commented on KAFKA-14970: Marking as blocker per comment from Col

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200293273 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] akatona84 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

akatona84 commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1556885401 I just wrote down my motivation to exclude unreadable ones from plugin path. This specific case can be easily solved with better dir organizing. But you made me think what I really want

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13738: KAFKA-14982: Improve the kafka-metadata-quorum output

divijvaidya commented on code in PR #13738: URL: https://github.com/apache/kafka/pull/13738#discussion_r1200248662 ## tools/src/test/java/org/apache/kafka/tools/MetadataQuorumCommandTest.java: ## @@ -172,4 +173,34 @@ public void testDescribeQuorumInZkMode() { );

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200239503 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200237262 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200235936 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200233985 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200233059 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200227960 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200154967 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200153306 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200149897 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2080 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200149162 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2080 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200145207 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200143037 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200138816 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200134115 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200129689 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] dajac commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1200087476 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,868 @@ +/* + * Licensed to the Apache Software Foundation (