[GitHub] [kafka] joobisb commented on a diff in pull request #13862: KAFKA-15050: format the prompts in the quickstart

joobisb commented on code in PR #13862: URL: https://github.com/apache/kafka/pull/13862#discussion_r1232988532 ## docs/streams/quickstart.html: ## @@ -91,8 +91,8 @@ Step https://www.apache.org/dyn/closer.cgi?path=/kafka/{{fullDotVersion}}/kafka_{{scalaVersion}}-{{fullDotVersion

[GitHub] [kafka] joobisb commented on pull request #13862: KAFKA-15050: format the prompts in the quickstart

joobisb commented on PR #13862: URL: https://github.com/apache/kafka/pull/13862#issuecomment-1595663538 @tombentley have addressed the comments, please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Commented] (KAFKA-15050) Prompts in the quickstarts

[ https://issues.apache.org/jira/browse/KAFKA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733714#comment-17733714 ] Joobi S B commented on KAFKA-15050: --- Thanks [~kshivendu] , [~tombentley] could you pl

[GitHub] [kafka] divijvaidya commented on pull request #13705: MINOR:Refactor the metric names into constants in ReplicaManager

divijvaidya commented on PR #13705: URL: https://github.com/apache/kafka/pull/13705#issuecomment-1595672796 Failing tests are unrelated. These are frequently failing tests in trunk. ``` [Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegra

[GitHub] [kafka] divijvaidya merged pull request #13705: MINOR:Refactor the metric names into constants in ReplicaManager

divijvaidya merged PR #13705: URL: https://github.com/apache/kafka/pull/13705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

[GitHub] [kafka] joobisb opened a new pull request, #13872: KAFKA-15085: Make Timer.java implement AutoCloseable

joobisb opened a new pull request, #13872: URL: https://github.com/apache/kafka/pull/13872 As a best practice implement AutoCloseable which many automatic bug finders will flag a warning if an object of a class is marked as AutoCloseable but is not closed properly in the code. ### Co

[jira] [Commented] (KAFKA-15085) Make Timer.java implement AutoCloseable

[ https://issues.apache.org/jira/browse/KAFKA-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733801#comment-17733801 ] Joobi S B commented on KAFKA-15085: --- Hi [~divijvaidya], since this was not yet picked,

[jira] [Commented] (KAFKA-14913) Migrate DistributedHerder Executor shutdown to use ThreadUtils#shutdownExecutorServiceQuietly

[ https://issues.apache.org/jira/browse/KAFKA-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733827#comment-17733827 ] Elkhan Eminov commented on KAFKA-14913: --- Hi [~sagarrao], stumbled on this while go

[jira] [Commented] (KAFKA-14913) Migrate DistributedHerder Executor shutdown to use ThreadUtils#shutdownExecutorServiceQuietly

[ https://issues.apache.org/jira/browse/KAFKA-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733859#comment-17733859 ] Sagar Rao commented on KAFKA-14913: --- [~elkkhan] , the PR for this fix is already merge

[jira] [Resolved] (KAFKA-14913) Migrate DistributedHerder Executor shutdown to use ThreadUtils#shutdownExecutorServiceQuietly

[ https://issues.apache.org/jira/browse/KAFKA-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-14913. --- Resolution: Fixed > Migrate DistributedHerder Executor shutdown to use > ThreadUtils#shutdownExecut