[
https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746199#comment-17746199
]
Luke Chen commented on KAFKA-12283:
---
Thanks [~sagarrao] !
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746198#comment-17746198
]
Sagar Rao commented on KAFKA-10457:
---
[~yash.mayya], IIRC, you had worked on an issue related to data
[
https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746197#comment-17746197
]
Sagar Rao edited comment on KAFKA-12283 at 7/24/23 5:02 AM:
The flakiness
[
https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao resolved KAFKA-12283.
---
Resolution: Fixed
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746197#comment-17746197
]
Sagar Rao commented on KAFKA-12283:
---
The flakiness with this test was also fixed as part of this PR=>
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao resolved KAFKA-8391.
--
Resolution: Fixed
Fixed with https://github.com/apache/kafka/pull/12561
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746195#comment-17746195
]
Sagar Rao edited comment on KAFKA-8391 at 7/24/23 5:00 AM:
---
Just bumped upon
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746195#comment-17746195
]
Sagar Rao commented on KAFKA-8391:
--
Just bumped upon this. The issue mentioned above
[
https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sagar Rao reassigned KAFKA-8391:
Assignee: Sagar Rao
> Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector
>
vamossagar12 commented on code in PR #14051:
URL: https://github.com/apache/kafka/pull/14051#discussion_r1271739558
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -1290,6 +1290,56 @@ class PartitionTest extends AbstractPartitionTest {
)
}
+
github-actions[bot] commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1647146954
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
zhpyc closed pull request #13105: MINOR: fix typo in KafkaConsumer.java
URL: https://github.com/apache/kafka/pull/13105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
showuon commented on code in PR #14051:
URL: https://github.com/apache/kafka/pull/14051#discussion_r1271666143
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -1290,6 +1290,56 @@ class PartitionTest extends AbstractPartitionTest {
)
}
+ @Test
+
rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1271665613
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/KAFKA-14712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-14712.
---
Resolution: Fixed
> Confusing error when writing downgraded FeatureImage
>
showuon merged PR #13773:
URL: https://github.com/apache/kafka/pull/13773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #13773:
URL: https://github.com/apache/kafka/pull/13773#issuecomment-1647109827
Failed tests are unrelated:
```
Build / JDK 17 and Scala 2.13 /
olalamichelle opened a new pull request, #14078:
URL: https://github.com/apache/kafka/pull/14078
"The test RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay
relies on the actual system clock, which makes it frequently fail. The fix adds
a second constructor that allows for
vamossagar12 commented on PR #14051:
URL: https://github.com/apache/kafka/pull/14051#issuecomment-1647039846
@showuon as suggested, I added the unit test. Thanks for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ex172000 closed pull request #14076: MINOR: Use Awaitility for waiting in test
URL: https://github.com/apache/kafka/pull/14076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746133#comment-17746133
]
Eike Thaden commented on KAFKA-15235:
-
[~bmscomp] thank you preparing this fix! The build process
ex172000 commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271558534
##
build.gradle:
##
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
executionData.from = javaProjects.jacocoTestReport.executionData
reports {
-
lihaosky commented on code in PR #14030:
URL: https://github.com/apache/kafka/pull/14030#discussion_r1271539596
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java:
##
@@ -185,4 +191,224 @@ public boolean
[
https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746108#comment-17746108
]
Elkhan Eminov commented on KAFKA-14112:
---
[~viktorsomogyi] I've created the PR, please take a look
elkkhan opened a new pull request, #14077:
URL: https://github.com/apache/kafka/pull/14077
The replication offset lag is the difference of the last end offset of the
source partition (LEO) the last replicated source offset (LRO), +1 (to account
for zero-based offset numbering) The offset
[
https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elkhan Eminov updated KAFKA-14112:
--
Description:
The replication offset lag is the difference of the {*}l{*}ast {*}e{*}nd
[
https://issues.apache.org/jira/browse/KAFKA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746106#comment-17746106
]
Guozhang Wang commented on KAFKA-15215:
---
Just realized I have not read the KIP! :) At first glance
[
https://issues.apache.org/jira/browse/KAFKA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746102#comment-17746102
]
Guozhang Wang commented on KAFKA-15215:
---
[~ableegoldman] Thanks for bringing this up! I agree that
ruslankrivoshein commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
ruslankrivoshein commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
ruslankrivoshein commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
ruslankrivoshein commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
ocadaruma commented on PR #10167:
URL: https://github.com/apache/kafka/pull/10167#issuecomment-1646844923
@hudeqi Yeah, that's right. The problem still exists. I'll share my thoughts
in KIP-842 discussion thread.
--
This is an automated message from the Apache Git Service.
To respond to
bmscomp commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437691
##
build.gradle:
##
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
executionData.from = javaProjects.jacocoTestReport.executionData
reports {
-
bmscomp commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437161
##
build.gradle:
##
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
executionData.from = javaProjects.jacocoTestReport.executionData
reports {
-
bmscomp commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437161
##
build.gradle:
##
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
executionData.from = javaProjects.jacocoTestReport.executionData
reports {
-
maniekes commented on PR #13321:
URL: https://github.com/apache/kafka/pull/13321#issuecomment-1646799859
hi @divijvaidya what do u think about my last changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vamossagar12 commented on PR #14051:
URL: https://github.com/apache/kafka/pull/14051#issuecomment-1646786096
Thanks @showuon . oh I didn’t realise I could use spy in scala tests as
well. Sorry I missed that and thanks for your help.
--
This is an automated message from the Apache Git
showuon commented on PR #14051:
URL: https://github.com/apache/kafka/pull/14051#issuecomment-1646779495
@vamossagar12 , sorry for late response.
For your suggestion:
> Remove the canAddReplicaToIsr call from
vamossagar12 commented on PR #14051:
URL: https://github.com/apache/kafka/pull/14051#issuecomment-1646758971
Actually now that I think of it, instead of null check, can we =>
1) Remove the `canAddReplicaToIsr` call from
40 matches
Mail list logo
