[GitHub] [kafka] ex172000 commented on pull request #14126: MINOR Fix a Scala 2.12 compile issue

2023-07-29 Thread via GitHub
ex172000 commented on PR #14126: URL: https://github.com/apache/kafka/pull/14126#issuecomment-1657049474 Nice, thanks for the fix! Verified Scala compilation issues gone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-15249) Verify Connect test-plugins artifact is published to Maven Central

2023-07-29 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15249: -- Component/s: KafkaConnect > Verify Connect test-plugins artifact is published to Maven

[GitHub] [kafka] ex172000 commented on pull request #14110: MINOR: Add test for describe topic with ID

2023-07-29 Thread via GitHub
ex172000 commented on PR #14110: URL: https://github.com/apache/kafka/pull/14110#issuecomment-1656951847 Hi @divijvaidya, any chance you can check this commit? Thank you in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ex172000 commented on a diff in pull request #14093: KAFKA-15248 Add BooleanConverter

2023-07-29 Thread via GitHub
ex172000 commented on code in PR #14093: URL: https://github.com/apache/kafka/pull/14093#discussion_r1278454237 ## connect/runtime/src/test/java/org/apache/kafka/connect/converters/BooleanConverterTest.java: ## @@ -74,10 +74,12 @@ public void testFromConnectNull() { @Test

[jira] [Comment Edited] (KAFKA-15258) Consider moving MockAdminClient to the public API

2023-07-29 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748858#comment-17748858 ] Muralidhar Basani edited comment on KAFKA-15258 at 7/29/23 9:18 PM:

[jira] [Commented] (KAFKA-15258) Consider moving MockAdminClient to the public API

2023-07-29 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748858#comment-17748858 ] Muralidhar Basani commented on KAFKA-15258: --- [~mimaison] I can pick this up, if it's confirmed

[GitHub] [kafka] guozhangwang commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

2023-07-29 Thread via GitHub
guozhangwang commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1656811793 @flashmouse Thanks! I echo other's thoughts that in a unit test, we could refrain ourselves from trying very large scale when trying to validate a specific logic or expose a bug.

[GitHub] [kafka] olalamichelle commented on pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-07-29 Thread via GitHub
olalamichelle commented on PR #14078: URL: https://github.com/apache/kafka/pull/14078#issuecomment-1656811452 Hi Divij, Thank you for your reply. I mean the failure of the existing CI job

[GitHub] [kafka] riedelmax commented on pull request #14124: Kafka-14509 Define ConsumerGroupDescribe API request and response schemas and classes.

2023-07-29 Thread via GitHub
riedelmax commented on PR #14124: URL: https://github.com/apache/kafka/pull/14124#issuecomment-1656728902 @jeffkbkim Thanks for overtaking. I saw there are some tests for requests but also many request classes do not have tests. Is it necessary to add tests for this PR? -- This is an

[jira] [Comment Edited] (KAFKA-14748) Relax non-null FK left-join requirement

2023-07-29 Thread Florin Akermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747670#comment-17747670 ] Florin Akermann edited comment on KAFKA-14748 at 7/29/23 12:55 PM: --- I

[jira] [Created] (KAFKA-15272) Fix the logic which finds candidate log segments to upload it to tiered storage

2023-07-29 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-15272: Summary: Fix the logic which finds candidate log segments to upload it to tiered storage Key: KAFKA-15272 URL: https://issues.apache.org/jira/browse/KAFKA-15272

[GitHub] [kafka] fvaleri commented on pull request #14121: MINOR: Add comment to onPartitionsLost override

2023-07-29 Thread via GitHub
fvaleri commented on PR #14121: URL: https://github.com/apache/kafka/pull/14121#issuecomment-1656589301 Thanks @showuon, noted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific