[jira] [Commented] (KAFKA-15302) Stale value returned when using store.all() in punctuation function.

2023-08-19 Thread Jinyong Choi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756245#comment-17756245 ] Jinyong Choi commented on KAFKA-15302: -- I got it. > Stale value returned when usin

[GitHub] [kafka] cadonna commented on pull request #14227: MINOR: Decouple purging committed records from committing

2023-08-19 Thread via GitHub
cadonna commented on PR #14227: URL: https://github.com/apache/kafka/pull/14227#issuecomment-1684911229 Build failures are unrelated: ``` Build / JDK 20 and Scala 2.13 / kafka.log.remote.RemoteIndexCacheTest.testClose() Build / JDK 20 and Scala 2.13 / kafka.network.ConnectionQuotas

[GitHub] [kafka] cadonna merged pull request #14227: MINOR: Decouple purging committed records from committing

2023-08-19 Thread via GitHub
cadonna merged PR #14227: URL: https://github.com/apache/kafka/pull/14227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] kun98-liu opened a new pull request, #14248: MINOR: Add libs.slf4jlog4j to dependencies in project(':core')

2023-08-19 Thread via GitHub
kun98-liu opened a new pull request, #14248: URL: https://github.com/apache/kafka/pull/14248 ## Description - When I use IntelliJ to debug `kafka.core.main` following the [wiki](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=145722808), I kept having error messages like

[GitHub] [kafka] cadonna closed pull request #14214: KAFKA-10199: Change to RUNNING if no pending task to init exist

2023-08-19 Thread via GitHub
cadonna closed pull request #14214: KAFKA-10199: Change to RUNNING if no pending task to init exist URL: https://github.com/apache/kafka/pull/14214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] cadonna opened a new pull request, #14249: KAFKA-10199: Change to RUNNING if no pending task to init exist

2023-08-19 Thread via GitHub
cadonna opened a new pull request, #14249: URL: https://github.com/apache/kafka/pull/14249 A stream thread should only change to RUNNING if there are no active tasks in restoration in the state updater and if there are no pending tasks to recycle and to init. Usually all pending task

[jira] [Assigned] (KAFKA-14138) The Exception Throwing Behavior of Transactional Producer is Inconsistent

2023-08-19 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14138: - Assignee: (was: Sagar Rao) > The Exception Throwing Behavior of Transactional Producer is I

[jira] [Commented] (KAFKA-14429) Move OffsetStorageReader from storage package to source package

2023-08-19 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756308#comment-17756308 ] Sagar Rao commented on KAFKA-14429: --- hey [~gharris1727], given Chris's comment above,

[GitHub] [kafka] cadonna commented on a diff in pull request #13927: [DO NOT MERGE] KAFKA-10199: Enable state updater by default

2023-08-19 Thread via GitHub
cadonna commented on code in PR #13927: URL: https://github.com/apache/kafka/pull/13927#discussion_r1299182368 ## streams/src/test/java/org/apache/kafka/streams/integration/PurgeRepartitionTopicIntegrationTest.java: ## @@ -212,10 +213,11 @@ public void shouldRestoreState() throw

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-19 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1299184981 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-19 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1299185257 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -698,11 +707,329 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213580 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213610 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213641 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213641 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213816 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213610 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213816 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[GitHub] [kafka] olalamichelle commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-19 Thread via GitHub
olalamichelle commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1299213816 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBod

[jira] [Created] (KAFKA-15382) Replace EasyMock with Mockito for KStreamTransformValuesTest

2023-08-19 Thread Fei Xie (Jira)
Fei Xie created KAFKA-15382: --- Summary: Replace EasyMock with Mockito for KStreamTransformValuesTest Key: KAFKA-15382 URL: https://issues.apache.org/jira/browse/KAFKA-15382 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-15383) Replace EasyMock with Mockito for KTableImplTest

2023-08-19 Thread Fei Xie (Jira)
Fei Xie created KAFKA-15383: --- Summary: Replace EasyMock with Mockito for KTableImplTest Key: KAFKA-15383 URL: https://issues.apache.org/jira/browse/KAFKA-15383 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-15384) Replace EasyMock with Mockito for KTableTransformValuesTest

2023-08-19 Thread Fei Xie (Jira)
Fei Xie created KAFKA-15384: --- Summary: Replace EasyMock with Mockito for KTableTransformValuesTest Key: KAFKA-15384 URL: https://issues.apache.org/jira/browse/KAFKA-15384 Project: Kafka Issue Type

[jira] [Created] (KAFKA-15385) Replace EasyMock with Mockito for AbstractStreamTest

2023-08-19 Thread Fei Xie (Jira)
Fei Xie created KAFKA-15385: --- Summary: Replace EasyMock with Mockito for AbstractStreamTest Key: KAFKA-15385 URL: https://issues.apache.org/jira/browse/KAFKA-15385 Project: Kafka Issue Type: Sub-ta

[GitHub] [kafka] olalamichelle opened a new pull request, #14250: Migrate EasyMock to Mockito in AbstractStreamTest.java

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14250: URL: https://github.com/apache/kafka/pull/14250 As titled. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[GitHub] [kafka] olalamichelle opened a new pull request, #14251: [KAFKA-15384] Migrate EasyMock to Mockito in KTableTransformValuesTest

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14251: URL: https://github.com/apache/kafka/pull/14251 As titled. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[GitHub] [kafka] olalamichelle opened a new pull request, #14252: [KAFKA-15383] Migrate EasyMock to Mockito in KTableImplTest

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14252: URL: https://github.com/apache/kafka/pull/14252 As titled. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[GitHub] [kafka] olalamichelle opened a new pull request, #14253: [KAFKA-15382] Migrate EasyMock to Mockito in KStreamTransformValuesTest

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14253: URL: https://github.com/apache/kafka/pull/14253 As titled. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[GitHub] [kafka] junrao commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-19 Thread via GitHub
junrao commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1299221576 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void handleLogSta

[GitHub] [kafka] cadonna commented on pull request #14249: KAFKA-10199: Change to RUNNING if no pending task to init exist

2023-08-19 Thread via GitHub
cadonna commented on PR #14249: URL: https://github.com/apache/kafka/pull/14249#issuecomment-1685047002 I got the approval for this PR in https://github.com/apache/kafka/pull/14214. I opened a new one because all build runs on https://github.com/apache/kafka/pull/14214 run into a timeout.

[jira] [Commented] (KAFKA-14133) Remaining EasyMock to Mockito tests

2023-08-19 Thread Fei Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756336#comment-17756336 ] Fei Xie commented on KAFKA-14133: - [~christo_lolov]  I have created 4 tickets and associ

[GitHub] [kafka] cadonna merged pull request #14249: KAFKA-10199: Change to RUNNING if no pending task to init exist

2023-08-19 Thread via GitHub
cadonna merged PR #14249: URL: https://github.com/apache/kafka/pull/14249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] rondagostino merged pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-19 Thread via GitHub
rondagostino merged PR #14083: URL: https://github.com/apache/kafka/pull/14083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] rondagostino commented on pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-19 Thread via GitHub
rondagostino commented on PR #14083: URL: https://github.com/apache/kafka/pull/14083#issuecomment-1685077921 Merged to 3.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Resolved] (KAFKA-15219) Support delegation tokens in KRaft

2023-08-19 Thread Ron Dagostino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino resolved KAFKA-15219. --- Fix Version/s: 3.6.0 Resolution: Fixed > Support delegation tokens in KRaft > ---

[GitHub] [kafka] olalamichelle opened a new pull request, #14254: [KAFKA-14133] Migrate EasyMock to Mockito in RecordCollectorTest

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14254: URL: https://github.com/apache/kafka/pull/14254 As titled. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation

[GitHub] [kafka] olalamichelle opened a new pull request, #14255: [KAFKA-14133] Migrate EasyMock to Mockito in StateRestoreCallbackAdapterTest, Store…

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14255: URL: https://github.com/apache/kafka/pull/14255 …ToProcessorContextAdapterTest, StreamsProducerTest *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a s

[GitHub] [kafka] olalamichelle opened a new pull request, #14256: [KAFKA-14133] Migrate EasyMock to Mockito in GlobalStateStoreProviderTest, KeyValue…

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14256: URL: https://github.com/apache/kafka/pull/14256 …IteratorFacadeTest, KeyValueSegmentTest, TopologyMetadataTest *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message,

[GitHub] [kafka] olalamichelle opened a new pull request, #14257: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredKeyValueStoreTest

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14257: URL: https://github.com/apache/kafka/pull/14257 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

[GitHub] [kafka] olalamichelle opened a new pull request, #14258: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredSessionStoreTest

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14258: URL: https://github.com/apache/kafka/pull/14258 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

[GitHub] [kafka] olalamichelle opened a new pull request, #14259: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredTimestampedKeyValueStoreTest

2023-08-19 Thread via GitHub
olalamichelle opened a new pull request, #14259: URL: https://github.com/apache/kafka/pull/14259 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

[jira] [Commented] (KAFKA-14133) Remaining EasyMock to Mockito tests

2023-08-19 Thread Fei Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756373#comment-17756373 ] Fei Xie commented on KAFKA-14133: - Sent out a few more PRs. All tests until #21 Metered

[GitHub] [kafka] satishd commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-19 Thread via GitHub
satishd commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299301497 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,393 @@ class ConsumerTask implements Runnable, Closea

[GitHub] [kafka] satishd commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-19 Thread via GitHub
satishd commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299301497 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,393 @@ class ConsumerTask implements Runnable, Closea