[GitHub] [kafka] dengziming commented on a diff in pull request #14295: Kraft support for Integration Tests

2023-08-28 Thread via GitHub
dengziming commented on code in PR #14295: URL: https://github.com/apache/kafka/pull/14295#discussion_r1308292372 ## core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala: ## @@ -38,6 +40,7 @@ class ProducerFailureHandlingTest extends KafkaServerTestHarnes

[GitHub] [kafka] dengziming merged pull request #14294: KRaft support for DescribeClusterRequestTest and DeleteConsumerGroupsTest

2023-08-28 Thread via GitHub
dengziming merged PR #14294: URL: https://github.com/apache/kafka/pull/14294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[GitHub] [kafka] dengziming commented on pull request #14294: KRaft support for DescribeClusterRequestTest and DeleteConsumerGroupsTest

2023-08-28 Thread via GitHub
dengziming commented on PR #14294: URL: https://github.com/apache/kafka/pull/14294#issuecomment-1696856670 LGTM, test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] cmccabe opened a new pull request, #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

2023-08-28 Thread via GitHub
cmccabe opened a new pull request, #14306: URL: https://github.com/apache/kafka/pull/14306 Implement KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration. This KIP adds a new version of DescribeClusterRequest which is supported by KRaf

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308181709 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308179490 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308177084 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308174694 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308174183 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308173397 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308173102 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308172074 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308171085 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308169146 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308167658 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308167128 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,390 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308166084 ## reviewers.py: ## @@ -28,7 +28,7 @@ def prompt_for_user(): while True: try: -user_input = input("\nName or email (case insensitive): ")

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308165924 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -103,9 +102,9 @@ public void testOneConsumerSubscribedToN

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308165291 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdPartition.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308164291 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-28 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1308153773 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] github-actions[bot] commented on pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #13493: URL: https://github.com/apache/kafka/pull/13493#issuecomment-1696716259 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #13558: URL: https://github.com/apache/kafka/pull/13558#issuecomment-1696716224 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] github-actions[bot] commented on pull request #13768: Suggest for performance fix: KAFKA-9693 Kafka latency spikes caused by log segment flush on roll

2023-08-28 Thread via GitHub
github-actions[bot] commented on PR #13768: URL: https://github.com/apache/kafka/pull/13768#issuecomment-1696716168 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Commented] (KAFKA-15414) remote logs get deleted after partition reassignment

2023-08-28 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759792#comment-17759792 ] Satish Duggana commented on KAFKA-15414: Rebalance will be tried out after the t

[jira] [Commented] (KAFKA-15414) remote logs get deleted after partition reassignment

2023-08-28 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759791#comment-17759791 ] Satish Duggana commented on KAFKA-15414: [~fvisconte] There are a few pending ch

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308155008 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-28 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1308153773 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308152462 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308151486 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308150974 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308150557 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] showuon commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-28 Thread via GitHub
showuon commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1308148879 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogSt

[jira] [Created] (KAFKA-15414) remote logs get deleted after partition reassignment

2023-08-28 Thread Luke Chen (Jira)
Luke Chen created KAFKA-15414: - Summary: remote logs get deleted after partition reassignment Key: KAFKA-15414 URL: https://issues.apache.org/jira/browse/KAFKA-15414 Project: Kafka Issue Type: Bu

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308143447 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308140708 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -17,6 +17,8 @@ package org.apache.kafka.coordinator.group.as

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-28 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1308137334 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308117301 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## Review Comment: Author’s note: most of these changes are related to th

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308116494 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## Review Comment: Author’s note: mostly encapsulating the instance vari

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308113122 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -27,26 +31,21 @@ class RequestState { private int numAttempts = 0;

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308113100 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -27,26 +31,21 @@ class RequestState { private int numAttempts = 0;

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308112596 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -66,13 +65,19 @@ public boolean canSendRequest(final long currentTimeMs)

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308111718 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -66,13 +65,19 @@ public boolean canSendRequest(final long currentTimeMs)

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308111377 ## clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java: ## Review Comment: Author’s note: adding `toString()` implementations is helpful i

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308109624 ## clients/src/main/java/org/apache/kafka/clients/NetworkClientUtils.java: ## Review Comment: Author’s note: The two new methods in this file were moved here from

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1308109624 ## clients/src/main/java/org/apache/kafka/clients/NetworkClientUtils.java: ## Review Comment: Reviewer’s note: The two new methods in this file were moved here fr

[GitHub] [kafka] kirktrue opened a new pull request, #14305: KAFKA-14274 #1: basic refactoring

2023-08-28 Thread via GitHub
kirktrue opened a new pull request, #14305: URL: https://github.com/apache/kafka/pull/14305 This change introduces some basic clean up and refactoring for forthcoming commits related to the revised fetch code for the consumer threading refactor project. See KAFKA-14274 for more backg

[GitHub] [kafka] junrao commented on a diff in pull request #14118: KAFKA-14875: Implement wakeup

2023-08-28 Thread via GitHub
junrao commented on code in PR #14118: URL: https://github.com/apache/kafka/pull/14118#discussion_r1308049575 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] philipnee commented on a diff in pull request #14118: KAFKA-14875: Implement wakeup

2023-08-28 Thread via GitHub
philipnee commented on code in PR #14118: URL: https://github.com/apache/kafka/pull/14118#discussion_r1308028327 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on pull request #14302: KAFKA-15412

2023-08-28 Thread via GitHub
jolshan commented on PR #14302: URL: https://github.com/apache/kafka/pull/14302#issuecomment-1696520592 Hey @mannoopj can we include the name of the ticket in the PR title? > Reading an unknown version of quorum-state-file should trigger an error -- This is an automated message fro

[GitHub] [kafka] philipnee commented on a diff in pull request #14118: KAFKA-14875: Implement wakeup

2023-08-28 Thread via GitHub
philipnee commented on code in PR #14118: URL: https://github.com/apache/kafka/pull/14118#discussion_r1308022177 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on pull request #14296: KAFKA-15404: Fix the flaky DynamicBrokerReconfiguration test.

2023-08-28 Thread via GitHub
jolshan commented on PR #14296: URL: https://github.com/apache/kafka/pull/14296#issuecomment-1696516543 @kamalcph so it looks like it isn't a kraft specific issue. Are you saying you also disabled other tests? I believe there is a way to run tests all on their own via Jenkins. I do wonder i

[GitHub] [kafka] jolshan closed pull request #10461: KAFKA-12603: Add benchmarks for handleFetchRequest and FetchContext

2023-08-28 Thread via GitHub
jolshan closed pull request #10461: KAFKA-12603: Add benchmarks for handleFetchRequest and FetchContext URL: https://github.com/apache/kafka/pull/10461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] jolshan closed pull request #10071: KAFKA-12298: Create LeaderAndIsrRequestBenchmark

2023-08-28 Thread via GitHub
jolshan closed pull request #10071: KAFKA-12298: Create LeaderAndIsrRequestBenchmark URL: https://github.com/apache/kafka/pull/10071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] junrao commented on a diff in pull request #14118: KAFKA-14875: Implement wakeup

2023-08-28 Thread via GitHub
junrao commented on code in PR #14118: URL: https://github.com/apache/kafka/pull/14118#discussion_r1308011131 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14303: KAFKA-13327: Gracefully report connector validation errors instead of returning 500 responses

2023-08-28 Thread via GitHub
gharris1727 commented on code in PR #14303: URL: https://github.com/apache/kafka/pull/14303#discussion_r1307943936 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -429,7 +429,9 @@ void enrich(ConfigDef newDef) { fina

[GitHub] [kafka] tanay27 commented on pull request #14229: KAFKA-15224: automating version change

2023-08-28 Thread via GitHub
tanay27 commented on PR #14229: URL: https://github.com/apache/kafka/pull/14229#issuecomment-1696392904 > Thank you for making this change @tanay27. Couple of remaining actions: > > 1. Please add a README.md in the release folder mentioning what you added in the description here, i.e.

[GitHub] [kafka] tanay27 commented on pull request #14229: KAFKA-15224: automating version change

2023-08-28 Thread via GitHub
tanay27 commented on PR #14229: URL: https://github.com/apache/kafka/pull/14229#issuecomment-1696389809 > ```python3 version_change.py --version 3.6.2 WARNING: Couldn't write lextab module . Won't overwrite existing lextab module WARNING: yacc table file version is out of date WARNI

[GitHub] [kafka] C0urante opened a new pull request, #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

2023-08-28 Thread via GitHub
C0urante opened a new pull request, #14304: URL: https://github.com/apache/kafka/pull/14304 [Jira 1](https://issues.apache.org/jira/browse/KAFKA-13328), [Jira 2](https://issues.apache.org/jira/browse/KAFKA-13329) Adds preflight validation checks for key, value, and header converter c

[GitHub] [kafka] C0urante commented on a diff in pull request #14303: KAFKA-13327: Gracefully report connector validation errors instead of returning 500 responses

2023-08-28 Thread via GitHub
C0urante commented on code in PR #14303: URL: https://github.com/apache/kafka/pull/14303#discussion_r1307910654 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -429,7 +429,9 @@ void enrich(ConfigDef newDef) { final C

[GitHub] [kafka] dopuskh3 commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-28 Thread via GitHub
dopuskh3 commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1307788374 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogS

[GitHub] [kafka] dopuskh3 commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-28 Thread via GitHub
dopuskh3 commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1307788374 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogS

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14303: KAFKA-13327: Gracefully report connector validation errors instead of returning 500 responses

2023-08-28 Thread via GitHub
gharris1727 commented on code in PR #14303: URL: https://github.com/apache/kafka/pull/14303#discussion_r1307738833 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -429,7 +429,9 @@ void enrich(ConfigDef newDef) { fina

[GitHub] [kafka] Taher-Ghaleb commented on pull request #14264: KAFKA-15403: Refactor @Test(expected) annotation with assertThrows

2023-08-28 Thread via GitHub
Taher-Ghaleb commented on PR #14264: URL: https://github.com/apache/kafka/pull/14264#issuecomment-1696099110 Hi @jolshan. I resolved the conflict and removed the extra space. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] philipnee commented on a diff in pull request #14118: KAFKA-14875: Implement wakeup

2023-08-28 Thread via GitHub
philipnee commented on code in PR #14118: URL: https://github.com/apache/kafka/pull/14118#discussion_r1307729523 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] philipnee commented on a diff in pull request #14118: KAFKA-14875: Implement wakeup

2023-08-28 Thread via GitHub
philipnee commented on code in PR #14118: URL: https://github.com/apache/kafka/pull/14118#discussion_r1307713180 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-15411) DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky

2023-08-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15411: - Labels: flaky-test (was: ) > DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky >

[jira] [Commented] (KAFKA-14517) Implement regex subscriptions

2023-08-28 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759655#comment-17759655 ] Jimmy Wang commented on KAFKA-14517:  Can I pick up this? Interested in this issue a

[jira] [Assigned] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-28 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-15372: --- Assignee: Greg Harris > MM2 rolling restart can drop configuration changes silently > -

[jira] [Commented] (KAFKA-15408) Restart failed tasks in Kafka Connect up to a configurable max-tries

2023-08-28 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759648#comment-17759648 ] Sagar Rao commented on KAFKA-15408: --- Hi, the steps are outline here: https://cwiki.ap

[jira] [Commented] (KAFKA-15411) DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky

2023-08-28 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759643#comment-17759643 ] Proven Provenzano commented on KAFKA-15411: --- Ran a loop and couldn't get it to

[jira] [Updated] (KAFKA-13329) Connect does not perform preflight validation for per-connector key and value converters

2023-08-28 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-13329: -- Description: Users may specify a key and/or value converter class for their connector directl

[GitHub] [kafka] C0urante commented on a diff in pull request #14303: KAFKA-13327: Gracefully report connector validation errors instead of returning 500 responses

2023-08-28 Thread via GitHub
C0urante commented on code in PR #14303: URL: https://github.com/apache/kafka/pull/14303#discussion_r1307643119 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -429,7 +429,9 @@ void enrich(ConfigDef newDef) { final C

[GitHub] [kafka] jolshan commented on pull request #14264: KAFKA-15403: Refactor @Test(expected) annotation with assertThrows

2023-08-28 Thread via GitHub
jolshan commented on PR #14264: URL: https://github.com/apache/kafka/pull/14264#issuecomment-1695959642 @Taher-Ghaleb can you pull in the latest changes from master and resolve conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] jolshan commented on a diff in pull request #14264: KAFKA-15403: Refactor @Test(expected) annotation with assertThrows

2023-08-28 Thread via GitHub
jolshan commented on code in PR #14264: URL: https://github.com/apache/kafka/pull/14264#discussion_r1307621341 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreToProcessorContextAdapterTest.java: ## @@ -26,10 +26,12 @@ import org.easymock.MockType; im

[GitHub] [kafka] C0urante closed pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

2023-08-28 Thread via GitHub
C0urante closed pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation URL: https://github.com/apache/kafka/pull/11369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] C0urante commented on pull request #11369: KAFKA-13327, KAFKA-13328, KAFKA-13329: Clean up preflight connector validation

2023-08-28 Thread via GitHub
C0urante commented on PR #11369: URL: https://github.com/apache/kafka/pull/11369#issuecomment-1695946733 A lot of merge conflicts have accrued on this one. Instead of resolving them all at once, I've decided to split this PR out into three smaller PRs, which should also make the review proc

[GitHub] [kafka] C0urante commented on pull request #14303: KAFKA-13327: Gracefully report connector validation errors instead of returning 500 responses

2023-08-28 Thread via GitHub
C0urante commented on PR #14303: URL: https://github.com/apache/kafka/pull/14303#issuecomment-1695943788 @gharris1727 since you reviewed https://github.com/apache/kafka/pull/11369, would you be interested in taking a look at its new successor? -- This is an automated message from the Apac

[GitHub] [kafka] C0urante opened a new pull request, #14303: KAFKA-13327: Gracefully report connector validation errors instead of returning 500 responses

2023-08-28 Thread via GitHub
C0urante opened a new pull request, #14303: URL: https://github.com/apache/kafka/pull/14303 [Jira](https://issues.apache.org/jira/browse/KAFKA-13327) Background context: this is split off from https://github.com/apache/kafka/pull/11369, which addressed this issue and two others. Not

[GitHub] [kafka] mannoopj opened a new pull request, #14302: KAFKA-15412

2023-08-28 Thread via GitHub
mannoopj opened a new pull request, #14302: URL: https://github.com/apache/kafka/pull/14302 Reading an unknown version of quorum-state-file should trigger an error. Currently the only known version is 0. Reading any other version should cause an error. -- This is an automated message fr

[GitHub] [kafka] satishd merged pull request #14297: MINOR: Fix the TBRLMMRestart test.

2023-08-28 Thread via GitHub
satishd merged PR #14297: URL: https://github.com/apache/kafka/pull/14297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14297: MINOR: Fix the TBRLMMRestart test.

2023-08-28 Thread via GitHub
satishd commented on PR #14297: URL: https://github.com/apache/kafka/pull/14297#issuecomment-1695842125 There are a few test failures that are unrelated to this change. Merging to trunk and 3.6 branches. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Created] (KAFKA-15413) kafka-server-stop fails with COLUMNS environment variable on Ubuntu

2023-08-28 Thread Takashi Sakai (Jira)
}} is set on Ubuntu. {*}Steps to reproduce{*}: kafka/zookeeper.properties {noformat} dataDir=/tmp/kafka-test-20230828-15217-1lop1tk/zookeeper clientPort=34461 maxClientCnxns=0 admin.enableServer=false {noformat} kafka/server.properties {noformat} broker.id=0 listeners=PLAINTEXT://:46161 num.network

[jira] [Created] (KAFKA-15412) Reading an unknown version of quorum-state-file should trigger an error

2023-08-28 Thread John Mannooparambil (Jira)
John Mannooparambil created KAFKA-15412: --- Summary: Reading an unknown version of quorum-state-file should trigger an error Key: KAFKA-15412 URL: https://issues.apache.org/jira/browse/KAFKA-15412

[GitHub] [kafka] dajac commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

2023-08-28 Thread via GitHub
dajac commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1307484913 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -426,9 +429,43 @@ public CompletableFuture listGroups(

[GitHub] [kafka] dajac commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

2023-08-28 Thread via GitHub
dajac commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1307484913 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -426,9 +429,43 @@ public CompletableFuture listGroups(

[GitHub] [kafka] dajac commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

2023-08-28 Thread via GitHub
dajac commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1307483188 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -426,9 +429,43 @@ public CompletableFuture listGroups(

[GitHub] [kafka] dajac commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

2023-08-28 Thread via GitHub
dajac commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1307482348 ## clients/src/main/resources/common/message/ListGroupsRequest.json: ## @@ -23,11 +23,15 @@ // Version 3 is the first flexible version. // // Version 4 adds the

[GitHub] [kafka] dajac merged pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-28 Thread via GitHub
dajac merged PR #14120: URL: https://github.com/apache/kafka/pull/14120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-15353) Empty ISR returned from controller after AlterPartition request

2023-08-28 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15353: --- Affects Version/s: 3.5.1 > Empty ISR returned from controller after AlterPartition request >

[GitHub] [kafka] pprovenzano commented on pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-28 Thread via GitHub
pprovenzano commented on PR #14083: URL: https://github.com/apache/kafka/pull/14083#issuecomment-1695736206 > DelegationTokenEndToEndAuthorizationWithOwnerTest I created https://issues.apache.org/jira/browse/KAFKA-15411 and will start looking at it today. -- This is an automated me

[jira] [Created] (KAFKA-15411) DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky

2023-08-28 Thread Proven Provenzano (Jira)
Proven Provenzano created KAFKA-15411: - Summary: DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky Key: KAFKA-15411 URL: https://issues.apache.org/jira/browse/KAFKA-15411 Project: Kafka

[GitHub] [kafka] satishd commented on a diff in pull request #14301: KAFKA-15351: Ensure log-start-offset not updated to local-log-start-offset when remote storage enabled

2023-08-28 Thread via GitHub
satishd commented on code in PR #14301: URL: https://github.com/apache/kafka/pull/14301#discussion_r1307433933 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/OffloadAndConsumeFromLeaderTest.java: ## @@ -127,7 +127,7 @@ protected void writeTestSpecification

[GitHub] [kafka] satishd commented on a diff in pull request #14301: KAFKA-15351: Ensure log-start-offset not updated to local-log-start-offset when remote storage enabled

2023-08-28 Thread via GitHub
satishd commented on code in PR #14301: URL: https://github.com/apache/kafka/pull/14301#discussion_r1307431851 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/OffloadAndConsumeFromLeaderTest.java: ## @@ -127,7 +127,7 @@ protected void writeTestSpecification

[jira] [Created] (KAFKA-15410) Add basic functionality integration test with tiered storage

2023-08-28 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-15410: Summary: Add basic functionality integration test with tiered storage Key: KAFKA-15410 URL: https://issues.apache.org/jira/browse/KAFKA-15410 Project:

[jira] [Updated] (KAFKA-15410) Add basic functionality integration test with tiered storage

2023-08-28 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15410: - Parent: KAFKA-7739 Issue Type: Sub-task (was: Task) > Add basic functio

[jira] [Commented] (KAFKA-14954) Use BufferPools to optimize allocation in RemoteLogInputStream

2023-08-28 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759558#comment-17759558 ] Arpit Goyal commented on KAFKA-14954: - [~abhijeetkumar]  Can i pick this up or you a

[GitHub] [kafka] kamalcph commented on pull request #14301: KAFKA-15351: Ensure log-start-offset not updated to local-log-start-offset when remote storage enabled

2023-08-28 Thread via GitHub
kamalcph commented on PR #14301: URL: https://github.com/apache/kafka/pull/14301#issuecomment-1695539631 ### Test Report ```scala [SUCCESS] (1) create topic: Topic[name=topicA partition-count=1 replication-factor=1 segment-size=1 assignment=null properties={remote.storage.enable=t

[GitHub] [kafka] divijvaidya commented on pull request #14229: KAFKA-15224: automating version change

2023-08-28 Thread via GitHub
divijvaidya commented on PR #14229: URL: https://github.com/apache/kafka/pull/14229#issuecomment-1695535002 The output of the script has an indentation problem in the following diff, it is not having the correct indentation for "" ``` diff --git a/streams/quickstart/java/pom.xml b/str

[GitHub] [kafka] divijvaidya commented on pull request #14229: KAFKA-15224: automating version change

2023-08-28 Thread via GitHub
divijvaidya commented on PR #14229: URL: https://github.com/apache/kafka/pull/14229#issuecomment-1695531757 @tanay27 When I run this script, I get the following warnings: ``` python3 version_change.py --version 3.6.2 WARNING: Couldn't write lextab module . Won't overwrite existing l

  1   2   >