satishd commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1314498306
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java:
##
@@ -98,35 +98,28 @@ public void waitTillConsumptionCatchesUp(Recor
satishd commented on code in PR #14328:
URL: https://github.com/apache/kafka/pull/14328#discussion_r1314490212
##
storage/src/test/java/org/apache/kafka/tiered/storage/integration/ReassignReplicaExpandTest.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundat
satishd commented on code in PR #14307:
URL: https://github.com/apache/kafka/pull/14307#discussion_r1314468818
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -301,7 +301,7 @@ private Stream filterPartitions(Set
partitions) {
private void cacheTopicPa
[
https://issues.apache.org/jira/browse/KAFKA-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-15351:
---
Description:
Case-1:
In the FETCH response, the leader-log-start-offset will be piggy-backe
[
https://issues.apache.org/jira/browse/KAFKA-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reassigned KAFKA-15414:
Assignee: Kamal Chandraprakash
https://github.com/apache/kafka/pull/14328
[
https://issues.apache.org/jira/browse/KAFKA-15260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana resolved KAFKA-15260.
Resolution: Fixed
> RLM Task should wait until RLMM is initialized before copying segments
[
https://issues.apache.org/jira/browse/KAFKA-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-14975:
---
Parent: (was: KAFKA-7739)
Issue Type: Task (was: Sub-task)
> Make TopicBasedRem
[
https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-9578:
--
Parent: (was: KAFKA-7739)
Issue Type: Test (was: Sub-task)
> Kafka Tiered Storage
[
https://issues.apache.org/jira/browse/KAFKA-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761691#comment-17761691
]
Satish Duggana commented on KAFKA-9564:
---
Framework PR: https://github.com/apache/ka
[
https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-9578:
--
Fix Version/s: 3.7.0
> Kafka Tiered Storage - System Tests
> -
[
https://issues.apache.org/jira/browse/KAFKA-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana resolved KAFKA-9564.
---
Resolution: Fixed
> Integration Test framework for Tiered Storage
> -
[
https://issues.apache.org/jira/browse/KAFKA-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-9564:
--
Summary: Integration Test framework for Tiered Storage (was: Integration
Tests for Tiered Stor
satishd commented on PR #13908:
URL: https://github.com/apache/kafka/pull/13908#issuecomment-1704568608
>(and should be also backported into 3.6 branch IMO, cc @satishd )
+1 on that @showuon .
--
This is an automated message from the Apache Git Service.
To respond to the message, p
satishd commented on PR #14113:
URL: https://github.com/apache/kafka/pull/14113#issuecomment-1704567178
Merging to trunk and 3.6 as the test failures are not related to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
satishd merged PR #14113:
URL: https://github.com/apache/kafka/pull/14113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
github-actions[bot] commented on PR #13433:
URL: https://github.com/apache/kafka/pull/13433#issuecomment-1704561295
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
showuon commented on code in PR #14306:
URL: https://github.com/apache/kafka/pull/14306#discussion_r1314398152
##
core/src/main/scala/kafka/server/AuthHelper.scala:
##
@@ -130,4 +134,57 @@ class AuthHelper(authorizer: Option[Authorizer]) {
}
}
+ def computeDescribeClu
showuon commented on PR #14113:
URL: https://github.com/apache/kafka/pull/14113#issuecomment-1704496025
See if @satishd has any other comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jolshan commented on code in PR #14324:
URL: https://github.com/apache/kafka/pull/14324#discussion_r1314325008
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManagerConfig.java:
##
@@ -16,12 +16,19 @@
*/
package org.apache.kafka.storage.internals
hachikuji commented on code in PR #14324:
URL: https://github.com/apache/kafka/pull/14324#discussion_r1314324506
##
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManagerConfig.java:
##
@@ -16,12 +16,19 @@
*/
package org.apache.kafka.storage.interna
kamalcph opened a new pull request, #14330:
URL: https://github.com/apache/kafka/pull/14330
Added the integration test for `DELETE_RECORDS` API for tiered storage
enabled topic. The test currently in the failed state.
### Committer Checklist (excluded from commit message)
- [ ] Ver
abhijeetk88 commented on code in PR #14113:
URL: https://github.com/apache/kafka/pull/14113#discussion_r1314290595
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -754,6 +755,62 @@ void
testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws
kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1314264907
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java:
##
@@ -98,35 +98,28 @@ public void waitTillConsumptionCatchesUp(Reco
kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1314264907
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java:
##
@@ -98,35 +98,28 @@ public void waitTillConsumptionCatchesUp(Reco
[
https://issues.apache.org/jira/browse/KAFKA-14510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761603#comment-17761603
]
Jimmy Wang commented on KAFKA-14510:
It seems not so difficult... Could I pick this
[
https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761601#comment-17761601
]
Jimmy Wang edited comment on KAFKA-14517 at 9/3/23 2:16 PM:
[
https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761601#comment-17761601
]
Jimmy Wang commented on KAFKA-14517:
[~dajac]
Thanks for your reply.
Would you hav
kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1314265438
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java:
##
@@ -377,7 +377,9 @@ private void initializeRes
kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1314265053
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -157,9 +157,10 @@ private void processConsumerRecord(ConsumerReco
kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1314264907
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java:
##
@@ -98,35 +98,28 @@ public void waitTillConsumptionCatchesUp(Reco
kamalcph commented on code in PR #14329:
URL: https://github.com/apache/kafka/pull/14329#discussion_r1314264284
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -379,9 +379,9 @@ public void stopPartitions(Set
topicPartitions,
LOGGER.error("Er
kamalcph commented on PR #14329:
URL: https://github.com/apache/kafka/pull/14329#issuecomment-1704311904
@clolov @divijvaidya @showuon @abhijeetk88 @satishd
This PR is stacked on top of #14307 and #14328 to review the change-set
separately (we can merge them if required). Please take
kamalcph opened a new pull request, #14329:
URL: https://github.com/apache/kafka/pull/14329
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
[
https://issues.apache.org/jira/browse/KAFKA-14510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jimmy Wang reassigned KAFKA-14510:
--
Assignee: (was: Jimmy Wang)
> Extend DescribeConfigs API to support group configs
> -
[
https://issues.apache.org/jira/browse/KAFKA-14510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jimmy Wang reassigned KAFKA-14510:
--
Assignee: Jimmy Wang
> Extend DescribeConfigs API to support group configs
>
showuon commented on PR #13908:
URL: https://github.com/apache/kafka/pull/13908#issuecomment-1704289222
@dimitarndimitrov , thanks for fixing it.
Re-triggering the CI build now. If by bumping the session timeout to 2 sec
(from 1 sec) can fix the flaky testBalancePartitionLeaders test,
[
https://issues.apache.org/jira/browse/KAFKA-15399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761585#comment-17761585
]
Luke Chen commented on KAFKA-15399:
---
Confirmed that in the [latest trunk
build|https:
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1314218928
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -309,6 +311,21 @@ public CoordinatorResult
commitOffset(
kamalcph opened a new pull request, #14328:
URL: https://github.com/apache/kafka/pull/14328
- Updated the log-start-offset to correct value while building the replica
state in ReplicaFetcherTierStateMachine#buildRemoteLogAuxState
This is a stacked PR on top of #14307
### Commi
zhaohaidao commented on PR #14271:
URL: https://github.com/apache/kafka/pull/14271#issuecomment-1704074948
> @zhaohaidao Thanks for the update! I just made another pass and I left a
few more comments for consideration. Could you take a look at them and let me
know what you think?
Tha
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1314219391
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -428,9 +430,44 @@ public CompletableFuture
listGroups(
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1314219340
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -428,9 +430,44 @@ public CompletableFuture
listGroups(
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1314218928
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -309,6 +311,21 @@ public CoordinatorResult
commitOffset(
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1314217880
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -420,6 +423,18 @@ public Group group(String groupId, long comm
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1314217786
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -420,6 +423,18 @@ public Group group(String groupId, long comm
zhaohaidao commented on code in PR #14271:
URL: https://github.com/apache/kafka/pull/14271#discussion_r1314217697
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -747,4 +749,15 @@ private static Integer decValue(String key
[
https://issues.apache.org/jira/browse/KAFKA-15404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash resolved KAFKA-15404.
--
Resolution: Fixed
> Failing Test DynamicBrokerReconfigurationTest#testThreadPo
showuon commented on PR #14320:
URL: https://github.com/apache/kafka/pull/14320#issuecomment-1704047268
> Did you find something that we can do in our test framework that can help
us investigate such leaks quickly?
Yes, there should be something we can do to improve it. Let me think a
[
https://issues.apache.org/jira/browse/KAFKA-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761566#comment-17761566
]
Luke Chen commented on KAFKA-15427:
---
PR: https://github.com/apache/kafka/pull/14319
>
showuon commented on PR #14320:
URL: https://github.com/apache/kafka/pull/14320#issuecomment-1704046955
> For my understanding, the issue was from tests disabled previously (ie,
not the 2 we just disabled?) And if so can we re-enable the 2 we just disabled
while investigating?
Yes, t
[
https://issues.apache.org/jira/browse/KAFKA-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-15427.
---
Resolution: Fixed
> Integration tests in TS test harness detect resource leaks
> ---
showuon commented on PR #14320:
URL: https://github.com/apache/kafka/pull/14320#issuecomment-1704045909
Backported into 3.6 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon merged PR #14320:
URL: https://github.com/apache/kafka/pull/14320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #14320:
URL: https://github.com/apache/kafka/pull/14320#issuecomment-1704045285
Failed tests are unrelated:
```
Build / JDK 20 and Scala 2.13 /
integration.kafka.server.FetchFromFollowerIntegrationTest.testFollowerCompleteDelayedFetchesOnReplication(String).
showuon commented on code in PR #14113:
URL: https://github.com/apache/kafka/pull/14113#discussion_r1314161952
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -754,6 +755,62 @@ void
testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws Exce
[
https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761565#comment-17761565
]
David Jacot commented on KAFKA-14517:
-
[~jimmywang611] We cannot the client side par
abhijeetk88 commented on code in PR #14113:
URL: https://github.com/apache/kafka/pull/14113#discussion_r1314155819
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -776,6 +777,8 @@ public void run() {
if (!isCancelled()) {
57 matches
Mail list logo
