[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327848517 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java: ## @@ -141,4 +146,53 @@ public static List> configuredConsumerIntercept

[GitHub] [kafka] kirktrue closed pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

2023-09-15 Thread via GitHub
kirktrue closed pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager URL: https://github.com/apache/kafka/pull/14359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] kirktrue commented on pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

2023-09-15 Thread via GitHub
kirktrue commented on PR #14359: URL: https://github.com/apache/kafka/pull/14359#issuecomment-1721974877 @junrao yeah, lots of errors in the socket/selector level for some reason: ``` kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest.testProduceConsumeWithWildcardAcls()

[GitHub] [kafka] junrao commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
junrao commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327802559 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java: ## @@ -141,4 +146,53 @@ public static List> configuredConsumerIntercept

[GitHub] [kafka] junrao commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
junrao commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327801964 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners confi

[GitHub] [kafka] lianetm commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327799007 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] CalvinConfluent commented on pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-15 Thread via GitHub
CalvinConfluent commented on PR #14053: URL: https://github.com/apache/kafka/pull/14053#issuecomment-1721869530 @splett2 Thanks for pointing it out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] lianetm commented on pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on PR #14385: URL: https://github.com/apache/kafka/pull/14385#issuecomment-1721865351 Thanks for the comments @junrao , all addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327788743 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners conf

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327784079 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners conf

[GitHub] [kafka] junrao commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
junrao commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327744776 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -298,8 +289,8 @@ private void onFailure(final long currentTimeMs,

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327781850 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327771100 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners conf

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327735512 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327733352 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] splett2 commented on pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-09-15 Thread via GitHub
splett2 commented on PR #14053: URL: https://github.com/apache/kafka/pull/14053#issuecomment-1721759781 @CalvinConfluent looks like there are some build failures, probably due to the `Partition` constructor change. -- This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] junrao commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
junrao commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327614488 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners confi

[GitHub] [kafka] satishd merged pull request #14393: MINOR Fixed missing licenses for libraries

2023-09-15 Thread via GitHub
satishd merged PR #14393: URL: https://github.com/apache/kafka/pull/14393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14393: MINOR Fixed missing licenses for libraries

2023-09-15 Thread via GitHub
satishd commented on PR #14393: URL: https://github.com/apache/kafka/pull/14393#issuecomment-1721642304 There are unrelated test failures, merging it to 3.6 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] nicktelford commented on a diff in pull request #14317: KAFKA-13973: Fix inflated block cache metrics

2023-09-15 Thread via GitHub
nicktelford commented on code in PR #14317: URL: https://github.com/apache/kafka/pull/14317#discussion_r1327598817 ## streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBBlockCacheMetricsTest.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] junrao commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
junrao commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327568639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Found

[jira] [Created] (KAFKA-15471) Allow independently stop KRaft controllers or brokers

2023-09-15 Thread Hailey Ni (Jira)
Hailey Ni created KAFKA-15471: - Summary: Allow independently stop KRaft controllers or brokers Key: KAFKA-15471 URL: https://issues.apache.org/jira/browse/KAFKA-15471 Project: Kafka Issue Type: I

[jira] [Updated] (KAFKA-15471) Allow independently stop KRaft controllers or brokers

2023-09-15 Thread Hailey Ni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hailey Ni updated KAFKA-15471: -- Labels: (was: KAFKA-15465) > Allow independently stop KRaft controllers or brokers > ---

[GitHub] [kafka] ethaden commented on pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-09-15 Thread via GitHub
ethaden commented on PR #14130: URL: https://github.com/apache/kafka/pull/14130#issuecomment-1721567371 Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] lianetm commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327524919 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -141,35 +142,57 @@ private Optional send(final long curren

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1326800659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1326800659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327515651 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitApplicationEvent.java: ## @@ -19,22 +19,23 @@ import org.apache.kafka.clients.consu

[GitHub] [kafka] philipnee commented on a diff in pull request #14364: KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1327513916 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Resolved] (KAFKA-15273) Log common name of expired client certificate

2023-09-15 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-15273. --- Fix Version/s: 3.7.0 Resolution: Fixed > Log common name of expired client certificate >

[GitHub] [kafka] omkreddy merged pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-09-15 Thread via GitHub
omkreddy merged PR #14130: URL: https://github.com/apache/kafka/pull/14130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327470102 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -141,35 +142,57 @@ private Optional send(final long curr

[GitHub] [kafka] omkreddy commented on pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-09-15 Thread via GitHub
omkreddy commented on PR #14130: URL: https://github.com/apache/kafka/pull/14130#issuecomment-1721476913 Test failures are not related: ``` Build / JDK 8 and Scala 2.12 / testDescribeTokenForOtherUserPasses(String).quorum=kraft – kafka.api.DelegationTokenEndToEndAuthorizationWithO

[GitHub] [kafka] ethaden commented on pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-09-15 Thread via GitHub
ethaden commented on PR #14130: URL: https://github.com/apache/kafka/pull/14130#issuecomment-1721466422 What needs to be done in order to get this merged into the trunk branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] kirktrue commented on a diff in pull request #14359: KAFKA-14274 [2-5/7]: Introduction of more infrastructure for forthcoming fetch request manager

2023-09-15 Thread via GitHub
kirktrue commented on code in PR #14359: URL: https://github.com/apache/kafka/pull/14359#discussion_r1327394904 ## clients/src/main/java/org/apache/kafka/common/internals/IdempotentCloser.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] lianetm commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327372398 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -141,35 +142,57 @@ private Optional send(final long curren

[GitHub] [kafka] lianetm commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327372398 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -141,35 +142,57 @@ private Optional send(final long curren

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13201: KAFKA-14596: Move TopicCommand to tools

2023-09-15 Thread via GitHub
OmniaGM commented on code in PR #13201: URL: https://github.com/apache/kafka/pull/13201#discussion_r1327326980 ## build.gradle: ## @@ -1880,9 +1880,10 @@ project(':tools:tools-api') { project(':tools') { archivesBaseName = "kafka-tools" - dependencies { +api libs.sc

[GitHub] [kafka] satishd commented on pull request #14393: MINOR Fixed missing licenses for libraries

2023-09-15 Thread via GitHub
satishd commented on PR #14393: URL: https://github.com/apache/kafka/pull/14393#issuecomment-1721174815 @showuon @mimaison @junrao Added the missing licenses for 3.6. We can do the same exercise as a followup for trunk. -- This is an automated message from the Apache Git Service. To resp

[jira] [Comment Edited] (KAFKA-15160) Message bytes duplication in Kafka headers when compression is enabled

2023-09-15 Thread Vikash Mishra (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765597#comment-17765597 ] Vikash Mishra edited comment on KAFKA-15160 at 9/15/23 12:11 PM: -

[GitHub] [kafka] satishd opened a new pull request, #14393: MINOR Fixed missing licenses for libraries

2023-09-15 Thread via GitHub
satishd opened a new pull request, #14393: URL: https://github.com/apache/kafka/pull/14393 Added the missing licenses for the libraries on 3.6 branch. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[jira] [Commented] (KAFKA-15160) Message bytes duplication in Kafka headers when compression is enabled

2023-09-15 Thread Vikash Mishra (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765597#comment-17765597 ] Vikash Mishra commented on KAFKA-15160: --- Hey [~phuctran] , thanks for looking into

[jira] [Updated] (KAFKA-15160) Message bytes duplication in Kafka headers when compression is enabled

2023-09-15 Thread Vikash Mishra (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikash Mishra updated KAFKA-15160: -- Attachment: dump-compressed-data-.7z > Message bytes duplication in Kafka headers when compres

[jira] [Created] (KAFKA-15470) Allow creating connectors in a stopped state

2023-09-15 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-15470: -- Summary: Allow creating connectors in a stopped state Key: KAFKA-15470 URL: https://issues.apache.org/jira/browse/KAFKA-15470 Project: Kafka Issue Type: New Feat

[jira] [Created] (KAFKA-15469) Document built-in configuration providers

2023-09-15 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-15469: -- Summary: Document built-in configuration providers Key: KAFKA-15469 URL: https://issues.apache.org/jira/browse/KAFKA-15469 Project: Kafka Issue Type: Tas

[GitHub] [kafka] soarez commented on pull request #14392: KAFKA-15360: Include dirs in BrokerRegistration

2023-09-15 Thread via GitHub
soarez commented on PR #14392: URL: https://github.com/apache/kafka/pull/14392#issuecomment-1721023968 cc @rondagostino -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (KAFKA-15463) StreamsException: Accessing from an unknown node

2023-09-15 Thread Yevgeny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765539#comment-17765539 ] Yevgeny commented on KAFKA-15463: - Hi,  For now will cancel, seems to be the issue is re

[jira] [Updated] (KAFKA-15326) Decouple Processing Thread from Polling Thread

2023-09-15 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15326: --- Issue Type: Improvement (was: Task) > Decouple Processing Thread from Polling Thread >

[GitHub] [kafka] soarez opened a new pull request, #14392: KAFKA-15360: Include dirs in BrokerRegistration

2023-09-15 Thread via GitHub
soarez opened a new pull request, #14392: URL: https://github.com/apache/kafka/pull/14392 Include OnlineDirs and OfflineDirs as part of the broker registration request. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify te

[jira] [Commented] (KAFKA-15464) Allow dynamic reloading of certificates with different DN / SANs

2023-09-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765515#comment-17765515 ] Luke Chen commented on KAFKA-15464: --- [~rsivaram] [~omkreddy], since you're the experts

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

2023-09-15 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765507#comment-17765507 ] Satish Duggana commented on KAFKA-7739: --- Please take a look at https://cwiki.apach

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

2023-09-15 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765502#comment-17765502 ] Luke Chen commented on KAFKA-7739: -- This will be included in v3.6.0, and be considered a

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

2023-09-15 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765500#comment-17765500 ] Evan Williams commented on KAFKA-7739: -- Great work [~satish.duggana] . However, will