Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-09 Thread via GitHub
jolshan commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1350934417 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class LeaderNode(

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-09 Thread via GitHub
jolshan commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1350934417 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class LeaderNode(

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-09 Thread via GitHub
jolshan commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1350936703 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class LeaderNode(

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-09 Thread via GitHub
jolshan commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1350945079 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() { p

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-09 Thread via GitHub
jolshan commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1350953160 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -1340,4 +1377,119 @@ public void testNonRetryableTimer(

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-09 Thread via GitHub
rbaddam commented on code in PR #14491: URL: https://github.com/apache/kafka/pull/14491#discussion_r1350996498 ## clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java: ## @@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder createPrincipalBuilder(Map

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-09 Thread via GitHub
hachikuji commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1351005643 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log * fe

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-09 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1351011656 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-09 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1351042141 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-09 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1351054656 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-09 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1351063405 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-09 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1351064502 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerTestBuilder.java: ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Software Foundation

[PR] KAFKA-15514: Metadata records Replicas->Assignment [kafka]

2023-10-09 Thread via GitHub
soarez opened a new pull request, #14516: URL: https://github.com/apache/kafka/pull/14516 The new "Assignments" field replaces the "Replicas" field in PartitionRecord and PartitionChangeRecord. Depends on #14290 - [KAFKA-15355](https://issues.apache.org/jira/browse/KAFKA-15355)

Re: [PR] KAFKA-10733: Clean up producer exceptions [kafka]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #13876: URL: https://github.com/apache/kafka/pull/13876#issuecomment-1754300502 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-09 Thread via GitHub
github-actions[bot] commented on PR #13528: URL: https://github.com/apache/kafka/pull/13528#issuecomment-1754300677 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[PR] MINOR: Rename log dir UUIDs [kafka]

2023-10-09 Thread via GitHub
soarez opened a new pull request, #14517: URL: https://github.com/apache/kafka/pull/14517 After a late discussion in the voting thread for KIP-858 we decided to improve the names for the designated reserved log directory UUID values. ### Committer Checklist (excluded from commit messa

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
iit2009060 commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1754314250 @showuon Can we merge this changes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [TEST] Run builds for PR #14364 [kafka]

2023-10-09 Thread via GitHub
philipnee closed pull request #14509: [TEST] Run builds for PR #14364 URL: https://github.com/apache/kafka/pull/14509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Assigned] (KAFKA-15514) Controller-side replica management changes

2023-10-09 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-15514: --- Assignee: Igor Soarez > Controller-side replica management changes > --

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
showuon commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1351504132 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -540,6 +545,8 @@ class RemoteIndexCacheTest { "Failed to mark cache entry for clea

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-09 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1351514017 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -540,6 +545,8 @@ class RemoteIndexCacheTest { "Failed to mark cache entry for c

<    1   2