[jira] [Created] (KAFKA-15579) KIP-966: Eligible Leader Replicas

2023-10-11 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15579: -- Summary: KIP-966: Eligible Leader Replicas Key: KAFKA-15579 URL: https://issues.apache.org/jira/browse/KAFKA-15579 Project: Kafka Issue Type: New Feature

[jira] [Updated] (KAFKA-15332) Eligible Leader Replicas

2023-10-11 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-15332: --- Description: A root ticket for the KIP-966 The KIP has accepted

Re: [PR] KAFKA-15578: System Tests for running old protocol with new coordinator [kafka]

2023-10-11 Thread via GitHub
imcdo commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355442947 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -277,6 +278,9 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI

Re: [PR] MINOR: Upgrade gradle to 8.4 [kafka]

2023-10-11 Thread via GitHub
divijvaidya commented on PR #14530: URL: https://github.com/apache/kafka/pull/14530#issuecomment-1758191492 There is an existing similar PR https://github.com/apache/kafka/pull/14502, can we wrap this change into that one? -- This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-15578) Run System Tests for Old protocol in the New Coordinator

2023-10-11 Thread Ritika Muduganti (Jira)
Ritika Muduganti created KAFKA-15578: Summary: Run System Tests for Old protocol in the New Coordinator Key: KAFKA-15578 URL: https://issues.apache.org/jira/browse/KAFKA-15578 Project: Kafka

[jira] [Commented] (KAFKA-15221) Potential race condition between requests from rebooted followers

2023-10-11 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774161#comment-17774161 ] Jason Gustafson commented on KAFKA-15221: - We merged the fix to trunk. Given that it is a rare

Re: [PR] System Tests for KIP-848 [kafka]

2023-10-11 Thread via GitHub
dajac commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355468634 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -44,7 +44,6 @@ def setUp(self): self.trogdor.start() if self.zk:

[jira] [Resolved] (KAFKA-15221) Potential race condition between requests from rebooted followers

2023-10-11 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-15221. - Fix Version/s: (was: 3.5.2) Resolution: Fixed > Potential race condition

Re: [PR] System Tests for KIP-848 [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355388919 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -114,7 +126,11 @@ def test_single_partition(self, metadata_quorum=quorum.zk):

[jira] [Updated] (KAFKA-15465) MM2 not working when its internal topics are pre-created on a cluster that disallows topic creation

2023-10-11 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-15465: -- Fix Version/s: 3.6.1 > MM2 not working when its internal topics are pre-created on a cluster

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-11 Thread via GitHub
hachikuji merged PR #14053: URL: https://github.com/apache/kafka/pull/14053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] System Tests for KIP-848 [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355363738 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1):

Re: [PR] System Tests for KIP-848 [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355360984 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -764,6 +769,9 @@ def prop_file(self, node): else:

Re: [PR] System Tests for KIP-848 [kafka]

2023-10-11 Thread via GitHub
rreddy-22 commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1355362411 ## tests/kafkatest/tests/core/consume_bench_test.py: ## @@ -68,12 +67,21 @@ def produce_messages(self, topics, max_messages=1):

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-11 Thread via GitHub
lucasbru commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1355337776 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] KAFKA-15498: bump snappy-java version to 1.1.10.5 [kafka]

2023-10-11 Thread via GitHub
mimaison commented on PR #14458: URL: https://github.com/apache/kafka/pull/14458#issuecomment-1758041371 FYI, I backported this to 3.6: https://github.com/apache/kafka/commit/eade5b877759aabf9efec711bf3c0a0791982230 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR: Add javadoc to all ConfigDef.Types values [kafka]

2023-10-11 Thread via GitHub
mimaison merged PR #14515: URL: https://github.com/apache/kafka/pull/14515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-11 Thread via GitHub
kirktrue commented on PR #13528: URL: https://github.com/apache/kafka/pull/13528#issuecomment-1758039378 > Sorry I must have missed this ping. :( My bad. No worries at all  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] MINOR: Upgrade gradle to 8.4 [kafka]

2023-10-11 Thread via GitHub
ijuma opened a new pull request, #14530: URL: https://github.com/apache/kafka/pull/14530 The highlight is improved support for Java 21, full release notes below: https://docs.gradle.org/8.4/release-notes.html ### Committer Checklist (excluded from commit message) - [ ]

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader [kafka]

2023-10-11 Thread via GitHub
ijuma commented on PR #14384: URL: https://github.com/apache/kafka/pull/14384#issuecomment-1758021595 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-11 Thread via GitHub
ijuma commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1355277747 ## core/src/main/scala/kafka/utils/CoreUtils.scala: ## @@ -66,11 +66,11 @@ object CoreUtils { action } catch { case e: Throwable => logLevel match { -

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-11 Thread via GitHub
ijuma commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1355274637 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1945,26 +1947,17 @@ object UnifiedLog extends Logging { logOffsetsListener) } - def logFile(dir:

[jira] [Commented] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-10-11 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774121#comment-17774121 ] Jimmy Wang commented on KAFKA-15388: Hi [~christo_lolov] , Have you worked on this issue? If not, I

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-11 Thread via GitHub
ijuma commented on code in PR #14529: URL: https://github.com/apache/kafka/pull/14529#discussion_r1355263700 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -733,8 +733,8 @@ private void copyLogSegment(UnifiedLog log, LogSegment segment, long nextSegment

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader [kafka]

2023-10-11 Thread via GitHub
msn-tldr commented on PR #14384: URL: https://github.com/apache/kafka/pull/14384#issuecomment-1757962406 @ijuma this is merged in 3.6 now, so should be available in 3.6.1. https://github.com/apache/kafka/pull/14522 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-15536:Dynamically resize remoteIndexCache [kafka]

2023-10-11 Thread via GitHub
hudeqi commented on code in PR #14511: URL: https://github.com/apache/kafka/pull/14511#discussion_r1355219802 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -716,4 +710,8 @@ public static String

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-11 Thread via GitHub
jeffkbkim commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1355212713 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader (#… [kafka]

2023-10-11 Thread via GitHub
wcarlson5 merged PR #14522: URL: https://github.com/apache/kafka/pull/14522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15536:Dynamically resize remoteIndexCache [kafka]

2023-10-11 Thread via GitHub
hudeqi commented on code in PR #14511: URL: https://github.com/apache/kafka/pull/14511#discussion_r1355175100 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -137,15 +138,8 @@ public RemoteIndexCache(long maxSize,

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-11 Thread via GitHub
dajac commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1355171994 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -709,6 +727,16 @@ public void complete(Throwable exception)

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-11 Thread via GitHub
dajac commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1355162764 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -709,6 +727,16 @@ public void complete(Throwable exception)

Re: [PR] MINOR: fix dependencycheck warnings [kafka]

2023-10-11 Thread via GitHub
jlprat merged PR #14476: URL: https://github.com/apache/kafka/pull/14476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add javadoc to all ConfigDef.Types values [kafka]

2023-10-11 Thread via GitHub
jlprat commented on code in PR #14515: URL: https://github.com/apache/kafka/pull/14515#discussion_r1355074869 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -802,11 +802,63 @@ else if (value instanceof Class) } /** - * The config

Re: [PR] Update HEADER [kafka]

2023-10-11 Thread via GitHub
jlprat closed pull request #14520: Update HEADER URL: https://github.com/apache/kafka/pull/14520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update HEADER [kafka]

2023-10-11 Thread via GitHub
jlprat commented on PR #14520: URL: https://github.com/apache/kafka/pull/14520#issuecomment-1757771261 Hi @adikarthik. I'll close this PR as it doesn't seem to introduce any meaningful change to the header. You are more than welcome to open a new PR if you find some problems or areas to

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2023-10-11 Thread via GitHub
mimaison commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1757770296 Yes it would be better if the Java version can be specified as a config. It's something you need to figure out. The job will be automatically created when we commit the updated

Re: [PR] KAFKA-15576: Add 3.6 to core upgrade and compatibility tests [kafka]

2023-10-11 Thread via GitHub
jlprat commented on PR #14527: URL: https://github.com/apache/kafka/pull/14527#issuecomment-1757765114 I restarted the jenkins job as lots of tests failed at the initialization step -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15576: Add 3.6 to core upgrade and compatibility tests [kafka]

2023-10-11 Thread via GitHub
jlprat commented on code in PR #14527: URL: https://github.com/apache/kafka/pull/14527#discussion_r1355056942 ## tests/kafkatest/tests/core/compatibility_test_new_broker_test.py: ## @@ -21,9 +21,10 @@ from kafkatest.services.zookeeper import ZookeeperService from

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

2023-10-11 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1355058608 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -178,31 +176,34 @@ public DefaultBackgroundThread(final Time

Re: [PR] KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests [kafka]

2023-10-11 Thread via GitHub
mimaison commented on PR #13860: URL: https://github.com/apache/kafka/pull/13860#issuecomment-1757751832 Thanks @mjsax for following up. So what's the path forward? Are we able to merge this or do we need to release new bugfix versions for 3.3 and 3.4 (and 3.5?)? -- This is an automated

[PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-11 Thread via GitHub
ijuma opened a new pull request, #14529: URL: https://github.com/apache/kafka/pull/14529 For broader context on this change, please check: * KAFKA-14470: Move log layer to storage module ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[jira] [Updated] (KAFKA-14481) Move LogSegment/LogSegments to storage module

2023-10-11 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14481: Fix Version/s: 3.7.0 > Move LogSegment/LogSegments to storage module >

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

2023-10-11 Thread via GitHub
lianetm commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1355025353 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -209,15 +213,21 @@ public NetworkClientDelegate.UnsentRequest

[jira] [Commented] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-11 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774062#comment-17774062 ] Lucian Ilie commented on KAFKA-15572: - It seems that this issue might have been indirectly fixed in

Re: [PR] MINOR: add quick start for tiered storage feature [kafka]

2023-10-11 Thread via GitHub
clolov commented on code in PR #14528: URL: https://github.com/apache/kafka/pull/14528#discussion_r1354990908 ## docs/ops.html: ## @@ -3984,27 +3984,73 @@ Configurations Example +Quick Start Example + +Apache Kafka doesn't provide an out-of-the-box RemoteStorageManager

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader (#… [kafka]

2023-10-11 Thread via GitHub
msn-tldr commented on PR #14522: URL: https://github.com/apache/kafka/pull/14522#issuecomment-1757644848 CI failed with unrelated flaky tests, see below. JDK17 had a 100% green run. JDK11 - https://ge.apache.org/s/q2va7lqt4kk3g/tests/overview?outcome=FLAKY,FAILED JDK20 -

Re: [PR] System Tests for KIP-848 [kafka]

2023-10-11 Thread via GitHub
dajac commented on code in PR #14524: URL: https://github.com/apache/kafka/pull/14524#discussion_r1354878772 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -764,6 +769,9 @@ def prop_file(self, node): else:

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
showuon commented on PR #14484: URL: https://github.com/apache/kafka/pull/14484#issuecomment-1757545229 There is still failed test: [Build / JDK 11 and Scala 2.13 / org.apache.kafka.tools.FeatureCommandTest.[1] Type=Raft-Isolated, Name=testDowngradeMetadataVersionWithKRaft,

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
showuon commented on code in PR #14484: URL: https://github.com/apache/kafka/pull/14484#discussion_r1354859219 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -343,10 +343,11 @@ private ApiError updateMetadataVersion( if

[jira] [Assigned] (KAFKA-15118) Need for a Centralized Configuration Management System in Apache Kafka

2023-10-11 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Wang reassigned KAFKA-15118: -- Assignee: Jimmy Wang > Need for a Centralized Configuration Management System in Apache

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2023-10-11 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1757493253 @mimaison As my point of view for Java version , may be we can have this part of config itself so we don't have to raise tickets frequently to ASF team, wdyt? -- This is an

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-11 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1354810862 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: add quick start for tiered storage feature [kafka]

2023-10-11 Thread via GitHub
showuon commented on PR #14528: URL: https://github.com/apache/kafka/pull/14528#issuecomment-1757377185 @kamalcph @divijvaidya @satishd , call for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] MINOR: add quick start for tiered storage feature [kafka]

2023-10-11 Thread via GitHub
showuon opened a new pull request, #14528: URL: https://github.com/apache/kafka/pull/14528 Some users complained they don't have a way to determine if there is something wrong in the RSM plug-in they implemented, or there's something wrong in Kafka itself. Also, if there are users who just

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
fvaleri commented on code in PR #14484: URL: https://github.com/apache/kafka/pull/14484#discussion_r1354636655 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -343,10 +343,11 @@ private ApiError updateMetadataVersion( if

[jira] [Commented] (KAFKA-15575) Prevent Connectors from exceeding tasks.max configuration

2023-10-11 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773988#comment-17773988 ] Mickael Maison commented on KAFKA-15575: Thanks for opening this item. Regardless of KIP-987, I

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-11 Thread via GitHub
lucasbru commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1354615069 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

[jira] [Resolved] (KAFKA-15577) Reload4j | CVE-2022-45868

2023-10-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-15577. --- Resolution: Not A Problem > Reload4j | CVE-2022-45868 > - > >

[jira] [Commented] (KAFKA-15577) Reload4j | CVE-2022-45868

2023-10-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773985#comment-17773985 ] Bruno Cadonna commented on KAFKA-15577: --- The vulnerability is in the H2 database engine and not

[PR] KAFKA-15576: Add 3.6 to core upgrade and compatibility tests [kafka]

2023-10-11 Thread via GitHub
satishd opened a new pull request, #14527: URL: https://github.com/apache/kafka/pull/14527 This is part of the 3.6.0 release process as mentioned [here](https://cwiki.apache.org/confluence/display/KAFKA/Release+Process). ``` For feature releases, file a JIRA for updating

Re: [PR] KAFKA-14517:Implement regex subscriptions [kafka]

2023-10-11 Thread via GitHub
JimmyWang6 commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-1757298813 @dajac Much Thanks for your review! As for target assignment updates, the function `maybeUpdateSubscribedTopicNames(oldMember, newMember)`

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2023-10-11 Thread via GitHub
mimaison commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1757278411 Then I'd probably make the new ppc job copy the existing jobs and use a single `stage`. Another question: What will be the process of updating the Java version? Can this be part

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
showuon commented on code in PR #14484: URL: https://github.com/apache/kafka/pull/14484#discussion_r1354582738 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -343,10 +343,11 @@ private ApiError updateMetadataVersion( if

Re: [PR] KAFKA-14133: Move MeteredTimestampedKeyValueStoreTest, ReadOnlyWindowStoreFacadeTest and TimestampedWindowStoreBuilderTest to Mockito [kafka]

2023-10-11 Thread via GitHub
divijvaidya merged PR #14412: URL: https://github.com/apache/kafka/pull/14412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14133: Move MeteredTimestampedKeyValueStoreTest, ReadOnlyWindowStoreFacadeTest and TimestampedWindowStoreBuilderTest to Mockito [kafka]

2023-10-11 Thread via GitHub
divijvaidya commented on PR #14412: URL: https://github.com/apache/kafka/pull/14412#issuecomment-1757221402 There are test failures but the tests modified in this PR are passing. The rest of failures are known flaky ones (primarily FetchRequest ones). -- This is an automated message from

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354520295 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -790,6 +812,12 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on PR #14432: URL: https://github.com/apache/kafka/pull/14432#issuecomment-1757221757 Thanks @dajac , I have addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354518973 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -285,6 +302,64 @@ public ConsumerGroupMember

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354516913 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -285,6 +302,64 @@ public ConsumerGroupMember

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354507878 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1127,7 +1176,9 @@ public void replay( Set

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354507878 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1127,7 +1176,9 @@ public void replay( Set

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354506847 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1084,10 +1129,14 @@ public CoordinatorResult consumerGro

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354505609 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -750,7 +770,9 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354491971 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -285,6 +302,64 @@ public ConsumerGroupMember

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354488025 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -285,6 +302,64 @@ public ConsumerGroupMember

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-11 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1354486658 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -564,6 +564,22 @@ private void throwIfNotNull( }

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-11 Thread via GitHub
lkokhreidze commented on code in PR #14519: URL: https://github.com/apache/kafka/pull/14519#discussion_r1354484003 ## streams/src/test/java/org/apache/kafka/streams/integration/StateRestoreListerIntegrationTest.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
fvaleri commented on PR #14484: URL: https://github.com/apache/kafka/pull/14484#issuecomment-1757158497 Thanks for raising @showuon. It is fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-11 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

Re: [PR] KAFKA-14048:Implement regex subscriptions [kafka]

2023-10-11 Thread via GitHub
JimmyWang6 commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-1757033354 @vamossagar12 Much thanks for your review. Will change to KAFKA-14517 later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-11 Thread via GitHub
showuon commented on PR #14484: URL: https://github.com/apache/kafka/pull/14484#issuecomment-1757018081 @fvaleri , there are some test failed because of this change. Please take a look. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14484/10/#showFailuresLink -- This is

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-11 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Affects Version/s: 3.6.0 (was: 3.5.1) > Unsafe

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-11 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" (lossy) downgrade in case metadata has

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-11 Thread via GitHub
lkokhreidze commented on code in PR #14519: URL: https://github.com/apache/kafka/pull/14519#discussion_r1354282349 ## streams/src/test/java/org/apache/kafka/streams/integration/StateRestoreListerIntegrationTest.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-11 Thread via GitHub
ableegoldman commented on code in PR #14519: URL: https://github.com/apache/kafka/pull/14519#discussion_r1354281780 ## streams/src/test/java/org/apache/kafka/streams/integration/StateRestoreListerIntegrationTest.java: ## @@ -0,0 +1,302 @@ +/* + * Licensed to the Apache Software

[PR] MINOR: Fix `KafkaStreams#streamThreadLeaveConsumerGroup` logging [kafka]

2023-10-11 Thread via GitHub
lkokhreidze opened a new pull request, #14526: URL: https://github.com/apache/kafka/pull/14526 Fixes logging for `KafkaStreams#streamThreadLeaveConsumerGroup`. In order not to loose the trace of the whole exception, passing `Exception e` as a second argument, while message is

[jira] [Updated] (KAFKA-15569) Update test and add test cases in IQv2StoreIntegrationTest

2023-10-11 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated KAFKA-15569: Description: * Update test and add test cases in IQv2StoreIntegrationTest. * Originally, all

[jira] [Updated] (KAFKA-15571) StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended

2023-10-11 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-15571: -- Affects Version/s: 3.6.0 > StateRestoreListener#onRestoreSuspended is never called

[jira] [Updated] (KAFKA-15569) Update test and add test cases in IQv2StoreIntegrationTest

2023-10-11 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated KAFKA-15569: Description: * Update test and add test cases in IQv2StoreIntegrationTest * Originally, all

[jira] [Created] (KAFKA-15577) Reload4j | CVE-2022-45868

2023-10-11 Thread masood (Jira)
masood created KAFKA-15577: -- Summary: Reload4j | CVE-2022-45868 Key: KAFKA-15577 URL: https://issues.apache.org/jira/browse/KAFKA-15577 Project: Kafka Issue Type: Bug Reporter: masood

[jira] [Commented] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2023-10-11 Thread Benoit Delbosc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773911#comment-17773911 ] Benoit Delbosc commented on KAFKA-15402: The problem is still present on the latest version

[jira] [Updated] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2023-10-11 Thread Benoit Delbosc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benoit Delbosc updated KAFKA-15402: --- Affects Version/s: 3.6.0 > Performance regression on close consumer after upgrading to

<    1   2