[
https://issues.apache.org/jira/browse/KAFKA-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784705#comment-17784705
]
Luke Chen commented on KAFKA-15802:
---
+1 to go with option 1 first.
> Trying to access uncopied
[
https://issues.apache.org/jira/browse/KAFKA-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784698#comment-17784698
]
Satish Duggana commented on KAFKA-15802:
[~jeqo] [~divijvaidya] +1 to go with filtering the
[
https://issues.apache.org/jira/browse/KAFKA-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-15802:
---
Attachment: (was: screenshot-1.png)
> Trying to access uncopied segments metadata on
[
https://issues.apache.org/jira/browse/KAFKA-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-15802:
---
Attachment: screenshot-1.png
> Trying to access uncopied segments metadata on listOffsets
>
alok123t commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1805185143
@divijvaidya I think it looks reasonable JUnit 4 test -
[ConsistencyVectorIntegrationTest](
artemlivshits commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1388948636
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -659,9 +660,21 @@ public TopicPartition key() {
showuon opened a new pull request, #14730:
URL: https://github.com/apache/kafka/pull/14730
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-10840:
---
Labels: authentication client (was: )
> Need way to catch auth issues in poll method of Java Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784681#comment-17784681
]
Philip Nee commented on KAFKA-10840:
Hey [~devin.bost] Are you still seeing this issue? I recently
jolshan merged PR #14712:
URL: https://github.com/apache/kafka/pull/14712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #14712:
URL: https://github.com/apache/kafka/pull/14712#issuecomment-1805099279
I saw all those selector tests failing on trunk in a different PR build. I
don't know how I get so lucky with these
Test failures look ok now so i will go ahead and merge. Maybe
jolshan merged PR #1:
URL: https://github.com/apache/kafka/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #1:
URL: https://github.com/apache/kafka/pull/1#issuecomment-1805088928
I've seen all these failures on other builds (both 3.6 and trunk) today and
yesterday.
I've commented on the applicable JIRAs.
--
This is an automated message from the Apache Git
showuon commented on PR #14506:
URL: https://github.com/apache/kafka/pull/14506#issuecomment-1805023823
I had a look, and think this flaky test should be the infra's issue, not our
code. Like you said, in 3.6 branch, after I backported this PR, it started to
fail (on Nov. 9). Now, checking
github-actions[bot] commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1805022042
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
apoorvmittal10 commented on PR #14632:
URL: https://github.com/apache/kafka/pull/14632#issuecomment-1804996531
> @apoorvmittal10 : Thanks for the updated PR. LGTM
>
> JDK 17 and Scala 2.13 didn't finish. Could you trigger another test run?
This can typically be done by closing the
mjsax commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1388813779
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##
@@ -90,9 +96,7 @@ public void beforeTest() throws
mjsax commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1388813585
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##
@@ -75,13 +79,15 @@ public static void before() throws Exception
mjsax commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1388813361
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##
@@ -75,13 +79,15 @@ public static void before() throws Exception
ableegoldman commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1388793799
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingStoreMaterializer.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
ableegoldman commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1388791856
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindowStoreMaterializer.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software
cmccabe closed pull request #14368: KAFKA-15451: Send offline dirs in broker
heartbeat
URL: https://github.com/apache/kafka/pull/14368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jolshan commented on PR #14387:
URL: https://github.com/apache/kafka/pull/14387#issuecomment-1804890304
Hmm tests are
I see a lot of `java.util.concurrent.ExecutionException:
java.lang.IllegalArgumentException: CoordinatorMetrics must be set.`
Did we miss this somewhere?
--
cmccabe commented on PR #14368:
URL: https://github.com/apache/kafka/pull/14368#issuecomment-1804886740
I believe this is a duplicate of #14392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gharris1727 opened a new pull request, #14729:
URL: https://github.com/apache/kafka/pull/14729
The KafkaServer startup() method instantiates a SocketServer, and then waits
to call enableRequestProcessing. In the intervening time, an exception may be
thrown which prevents the
[
https://issues.apache.org/jira/browse/KAFKA-15804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784630#comment-17784630
]
Greg Harris commented on KAFKA-15804:
-
I believe what is happening is:
1. The SocketServer is
jsancio merged PR #14726:
URL: https://github.com/apache/kafka/pull/14726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsancio commented on PR #14726:
URL: https://github.com/apache/kafka/pull/14726#issuecomment-1804852674
Green system tests:
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.14
session_id:
jolshan commented on PR #1:
URL: https://github.com/apache/kafka/pull/1#issuecomment-1804848080
These build failures are out of control. I have to rebuild again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-15804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15804:
Component/s: (was: Tiered-Storage)
> Broker leaks ServerSocketChannel when exception is
[
https://issues.apache.org/jira/browse/KAFKA-15804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15804:
Description:
This exception is thrown during the
philipnee commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388700690
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software
Greg Harris created KAFKA-15804:
---
Summary: Broker leaks ServerSocketChannel when exception is thrown
from ZkConfigManager during startup
Key: KAFKA-15804
URL: https://issues.apache.org/jira/browse/KAFKA-15804
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1388693648
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java:
##
@@ -0,0 +1,2554 @@
+/*
+ * Licensed to the Apache Software
ableegoldman commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1388683082
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
jolshan commented on PR #14712:
URL: https://github.com/apache/kafka/pull/14712#issuecomment-1804821028
Commented on
[KAFKA-14806](https://issues.apache.org/jira/browse/KAFKA-14806) which saw the
same Selector + SocketServer problems.
I also commented on
[
https://issues.apache.org/jira/browse/KAFKA-14806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784619#comment-17784619
]
Justine Olshan commented on KAFKA-14806:
Had the same sort of failures on my run recently:
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388669816
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/SinglePointMetric.java:
##
@@ -16,22 +16,135 @@
*/
package
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388668684
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/SinglePointMetric.java:
##
@@ -16,22 +16,135 @@
*/
package
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388668684
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/SinglePointMetric.java:
##
@@ -16,22 +16,135 @@
*/
package
jolshan commented on PR #14506:
URL: https://github.com/apache/kafka/pull/14506#issuecomment-1804803577
Hey I was taking a look at 3.6 builds and it looks like
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388666021
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388666021
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1388662985
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerDelegate.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation
jolshan commented on PR #14712:
URL: https://github.com/apache/kafka/pull/14712#issuecomment-1804796567
*[Build / JDK 17 and Scala 2.13 /
jolshan commented on PR #14712:
URL: https://github.com/apache/kafka/pull/14712#issuecomment-1804781724
I will look at the build. The test failures don't look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388649353
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388645527
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricsProvider.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
artemlivshits commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1388644791
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -659,9 +660,21 @@ public TopicPartition key() {
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388643692
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/LastValueTracker.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388643692
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/LastValueTracker.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388623720
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -656,48 +586,43 @@ public void
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388627971
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -838,39 +733,32 @@ public void testPutConnectorConfig()
artemlivshits opened a new pull request, #14728:
URL: https://github.com/apache/kafka/pull/14728
This is a PoC (not tested and probably needs some corner cases
addressed) for running group coordinator on the request handler pool
instead of dedicated thread pool.
The main new
philipnee commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388624127
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388621758
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -817,19 +731,11 @@ public void testAccessors() throws
C0urante commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1388621193
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -722,89 +646,68 @@ public void
philipnee commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388613020
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388613020
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software
junrao commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1387273811
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -16,12 +16,48 @@
*/
package kafka.server;
+import java.util.Collections;
Review Comment:
philipnee commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388606440
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/SinglePointMetric.java:
##
@@ -16,22 +16,135 @@
*/
package
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388600305
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388599565
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/SinglePointMetric.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
philipnee commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388591055
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1804683635
Hi @apoorvmittal10 - I left some questions while making the first pass of
the PR. They are all aesthetics. Will follow up with more questions. Thanks!
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784606#comment-17784606
]
Jorge Esteban Quilcate Otoya commented on KAFKA-15802:
--
Hi [~divijvaidya] , see
agavra commented on code in PR #14708:
URL: https://github.com/apache/kafka/pull/14708#discussion_r1388579633
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -217,8 +217,19 @@ public TopologyConfig(final String topologyName, final
StreamsConfig
jeqo opened a new pull request, #14727:
URL: https://github.com/apache/kafka/pull/14727
See commits for more details
[[KAFKA-15802](https://issues.apache.org/jira/browse/KAFKA-15802)]
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388576337
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388575600
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388575600
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388574457
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388571702
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388563259
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,922 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388562526
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,922 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388550188
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,922 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388545752
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,922 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388543003
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,922 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388542056
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,922 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dajac commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1388535147
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -659,9 +660,21 @@ public TopicPartition key() {
*/
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1388532678
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
jsancio merged PR #14722:
URL: https://github.com/apache/kafka/pull/14722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jsancio commented on PR #14722:
URL: https://github.com/apache/kafka/pull/14722#issuecomment-1804567979
System tests are green.
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.14
session_id:
jsancio opened a new pull request, #14726:
URL: https://github.com/apache/kafka/pull/14726
Use a smaller cluster sizes instead of the default cluster size
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388518531
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388515966
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation
wolfchimneyrock commented on PR #14635:
URL: https://github.com/apache/kafka/pull/14635#issuecomment-1804548652
looks like all the jenkins agents ran out of disk space. After your
comments, the tests still pass locally for me.
--
This is an automated message from the Apache Git Service.
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388504600
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,347 @@
+/*
+ * Licensed to the Apache Software Foundation
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388503750
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundation
artemlivshits commented on code in PR #14705:
URL: https://github.com/apache/kafka/pull/14705#discussion_r1388499287
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -659,9 +660,21 @@ public TopicPartition key() {
dajac commented on code in PR #14635:
URL: https://github.com/apache/kafka/pull/14635#discussion_r1388489571
##
clients/src/test/java/org/apache/kafka/common/requests/LeaveGroupResponseTest.java:
##
@@ -165,4 +169,55 @@ public void testEqualityWithMemberResponses() {
xvrl commented on code in PR #14620:
URL: https://github.com/apache/kafka/pull/14620#discussion_r1388489436
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java:
##
@@ -0,0 +1,347 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe closed pull request #14392: KAFKA-15360: Include dirs in
BrokerRegistration
URL: https://github.com/apache/kafka/pull/14392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cmccabe commented on PR #14392:
URL: https://github.com/apache/kafka/pull/14392#issuecomment-1804419672
Committed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dajac commented on PR #14637:
URL: https://github.com/apache/kafka/pull/14637#issuecomment-1804364013
Re-triggered a build because the last one failed due to, it seems, unrelated
things. I merge if the next build passes.
--
This is an automated message from the Apache Git Service.
To
jolshan commented on PR #14712:
URL: https://github.com/apache/kafka/pull/14712#issuecomment-1804347578
I see this multiple times a day. Might be time to file another Infra ticket
:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1388420510
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -712,6 +729,10 @@ private void close(Duration timeout,
dajac commented on PR #14635:
URL: https://github.com/apache/kafka/pull/14635#issuecomment-1804333051
@wolfchimneyrock Understood. If you agree with my suggestion, I think that
we could just do it. Sorry for the confusion.
--
This is an automated message from the Apache Git Service.
To
philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1388411256
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -1096,4 +,76 @@ private void subscribeInternal(Collection
philipnee commented on code in PR #14680:
URL: https://github.com/apache/kafka/pull/14680#discussion_r1388410485
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -1096,4 +,76 @@ private void subscribeInternal(Collection
1 - 100 of 167 matches
Mail list logo
