[jira] [Created] (KAFKA-15875) Snapshot class is package protected but returned in public methods

2023-11-22 Thread Josep Prat (Jira)
Josep Prat created KAFKA-15875: -- Summary: Snapshot class is package protected but returned in public methods Key: KAFKA-15875 URL: https://issues.apache.org/jira/browse/KAFKA-15875 Project: Kafka

[jira] [Assigned] (KAFKA-15699) MirrorConnectorsIntegrationBaseTest is flaky

2023-11-22 Thread Ashwin Pankaj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashwin Pankaj reassigned KAFKA-15699: - Assignee: Ashwin Pankaj > MirrorConnectorsIntegrationBaseTest is flaky > --

Re: [PR] KAFKA-15578: Migrating other system tests to use the group coordinator [kafka]

2023-11-22 Thread via GitHub
dajac merged PR #14582: URL: https://github.com/apache/kafka/pull/14582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-15869) Document semantics of nullable nested API entities

2023-11-22 Thread Anton Agestam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788694#comment-17788694 ] Anton Agestam commented on KAFKA-15869: --- [~dajac] The discussion link on that KIP

[jira] [Commented] (KAFKA-15869) Document semantics of nullable nested API entities

2023-11-22 Thread Anton Agestam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788698#comment-17788698 ] Anton Agestam commented on KAFKA-15869: --- Sorry for spamming here, I found the thre

[PR] KAFKA-15717: KRaft support in LeaderEpochIntegrationTest [kafka]

2023-11-22 Thread via GitHub
appchemist opened a new pull request, #14815: URL: https://github.com/apache/kafka/pull/14815 KRaft support in LeaderEpochIntegrationTest ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

Re: [PR] KAFKA-15756: [1/2] Migrate existing integration tests to run old protocol in new coordinator [kafka]

2023-11-22 Thread via GitHub
dajac commented on code in PR #14781: URL: https://github.com/apache/kafka/pull/14781#discussion_r1401788044 ## core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala: ## @@ -67,6 +67,10 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness {

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-22 Thread via GitHub
dajac commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1401815563 ## clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java: ## @@ -37,6 +37,12 @@ public JoinGroupResponse(JoinGroupResponseData data, short versio

[PR] KAFKA-15875 Make Snapshot public [kafka]

2023-11-22 Thread via GitHub
jlprat opened a new pull request, #14816: URL: https://github.com/apache/kafka/pull/14816 Makes Snapshop, Revertable and Delta classes public. Only read methods are made public as well. Snapshot, Revertable and Delta are package protected but they potentially leak to classes in other

Re: [PR] KAFKA-15875 Make Snapshot public [kafka]

2023-11-22 Thread via GitHub
jlprat commented on code in PR #14816: URL: https://github.com/apache/kafka/pull/14816#discussion_r1401847506 ## server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java: ## @@ -24,10 +24,10 @@ * A snapshot of some timeline data structures. * * The snapshot con

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

2023-11-22 Thread via GitHub
cadonna commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1401760510 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -277,8 +294,10 @@ class PlaintextConsumerTest extends BaseConsumerTest { assertEqua

Re: [PR] MINOR: Update LICENSE-binary for 3.6.1 [kafka]

2023-11-22 Thread via GitHub
showuon commented on code in PR #14812: URL: https://github.com/apache/kafka/pull/14812#discussion_r1401875110 ## LICENSE-binary: ## @@ -205,7 +205,7 @@ This project bundles some components that are also licensed under the Apache License Version 2.0: -audience-annotations-0.

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

2023-11-22 Thread via GitHub
dajac commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1822554162 @AndrewJSchofield We are about to merge https://github.com/apache/kafka/pull/14781. Is it possible to build this one on top of it? -- This is an automated message from the Apache Git Ser

[jira] [Created] (KAFKA-15876) Introduce Remote Storage Not Ready Exception

2023-11-22 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-15876: Summary: Introduce Remote Storage Not Ready Exception Key: KAFKA-15876 URL: https://issues.apache.org/jira/browse/KAFKA-15876 Project: Kafka

[jira] [Created] (KAFKA-15877) Support change of temporality in Java client

2023-11-22 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15877: - Summary: Support change of temporality in Java client Key: KAFKA-15877 URL: https://issues.apache.org/jira/browse/KAFKA-15877 Project: Kafka Issue Type: S

Re: [PR] KAFKA-15618: Kafka metrics collector and supporting classes (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 commented on code in PR #14620: URL: https://github.com/apache/kafka/pull/14620#discussion_r1401906005 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java: ## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] KAFKA-15618: Kafka metrics collector and supporting classes (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 commented on PR #14620: URL: https://github.com/apache/kafka/pull/14620#issuecomment-1822599777 @xvrl Can you please re-review and let me know if fixing temporality change by resetting ledger in follow up PR makes sense? -- This is an automated message from the Apache Git S

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 commented on PR #14699: URL: https://github.com/apache/kafka/pull/14699#issuecomment-1822604515 > @apoorvmittal10 : Thanks for the updated PR. LGTM. Are the 34 test failures related? Thanks @junrao, the tests are not related and I ll trigger re-build to see if tests fa

[jira] [Created] (KAFKA-15878) KIP-768: Extend support for opaque (i.e. non-JWT) tokens in SASL/OAUTHBEARER

2023-11-22 Thread Anuj Sharma (Jira)
Anuj Sharma created KAFKA-15878: --- Summary: KIP-768: Extend support for opaque (i.e. non-JWT) tokens in SASL/OAUTHBEARER Key: KAFKA-15878 URL: https://issues.apache.org/jira/browse/KAFKA-15878 Project: K

[jira] [Updated] (KAFKA-15878) KIP-768: Extend support for opaque (i.e. non-JWT) tokens in SASL/OAUTHBEARER

2023-11-22 Thread Anuj Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anuj Sharma updated KAFKA-15878: Description: {code:java} // code placeholder {code} h1. Overview * This issue pertains to [SASL/

[jira] [Commented] (KAFKA-15803) Update last seen epoch during commit

2023-11-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788757#comment-17788757 ] Lucas Brutschy commented on KAFKA-15803: >From what I can see, we seem to be mis

[PR] KAFKA-15803: Update leader epoch in commitAsync and committed [kafka]

2023-11-22 Thread via GitHub
lucasbru opened a new pull request, #14817: URL: https://github.com/apache/kafka/pull/14817 To align the new consumer completely with the legacy consumer, we need to update the latest seen leader epoch in the metadata both when we commit offsets with a leader epoch using `commitAsync

[jira] [Created] (KAFKA-15879) Add documentation for the Docker image

2023-11-22 Thread Vedarth Sharma (Jira)
Vedarth Sharma created KAFKA-15879: -- Summary: Add documentation for the Docker image Key: KAFKA-15879 URL: https://issues.apache.org/jira/browse/KAFKA-15879 Project: Kafka Issue Type: Sub-ta

[jira] [Created] (KAFKA-15880) Add github actions workflow for promoting RC docker image

2023-11-22 Thread Vedarth Sharma (Jira)
Vedarth Sharma created KAFKA-15880: -- Summary: Add github actions workflow for promoting RC docker image Key: KAFKA-15880 URL: https://issues.apache.org/jira/browse/KAFKA-15880 Project: Kafka

[PR] KAFKA-15878: KIP-768 - Extend support for opaque (i.e. non-JWT) tokens in SASL/OAUTHBEARER [kafka]

2023-11-22 Thread via GitHub
jcme opened a new pull request, #14818: URL: https://github.com/apache/kafka/pull/14818 # Overview * This change pertains to [SASL/OAUTHBEARER ](https://kafka.apache.org/documentation/#security_sasl_oauthbearer) mechanism of Kafka authentication. * Kafka clients can use [SASL/OAUTHB

[jira] [Created] (KAFKA-15881) Update release.py script to include docker image

2023-11-22 Thread Vedarth Sharma (Jira)
Vedarth Sharma created KAFKA-15881: -- Summary: Update release.py script to include docker image Key: KAFKA-15881 URL: https://issues.apache.org/jira/browse/KAFKA-15881 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-15882) Scheduled nightly github actions workflow for CVE reports on published docker images

2023-11-22 Thread Vedarth Sharma (Jira)
Vedarth Sharma created KAFKA-15882: -- Summary: Scheduled nightly github actions workflow for CVE reports on published docker images Key: KAFKA-15882 URL: https://issues.apache.org/jira/browse/KAFKA-15882

Re: [PR] KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 commented on PR #14632: URL: https://github.com/apache/kafka/pull/14632#issuecomment-1822777968 > @apoorvmittal10 : > > 1. Do you know why JDK 11 and Scala 2.13 didn't build? > 2. For getting green build, it would be useful to help triage the new test failures. If we

Re: [PR] MINOR: Update LICENSE-binary for 3.6.1 [kafka]

2023-11-22 Thread via GitHub
mimaison merged PR #14812: URL: https://github.com/apache/kafka/pull/14812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-15883) Implement RemoteCopyLagBytes

2023-11-22 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-15883: - Summary: Implement RemoteCopyLagBytes Key: KAFKA-15883 URL: https://issues.apache.org/jira/browse/KAFKA-15883 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-15856: Add integration tests for JoinGroup API and SyncGroup API [kafka]

2023-11-22 Thread via GitHub
dongnuo123 commented on code in PR #14800: URL: https://github.com/apache/kafka/pull/14800#discussion_r1402122588 ## core/src/test/scala/unit/kafka/server/SyncGroupRequestTest.scala: ## @@ -0,0 +1,283 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (KAFKA-7631) NullPointerException when SCRAM is allowed bu ScramLoginModule is not in broker's jaas.conf

2023-11-22 Thread Andrew Olson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788786#comment-17788786 ] Andrew Olson commented on KAFKA-7631: - This looks like a duplicate of KAFKA-10556 (fi

Re: [PR] KAFKA-15830: Add telemetry API handling (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 commented on code in PR #14767: URL: https://github.com/apache/kafka/pull/14767#discussion_r1402135807 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -913,6 +915,13 @@ class DynamicMetricReporterState(brokerId: Int, config: KafkaConfig, metr

[jira] [Resolved] (KAFKA-7631) NullPointerException when SCRAM is allowed bu ScramLoginModule is not in broker's jaas.conf

2023-11-22 Thread Andrew Olson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson resolved KAFKA-7631. - Resolution: Fixed Marking as resolved since I believe it is. > NullPointerException when SCRAM i

[jira] [Updated] (KAFKA-7631) NullPointerException when SCRAM is allowed bu ScramLoginModule is not in broker's jaas.conf

2023-11-22 Thread Andrew Olson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Olson updated KAFKA-7631: Fix Version/s: 2.7.0 > NullPointerException when SCRAM is allowed bu ScramLoginModule is not in >

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1402159178 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Created] (KAFKA-15884) Reduce lock contention when cleaning topics

2023-11-22 Thread Krzysztof Piecuch (Jira)
Krzysztof Piecuch created KAFKA-15884: - Summary: Reduce lock contention when cleaning topics Key: KAFKA-15884 URL: https://issues.apache.org/jira/browse/KAFKA-15884 Project: Kafka Issue T

[jira] [Created] (KAFKA-15885) Reduce lock contention when cleaning topics

2023-11-22 Thread Krzysztof Piecuch (Jira)
Krzysztof Piecuch created KAFKA-15885: - Summary: Reduce lock contention when cleaning topics Key: KAFKA-15885 URL: https://issues.apache.org/jira/browse/KAFKA-15885 Project: Kafka Issue T

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1402179874 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-22 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1402215662 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -898,31 +1000,45 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-11-22 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1402217667 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -829,21 +902,50 @@ private CoordinatorResult consumerGr

[PR] MINOR: Fix a few reconciliation bugs [kafka]

2023-11-22 Thread via GitHub
dajac opened a new pull request, #14819: URL: https://github.com/apache/kafka/pull/14819 Requires changes to make the reconciliation logic in the async consumer work. With this, I was able to join a consumer groups with a few members. ### Committer Checklist (excluded from commit mess

Re: [PR] KAFKA-15241: Compute tiered copied offset by keeping the respective epochs in scope [kafka]

2023-11-22 Thread via GitHub
kamalcph commented on PR #14787: URL: https://github.com/apache/kafka/pull/14787#issuecomment-1823088481 @satishd Addressed your review comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

2023-11-22 Thread via GitHub
soarez commented on code in PR #14790: URL: https://github.com/apache/kafka/pull/14790#discussion_r1402362044 ## server/src/main/java/org/apache/kafka/server/AssignmentsManager.java: ## @@ -231,13 +238,12 @@ public void run() throws Exception { } else {

Re: [PR] KAFKA-15047: Roll active segment when it breaches the retention policy [kafka]

2023-11-22 Thread via GitHub
kamalcph commented on PR #14766: URL: https://github.com/apache/kafka/pull/14766#issuecomment-1823109337 > The first one is that I no longer see a point in segment.bytes and segment.ms (and by extension log.segment.bytes and log.segment.ms) with respect to tiered topics. If a person says "h

[jira] [Updated] (KAFKA-15620) Duplicate remote log DELETE_SEGMENT metadata is generated when there are multiple leader epochs in the segment

2023-11-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15620: --- Fix Version/s: (was: 3.6.1) > Duplicate remote log DELETE_SEGMENT metadata is generated

[jira] [Created] (KAFKA-15886) Always specify directories for new partition registrations

2023-11-22 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-15886: --- Summary: Always specify directories for new partition registrations Key: KAFKA-15886 URL: https://issues.apache.org/jira/browse/KAFKA-15886 Project: Kafka Issu

[jira] [Updated] (KAFKA-15876) Introduce Remote Storage Not Ready Exception

2023-11-22 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15876: - Labels: kip (was: ) > Introduce Remote Storage Not Ready Exception > --

[jira] [Commented] (KAFKA-15620) Duplicate remote log DELETE_SEGMENT metadata is generated when there are multiple leader epochs in the segment

2023-11-22 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788830#comment-17788830 ] Mickael Maison commented on KAFKA-15620: Removed 3.6.1 from the fix version list

[PR] KAFKA-15886: Always specify directories for new partition registrations [kafka]

2023-11-22 Thread via GitHub
soarez opened a new pull request, #14820: URL: https://github.com/apache/kafka/pull/14820 When creating partition registrations directories must always be defined. If creating a partition from a PartitionRecord or PartitionChangeRecord from an older version that does not support direc

[jira] [Assigned] (KAFKA-15886) Always specify directories for new partition registrations

2023-11-22 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-15886: --- Assignee: Igor Soarez > Always specify directories for new partition registrations > --

[PR] KAFKA-15768: StateQueryResult#getOnlyPartitionResult should not throw for FailedQueryResult [kafka]

2023-11-22 Thread via GitHub
hanyuzheng7 opened a new pull request, #14821: URL: https://github.com/apache/kafka/pull/14821 Calling `StateQueryResult#getOnlyPartitionResult` crashes with an incorrect `IllegalArgumentException` if the any result is a `FailedQueryResult` (and even if there is only a single FailedQueryRes

[PR] KAFKA-15876: Introduce RemoteStorageNotReadyException retryable error [kafka]

2023-11-22 Thread via GitHub
kamalcph opened a new pull request, #14822: URL: https://github.com/apache/kafka/pull/14822 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

Re: [PR] KAFKA-15768: StateQueryResult#getOnlyPartitionResult should not throw for FailedQueryResult [kafka]

2023-11-22 Thread via GitHub
hanyuzheng7 commented on code in PR #14821: URL: https://github.com/apache/kafka/pull/14821#discussion_r1402442067 ## streams/src/main/java/org/apache/kafka/streams/query/StateQueryResult.java: ## @@ -77,6 +79,12 @@ public QueryResult getOnlyPartitionResult() {

[PR] HOTFIX: Fix compilation error with Scala 2.12 [kafka]

2023-11-22 Thread via GitHub
mimaison opened a new pull request, #14823: URL: https://github.com/apache/kafka/pull/14823 Fixes [Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka_3.6/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:2646:51: the result type of an implicit conversion must be more spec

Re: [PR] HOTFIX: Fix compilation error with Scala 2.12 [kafka]

2023-11-22 Thread via GitHub
mimaison commented on PR #14823: URL: https://github.com/apache/kafka/pull/14823#issuecomment-1823186116 The Java 8 Scala 2.12 build has been broken for 9 days since this backport https://github.com/apache/kafka/commit/1de84590c476d3ea0577cde2b4cd12e6584b8fe9 https://ci-builds.apache.org

Re: [PR] KAFKA-15768: StateQueryResult#getOnlyPartitionResult should not throw for FailedQueryResult [kafka]

2023-11-22 Thread via GitHub
hanyuzheng7 commented on code in PR #14821: URL: https://github.com/apache/kafka/pull/14821#discussion_r1402442067 ## streams/src/main/java/org/apache/kafka/streams/query/StateQueryResult.java: ## @@ -77,6 +79,12 @@ public QueryResult getOnlyPartitionResult() {

Re: [PR] HOTFIX: Fix compilation error with Scala 2.12 [kafka]

2023-11-22 Thread via GitHub
mimaison commented on PR #14823: URL: https://github.com/apache/kafka/pull/14823#issuecomment-1823191335 cc @ijuma @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

2023-11-22 Thread via GitHub
viktorsomogyi commented on code in PR #14756: URL: https://github.com/apache/kafka/pull/14756#discussion_r1400948591 ## clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java: ## @@ -185,6 +188,18 @@ private SslEngineFactory createNewSslEngineFactory(Map new

Re: [PR] KAFKA-15860: ControllerRegistration must be written out to the metadata image [kafka]

2023-11-22 Thread via GitHub
jsancio commented on code in PR #14807: URL: https://github.com/apache/kafka/pull/14807#discussion_r1402453079 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -205,4 +207,22 @@ private static List getImageRecords(ClusterImage image) { imag

Re: [PR] KAFKA-15860: ControllerRegistration must be written out to the metadata image [kafka]

2023-11-22 Thread via GitHub
cmccabe commented on code in PR #14807: URL: https://github.com/apache/kafka/pull/14807#discussion_r1402476918 ## metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java: ## @@ -205,4 +207,22 @@ private static List getImageRecords(ClusterImage image) { imag

[jira] [Created] (KAFKA-15887) Autocommit during close consistently fails with exception in background thread

2023-11-22 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15887: -- Summary: Autocommit during close consistently fails with exception in background thread Key: KAFKA-15887 URL: https://issues.apache.org/jira/browse/KAFKA-15887 Pr

[PR] MINOR: Fix broken method link in DistributedHerder::writeToConfigTopicAsLeader Javadoc [kafka]

2023-11-22 Thread via GitHub
yashmayya opened a new pull request, #14824: URL: https://github.com/apache/kafka/pull/14824 - The `ConfigBackingStore::putConnectorConfig` method was modified in https://github.com/apache/kafka/pull/14704 to take in a third parameter (`TargetState`). - This breaks the method link in the

[jira] [Created] (KAFKA-15888) DistributedHerder log context should not use the same client ID for each Connect worker by default

2023-11-22 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-15888: -- Summary: DistributedHerder log context should not use the same client ID for each Connect worker by default Key: KAFKA-15888 URL: https://issues.apache.org/jira/browse/KAFKA-15888

[PR] KAFKA-15888: DistributedHerder log context should not use the same client ID for each Connect worker by default [kafka]

2023-11-22 Thread via GitHub
yashmayya opened a new pull request, #14825: URL: https://github.com/apache/kafka/pull/14825 - https://issues.apache.org/jira/browse/KAFKA-15888 - By default, if there is no `client.id` configured on a Connect worker running in distributed mode, the same client ID (`connect-1`) will be us

Re: [PR] KAFKA-15836: KafkaConsumer subscribes to multiple topics does not respect max.poll.records [kafka]

2023-11-22 Thread via GitHub
jolshan commented on PR #14789: URL: https://github.com/apache/kafka/pull/14789#issuecomment-1823374923 I realized i didn't cherrypick to 3.6.1. I can do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 closed pull request #14632: KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) URL: https://github.com/apache/kafka/pull/14632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 opened a new pull request, #14632: URL: https://github.com/apache/kafka/pull/14632 The PR adds support of alter/describe configs for client-metrics as defined in [KIP-714](https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability#KIP714:Cli

Re: [PR] KIP-978: Allow dynamic reloading of certificates with different DN / SANs [kafka]

2023-11-22 Thread via GitHub
scholzj commented on PR #14756: URL: https://github.com/apache/kafka/pull/14756#issuecomment-1823431704 Thanks for the review comments @viktorsomogyi. They should be now fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-15888: DistributedHerder log context should not use the same client ID for each Connect worker by default [kafka]

2023-11-22 Thread via GitHub
C0urante commented on PR #14825: URL: https://github.com/apache/kafka/pull/14825#issuecomment-1823468350 Would it be worth it to keep the `connect-` prefix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-14552) Remove no longer required server protocol versions in Kafka 4.0

2023-11-22 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788891#comment-17788891 ] Colin McCabe commented on KAFKA-14552: -- I could go either way. I think most of the

Re: [PR] MINOR: Fix broken method link in DistributedHerder::writeToConfigTopicAsLeader Javadoc [kafka]

2023-11-22 Thread via GitHub
yashmayya merged PR #14824: URL: https://github.com/apache/kafka/pull/14824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Updated] (KAFKA-15817) Avoid reconnecting to the same IP address if multiple addresses are available

2023-11-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15817: -- Fix Version/s: 3.7.0 3.6.1 > Avoid reconnecting to the same IP address if multiple

[jira] [Updated] (KAFKA-15768) StateQueryResult#getOnlyPartitionResult should not throw for FailedQueryResult

2023-11-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15768: Description: Calling `StateQueryResult#getOnlyPartitionResult` crashes with an incorrect

[jira] [Updated] (KAFKA-15768) StateQueryResult#getOnlyPartitionResult should not throw for FailedQueryResult

2023-11-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15768: Description: Calling `StateQueryResult#getOnlyPartitionResult` crashes with an incorrect

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id [kafka]

2023-11-22 Thread via GitHub
mjsax commented on code in PR #14768: URL: https://github.com/apache/kafka/pull/14768#discussion_r1402777467 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -163,11 +163,9 @@ public class AsyncKafkaConsumer implements Consumer

Re: [PR] KAFKA-15886: Always specify directories for new partition registrations [kafka]

2023-11-22 Thread via GitHub
soarez commented on PR #14820: URL: https://github.com/apache/kafka/pull/14820#issuecomment-1823599261 @cmccabe @pprovenzano please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id [kafka]

2023-11-22 Thread via GitHub
mjsax commented on code in PR #14768: URL: https://github.com/apache/kafka/pull/14768#discussion_r1402777467 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -163,11 +163,9 @@ public class AsyncKafkaConsumer implements Consumer

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id [kafka]

2023-11-22 Thread via GitHub
mjsax commented on code in PR #14768: URL: https://github.com/apache/kafka/pull/14768#discussion_r1402777990 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java: ## @@ -150,11 +150,9 @@ public class LegacyKafkaConsumer implements Consum

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id [kafka]

2023-11-22 Thread via GitHub
mjsax commented on PR #14768: URL: https://github.com/apache/kafka/pull/14768#issuecomment-1823600766 Even if there was KIP for this change, we cannot put it into a minor release, but need to wait for 4.0. This change would have been ok for 3.0, but this ship has sailed. -- This is

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id [kafka]

2023-11-22 Thread via GitHub
kirktrue commented on code in PR #14768: URL: https://github.com/apache/kafka/pull/14768#discussion_r1402784590 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/LegacyKafkaConsumer.java: ## @@ -150,11 +150,9 @@ public class LegacyKafkaConsumer implements Con

Re: [PR] KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id [kafka]

2023-11-22 Thread via GitHub
kirktrue commented on PR #14768: URL: https://github.com/apache/kafka/pull/14768#issuecomment-1823610187 > Even if there was KIP for this change, we cannot put it into a minor release, but need to wait for 4.0. Is there any preparatory steps we need to take now (i.e. in the 3.7 releas

Re: [PR] KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance [kafka]

2023-11-22 Thread via GitHub
ocadaruma commented on PR #14242: URL: https://github.com/apache/kafka/pull/14242#issuecomment-1823612335 closing once to rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance [kafka]

2023-11-22 Thread via GitHub
ocadaruma opened a new pull request, #14242: URL: https://github.com/apache/kafka/pull/14242 JIRA ticket: https://issues.apache.org/jira/browse/KAFKA-15046 - While any blocking operation under holding the UnifiedLog.lock could lead to serious performance (even availability) issues, cu

[jira] [Updated] (KAFKA-15848) Consumer API timeout inconsistent between ConsumerDelegate implementations

2023-11-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15848: -- Summary: Consumer API timeout inconsistent between ConsumerDelegate implementations (was: Consumer AP

[jira] [Updated] (KAFKA-15848) Consumer API timeout inconsistent between ConsumerDelegate implementations

2023-11-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15848: -- Description: The two {{ConsumerDelegate}} implementations ({{{}LegacyKafkaConsumer{}}} and {{{}AsyncK

[jira] [Updated] (KAFKA-15848) Consumer API timeout inconsistent between ConsumerDelegate implementations

2023-11-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15848: -- Description: The two {{ConsumerDelegate}} implementations ({{{}LegacyKafkaConsumer{}}} and {{{}AsyncK

[jira] [Assigned] (KAFKA-15848) Consumer API timeout inconsistent between ConsumerDelegate implementations

2023-11-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15848: - Assignee: Kirk True > Consumer API timeout inconsistent between ConsumerDelegate implementation

[jira] [Updated] (KAFKA-12281) Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException

2023-11-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12281: Labels: beginner needs-kip newbie (was: needs-kip) > Deprecate org.apache.kafka.streams.e

[jira] [Updated] (KAFKA-8088) Deprecate `WindowStoreIterator` interface

2023-11-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-8088: --- Fix Version/s: 4.0.0 > Deprecate `WindowStoreIterator` interface > --

[jira] [Updated] (KAFKA-8575) Investigate removing EAGER protocol & cleaning up task suspension in Streams rebalancing

2023-11-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-8575: --- Fix Version/s: 4.0.0 > Investigate removing EAGER protocol & cleaning up task suspension in

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 closed pull request #14699: KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) URL: https://github.com/apache/kafka/pull/14699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) [kafka]

2023-11-22 Thread via GitHub
apoorvmittal10 closed pull request #14632: KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) URL: https://github.com/apache/kafka/pull/14632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-15860: ControllerRegistration must be written out to the metadata image [kafka]

2023-11-22 Thread via GitHub
cmccabe merged PR #14807: URL: https://github.com/apache/kafka/pull/14807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15645 ReplicationQuotasTestRig rewritten in java [kafka]

2023-11-22 Thread via GitHub
nizhikov commented on PR #14588: URL: https://github.com/apache/kafka/pull/14588#issuecomment-1823869599 Hello @mimaison Are you be able to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab