[jira] [Updated] (KAFKA-15894) MessageConversionsTimeMs and TemporaryMemoryBytes may not be recorded correctly.

2023-11-25 Thread Minoru Tomioka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Minoru Tomioka updated KAFKA-15894: --- Description: {{KafkaApis.updateRecordConversionStats}} may be called multiple times for a

Re: [PR] KAFKA-15821: Delete active topics after connector deletion in standal… [kafka]

2023-11-25 Thread via GitHub
C0urante commented on PR #14776: URL: https://github.com/apache/kafka/pull/14776#issuecomment-1826433209 Thanks for the PR @djameson42! I agree with @hudeqi that we should have a test to cover this change and prevent regression. Also, not a blocker, but it seems a little strange to

Re: [PR] KAFKA-15827: Prevent KafkaBasedLog subclasses from leaking passed-in clients [kafka]

2023-11-25 Thread via GitHub
C0urante commented on PR #14763: URL: https://github.com/apache/kafka/pull/14763#issuecomment-1826432299 Can we add a comment to the class explaining why we're explicitly closing the clients even though it also looks like they're closed in the superclass's `stop` method? Also, is it

[jira] [Commented] (KAFKA-14624) State restoration is broken with standby tasks and cache-enabled stores in processor API

2023-11-25 Thread Balaji Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789716#comment-17789716 ] Balaji Rao commented on KAFKA-14624: Hi [~lbrutschy], I tested this against 3.5 and 3.6 too and I

Re: [PR] KAFKA-15618: Kafka metrics collector and supporting classes (KIP-714) [kafka]

2023-11-25 Thread via GitHub
apoorvmittal10 commented on code in PR #14620: URL: https://github.com/apache/kafka/pull/14620#discussion_r1405206281 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/KafkaMetricsCollector.java: ## @@ -0,0 +1,334 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15618: Kafka metrics collector and supporting classes (KIP-714) [kafka]

2023-11-25 Thread via GitHub
apoorvmittal10 commented on PR #14620: URL: https://github.com/apache/kafka/pull/14620#issuecomment-1826401674 @AndrewJSchofield @philipnee Thanks for approving the PR. @xvrl I have also added support for handling temporality change in KafkaMetricsCollector

[jira] [Created] (KAFKA-15900) Flaky test: testOutdatedCoordinatorAssignment() – org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest

2023-11-25 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15900: - Summary: Flaky test: testOutdatedCoordinatorAssignment() – org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest Key: KAFKA-15900 URL:

[jira] [Commented] (KAFKA-15898) Flaky test: testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest

2023-11-25 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789715#comment-17789715 ] Apoorv Mittal commented on KAFKA-15898: --- Another failure reported:

[jira] [Commented] (KAFKA-15891) Flaky test: testResetSinkConnectorOffsetsOverriddenConsumerGroupId – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest

2023-11-25 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789712#comment-17789712 ] Apoorv Mittal commented on KAFKA-15891: --- Another PR build run failure for same test:

[jira] [Resolved] (KAFKA-14527) Move `kafka.security` from `core` to separate module

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14527. - Resolution: Won't Do Closing as "Won't do" for now. We'll start with KAFKA-15842 and then

[jira] [Comment Edited] (KAFKA-14527) Move `kafka.security` from `core` to separate module

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789709#comment-17789709 ] Ismael Juma edited comment on KAFKA-14527 at 11/25/23 6:51 PM: --- Closing as

[jira] [Created] (KAFKA-15899) Move kafka.security package from core to server module

2023-11-25 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15899: --- Summary: Move kafka.security package from core to server module Key: KAFKA-15899 URL: https://issues.apache.org/jira/browse/KAFKA-15899 Project: Kafka Issue

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-25 Thread via GitHub
apoorvmittal10 commented on PR #14699: URL: https://github.com/apache/kafka/pull/14699#issuecomment-1826397165 @junrao @AndrewJSchofield Thanks for the LGTM and approving the PR. Below is the test run status, none of the failing tests are related to the changes in the PR but I have tried

[jira] [Created] (KAFKA-15898) Flaky test: testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest

2023-11-25 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15898: - Summary: Flaky test: testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest Key: KAFKA-15898 URL: https://issues.apache.org/jira/browse/KAFKA-15898

[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789707#comment-17789707 ] Ismael Juma commented on KAFKA-15853: - [~omnia_h_ibrahim] Sounds reasonable to me. The `ProcessRole`

[jira] [Created] (KAFKA-15897) Flaky Test: testWrongIncarnationId() – kafka.server.ControllerRegistrationManagerTest

2023-11-25 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15897: - Summary: Flaky Test: testWrongIncarnationId() – kafka.server.ControllerRegistrationManagerTest Key: KAFKA-15897 URL: https://issues.apache.org/jira/browse/KAFKA-15897

[jira] [Created] (KAFKA-15896) Flaky test: shouldQuerySpecificStalePartitionStores() – org.apache.kafka.streams.integration.StoreQueryIntegrationTest

2023-11-25 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15896: - Summary: Flaky test: shouldQuerySpecificStalePartitionStores() – org.apache.kafka.streams.integration.StoreQueryIntegrationTest Key: KAFKA-15896 URL:

[jira] [Comment Edited] (KAFKA-15853) Move KafkaConfig to server module

2023-11-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789703#comment-17789703 ] Omnia Ibrahim edited comment on KAFKA-15853 at 11/25/23 6:12 PM: - As

[jira] [Comment Edited] (KAFKA-15853) Move KafkaConfig to server module

2023-11-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789703#comment-17789703 ] Omnia Ibrahim edited comment on KAFKA-15853 at 11/25/23 6:10 PM: - As

[jira] [Created] (KAFKA-15895) Move DynamicBrokerConfig to server module

2023-11-25 Thread Omnia Ibrahim (Jira)
Omnia Ibrahim created KAFKA-15895: - Summary: Move DynamicBrokerConfig to server module Key: KAFKA-15895 URL: https://issues.apache.org/jira/browse/KAFKA-15895 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module

2023-11-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789703#comment-17789703 ] Omnia Ibrahim commented on KAFKA-15853: --- As KafkaConfig depends on many object compinanion of

[jira] [Commented] (KAFKA-15690) EosIntegrationTest is flaky.

2023-11-25 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789702#comment-17789702 ] Apoorv Mittal commented on KAFKA-15690: --- Another failure:

[jira] [Commented] (KAFKA-14527) Move `kafka.security` from `core` to separate module

2023-11-25 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789700#comment-17789700 ] Omnia Ibrahim commented on KAFKA-14527: --- I think this makes more sense. Thanks, [~ijuma]. Please

[jira] [Commented] (KAFKA-15772) Flaky test TransactionsWithTieredStoreTest

2023-11-25 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789695#comment-17789695 ] Apoorv Mittal commented on KAFKA-15772: --- Another failure:

[jira] [Comment Edited] (KAFKA-15411) DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky

2023-11-25 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789694#comment-17789694 ] Apoorv Mittal edited comment on KAFKA-15411 at 11/25/23 5:26 PM: -

[jira] [Commented] (KAFKA-15411) DelegationTokenEndToEndAuthorizationWithOwnerTest is Flaky

2023-11-25 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789694#comment-17789694 ] Apoorv Mittal commented on KAFKA-15411: --- Another failure:

[jira] [Updated] (KAFKA-15894) MessageConversionsTimeMs and TemporaryMemoryBytes may not be recorded correctly.

2023-11-25 Thread Minoru Tomioka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Minoru Tomioka updated KAFKA-15894: --- Component/s: core > MessageConversionsTimeMs and TemporaryMemoryBytes may not be recorded

[jira] [Updated] (KAFKA-15894) MessageConversionsTimeMs and TemporaryMemoryBytes may not be recorded correctly.

2023-11-25 Thread Minoru Tomioka (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Minoru Tomioka updated KAFKA-15894: --- Component/s: metrics > MessageConversionsTimeMs and TemporaryMemoryBytes may not be

[jira] [Created] (KAFKA-15894) MessageConversionsTimeMs and TemporaryMemoryBytes may not be recorded correctly.

2023-11-25 Thread Minoru Tomioka (Jira)
Minoru Tomioka created KAFKA-15894: -- Summary: MessageConversionsTimeMs and TemporaryMemoryBytes may not be recorded correctly. Key: KAFKA-15894 URL: https://issues.apache.org/jira/browse/KAFKA-15894

[jira] [Commented] (KAFKA-14527) Move `kafka.security` from `core` to separate module

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789690#comment-17789690 ] Ismael Juma commented on KAFKA-14527: - [~omnia_h_ibrahim] Thinking about this some more, I think we

[jira] [Updated] (KAFKA-14524) Modularize `core` monolith

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14524: Description: The `core` module has grown too large and it's time to split it into multiple

[jira] [Updated] (KAFKA-15852) Move server code from `core` to `server` module

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-15852: Description: The relevant packages would be `kafka.server`, `kafka.cluster`, `kafka.network`,

[jira] [Resolved] (KAFKA-14526) Move `kafka.network` from `core` to separate module

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14526. - Resolution: Won't Do Marking this as "Won't do" for now in favor of KAFKA-15852. Once that's

[jira] [Resolved] (KAFKA-14528) Move replication code from `core` to separate module

2023-11-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14528. - Resolution: Won't Do Marking this as "Won't Do" for now in favor of KAFKA-15852. Once that is

[jira] [Updated] (KAFKA-15809) Update broker's metadata schema to include TS enable status

2023-11-25 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran updated KAFKA-15809: --- Summary: Update broker's metadata schema to include TS enable status (was: Updating

Re: [PR] MINOR: Add retry for CI [kafka]

2023-11-25 Thread via GitHub
dajac commented on PR #14828: URL: https://github.com/apache/kafka/pull/14828#issuecomment-1826316639 Thanks for the PR. The Jenkins file already sets those settings to retry failed tests in cradle. See here: