cadonna commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1416983368
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -103,6 +103,12 @@ public class HeartbeatRequestManager implemen
ableegoldman commented on PR #14735:
URL: https://github.com/apache/kafka/pull/14735#issuecomment-1842502256
Test failures are unrelated, looks good to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/KAFKA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793591#comment-17793591
]
Mickael Maison commented on KAFKA-15593:
The PR was merged, can we resolve this
ableegoldman merged PR #14735:
URL: https://github.com/apache/kafka/pull/14735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
cadonna commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1416983368
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -103,6 +103,12 @@ public class HeartbeatRequestManager implemen
cadonna commented on code in PR #14912:
URL: https://github.com/apache/kafka/pull/14912#discussion_r1416941420
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -966,22 +967,25 @@ private void
testUpdateFetchPositionsWithFet
ashmeet13 commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1842424947
Hi @mjsax apologies for the delay. Pushing this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mimaison commented on PR #12228:
URL: https://github.com/apache/kafka/pull/12228#issuecomment-1842424977
@divijvaidya You had 1 approval, so if you rebase you could merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
philipnee commented on PR #14920:
URL: https://github.com/apache/kafka/pull/14920#issuecomment-1842376289
@kirktrue - Thanks for reviewing the code. I did some refactor on a
separated branch, I hope this is inline with what you meant there:
https://github.com/apache/kafka/pull/14937 cc @lu
philipnee opened a new pull request, #14937:
URL: https://github.com/apache/kafka/pull/14937
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testi
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1842367014
Thanks @dengziming. I will investigate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
201 - 211 of 211 matches
Mail list logo