iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435445309
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1289,15 +1289,21 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435445309
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1289,15 +1289,21 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435444785
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2161,6 +2167,86 @@ RecordBatch findFirstBatch(RemoteLogInputStream
remoteLogInputStream,
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435445309
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1289,15 +1289,21 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435446137
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1412,8 +1422,8 @@ private void
collectAbortedTransactionInLocalSegments(long startOffset,
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435445309
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1289,15 +1289,21 @@ public FetchDataInfo read(RemoteStorageFetchInfo
remoteStorageFetchInfo)
iit2009060 commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435444785
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2161,6 +2167,86 @@ RecordBatch findFirstBatch(RemoteLogInputStream
remoteLogInputStream,
[
https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799209#comment-17799209
]
Alexander Aghili edited comment on KAFKA-16027 at 12/23/23 2:09 AM:
satishd commented on PR #15063:
URL: https://github.com/apache/kafka/pull/15063#issuecomment-1868160079
Nice catch @dajac, thanks for resolving it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-16012.
Resolution: Fixed
> Incomplete range assignment in consumer
>
jolshan merged PR #15023:
URL: https://github.com/apache/kafka/pull/15023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15023:
URL: https://github.com/apache/kafka/pull/15023#issuecomment-1868141386
Ok -- looks good. I will merge and backport to 3.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-16047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angelos Kaltsikis updated KAFKA-16047:
--
Description:
Source Connectors with 'exactly.once.support = required' may have some
[
https://issues.apache.org/jira/browse/KAFKA-16047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angelos Kaltsikis updated KAFKA-16047:
--
Summary: Source connector with EOS enabled have some InitProducerId
requests timing
[
https://issues.apache.org/jira/browse/KAFKA-16047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799953#comment-17799953
]
Angelos Kaltsikis commented on KAFKA-16047:
---
cc. [~gregharris73]
> Source connector with EOS
[
https://issues.apache.org/jira/browse/KAFKA-16047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angelos Kaltsikis updated KAFKA-16047:
--
Summary: Source connector with EOS enabled have some InitProducerId
requests timing
Angelos Kaltsikis created KAFKA-16047:
-
Summary: Source connector with EOS enabled have some
InitProducerId requests timing out
Key: KAFKA-16047
URL: https://issues.apache.org/jira/browse/KAFKA-16047
afshing opened a new pull request, #15066:
URL: https://github.com/apache/kafka/pull/15066
It seems like this PR duplicated the implementation to QuotaUtils, but
didn't remove this implementation
*More detailed description of your change,
if necessary. The PR title and PR message
clolov commented on code in PR #15060:
URL: https://github.com/apache/kafka/pull/15060#discussion_r1435282790
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2161,6 +2167,86 @@ RecordBatch findFirstBatch(RemoteLogInputStream
remoteLogInputStream, long
philipnee commented on PR #15023:
URL: https://github.com/apache/kafka/pull/15023#issuecomment-1867985789
Hey @jolshan seems like the build finished without oom, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mimaison merged PR #14867:
URL: https://github.com/apache/kafka/pull/14867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #14867:
URL: https://github.com/apache/kafka/pull/14867#issuecomment-1867895289
I'm waiting for the CI to finish. I don't want to risk breaking trunk just
before logging off for PTO.
--
This is an automated message from the Apache Git Service.
To respond to the
tinaselenge commented on PR #14846:
URL: https://github.com/apache/kafka/pull/14846#issuecomment-1867865063
@dengziming I have triggered the build 3 more times and DeleteTopicTest
passed. I have also enabled KRaft for
testIncreasePartitionCountDuringDeleteTopic (they didn't have much
srdo commented on PR #15024:
URL: https://github.com/apache/kafka/pull/15024#issuecomment-1867860145
Sure, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
divijvaidya merged PR #14662:
URL: https://github.com/apache/kafka/pull/14662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #14662:
URL: https://github.com/apache/kafka/pull/14662#issuecomment-1867857397
Unrelated test failures
```
[Build / JDK 8 and Scala 2.12 /
divijvaidya commented on PR #15024:
URL: https://github.com/apache/kafka/pull/15024#issuecomment-1867854246
A fix to make CI stable was pushed today. @srdo Can you please rebase from
trunk one time? It will probably help us get a better picture of CI
failures/success.
--
This is an
nizhikov commented on PR #14867:
URL: https://github.com/apache/kafka/pull/14867#issuecomment-1867850331
@mimaison Are we want to merge this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-16046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Almog Gavra resolved KAFKA-16046.
-
Resolution: Fixed
> Stream Stream Joins fail after restoration with deserialization exceptions
lucasbru closed pull request #15064: DNM: test
URL: https://github.com/apache/kafka/pull/15064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799859#comment-17799859
]
Hugo Abreu edited comment on KAFKA-10875 at 12/22/23 3:22 PM:
--
We are
[
https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799859#comment-17799859
]
Hugo Abreu edited comment on KAFKA-10875 at 12/22/23 3:21 PM:
--
We are
[
https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799859#comment-17799859
]
Hugo Abreu commented on KAFKA-10875:
We are seeing this behaviour with kafka-clients 3.6.1 and
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1867795357
Hey @MikeEdgar I'm seeing KafkaAdminClientTest.testDescribeTopicByIds
failing due to it expecting the old error. Can we update that test?
--
This is an automated message from the
lucasbru merged PR #15061:
URL: https://github.com/apache/kafka/pull/15061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #15061:
URL: https://github.com/apache/kafka/pull/15061#issuecomment-1867744948
Cause of OOM on trunk identified, so merging this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lucasbru merged PR #15035:
URL: https://github.com/apache/kafka/pull/15035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac merged PR #15062:
URL: https://github.com/apache/kafka/pull/15062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac merged PR #15063:
URL: https://github.com/apache/kafka/pull/15063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15065:
URL: https://github.com/apache/kafka/pull/15065#issuecomment-1867639044
@dajac @ijuma @jolshan @stanislavkozlovski , call for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon opened a new pull request, #15065:
URL: https://github.com/apache/kafka/pull/15065
As @stanislavkozlovski found
[here](https://gist.github.com/stanislavkozlovski/8959f7ee59434f774841f4ae2f5228c2),
there are some tests ran more than 1 ~ 2 hours, which make our CI build meet 8
hours
lucasbru commented on PR #15061:
URL: https://github.com/apache/kafka/pull/15061#issuecomment-1867506949
Restarting the CI since we had OOM before - however, OOM affects trunk so if
we don't see anything in the next run, I think we should merge this.
--
This is an automated message from
lucasbru opened a new pull request, #15064:
URL: https://github.com/apache/kafka/pull/15064
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
mfvitale commented on PR #14992:
URL: https://github.com/apache/kafka/pull/14992#issuecomment-1867484294
> haha! I like your commit message "code beauty" :)
> I see that this is your first change to Apache Kafka. Congratulations and
welcome!
Yes! Thanks!
> As
sciclon2 commented on code in PR #15030:
URL: https://github.com/apache/kafka/pull/15030#discussion_r1434907926
##
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java:
##
@@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws
Exception
divijvaidya commented on code in PR #15030:
URL: https://github.com/apache/kafka/pull/15030#discussion_r1434893044
##
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java:
##
@@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws
dajac opened a new pull request, #15063:
URL: https://github.com/apache/kafka/pull/15063
I was inspecting heap dumps to chase the OOM errors that we see in builds
and I have noticed that `remote-log-index-cleaner` threads were still running.
This may be one of the sources.
We should
[
https://issues.apache.org/jira/browse/KAFKA-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799742#comment-17799742
]
Arpit Goyal commented on KAFKA-15301:
-
[~mital.awachat] does this ticket addresses your concern.
mfvitale commented on PR #14992:
URL: https://github.com/apache/kafka/pull/14992#issuecomment-1867448606
@divijvaidya Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
clolov commented on PR #15060:
URL: https://github.com/apache/kafka/pull/15060#issuecomment-1867443497
Thank you for the contribution! I will aim to provide a review throughout
the day!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
divijvaidya commented on PR #14992:
URL: https://github.com/apache/kafka/pull/14992#issuecomment-1867441468
@mfvitale one last comment about fixing indentation, otherwise we should be
good to ship!
--
This is an automated message from the Apache Git Service.
To respond to the message,
divijvaidya commented on code in PR #14992:
URL: https://github.com/apache/kafka/pull/14992#discussion_r1434876077
##
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##
@@ -235,18 +235,31 @@ public Object toConnect(final Schema schema, final
divijvaidya commented on PR #15024:
URL: https://github.com/apache/kafka/pull/15024#issuecomment-1867439333
I have restarted the CI to get a better build status since last one failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac opened a new pull request, #15062:
URL: https://github.com/apache/kafka/pull/15062
I was investigating a build which failed with "exit 1". In the logs of the
broker, I was that the first call to exist was caught. However, a second one
was not. See the logs below. The issue seems to
nizhikov commented on PR #14867:
URL: https://github.com/apache/kafka/pull/14867#issuecomment-1867374109
@mimaison
> This commit cannot be built
Build status is scary, but looks like some tests just failed.
And they not related to my changes.
--
This is an automated
55 matches
Mail list logo