[jira] [Commented] (KAFKA-16059) Fix leak of ExpirationReaper-1-AlterAcls threads in :core:test

2023-12-28 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801106#comment-17801106 ] Arpit Goyal commented on KAFKA-16059: - [~divijvaidya] Which tool or command you are using to

Re: [PR] KAFKA-15760: Disable flaky test testTaskRequestWithOldStartMsGetsUpdated [kafka]

2023-12-28 Thread via GitHub
vamossagar12 commented on PR #14917: URL: https://github.com/apache/kafka/pull/14917#issuecomment-1871795472 I noticed another instance of this test's failure here: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15072/5/tests/ -- This is an automated

Re: [PR] KAFKA-15742 KRaft support in GroupCoordinatorIntegrationTest [kafka]

2023-12-28 Thread via GitHub
wernerdv commented on PR #15086: URL: https://github.com/apache/kafka/pull/15086#issuecomment-1871783161 Hello, @mimaison @jolshan Please, take a look.

[jira] [Assigned] (KAFKA-16059) Fix leak of ExpirationReaper-1-AlterAcls threads in :core:test

2023-12-28 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Goyal reassigned KAFKA-16059: --- Assignee: Arpit Goyal > Fix leak of ExpirationReaper-1-AlterAcls threads in :core:test >

[PR] KAFKA-16025: Fix orphaned locks when rebalancing and store cleanup race on unassigned task directories [kafka]

2023-12-28 Thread via GitHub
sanepal opened a new pull request, #15088: URL: https://github.com/apache/kafka/pull/15088 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[jira] [Comment Edited] (KAFKA-16050) consumer was removed from group,but still can poll data from kafka, data duplicate

2023-12-28 Thread Xin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801087#comment-17801087 ] Xin edited comment on KAFKA-16050 at 12/29/23 3:05 AM: --- Finally Ifound the reason

[jira] [Commented] (KAFKA-16050) consumer was removed from group,but still can poll data from kafka, data duplicate

2023-12-28 Thread Xin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801087#comment-17801087 ] Xin commented on KAFKA-16050: - Finally Ifound the rreson consumer Rejoin operation was delay for a long

[jira] [Resolved] (KAFKA-14127) KIP-858: Handle JBOD broker disk failure in KRaft

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14127. -- Resolution: Fixed > KIP-858: Handle JBOD broker disk failure in KRaft >

[jira] [Updated] (KAFKA-15955) Migrating ZK brokers send dir assignments

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15955: - Parent: KAFKA-16061 Issue Type: Sub-task (was: Bug) > Migrating ZK brokers send dir

[jira] [Updated] (KAFKA-15955) Migrating ZK brokers send dir assignments

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15955: - Parent: (was: KAFKA-14127) Issue Type: Bug (was: Sub-task) > Migrating ZK brokers

[jira] [Commented] (KAFKA-15650) Data-loss on leader shutdown right after partition creation?

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801078#comment-17801078 ] Colin McCabe commented on KAFKA-15650: -- Based on our follow-up discussions, this is not an issue

[jira] [Resolved] (KAFKA-15650) Data-loss on leader shutdown right after partition creation?

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-15650. -- Resolution: Not A Problem > Data-loss on leader shutdown right after partition creation? >

[jira] [Updated] (KAFKA-15649) Handle directory failure timeout

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15649: - Parent: KAFKA-16061 Issue Type: Sub-task (was: Bug) > Handle directory failure timeout

[jira] [Updated] (KAFKA-15367) Test KRaft non-JBOD -> JBOD migration

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15367: - Parent: KAFKA-16061 Issue Type: Sub-task (was: Bug) > Test KRaft non-JBOD -> JBOD

[jira] [Updated] (KAFKA-15649) Handle directory failure timeout

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15649: - Parent: (was: KAFKA-14127) Issue Type: Bug (was: Sub-task) > Handle directory

[jira] [Updated] (KAFKA-15368) Test ZK JBOD to KRaft migration

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15368: - Parent: KAFKA-16061 Issue Type: Sub-task (was: Bug) > Test ZK JBOD to KRaft migration

[jira] [Updated] (KAFKA-15368) Test ZK JBOD to KRaft migration

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15368: - Parent: (was: KAFKA-14127) Issue Type: Bug (was: Sub-task) > Test ZK JBOD to KRaft

[jira] [Updated] (KAFKA-15367) Test KRaft non-JBOD -> JBOD migration

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15367: - Parent: (was: KAFKA-14127) Issue Type: Bug (was: Sub-task) > Test KRaft non-JBOD

[jira] [Commented] (KAFKA-14127) KIP-858: Handle JBOD broker disk failure in KRaft

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801077#comment-17801077 ] Colin McCabe commented on KAFKA-14127: -- JBOD is a feature that is in 3.7, so the fix version needs

[jira] [Updated] (KAFKA-14127) KIP-858: Handle JBOD broker disk failure in KRaft

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-14127: - Fix Version/s: 3.7.0 (was: 3.8.0) > KIP-858: Handle JBOD broker disk

[jira] [Updated] (KAFKA-15359) log.dir.failure.timeout.ms configuration

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15359: - Parent: (was: KAFKA-14127) Issue Type: Improvement (was: Sub-task) >

[jira] [Updated] (KAFKA-15359) Support log.dir.failure.timeout.ms configuration for JBOD

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15359: - Summary: Support log.dir.failure.timeout.ms configuration for JBOD (was:

[jira] [Updated] (KAFKA-16061) KRaft JBOD follow-ups and improvements

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16061: - Summary: KRaft JBOD follow-ups and improvements (was: JBOD follow-ups) > KRaft JBOD follow-ups

[jira] [Updated] (KAFKA-15359) log.dir.failure.timeout.ms configuration

2023-12-28 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15359: - Parent: KAFKA-16061 Issue Type: Sub-task (was: Improvement) >

[jira] [Created] (KAFKA-16061) JBOD follow-ups

2023-12-28 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-16061: Summary: JBOD follow-ups Key: KAFKA-16061 URL: https://issues.apache.org/jira/browse/KAFKA-16061 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-16060) Some questions about tiered storage capabilities

2023-12-28 Thread Jianbin Chen (Jira)
Jianbin Chen created KAFKA-16060: Summary: Some questions about tiered storage capabilities Key: KAFKA-16060 URL: https://issues.apache.org/jira/browse/KAFKA-16060 Project: Kafka Issue Type:

Re: [PR] Duplicate method; The QuotaUtils one is used. [kafka]

2023-12-28 Thread via GitHub
jolshan commented on PR #15066: URL: https://github.com/apache/kafka/pull/15066#issuecomment-1871633221 Given the nature of the change, I merged this as a MINOR commit. But if you plan to contribute more in the future, please consider filing a JIRA ticket and using the name of the ticket

Re: [PR] Duplicate method; The QuotaUtils one is used. [kafka]

2023-12-28 Thread via GitHub
jolshan merged PR #15066: URL: https://github.com/apache/kafka/pull/15066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Duplicate method; The QuotaUtils one is used. [kafka]

2023-12-28 Thread via GitHub
jolshan commented on PR #15066: URL: https://github.com/apache/kafka/pull/15066#issuecomment-1871632309 Hey @afshing -- unfortunately fully green kafka builds are not super common. But we are working on it! Given your change, I think we are ok to merge. -- This is an automated message

[PR] KAFKA-15987: Refactor ReplicaManager code for transaction verification [kafka]

2023-12-28 Thread via GitHub
jolshan opened a new pull request, #15087: URL: https://github.com/apache/kafka/pull/15087 I originally did some refactors in https://github.com/apache/kafka/pull/14774, but we decided to keep the changes minimal since the ticket was a blocker. Here are those refactors: * Removed

[jira] [Updated] (KAFKA-16025) Streams StateDirectory has orphaned locks after rebalancing, blocking future rebalancing

2023-12-28 Thread Sabit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sabit updated KAFKA-16025: -- Description: Hello,   We are encountering an issue where during rebalancing, we see streams threads on one

[jira] (KAFKA-16025) Streams StateDirectory has orphaned locks after rebalancing, blocking future rebalancing

2023-12-28 Thread Sabit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16025 ] Sabit deleted comment on KAFKA-16025: --- was (Author: JIRAUSER303392): I think this bug can occur when rebalancing is triggered in the middle of the cleanup thread running due to multiple calls to

[jira] [Comment Edited] (KAFKA-15742) KRaft support in GroupCoordinatorIntegrationTest

2023-12-28 Thread Dmitry (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801058#comment-17801058 ] Dmitry edited comment on KAFKA-15742 at 12/28/23 10:07 PM: --- Hello, can you

[jira] [Comment Edited] (KAFKA-15742) KRaft support in GroupCoordinatorIntegrationTest

2023-12-28 Thread Dmitry (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801058#comment-17801058 ] Dmitry edited comment on KAFKA-15742 at 12/28/23 10:07 PM: --- Hello, can you

[PR] KAFKA-15742 KRaft support in GroupCoordinatorIntegrationTest [kafka]

2023-12-28 Thread via GitHub
wernerdv opened a new pull request, #15086: URL: https://github.com/apache/kafka/pull/15086 updated GroupCoordinatorIntegrationTest to support KRaft ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[jira] [Commented] (KAFKA-15742) KRaft support in GroupCoordinatorIntegrationTest

2023-12-28 Thread Dmitry (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801058#comment-17801058 ] Dmitry commented on KAFKA-15742: Hello, can you assign it to me? > KRaft support in

Re: [PR] KAFKA-16015: Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
sciclon2 commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871500486 thanks for your collaboration @divijvaidya I really appreciate it, all sorted!!! `➜ kafka git:(KAFKA-16015-bugfix) ✗ ./gradlew tools:test --tests

[PR] init commit - no config [kafka]

2023-12-28 Thread via GitHub
afshing opened a new pull request, #15085: URL: https://github.com/apache/kafka/pull/15085 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] [MINOR] More image replay test cases [kafka]

2023-12-28 Thread via GitHub
ahuang98 commented on PR #14206: URL: https://github.com/apache/kafka/pull/14206#issuecomment-1871434311 Latest test run has 14 "new failing" which are all timeout related/unrelated - https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14206/17/tests --

[jira] [Assigned] (KAFKA-16034) AsyncKafkaConsumer will get Invalid Request error when trying to rejoin on fenced/unknown member Id

2023-12-28 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-16034: -- Assignee: Phuc Hong Tran > AsyncKafkaConsumer will get Invalid Request error when

Re: [PR] Duplicate method; The QuotaUtils one is used. [kafka]

2023-12-28 Thread via GitHub
afshing commented on PR #15066: URL: https://github.com/apache/kafka/pull/15066#issuecomment-1871415820 @jolshan it seems like the build for JDK 11 passed, and the other three are failed by some unrelated (flaky?) tests. Should I keep trying the CI pipeline? -- This is an automated

[jira] [Commented] (KAFKA-16059) Fix leak of ExpirationReaper-1-AlterAcls threads in :core:test

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801035#comment-17801035 ] Divij Vaidya commented on KAFKA-16059: -- This might have been fixed by

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801034#comment-17801034 ] Divij Vaidya commented on KAFKA-16052: -- The fix in the PR for these improved but did not completely

Re: [PR] KAFKA-16047: Leverage the fenceProducers timeout in the InitProducerId [kafka]

2023-12-28 Thread via GitHub
akaltsikis commented on code in PR #15078: URL: https://github.com/apache/kafka/pull/15078#discussion_r1437810684 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/FenceProducersHandler.java: ## @@ -82,9 +86,10 @@ InitProducerIdRequest.Builder

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-28 at 18.44.19.png > OOM in Kafka test suite >

[jira] [Created] (KAFKA-16059) Fix trhead l

2023-12-28 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-16059: Summary: Fix trhead l Key: KAFKA-16059 URL: https://issues.apache.org/jira/browse/KAFKA-16059 Project: Kafka Issue Type: Sub-task Reporter:

[jira] [Updated] (KAFKA-16059) Fix leak of ExpirationReaper-1-AlterAcls threads in :core:test

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16059: - Summary: Fix leak of ExpirationReaper-1-AlterAcls threads in :core:test (was: Fix trhead l) >

[jira] [Updated] (KAFKA-16058) Fix leaked in ControllerApiTest

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16058: - Fix Version/s: 3.7.0 3.8.0 > Fix leaked in ControllerApiTest >

Re: [PR] Duplicate method; The QuotaUtils one is used. [kafka]

2023-12-28 Thread via GitHub
jolshan commented on PR #15066: URL: https://github.com/apache/kafka/pull/15066#issuecomment-1871351338 Hey @afshing -- the place to view the test results is on the tests tab. The default page really only tells you if the workflow is done. -- see

Re: [PR] WIP -- clear mocks in AbstractCoordinatorConcurrencyTest [kafka]

2023-12-28 Thread via GitHub
jolshan closed pull request #15081: WIP -- clear mocks in AbstractCoordinatorConcurrencyTest URL: https://github.com/apache/kafka/pull/15081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16052: create a real dummy replicaManager instance to save memory [kafka]

2023-12-28 Thread via GitHub
jolshan commented on PR #15083: URL: https://github.com/apache/kafka/pull/15083#issuecomment-1871343921 I had also started an attempt of this and was trying to get the produce purgatory to be hooked up as expected. I also had some issues with passing nulls into the optional arguments.

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801029#comment-17801029 ] Justine Olshan commented on KAFKA-16052: Hey Luke – thanks for your help with the non-mocked

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
ijuma commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871302733 It's usually more robust to automatically handle clean-up during tearDown by instrumenting the create method so that it keeps track of all creations. -- This is an automated message from

Re: [PR] KAFKA-16053: Fix leaks of KDC server in tests [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15079: URL: https://github.com/apache/kafka/pull/15079#issuecomment-1871286492 backported to 3.6 and 3.7 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871285636 backported to 3.6 and 3.7 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
divijvaidya merged PR #15084: URL: https://github.com/apache/kafka/pull/15084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16058: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871281383 There are other test failures but `ControllerAPIsTest` is successful.

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871243698 Hey @sciclon2 , try something like this ``` @ClusterTest public void testAdminConfigCustomTimeouts() throws Exception { int defaultApiTimeoutMs = 24;

Re: [PR] Duplicate method; The QuotaUtils one is used. [kafka]

2023-12-28 Thread via GitHub
afshing commented on PR #15066: URL: https://github.com/apache/kafka/pull/15066#issuecomment-1871221164 > @afshing -- can you link the commit that moved the code in your description? Oh! I missed that link. Added now. @jolshan do you know why the CI is failing? it seems all the

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on code in PR #15030: URL: https://github.com/apache/kafka/pull/15030#discussion_r1437697827 ## tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java: ## @@ -99,8 +99,12 @@ static void run(Duration timeoutMs, String... args) throws

Re: [PR] KAFKA-16052: create a real dummy replicaManager instance to save memory [kafka]

2023-12-28 Thread via GitHub
divijvaidya commented on PR #15083: URL: https://github.com/apache/kafka/pull/15083#issuecomment-1871218253 Hey @showuon There are multiple other things that need to be corrected with this test, such as closing metrics, ensuring that producePurgatory is being closed etc. Also, the

Re: [PR] [KAFKA-16015] Fix custom timeouts overwritten by defaults [kafka]

2023-12-28 Thread via GitHub
sciclon2 commented on PR #15030: URL: https://github.com/apache/kafka/pull/15030#issuecomment-1871195223 hey @divijvaidya if you dont mind I need a bit of help ofr the test, I have created this: `@ClusterTest public void testAdminConfigCustomTimeouts() throws Exception {

[jira] [Commented] (KAFKA-15147) Measure pending and outstanding Remote Segment operations

2023-12-28 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801000#comment-17801000 ] Stanislav Kozlovski commented on KAFKA-15147: - [~christo_lolov] sounds good. The repo is: -

[jira] [Created] (KAFKA-16058) Fix leaked in ControllerApiTest

2023-12-28 Thread Luke Chen (Jira)
Luke Chen created KAFKA-16058: - Summary: Fix leaked in ControllerApiTest Key: KAFKA-16058 URL: https://issues.apache.org/jira/browse/KAFKA-16058 Project: Kafka Issue Type: Sub-task

[jira] [Comment Edited] (KAFKA-15558) Determine if Timer should be used elsewhere in PrototypeAsyncConsumer.updateFetchPositions()

2023-12-28 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800672#comment-17800672 ] Phuc Hong Tran edited comment on KAFKA-15558 at 12/28/23 12:32 PM: ---

[jira] [Assigned] (KAFKA-15867) Should ConsumerNetworkThread wrap the exception and notify the polling thread?

2023-12-28 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-15867: -- Assignee: Phuc Hong Tran > Should ConsumerNetworkThread wrap the exception and

[jira] [Resolved] (KAFKA-16011) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose

2023-12-28 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran resolved KAFKA-16011. Resolution: Fixed > Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose >

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800978#comment-17800978 ] Luke Chen edited comment on KAFKA-16052 at 12/28/23 12:13 PM: -- Sharing my

[jira] [Commented] (KAFKA-16011) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose

2023-12-28 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800979#comment-17800979 ] Phuc Hong Tran commented on KAFKA-16011: I think [~pnee] already fixed this in

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800978#comment-17800978 ] Luke Chen commented on KAFKA-16052: --- Sharing my way to detect the leaking threads:

Re: [PR] KAFKA-16053: Fix leaks of KDC server in tests [kafka]

2023-12-28 Thread via GitHub
showuon commented on PR #15079: URL: https://github.com/apache/kafka/pull/15079#issuecomment-1871098961 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
showuon commented on PR #15084: URL: https://github.com/apache/kafka/pull/15084#issuecomment-1871096448 @divijvaidya @jolshan , please take a look. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] MINOR: close controllerApi instance to avoid thread leaking [kafka]

2023-12-28 Thread via GitHub
showuon opened a new pull request, #15084: URL: https://github.com/apache/kafka/pull/15084 The `controllerApi` will create some resources, including the reaper threads, but in `ControllerApisTest`, we created it on many test cases, but didn't close it. This PR doesn't change

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800967#comment-17800967 ] Luke Chen commented on KAFKA-16052: --- Great! Thanks! > OOM in Kafka test suite >

[jira] [Comment Edited] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800960#comment-17800960 ] Divij Vaidya edited comment on KAFKA-16052 at 12/28/23 10:27 AM: - I have

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-28 at 11.26.09.png > OOM in Kafka test suite >

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16052: - Attachment: Screenshot 2023-12-28 at 11.26.03.png > OOM in Kafka test suite >

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800960#comment-17800960 ] Divij Vaidya commented on KAFKA-16052: -- I can verify [~showuon] that using actual ReplicaManager as

[jira] [Updated] (KAFKA-16053) Fix leaked Default DirectoryService

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16053: - Fix Version/s: 3.8.0 > Fix leaked Default DirectoryService >

[jira] [Updated] (KAFKA-16053) Fix leaked Default DirectoryService

2023-12-28 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16053: - Fix Version/s: 3.7.0 3.6.2 > Fix leaked Default DirectoryService >

[jira] [Created] (KAFKA-16057) Admin Client connections.max.idle.ms should be 9 minutes by default

2023-12-28 Thread Marcin Kuthan (Jira)
Marcin Kuthan created KAFKA-16057: - Summary: Admin Client connections.max.idle.ms should be 9 minutes by default Key: KAFKA-16057 URL: https://issues.apache.org/jira/browse/KAFKA-16057 Project: Kafka

Re: [PR] KAFKA-16053: Fix leaks of KDC server in tests [kafka]

2023-12-28 Thread via GitHub
divijvaidya merged PR #15079: URL: https://github.com/apache/kafka/pull/15079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16016: Add docker wrapper in core and remove docker utility script [kafka]

2023-12-28 Thread via GitHub
VedarthConfluent commented on code in PR #15048: URL: https://github.com/apache/kafka/pull/15048#discussion_r1437520478 ## docker/jvm/launch: ## @@ -28,25 +27,25 @@ fi # the default is to pick the first IP (or network). export

Re: [PR] KAFKA-15388: Handling remote segment read in case of log compaction [kafka]

2023-12-28 Thread via GitHub
iit2009060 commented on PR #15060: URL: https://github.com/apache/kafka/pull/15060#issuecomment-1870969987 @clolov @divijvaidya Do you have any additional review comments ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800948#comment-17800948 ] Luke Chen commented on KAFKA-16052: --- OK, I've checked the output before my change, there are also many

[PR] MINOR: create a real dummy replicaManager instance to save memory [kafka]

2023-12-28 Thread via GitHub
showuon opened a new pull request, #15083: URL: https://github.com/apache/kafka/pull/15083 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Commented] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800942#comment-17800942 ] Luke Chen commented on KAFKA-16052: --- I'm trying to fix it by creating a "real" replicaManager, instead

[jira] [Updated] (KAFKA-16052) OOM in Kafka test suite

2023-12-28 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16052: -- Attachment: newRM.patch > OOM in Kafka test suite > --- > > Key: