Re: [PR] KAFKA-15876: Introduce RemoteStorageNotReadyException retryable error [kafka]

2024-01-11 Thread via GitHub
showuon commented on code in PR #14822: URL: https://github.com/apache/kafka/pull/14822#discussion_r1449931227 ## clients/src/main/java/org/apache/kafka/common/errors/RemoteStorageNotReadyException.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-11 Thread via GitHub
artemlivshits commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1449897783 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] MINOR: Add test case for follower fetch [kafka]

2024-01-11 Thread via GitHub
showuon commented on PR #14212: URL: https://github.com/apache/kafka/pull/14212#issuecomment-1888514023 @divijvaidya , do you want to have another look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] [KAFKA-15749] Adding support for Kraft in test testClusterIdPresent [kafka]

2024-01-11 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #15181: URL: https://github.com/apache/kafka/pull/15181 Adding the KRaft test for testClusterIdPresent() in KafkaMetricReporterClusterIdTest class Ref: [KAFKA-15749](https://issues.apache.org/jira/browse/KAFKA-15749?jql=labels%20%3D%20kraft-test)

[jira] [Commented] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2024-01-11 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805883#comment-17805883 ] Phuc Hong Tran commented on KAFKA-15561: I figured those out, so they were auto-

[jira] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2024-01-11 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561 ] Phuc Hong Tran deleted comment on KAFKA-15561: was (Author: JIRAUSER301295): [~lianetm], look like the problem is on my local machine. > Client support for new SubscriptionPattern based

[jira] [Commented] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2024-01-11 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805880#comment-17805880 ] Phuc Hong Tran commented on KAFKA-15561: [~lianetm], look like the problem is on

Re: [PR] KAFKA-16085: Add metric value consolidated for topics on a broker for tiered storage. [kafka]

2024-01-11 Thread via GitHub
showuon commented on PR #15133: URL: https://github.com/apache/kafka/pull/15133#issuecomment-1888394290 @satishd , call for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINOR: Add isRemoteLogEnabled parameter to the Log Loader Javadoc [kafka]

2024-01-11 Thread via GitHub
showuon commented on PR #15179: URL: https://github.com/apache/kafka/pull/15179#issuecomment-1888393499 This is just a javadoc update. I'll merge it after the CI build completes if no other comments. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] MINOR: Enable kraft test in kafka.api [kafka]

2024-01-11 Thread via GitHub
dengziming merged PR #14595: URL: https://github.com/apache/kafka/pull/14595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] MINOR: Optimization of equals methods on implementations of Commands.Handler in shell.command package [kafka]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #14018: URL: https://github.com/apache/kafka/pull/14018#issuecomment-1888380284 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] MINOR: Add test case for follower fetch [kafka]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #14212: URL: https://github.com/apache/kafka/pull/14212#issuecomment-1888380213 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2024-01-11 Thread via GitHub
github-actions[bot] commented on PR #14491: URL: https://github.com/apache/kafka/pull/14491#issuecomment-1888380144 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Commented] (KAFKA-16095) Update list group state type filter to include the states for the new consumer group type

2024-01-11 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805868#comment-17805868 ] Lan Ding commented on KAFKA-16095: -- [~rreddy22] I think the flag "–type" should be adde

Re: [PR] MINOR: Log a warning when connectors generate greater than tasks.max task configs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on PR #14694: URL: https://github.com/apache/kafka/pull/14694#issuecomment-1888248086 @C0urante Is this superseded by #15180 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (KAFKA-8115) Flaky Test CoordinatorTest#testTaskRequestWithOldStartMsGetsUpdated

2024-01-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805849#comment-17805849 ] Greg Harris commented on KAFKA-8115: We doubled the timeout for this test in KAFKA-15

[jira] [Resolved] (KAFKA-15760) org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated is flaky

2024-01-11 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15760. - Fix Version/s: 3.8.0 Assignee: David Mao Resolution: Fixed > org.apache.kafka.tr

Re: [PR] KAFKA-15760: Disable flaky test testTaskRequestWithOldStartMsGetsUpdated [kafka]

2024-01-11 Thread via GitHub
gharris1727 merged PR #14917: URL: https://github.com/apache/kafka/pull/14917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-15760: Disable flaky test testTaskRequestWithOldStartMsGetsUpdated [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on PR #14917: URL: https://github.com/apache/kafka/pull/14917#issuecomment-1888236729 Test failures appear unrelated, the test which is being changed has no failures, and this is just a timeout increase. Merging. -- This is an automated message from the Apache Git Se

Re: [PR] KAFKA-16072: JUnit 5 extension to detect thread leak [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on PR #15101: URL: https://github.com/apache/kafka/pull/15101#issuecomment-1888225488 > One reason that some stream tests are failing because they use the same server for the duration of the entire test suite and don't create a server per test, for example MetricsInteg

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1449550586 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -620,6 +650,11 @@ private boolean startTask( try (LoaderSwap loa

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449513344 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -168,11 +102,13 @@ public String toString(boolean includeMess

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449513344 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -168,11 +102,13 @@ public String toString(boolean includeMess

[jira] [Updated] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16116: -- Fix Version/s: 3.8.0 > AsyncKafkaConsumer: Add missing rebalance metrics > ---

[jira] [Updated] (KAFKA-16115) AsyncKafkaConsumer: Add missing heartbeat metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16115: -- Component/s: clients > AsyncKafkaConsumer: Add missing heartbeat metrics > ---

[jira] [Updated] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16116: -- Component/s: clients > AsyncKafkaConsumer: Add missing rebalance metrics > ---

[jira] [Updated] (KAFKA-16115) AsyncKafkaConsumer: Add missing heartbeat metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16115: -- Labels: consumer-threading-refactor (was: ) > AsyncKafkaConsumer: Add missing heartbeat metrics > ---

[jira] [Commented] (KAFKA-16095) Update list group state type filter to include the states for the new consumer group type

2024-01-11 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805828#comment-17805828 ] Ritika Reddy commented on KAFKA-16095: -- [~isding_l] When would you be taking up thi

[jira] [Updated] (KAFKA-16115) AsyncKafkaConsumer: Add missing heartbeat metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16115: -- Fix Version/s: 3.8.0 > AsyncKafkaConsumer: Add missing heartbeat metrics > ---

[jira] [Created] (KAFKA-16117) Add Integration test for checking if the correct assignor is chosen

2024-01-11 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-16117: Summary: Add Integration test for checking if the correct assignor is chosen Key: KAFKA-16117 URL: https://issues.apache.org/jira/browse/KAFKA-16117 Project: Kafka

[jira] [Updated] (KAFKA-16022) AsyncKafkaConsumer sometimes complains “No current assignment for partition {}”

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16022: -- Summary: AsyncKafkaConsumer sometimes complains “No current assignment for partition {}” (was: AsyncK

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-11 Thread via GitHub
apoorvmittal10 commented on PR #15148: URL: https://github.com/apache/kafka/pull/15148#issuecomment-1888052029 @mjsax Can you please take a re-look, I have addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Updated] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-01-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16116: --- Labels: consumer-threading-refactor (was: ) > AsyncKafkaConsumer: Add missing rebalance metrics > -

[jira] [Updated] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-01-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16116: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Improvement) > AsyncKafkaConsumer: Add missi

[jira] [Updated] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-01-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16116: --- Component/s: consumer metrics > AsyncKafkaConsumer: Add missing rebalance metrics >

[jira] [Created] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-01-11 Thread Philip Nee (Jira)
Philip Nee created KAFKA-16116: -- Summary: AsyncKafkaConsumer: Add missing rebalance metrics Key: KAFKA-16116 URL: https://issues.apache.org/jira/browse/KAFKA-16116 Project: Kafka Issue Type: Imp

[jira] [Created] (KAFKA-16115) AsyncKafkaConsumer: Add missing heartbeat metrics

2024-01-11 Thread Philip Nee (Jira)
Philip Nee created KAFKA-16115: -- Summary: AsyncKafkaConsumer: Add missing heartbeat metrics Key: KAFKA-16115 URL: https://issues.apache.org/jira/browse/KAFKA-16115 Project: Kafka Issue Type: Imp

[jira] [Updated] (KAFKA-16115) AsyncKafkaConsumer: Add missing heartbeat metrics

2024-01-11 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16115: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Improvement) > AsyncKafkaConsumer: Add missi

[jira] [Commented] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2024-01-11 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805806#comment-17805806 ] Phuc Hong Tran commented on KAFKA-15561: [~lianetm] are the classes that impleme

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449403859 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -303,48 +303,14 @@ public String toString() {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449403859 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -303,48 +303,14 @@ public String toString() {

[jira] [Updated] (KAFKA-16089) Kafka Streams still leaking memory

2024-01-11 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-16089: --- Fix Version/s: 3.8.0 > Kafka Streams still leaking memory >

[jira] [Commented] (KAFKA-16089) Kafka Streams still leaking memory

2024-01-11 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805801#comment-17805801 ] A. Sophie Blee-Goldman commented on KAFKA-16089: Yeah, nice investigatio

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-11 Thread via GitHub
philipnee commented on PR #15000: URL: https://github.com/apache/kafka/pull/15000#issuecomment-1887951845 hey @lucasbru - i assume invoker queue here you meant by `OffsetCommitCallbackInvoker`. It is not shared with the background thread. There are two invokers used by the async consumer,

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449351768 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/DeadLetterQueueReporter.java: ## @@ -121,20 +121,22 @@ public static DeadLetterQueueReporte

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449349792 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/DeadLetterQueueReporter.java: ## @@ -121,20 +121,22 @@ public static DeadLetterQueueReporte

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449347346 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -236,7 +237,7 @@ protected V execAndHandleError(Ope

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449326220 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -80,59 +83,57 @@ public class RetryWithToleranceOper

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449313479 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -17,82 +17,36 @@ package org.apache.kafka.connect.runtime.er

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-11 Thread via GitHub
C0urante commented on PR #15180: URL: https://github.com/apache/kafka/pull/15180#issuecomment-1887808692 @gharris1727 @yashmayya @mimaison would any of you mind taking a look when you have a moment? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2024-01-11 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805779#comment-17805779 ] Lianet Magrans commented on KAFKA-15561: Hey [~phuctran], this ticket is only fo

[jira] [Updated] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15475: -- Priority: Critical (was: Minor) > Timeout request might retry forever even if the user API times out

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449271258 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -143,7 +144,7 @@ public synchronized Future executeFail

[jira] [Updated] (KAFKA-15320) Document event queueing patterns

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15320: -- Priority: Minor (was: Major) > Document event queueing patterns > >

[jira] [Updated] (KAFKA-15283) Client support for OffsetFetch and OffsetCommit with topic ID

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15283: -- Priority: Minor (was: Major) > Client support for OffsetFetch and OffsetCommit with topic ID > --

[jira] [Updated] (KAFKA-15173) Consumer event queues should be bounded

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15173: -- Priority: Minor (was: Major) > Consumer event queues should be bounded >

[jira] [Assigned] (KAFKA-16104) Enable additional PlaintextConsumerTest tests for new consumer

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16104: - Assignee: Kirk True > Enable additional PlaintextConsumerTest tests for new consumer >

[jira] [Assigned] (KAFKA-16107) Ensure consumer does not start fetching from added partitions until onPartitionsAssigned completes

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16107: - Assignee: Lianet Magrans > Ensure consumer does not start fetching from added partitions until

[jira] [Assigned] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16010: - Assignee: Kirk True > Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling >

[jira] [Assigned] (KAFKA-16009) Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16009: - Assignee: Kirk True > Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation > --

[jira] [Assigned] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16008: - Assignee: Kirk True > Fix PlaintextConsumerTest.testMaxPollIntervalMs > ---

[jira] [Assigned] (KAFKA-16023) PlaintextConsumerTest needs to wait for reconciliation to complete before proceeding

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16023: - Assignee: Kirk True > PlaintextConsumerTest needs to wait for reconciliation to complete before

[jira] [Assigned] (KAFKA-16100) Consistent handling of timeouts and responses for new consumer ApplicationEvents

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16100: - Assignee: Kirk True > Consistent handling of timeouts and responses for new consumer > Applica

[jira] [Assigned] (KAFKA-16019) Some of the tests in PlaintextConsumer can't seem to deterministically invoke and verify the consumer callback

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16019: - Assignee: Kirk True > Some of the tests in PlaintextConsumer can't seem to deterministically in

[jira] [Assigned] (KAFKA-16004) Review new consumer inflight offset commit logic

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16004: - Assignee: Lianet Magrans > Review new consumer inflight offset commit logic > -

[jira] [Assigned] (KAFKA-16001) Migrate ConsumerNetworkThreadTest away from ConsumerTestBuilder

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16001: - Assignee: Kirk True > Migrate ConsumerNetworkThreadTest away from ConsumerTestBuilder > ---

[jira] [Assigned] (KAFKA-15993) Enable max poll integration tests that depend on callback invocation

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15993: - Assignee: Kirk True > Enable max poll integration tests that depend on callback invocation > --

[jira] [Assigned] (KAFKA-15999) Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15999: - Assignee: Kirk True > Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder > -

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-11 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1449180005 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -80,59 +83,57 @@ public class RetryWithToleranceOperato

[jira] [Assigned] (KAFKA-15843) Review consumer onPartitionsAssigned called with empty partitions

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15843: - Assignee: Lianet Magrans > Review consumer onPartitionsAssigned called with empty partitions >

[jira] [Assigned] (KAFKA-15847) Consider partial metadata requests for client reconciliation

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15847: - Assignee: Lianet Magrans > Consider partial metadata requests for client reconciliation > -

[jira] [Assigned] (KAFKA-15652) Add tests to verify OffsetFetcherUtils.getOffsetResetTimestamp()

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15652: - Assignee: Philip Nee > Add tests to verify OffsetFetcherUtils.getOffsetResetTimestamp() > -

[jira] [Assigned] (KAFKA-15691) Add new system tests to use new consumer

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15691: - Assignee: Kirk True > Add new system tests to use new consumer > --

[jira] [Assigned] (KAFKA-15638) Investigate ConsumerNetworkThreadTest's testPollResultTimer

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15638: - Assignee: Kirk True (was: Philip Nee) > Investigate ConsumerNetworkThreadTest's testPollResult

[jira] [Assigned] (KAFKA-15551) Evaluate conditions for short circuiting consumer API calls

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15551: - Assignee: Lianet Magrans (was: Philip Nee) > Evaluate conditions for short circuiting consumer

[jira] [Assigned] (KAFKA-15639) Investigate ConsumerNetworkThreadTest's testResetPositionsProcessFailureIsIgnored

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15639: - Assignee: Kirk True (was: Philip Nee) > Investigate ConsumerNetworkThreadTest's > testResetPo

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-11 Thread via GitHub
dajac commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1449270020 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1963,6 +2080,75 @@ public void testFetchAllOffsetsAtDifferen

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-11 Thread via GitHub
jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1449268767 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1963,6 +2080,75 @@ public void testFetchAllOffsetsAtDiffer

[jira] [Assigned] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15475: - Assignee: Kirk True (was: Philip Nee) > Timeout request might retry forever even if the user A

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-11 Thread via GitHub
dajac commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1449266480 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1963,6 +2080,75 @@ public void testFetchAllOffsetsAtDifferen

[jira] [Assigned] (KAFKA-16110) Implement consumer performance tests

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16110: - Assignee: Philip Nee (was: Kirk True) > Implement consumer performance tests > ---

[jira] [Assigned] (KAFKA-15283) Client support for OffsetFetch and OffsetCommit with topic ID

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15283: - Assignee: Lianet Magrans > Client support for OffsetFetch and OffsetCommit with topic ID >

[jira] [Assigned] (KAFKA-15305) The background thread should try to process the remaining task until the shutdown timer is expired

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15305: - Assignee: Kirk True (was: Philip Nee) > The background thread should try to process the remain

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-11 Thread via GitHub
AndrewJSchofield commented on PR #15000: URL: https://github.com/apache/kafka/pull/15000#issuecomment-1887735105 I agree with @lianetm that the second option seems best. The invoker mechanism already exists for `commitAsync()` and submitting to the invoker is already using a thread-safe obj

Re: [PR] KAFKA-16085: Add metric value consolidated for topics on a broker for tiered storage. [kafka]

2024-01-11 Thread via GitHub
kamalcph commented on code in PR #15133: URL: https://github.com/apache/kafka/pull/15133#discussion_r1449241531 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -473,6 +498,11 @@ class BrokerTopicMetrics(name: Option[String], configOpt: java.util.Optional[Ka

[jira] [Updated] (KAFKA-16113) AsyncKafkaConsumer: Add missing offset commit metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16113: -- Fix Version/s: 3.8.0 > AsyncKafkaConsumer: Add missing offset commit metrics > ---

[jira] [Updated] (KAFKA-16113) AsyncKafkaConsumer: Add missing offset commit metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16113: -- Labels: consumer-threading-refactor (was: ) > AsyncKafkaConsumer: Add missing offset commit metrics >

[jira] [Updated] (KAFKA-16113) AsyncKafkaConsumer: Add missing offset commit metrics

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16113: -- Component/s: clients metrics > AsyncKafkaConsumer: Add missing offset commit metrics

Re: [PR] KAFKA-14505; [5/N] Add `UNSTABLE_OFFSET_COMMIT` error support [kafka]

2024-01-11 Thread via GitHub
jolshan commented on code in PR #15155: URL: https://github.com/apache/kafka/pull/15155#discussion_r1449238660 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1963,6 +2080,75 @@ public void testFetchAllOffsetsAtDiffer

[jira] [Updated] (KAFKA-16111) Implement tests for tricky rebalance callback scenarios

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16111: -- Summary: Implement tests for tricky rebalance callback scenarios (was: Implement tests for tricky reb

Re: [PR] KAFKA-15876: Introduce RemoteStorageNotReadyException retryable error [kafka]

2024-01-11 Thread via GitHub
kamalcph commented on code in PR #14822: URL: https://github.com/apache/kafka/pull/14822#discussion_r1449228856 ## clients/src/main/java/org/apache/kafka/common/errors/RemoteStorageNotReadyException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Updated] (KAFKA-16019) Some of the tests in PlaintextConsumer can't seem to deterministically invoke and verify the consumer callback

2024-01-11 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16019: -- Summary: Some of the tests in PlaintextConsumer can't seem to deterministically invoke and verify the

Re: [PR] KAFKA-15876: Introduce RemoteStorageNotReadyException retryable error [kafka]

2024-01-11 Thread via GitHub
kamalcph commented on code in PR #14822: URL: https://github.com/apache/kafka/pull/14822#discussion_r1449218105 ## clients/src/main/java/org/apache/kafka/common/errors/RemoteStorageNotReadyException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-15942: Implement ConsumerInterceptors in the async consumer [kafka]

2024-01-11 Thread via GitHub
lianetm commented on PR #15000: URL: https://github.com/apache/kafka/pull/15000#issuecomment-1887680132 My take would be option 2, using the invoker in the background thread and submitting a task for the interceptor. Seems like a clean way, re-using the mechanism of the invoker already in p

Re: [PR] KAFKA-14683 Migrate #testStartPaused to Mockito [kafka]

2024-01-11 Thread via GitHub
hgeraldino commented on PR #14663: URL: https://github.com/apache/kafka/pull/14663#issuecomment-1887674876 > Hi @hgeraldino Thanks for taking on the migration! > > I understand the idea behind your refactor-then-deduplicate strategy, but I think the excessive duplication is making it

[jira] [Commented] (KAFKA-15147) Measure pending and outstanding Remote Segment operations

2024-01-11 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805734#comment-17805734 ] Christo Lolov commented on KAFKA-15147: --- Heya [~fvisconte], a couple of days ago [

Re: [PR] KAFKA-15460: Add group type filter to List Groups API [kafka]

2024-01-11 Thread via GitHub
dajac commented on code in PR #15152: URL: https://github.com/apache/kafka/pull/15152#discussion_r1449170060 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -453,19 +454,31 @@ public Group group(String groupId, long committe

Re: [PR] KAFKA-16089: Fix memory leak in RocksDBStore [kafka]

2024-01-11 Thread via GitHub
lucasbru merged PR #15174: URL: https://github.com/apache/kafka/pull/15174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15351: Ensure log-start-offset not updated to local-log-start-offset when remote storage enabled [kafka]

2024-01-11 Thread via GitHub
kamalcph commented on code in PR #14301: URL: https://github.com/apache/kafka/pull/14301#discussion_r1449147426 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -78,7 +78,8 @@ class LogLoader( recoveryPointCheckpoint: Long, leaderEpochCache: Option[LeaderEpochFileCa

[PR] MINOR: Add isRemoteLogEnabled parameter to the Log Loader Javadoc. [kafka]

2024-01-11 Thread via GitHub
kamalcph opened a new pull request, #15179: URL: https://github.com/apache/kafka/pull/15179 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

  1   2   >