divijvaidya merged PR #15072:
URL: https://github.com/apache/kafka/pull/15072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1887569050
The compilation is successful. This PR doesn't impact any runtime and hence,
tests failing in CI can be ignored.
--
This is an automated message from the Apache Git Service.
To
C0urante opened a new pull request, #15178:
URL: https://github.com/apache/kafka/pull/15178
Currently,
dajac commented on PR #15155:
URL: https://github.com/apache/kafka/pull/15155#issuecomment-188752
@jolshan Thanks for your comments. I have addressed all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
akatona84 commented on code in PR #11982:
URL: https://github.com/apache/kafka/pull/11982#discussion_r1449041296
##
build.gradle:
##
@@ -998,6 +973,9 @@ project(':core') {
if (userEnableTestCoverage) {
scoverage {
scoverageVersion = versions.scoverage
+ if
akatona84 commented on code in PR #11982:
URL: https://github.com/apache/kafka/pull/11982#discussion_r1449041296
##
build.gradle:
##
@@ -998,6 +973,9 @@ project(':core') {
if (userEnableTestCoverage) {
scoverage {
scoverageVersion = versions.scoverage
+ if
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805656#comment-17805656
]
Francois Visconte edited comment on KAFKA-15147 at 1/11/24 3:35 PM:
akatona84 commented on code in PR #11982:
URL: https://github.com/apache/kafka/pull/11982#discussion_r1449038478
##
build.gradle:
##
@@ -799,33 +799,8 @@ def checkstyleConfigProperties(configFileName) {
[importControlFile: "$configFileName"]
}
-// Aggregates all jacoco
mimaison commented on code in PR #15159:
URL: https://github.com/apache/kafka/pull/15159#discussion_r1449038990
##
checkstyle/import-control-core.xml:
##
@@ -49,6 +49,7 @@
+
Review Comment:
Thanks, I'll wait for the CI to run then I'll take another
dajac commented on PR #15176:
URL: https://github.com/apache/kafka/pull/15176#issuecomment-1887429299
@artemlivshits @jolshan Could you please take a look at this one when you
get a chance? Let me know what you think.
--
This is an automated message from the Apache Git Service.
To
nizhikov commented on PR #15159:
URL: https://github.com/apache/kafka/pull/15159#issuecomment-1887427971
Hello @OmniaGM
Can you, please, omit force push to the PR's? :)
This breaks commit history and reviewers (like I am) don't understand what
have changed with force push.
OmniaGM commented on code in PR #15159:
URL: https://github.com/apache/kafka/pull/15159#discussion_r1449032281
##
checkstyle/import-control-core.xml:
##
@@ -49,6 +49,7 @@
+
Review Comment:
removed it now
--
This is an automated message from the
OmniaGM commented on code in PR #15159:
URL: https://github.com/apache/kafka/pull/15159#discussion_r1449031912
##
checkstyle/import-control-core.xml:
##
@@ -49,6 +49,7 @@
+
Review Comment:
you right wit is not needed I think I forgot it while am
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805656#comment-17805656
]
Francois Visconte edited comment on KAFKA-15147 at 1/11/24 3:28 PM:
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805656#comment-17805656
]
Francois Visconte edited comment on KAFKA-15147 at 1/11/24 3:28 PM:
adixitconfluent commented on PR #15171:
URL: https://github.com/apache/kafka/pull/15171#issuecomment-1887418676
As represented by the CLI screenshot, the tests changed are passing. However
the build is failing.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805656#comment-17805656
]
Francois Visconte commented on KAFKA-15147:
---
I tried these new metrics on a test cluster where
akatona84 commented on code in PR #11982:
URL: https://github.com/apache/kafka/pull/11982#discussion_r1449026899
##
build.gradle:
##
@@ -1289,7 +1267,7 @@ project(':metadata') {
}
test {
java {
-srcDirs = ["src/generated/java", "src/test/java"]
+
akatona84 commented on code in PR #11982:
URL: https://github.com/apache/kafka/pull/11982#discussion_r1449020181
##
gradle/dependencies.gradle:
##
@@ -158,7 +158,7 @@ versions += [
// https://github.com/scalameta/scalafmt/releases/tag/v3.1.0.
scalafmt: "3.7.14",
OmniaGM commented on code in PR #15158:
URL: https://github.com/apache/kafka/pull/15158#discussion_r1449013239
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfig.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software
dajac merged PR #15173:
URL: https://github.com/apache/kafka/pull/15173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna opened a new pull request, #15177:
URL: https://github.com/apache/kafka/pull/15177
Kafka Streams checkpoints the wrong offset when a task is closed during
restoration. If under exactly-once processing guarantees a
TaskCorruptedException happens, the affected task is closed dirty,
AyoubOm commented on PR #15162:
URL: https://github.com/apache/kafka/pull/15162#issuecomment-1887255622
@ableegoldman Would you have time to check this ? If so, please let me know
if you think we should describe any other fields here. Thanks :)
--
This is an automated message from the
ijuma commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1448871794
##
core/src/main/scala/kafka/log/LogLoader.scala:
##
@@ -489,16 +488,16 @@ class LogLoader(
*
* @param segmentsToDelete The log segments to schedule for deletion
dajac commented on code in PR #15176:
URL: https://github.com/apache/kafka/pull/15176#discussion_r1448892815
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig,
* @param producerId the
mimaison commented on PR #15147:
URL: https://github.com/apache/kafka/pull/15147#issuecomment-1887174983
@showuon @divijvaidya Can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
divijvaidya commented on code in PR #14822:
URL: https://github.com/apache/kafka/pull/14822#discussion_r1448843600
##
clients/src/main/java/org/apache/kafka/common/errors/RemoteStorageNotReadyException.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac opened a new pull request, #15176:
URL: https://github.com/apache/kafka/pull/15176
This patch removes the extra hop via the request thread when the new group
coordinator verifies a transaction. Prior to it, the ReplicaManager would
automatically re-schedule the callback to a request
divijvaidya commented on PR #15071:
URL: https://github.com/apache/kafka/pull/15071#issuecomment-1887126184
(rebased from trunk to resolve conflict, will merge after CI is sane)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dajac commented on PR #15173:
URL: https://github.com/apache/kafka/pull/15173#issuecomment-1887121573
Indeed, null is valid. Empty string is also valid but deprecated. Here I
only want to ensure that we don't use it with the new protocol now. We
strengthen the validation on the client in
divijvaidya commented on PR #15173:
URL: https://github.com/apache/kafka/pull/15173#issuecomment-1887118525
Perhaps we need a ConfigValidator whcih says NullOrNonEmptyString. We could
have used that validator here.
dajac merged PR #15142:
URL: https://github.com/apache/kafka/pull/15142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805567#comment-17805567
]
Anatolii Popov commented on KAFKA-16105:
FYI [~satishd] [~abhijeetkumar]
> Reassignment of
divijvaidya commented on PR #15072:
URL: https://github.com/apache/kafka/pull/15072#issuecomment-1887103085
I have rebased from trunk. Apologies that I didn't create a separate commit
which would have made it easier to review the diff. Is there a better way to do
it?
--
This is an
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1448816308
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/StandardAuthorizerUpdateBenchmark.java:
##
@@ -59,17 +59,15 @@
@BenchmarkMode(Mode.AverageTime)
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1448815537
##
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java:
##
@@ -64,11 +64,11 @@ public class MockConsumer implements Consumer {
private
divijvaidya commented on code in PR #15072:
URL: https://github.com/apache/kafka/pull/15072#discussion_r1448815104
##
clients/src/main/java/org/apache/kafka/common/record/LazyDownConversionRecordsSend.java:
##
@@ -36,9 +36,9 @@ public final class LazyDownConversionRecordsSend
[
https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-16089:
--
Assignee: Nicholas Telford
> Kafka Streams still leaking memory
>
[
https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805551#comment-17805551
]
Lucas Brutschy commented on KAFKA-16089:
Thanks for the investigation, Nick!
> Kafka Streams
[
https://issues.apache.org/jira/browse/KAFKA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805548#comment-17805548
]
Luke Chen edited comment on KAFKA-16101 at 1/11/24 12:12 PM:
-
It seems we
[
https://issues.apache.org/jira/browse/KAFKA-16101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805548#comment-17805548
]
Luke Chen commented on KAFKA-16101:
---
It seems we didn't consider it during our KIP design. I'm
mimaison commented on PR #15028:
URL: https://github.com/apache/kafka/pull/15028#issuecomment-1886957991
I approved the request and assigned the ticket to you. I added you to the
list of contributors so you should now be able to assign tickets to yourself.
Thanks
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-15747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-15747:
--
Assignee: Quoc Phong Dang
> KRaft support in DynamicConnectionQuotaTest
>
tinaselenge opened a new pull request, #15175:
URL: https://github.com/apache/kafka/pull/15175
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805519#comment-17805519
]
Nicholas Telford commented on KAFKA-16089:
--
I built a basic memory leak test, which essentially
phong260702 commented on PR #15028:
URL: https://github.com/apache/kafka/pull/15028#issuecomment-1886936190
I think the username is "phong260702". And I have just submit a new one just
now with the same username.
--
This is an automated message from the Apache Git Service.
To respond to
nicktelford commented on PR #15174:
URL: https://github.com/apache/kafka/pull/15174#issuecomment-1886931733
@lucasbru I'm just writing up a more detailed explanation, including graphs,
in the ticket. I'm also going to raise a bug with RocksDB, because I believe
this to be a bug in
nicktelford opened a new pull request, #15174:
URL: https://github.com/apache/kafka/pull/15174
`ColumnFamilyDescriptor` is _not_ a `RocksObject`, which in theory means
it's not backed by any native memory allocated by RocksDB.
However, in practice,
[
https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Telford updated KAFKA-16089:
-
Attachment: fix.png
> Kafka Streams still leaking memory
>
mimaison commented on PR #15028:
URL: https://github.com/apache/kafka/pull/15028#issuecomment-1886925741
I don't see any pending requests, do you remember which username you
requested?
Otherwise you can submit a new request:
https://selfserve.apache.org/jira-account.html
--
This is
[
https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicholas Telford updated KAFKA-16089:
-
Attachment: unfix.png
> Kafka Streams still leaking memory
>
phong260702 commented on PR #15028:
URL: https://github.com/apache/kafka/pull/15028#issuecomment-1886924560
> Do you have a Jira id? so I can assign the
[ticket](https://issues.apache.org/jira/browse/KAFKA-15747) to you
I do not have one. I've been trying to request for an account
phong260702 commented on PR #15028:
URL: https://github.com/apache/kafka/pull/15028#issuecomment-1886915399
> Do you have a Jira id? so I can assign the
[ticket](https://issues.apache.org/jira/browse/KAFKA-15747) to you
I do not have one. I've been trying to request for an account but
mimaison commented on PR #13842:
URL: https://github.com/apache/kafka/pull/13842#issuecomment-1886830476
@stevenbooke Do you intend to finish this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
viktorsomogyi commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1886801135
@mumrah it also crossed my mind when implementing this, however it seemed to
have a little bit high entry levels (publishing, etc.) compared to this little
bash script. It would
showuon commented on PR #15133:
URL: https://github.com/apache/kafka/pull/15133#issuecomment-1886791219
@divijvaidya @kamalcph @clolov , I finally got some time to complete the PR.
Please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To
showuon commented on code in PR #15133:
URL: https://github.com/apache/kafka/pull/15133#discussion_r1448610306
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -860,28 +871,39 @@ void testRemoteLogManagerRemoteMetrics() throws Exception
{
clolov commented on PR #15133:
URL: https://github.com/apache/kafka/pull/15133#issuecomment-1886780194
I will aim to provide another review today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac opened a new pull request, #15173:
URL: https://github.com/apache/kafka/pull/15173
This patch strengthen the validation of the group id when the new consumer
group protocol is used.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
flyingcougar commented on PR #9937:
URL: https://github.com/apache/kafka/pull/9937#issuecomment-1886760618
I agree with @rgo - implementing ipv4 and ipv6 string parsing, range
checking might be error prone (lots of code and tests) and its better to realy
on existing implementation that
mimaison commented on code in PR #15159:
URL: https://github.com/apache/kafka/pull/15159#discussion_r1448589814
##
checkstyle/import-control-core.xml:
##
@@ -49,6 +49,7 @@
+
Review Comment:
I don't think we need the changes in this file
--
This is
[
https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805460#comment-17805460
]
Oleg Opolev commented on KAFKA-15371:
-
I was never able to read the metadata in the cluster.
Albedooo opened a new pull request, #15172:
URL: https://github.com/apache/kafka/pull/15172
This is to address issue described in
[KAFKA-16114](https://issues.apache.org/jira/browse/KAFKA-16114)
To fix partiton not retention after cancel alter intra broker log dir task.
1.
mimaison merged PR #15161:
URL: https://github.com/apache/kafka/pull/15161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #15101:
URL: https://github.com/apache/kafka/pull/15101#issuecomment-1886655919
We can exclude streams from this PR (don't enable this extension) and create
a JIRA to address thread leaks in streams. This will at least allow us to make
progress for majority of
stanislavkozlovski merged PR #15130:
URL: https://github.com/apache/kafka/pull/15130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac merged PR #15170:
URL: https://github.com/apache/kafka/pull/15170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #15155:
URL: https://github.com/apache/kafka/pull/15155#discussion_r1448472421
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1963,6 +2080,75 @@ public void
adixitconfluent opened a new pull request, #15171:
URL: https://github.com/apache/kafka/pull/15171
**About**
This PR adds KRaft support to the following tests in
`ConsumerWithLegacyMessageFormatIntegrationTest` class -
1. `testOffsetsForTimes`
2. `testEarliestOrLatestOffsets`
mimaison commented on PR #15147:
URL: https://github.com/apache/kafka/pull/15147#issuecomment-1886581010
I ran the build [7
times](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15147/) and
this test did not fail once. So I'm proposing re-enabling this test
--
This is an
101 - 170 of 170 matches
Mail list logo
