[jira] [Comment Edited] (KAFKA-16114) Fix partiton not retention after cancel alter intra broker log dir task

2024-03-10 Thread wangliucheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825153#comment-17825153 ] wangliucheng edited comment on KAFKA-16114 at 3/11/24 5:52 AM: --- Hello, are

[jira] [Commented] (KAFKA-16114) Fix partiton not retention after cancel alter intra broker log dir task

2024-03-10 Thread wangliucheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825153#comment-17825153 ] wangliucheng commented on KAFKA-16114: -- Hello, are you interested in seeing this issue? I think

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #14903: URL: https://github.com/apache/kafka/pull/14903#issuecomment-1987577154 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-13403 Fix KafkaServer crashes when deleting topics due to the race in log deletion [kafka]

2024-03-10 Thread via GitHub
arunmathew88 commented on PR #11438: URL: https://github.com/apache/kafka/pull/11438#issuecomment-1987468636 @divijvaidya The test seems to be flaky, and not due to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] MINOR: Remove deprecation and exception throw in ProcessorRecordContext#hashcode [kafka]

2024-03-10 Thread via GitHub
ableegoldman opened a new pull request, #15508: URL: https://github.com/apache/kafka/pull/15508 Something I noticed while working on a new feature -- this class has deprecated its hashcode and actually goes so far as to throw an exception if/when it's invoked. The deprecation note claims

[jira] [Commented] (KAFKA-14482) Move LogLoader to storage module

2024-03-10 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825089#comment-17825089 ] Dmitry Werner commented on KAFKA-14482: --- [~ijuma] Hello, can I assign a task to myself? > Move

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-03-10 Thread via GitHub
VictorvandenHoven commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1518866473 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -230,8 +234,19 @@ private void emitNonJoinedOuterRecords(

Re: [PR] KAFKA-14683 Cleanup WorkerSinkTaskTest [kafka]

2024-03-10 Thread via GitHub
hgeraldino commented on PR #15506: URL: https://github.com/apache/kafka/pull/15506#issuecomment-1987243289 > @hgeraldino thank for this patch. Could you please apply `assertThrow` to this class? For example, the following assert can be rewritten. _origin_ > > ```java > try

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-03-10 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15188: URL: https://github.com/apache/kafka/pull/15188#discussion_r1517714052 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java: ## @@ -84,6 +85,9 @@ private enum SubscriptionType { /* the

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-03-10 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15188: URL: https://github.com/apache/kafka/pull/15188#discussion_r1518849655 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -494,6 +501,14 @@ public void

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

2024-03-10 Thread via GitHub
florin-akermann commented on code in PR #15189: URL: https://github.com/apache/kafka/pull/15189#discussion_r1518848428 ## streams/src/test/java/org/apache/kafka/streams/integration/RelaxedNullKeyRequirementJoinTest.java: ## @@ -71,11 +71,21 @@ void afterEach() { @Test