[
https://issues.apache.org/jira/browse/KAFKA-16342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16342.
---
Fix Version/s: 3.6.2
3.8.0
3.7.1
Resolution: Fixed
> Fi
showuon merged PR #15542:
URL: https://github.com/apache/kafka/pull/15542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527116740
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarn
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527116473
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -77,11 +77,34 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHar
artemlivshits commented on PR #15524:
URL: https://github.com/apache/kafka/pull/15524#issuecomment-2001771301
LogDirFailureTest > testIOExceptionDuringLogRoll(String) >
testIOExceptionDuringLogRoll(String).quorum=kraft is failing locally, will
investigate.
ReplicaManagerTest -- all tests
[
https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827651#comment-17827651
]
Chia-Ping Tsai commented on KAFKA-16376:
Thanks for handling this flaky! Chris w
[
https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Holland reassigned KAFKA-16376:
-
Assignee: (was: Chris Holland)
> Fix flaky ReplicaManagerTest.testRemoteFetchExpire
[ https://issues.apache.org/jira/browse/KAFKA-16376 ]
Chris Holland deleted comment on KAFKA-16376:
---
was (Author: JIRAUSER304519):
[~chia7712] As discussed on GitHub, I can try and tackle this
> Fix flaky ReplicaManagerTest.testRemoteFetchExp
[
https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Holland reassigned KAFKA-16376:
-
Assignee: Chris Holland
> Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetr
[
https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827649#comment-17827649
]
Chris Holland commented on KAFKA-16376:
---
[~chia7712] As discussed on GitHub, I can
github-actions[bot] commented on PR #14923:
URL: https://github.com/apache/kafka/pull/14923#issuecomment-2001437254
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-16380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827641#comment-17827641
]
Chia-Ping Tsai commented on KAFKA-16380:
[~johnnyhsu] please complete the descri
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527041931
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition
partition, Iter
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527029580
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarn
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527026867
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -173,9 +173,9 @@ class LogValidatorTest {
assertEquals(now, validatedResults.maxTimestampMs
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1527018572
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
chia7712 commented on code in PR #15512:
URL: https://github.com/apache/kafka/pull/15512#discussion_r1527016313
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2718,7 +2719,7 @@ public void testDropCommitOnBatchExpiry() th
chia7712 commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-2001031718
> Do you have any in particular?
how about https://issues.apache.org/jira/browse/KAFKA-16376 ? or check the
following link:
https://issues.apache.org/jira/issues/?jql=proj
stan-is-hate closed pull request #12402: remove min_cluster_size() calls
URL: https://github.com/apache/kafka/pull/12402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
stan-is-hate closed pull request #12120: Add mini test
URL: https://github.com/apache/kafka/pull/12120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1526958117
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##
@@ -177,6 +178,86 @@ class TransactionMarkerChannelManagerTest {
artemlivshits commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1526939166
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##
@@ -177,6 +178,86 @@ class TransactionMarkerChannelManager
dongnuo123 commented on code in PR #14675:
URL: https://github.com/apache/kafka/pull/14675#discussion_r1526926450
##
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##
@@ -77,8 +83,9 @@ class ConsumerBounceTest extends AbstractConsumerTest with
Logging {
dongnuo123 opened a new pull request, #15547:
URL: https://github.com/apache/kafka/pull/15547
This pr is based on #14675 where enabling kraft in
testConsumptionWithBrokerFailures showed flakiness. We'll need to find a way to
fix it.
### Committer Checklist (excluded from commit messa
[
https://issues.apache.org/jira/browse/KAFKA-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongnuo Lyu updated KAFKA-15756:
Description:
There is one flaky test left, we need to figure out how to reduce the flakiness.
{cod
mjsax commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526870886
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
Sta
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526869018
##
core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala:
##
@@ -72,6 +72,8 @@ class AddPartitionsToTxnManagerTest {
private val versionMismatchR
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526868437
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -975,12 +978,13 @@ class ReplicaManager(val config: KafkaConfig,
/**
*
- * @param topicPartit
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526864714
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3523,6 +3524,129 @@ public void
testForegroundInvalidStateTran
jolshan commented on PR #15486:
URL: https://github.com/apache/kafka/pull/15486#issuecomment-2000460307
I was thinking about this change and am wondering if we should bump all the
transactional APIs to make it clear this error can be returned. Let me get back
to you @sjhajharia -- I will co
jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1526861466
##
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java:
##
@@ -392,7 +393,8 @@ public enum Errors {
UNKNOWN_CONTROLLER_ID(116, "This controller ID i
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526811182
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
ijuma commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1526810480
##
gradle/dependencies.gradle:
##
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle: "8.5"
wcarlson5 commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526810331
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
mjsax commented on code in PR #15414:
URL: https://github.com/apache/kafka/pull/15414#discussion_r1526795838
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -236,6 +247,76 @@ private List topicPartitionsForStore(final
Sta
lianetm commented on PR #15511:
URL: https://github.com/apache/kafka/pull/15511#issuecomment-2000323516
Went over the latests updates, LGTM. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827594#comment-17827594
]
Kirk True commented on KAFKA-16190:
---
Thank you [~phong260702] for your help on this! :
pasharik commented on code in PR #15404:
URL: https://github.com/apache/kafka/pull/15404#discussion_r1526739190
##
gradle/dependencies.gradle:
##
@@ -100,10 +100,10 @@ versions += [
commonsCli: "1.4",
commonsValidator: "1.7",
dropwizardMetrics: "4.1.12.1",
- gradle: "8
[
https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16375:
---
Fix Version/s: 3.8.0
> Fix logic for discarding reconciliation if member rejoined
>
[
https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827589#comment-17827589
]
Lianet Magrans commented on KAFKA-16375:
Yes, I just updated the version ;)
> F
[
https://issues.apache.org/jira/browse/KAFKA-16375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827587#comment-17827587
]
Kirk True commented on KAFKA-16375:
---
[~lianetm]—do we want this in 3.8?
> Fix logic f
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526716168
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -565,6 +565,58 @@ public void testSameAssignmentReconciledAg
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526715547
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -565,6 +565,58 @@ public void testSameAssignmentReconciledAga
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526696015
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -639,6 +639,25 @@ public void testDescribe(String quorum) throws
Executio
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526695825
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -799,6 +820,11 @@ public TopicCommandOptions(String[] args) {
"if set wh
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526695578
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526690281
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526685631
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2256,6 +2384,26 @@ void handleFailure(Throwable throwable) {
retu
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526581796
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -889,42 +894,39 @@ private void transitionToStale() {
*/
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526680281
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {
lucasbru merged PR #15401:
URL: https://github.com/apache/kafka/pull/15401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526587744
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness {
lianetm commented on PR #15511:
URL: https://github.com/apache/kafka/pull/15511#issuecomment-2000134008
Thanks for the updates @lucasbru, took another look, LGTM considering the
latests nits.
Just for the record, I will follow-up with
[KAFKA-16375](https://issues.apache.org/jira/bro
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526609264
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -29,6 +29,8 @@
import org.apache.kafka.common.TopicPartition
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526609264
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -29,6 +29,8 @@
import org.apache.kafka.common.TopicPartition
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526609264
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -29,6 +29,8 @@
import org.apache.kafka.common.TopicPartition
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526605829
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -976,6 +974,10 @@ void maybeReconcile() {
}
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526605292
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -911,9 +911,13 @@ void maybeReconcile() {
SortedSet assi
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526595161
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526594353
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(Long
Johnny Hsu created KAFKA-16380:
--
Summary: Rename the shallowOffsetOfMaxTimestamp in LogSegment
Key: KAFKA-16380
URL: https://issues.apache.org/jira/browse/KAFKA-16380
Project: Kafka
Issue Type:
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526591324
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,14 +404,8 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimes
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-287090
test with
```
./gradlew clean core:test --tests kafka.log.LogValidatorTest
./gradlew clean client:test --tests
org.apache.kafka.common.record.MemoryRecordsBuilderTest
./g
ChrisAHolland commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-277204
I will take a look for some unassigned tickets! Do you have any in
particular?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-237478
thanks @junrao @chia7712 @showuon for the suggestions and comments!
I have updated the following:
- rename the ValidationResult.shallowOffsetOfMaxTimestamp to
ValidationResult.re
mumrah commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1526390858
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2185,9 +2179,143 @@ void handleFailure(Throwable throwable) {
comp
[
https://issues.apache.org/jira/browse/KAFKA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16349:
Description:
`ShutdownableThread` calls `Exit.exit()` when the thread's operation throws
FatalExi
Jeff Kim created KAFKA-16379:
Summary: add metric to measure time spent in purgatory
Key: KAFKA-16379
URL: https://issues.apache.org/jira/browse/KAFKA-16379
Project: Kafka
Issue Type: Sub-task
dajac commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526420387
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -970,7 +973,11 @@ void maybeReconcile() {
log.debu
mumrah commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1526384089
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1369,7 +1384,23 @@ void handleBrokerInControlledShutdown(int brokerId, long
johnnychhsu commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1526027063
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -19,82 +19,236 @@ package kafka.admin
import kafka.integration.KafkaServer
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-socketServer.ena
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-socketServer.ena
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526349331
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -529,25 +530,18 @@ public ConsumerGroupHeartbeatRequestData
b
lucasbru commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1526346873
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -911,9 +911,13 @@ void maybeReconcile() {
SortedSet ass
dongnuo123 opened a new pull request, #15546:
URL: https://github.com/apache/kafka/pull/15546
This patch enables the empty classic groups to upgrade to classic groups and
empty consumer groups to upgrade to consumer groups.
jira: https://issues.apache.org/jira/browse/KAFKA-16313
dongnuo123 closed pull request #15442: KAFKA-16313: offline group protocol
migration
URL: https://github.com/apache/kafka/pull/15442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
lucasbru merged PR #15538:
URL: https://github.com/apache/kafka/pull/15538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru merged PR #15540:
URL: https://github.com/apache/kafka/pull/15540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru merged PR #15539:
URL: https://github.com/apache/kafka/pull/15539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15507:
URL: https://github.com/apache/kafka/pull/15507#issuecomment-1999649048
@ChrisAHolland thanks for contribution. If you have free cycle, please help
us fix the flaky. There are a bunch of tickets about flaky tests :)
--
This is an automated message from the
lucasbru merged PR #15537:
URL: https://github.com/apache/kafka/pull/15537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #15507:
URL: https://github.com/apache/kafka/pull/15507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru merged PR #15330:
URL: https://github.com/apache/kafka/pull/15330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
lucasbru commented on PR #15330:
URL: https://github.com/apache/kafka/pull/15330#issuecomment-1999644666
LGTM, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526268639
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-socketServer.ena
dajac opened a new pull request, #15545:
URL: https://github.com/apache/kafka/pull/15545
In https://github.com/apache/kafka/pull/15364, we introduced, thoughtfully,
a non-backward compatible record change for the new consumer group protocol. So
it is a good opportunity for cleaning unused f
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526237310
##
core/src/test/scala/unit/kafka/server/KafkaServerTest.scala:
##
@@ -42,6 +42,32 @@ class KafkaServerTest extends QuorumTestHarness {
TestUtils.shutdownServ
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526229909
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -116,14 +116,14 @@ public class HeartbeatRequestManager imp
dajac merged PR #15528:
URL: https://github.com/apache/kafka/pull/15528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
nizhikov commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999556511
Hello @mimaison , @jolshan
Do you have time to review this PR?
We are ready to move `ConsumerGroupCommand` to tools - all tests moved to
java, I've checked system tests and che
chia7712 commented on PR #14471:
URL: https://github.com/apache/kafka/pull/14471#issuecomment-1999553646
> Are you suggesting to find more reviewers for this PR?
Yep, if they have free cycle 😃
Anyway, I will take a look later. Thanks for updating code
--
This is an automated
soarez commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-1999531297
@OmniaGM can you resolve the conflicts for this PR? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526193892
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -116,14 +116,14 @@ public class HeartbeatRequestManager implem
phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526177488
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -428,9 +429,28 @@ public void testHeartbeatState() {
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-socketServer.ena
edoardocomar commented on code in PR #15530:
URL: https://github.com/apache/kafka/pull/15530#discussion_r1526169481
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -617,14 +617,21 @@ class KafkaServer(
}
}
}
-socketServer.ena
apoorvmittal10 commented on PR #15532:
URL: https://github.com/apache/kafka/pull/15532#issuecomment-1999421797
Re-triggering the build by re-opening the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1526107034
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -116,14 +116,14 @@ public class HeartbeatRequestManager implem
1 - 100 of 125 matches
Mail list logo
