philipnee commented on PR #15525:
URL: https://github.com/apache/kafka/pull/15525#issuecomment-2026690869
@lucasbru - Thanks for taking time reviewing this PR. This PR is ready for
another pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
philipnee commented on code in PR #15525:
URL: https://github.com/apache/kafka/pull/15525#discussion_r1544067091
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -946,7 +956,7 @@ public void testOffsetsForTimesWithZeroTimeou
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2026641230
> (1) revert all offsetForMaxTimestamp to shallowOffsetMaxTimestamp
(2) change/revert the implementation to set shallowOffsetMaxTimestamp
accordingly.
Do we need to revert all o
chia7712 commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1544046500
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1337,13 +1337,16 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
philipnee commented on code in PR #15525:
URL: https://github.com/apache/kafka/pull/15525#discussion_r1544046037
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1141,21 +1141,27 @@ private Map
beginningOrEndOffset(Collection
github-actions[bot] commented on PR #15034:
URL: https://github.com/apache/kafka/pull/15034#issuecomment-2026574417
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
showuon commented on code in PR #14760:
URL: https://github.com/apache/kafka/pull/14760#discussion_r1544017066
##
core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala:
##
@@ -386,6 +386,7 @@ class NodeToControllerRequestThread(
if (response.authenticationEx
showuon commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1544007618
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,25 @@ protected final Map
crea
[
https://issues.apache.org/jira/browse/KAFKA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-16349.
-
Fix Version/s: 3.8.0
Assignee: Greg Harris
Resolution: Fixed
> ShutdownableThrea
gharris1727 merged PR #15484:
URL: https://github.com/apache/kafka/pull/15484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
gharris1727 commented on PR #15484:
URL: https://github.com/apache/kafka/pull/15484#issuecomment-2026540118
Test failures appear unrelated, and I got a local run of `./gradlew test` to
pass!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
showuon commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1543916425
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1337,13 +1337,16 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
Owen-CH-Leung commented on PR #15489:
URL: https://github.com/apache/kafka/pull/15489#issuecomment-2026412628
> adde167
No prob. Added back `ToString` to troubleshoot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1543906755
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1337,13 +1337,16 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp ==
soarez commented on PR #15622:
URL: https://github.com/apache/kafka/pull/15622#issuecomment-2026356492
> events have relatively unique names (we include offset in some) so the
cardinality is quite high
I see. What I meant would result in too many more metrics. Makes sense then.
--
mumrah commented on code in PR #15622:
URL: https://github.com/apache/kafka/pull/15622#discussion_r1543844228
##
metadata/src/main/java/org/apache/kafka/controller/metrics/SlowEventsLogger.java:
##
@@ -0,0 +1,58 @@
+package org.apache.kafka.controller.metrics;
+
+import org.apac
mumrah commented on PR #15622:
URL: https://github.com/apache/kafka/pull/15622#issuecomment-2026321417
@soarez wdym by tagging here?
Note that the events have relatively unique names (we include offset in
some) so the cardinality is quite high.
--
This is an automated message from
soarez commented on code in PR #15622:
URL: https://github.com/apache/kafka/pull/15622#discussion_r1543829135
##
metadata/src/main/java/org/apache/kafka/controller/metrics/SlowEventsLogger.java:
##
@@ -0,0 +1,58 @@
+package org.apache.kafka.controller.metrics;
+
+import org.apac
soarez commented on code in PR #15620:
URL: https://github.com/apache/kafka/pull/15620#discussion_r1543811354
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -74,25 +72,25 @@ protected final Map
creat
soarez commented on PR #14760:
URL: https://github.com/apache/kafka/pull/14760#issuecomment-2026260420
This still needs a review from a committer.
@mimaison @mumrah @rondagostino @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-15955:
Priority: Minor (was: Major)
> Migrating ZK brokers send dir assignments
> --
soarez commented on PR #15617:
URL: https://github.com/apache/kafka/pull/15617#issuecomment-2026228502
Olá Filipe. Thanks for your contribution.
`BrokerServer` shouldn't aim to follow the structure or interface in
`KafkaServer`. What those two are meant to have in common is defined i
[
https://issues.apache.org/jira/browse/KAFKA-16286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-16286.
Resolution: Fixed
> KRaft doesn't always notify listener of latest
[
https://issues.apache.org/jira/browse/KAFKA-16286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-16286:
---
Fix Version/s: 3.8.0
> KRaft doesn't always notify listener of lates
soarez commented on PR #15607:
URL: https://github.com/apache/kafka/pull/15607#issuecomment-2026208622
@mjsax I think this one should also be tagged 'streams'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
soarez commented on PR #15611:
URL: https://github.com/apache/kafka/pull/15611#issuecomment-2026205805
Seems like a gray area to me. Regardless, I'd like to encourage @brandboat
to keep looking for opportunities to cleanup and refactor.
--
This is an automated message from the Apache Git
soarez commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1543761783
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,22 +38,32 @@ import org.mockito.Mockito.{mock, when}
import java.util.c
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1543754297
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1337,13 +1337,16 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else if (targetTimestamp == L
David Arthur created KAFKA-16446:
Summary: Log slow controller events
Key: KAFKA-16446
URL: https://issues.apache.org/jira/browse/KAFKA-16446
Project: Kafka
Issue Type: Improvement
mumrah opened a new pull request, #15622:
URL: https://github.com/apache/kafka/pull/15622
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831966#comment-17831966
]
Chia-Ping Tsai commented on KAFKA-16310:
see the following link to check the rev
[
https://issues.apache.org/jira/browse/KAFKA-16342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16342:
---
Fix Version/s: (was: 3.7.1)
> Fix compressed records
> --
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16341:
---
Fix Version/s: (was: 3.7.1)
> Fix un-compressed records
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16310:
---
Fix Version/s: (was: 3.7.1)
> ListOffsets doesn't report the offset with maxTimestamp an
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831965#comment-17831965
]
Chia-Ping Tsai commented on KAFKA-16310:
{quote}
Since the follower only maintai
chia7712 opened a new pull request, #15621:
URL: https://github.com/apache/kafka/pull/15621
We do iterate the records to find the `offsetOfMaxTimestamp` instead of
returning the cached one when handling `ListOffsetsRequest.MAX_TIMESTAMP`,
since it is hard to align all paths to get correct `
gharris1727 merged PR #15597:
URL: https://github.com/apache/kafka/pull/15597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
gharris1727 commented on PR #15597:
URL: https://github.com/apache/kafka/pull/15597#issuecomment-2026050399
Test failures appear unrelated:
1. ReplicaManagerTest has tickets
[KAFKA-16323](https://issues.apache.org/jira/browse/KAFKA-16323) and
[KAFKA-13530](https://issues.apache.org/jira/
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831959#comment-17831959
]
Jun Rao commented on KAFKA-16310:
-
Since the follower only maintains offsetForMaxTimesta
chia7712 commented on PR #15618:
URL: https://github.com/apache/kafka/pull/15618#issuecomment-2026013673
> I am just saying that we only need to fix this in trunk since the
implementation was never correct in any previous branches, thus not a
regression.
got it. will open another PR
chia7712 closed pull request #15618: KAFKA-16310 ListOffsets doesn't report the
offset with maxTimestamp a…
URL: https://github.com/apache/kafka/pull/15618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gharris1727 commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2026008220
@linu-shibu Could you fix the rawtypes warnings in this class? You can see
them if you make this change in build.gradle:
```diff
options.encoding = 'UTF-8'
optio
junrao commented on PR #15618:
URL: https://github.com/apache/kafka/pull/15618#issuecomment-2026000277
> I am not sure I understand this. All we need for this solution (or
workaround) is the "max timestamp" of a segment, since we always iterate the
batches (from the segment having the max t
junrao commented on code in PR #15618:
URL: https://github.com/apache/kafka/pull/15618#discussion_r1543560539
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1320,10 +1320,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// constant time access while
chia7712 commented on PR #15618:
URL: https://github.com/apache/kafka/pull/15618#issuecomment-2025943523
> Since the follower only maintains offsetForMaxTimestamp at the batch
level, the listMaxTimestamp API was never implemented correctly.
I am not sure I understand this. All we need
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2025930412
@gharris1727 please do take a look and provide some guidance/feedback.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
linu-shibu opened a new pull request, #15620:
URL: https://github.com/apache/kafka/pull/15620
RemoteLogMetadata object, and has to dispatch to one of four serializers
depending on it's type which is currently done by taking the class name of the
RemoteLogMetadata and looking it up i
chia7712 commented on code in PR #15618:
URL: https://github.com/apache/kafka/pull/15618#discussion_r1543505409
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1320,10 +1320,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// constant time access whil
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543492385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -984,6 +984,8 @@ public void close(final Timer timer) {
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543492385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -984,6 +984,8 @@ public void close(final Timer timer) {
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543492385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -984,6 +984,8 @@ public void close(final Timer timer) {
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543492385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -984,6 +984,8 @@ public void close(final Timer timer) {
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long now
[
https://issues.apache.org/jira/browse/KAFKA-16445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Yurchenko updated KAFKA-16445:
---
Summary: PATCH method for connector configuration (was: PATCH method for
connecto configura
Ivan Yurchenko created KAFKA-16445:
--
Summary: PATCH method for connecto configuration
Key: KAFKA-16445
URL: https://issues.apache.org/jira/browse/KAFKA-16445
Project: Kafka
Issue Type: Impro
junrao commented on PR #15618:
URL: https://github.com/apache/kafka/pull/15618#issuecomment-2025853565
@chia7712: Since the follower only maintains offsetForMaxTimestamp at the
batch level, the listMaxTimestamp API was never implemented correctly. So,
technically, there was no regression fo
junrao commented on code in PR #15618:
URL: https://github.com/apache/kafka/pull/15618#discussion_r1543430656
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1320,10 +1320,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// constant time access while
kirktrue closed pull request #15427: [WIp] Fixes consume bench test.py maybe
URL: https://github.com/apache/kafka/pull/15427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kirktrue closed pull request #15250: KAFKA-15974: Enforce that event processing
respects user-provided timeout
URL: https://github.com/apache/kafka/pull/15250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Kirk True created KAFKA-16444:
-
Summary: Run KIP-848 unit tests under code coverage
Key: KAFKA-16444
URL: https://issues.apache.org/jira/browse/KAFKA-16444
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-16442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16442:
--
Component/s: streams
> Update streams_standby_replica_test.py to support KIP-848’s group protocol
> c
[
https://issues.apache.org/jira/browse/KAFKA-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16443:
--
Component/s: streams
> Update streams_static_membership_test.py to support KIP-848’s group protocol
>
[
https://issues.apache.org/jira/browse/KAFKA-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16441:
--
Component/s: streams
> Update streams_broker_down_resilience_test.py to support KIP-848’s group
> pro
[
https://issues.apache.org/jira/browse/KAFKA-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16441:
--
Description:
This task is to update the test method(s) in
{{streams_broker_down_resilience_test.py}}
[
https://issues.apache.org/jira/browse/KAFKA-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16443:
--
Description:
This task is to update the test method(s) in
{{streams_static_membership_test.py}} to su
Kirk True created KAFKA-16443:
-
Summary: Update streams_static_membership_test.py to support
KIP-848’s group protocol config
Key: KAFKA-16443
URL: https://issues.apache.org/jira/browse/KAFKA-16443
Project
[
https://issues.apache.org/jira/browse/KAFKA-16442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16442:
--
Description:
This task is to update the test method(s) in
{{streams_standby_replica_test.py}} to supp
Kirk True created KAFKA-16442:
-
Summary: Update streams_standby_replica_test.py to support
KIP-848’s group protocol config
Key: KAFKA-16442
URL: https://issues.apache.org/jira/browse/KAFKA-16442
Project:
[
https://issues.apache.org/jira/browse/KAFKA-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16441:
--
Fix Version/s: 4.0.0
(was: 3.8.0)
> Update streams_broker_down_resilience_test.
Kirk True created KAFKA-16441:
-
Summary: Update streams_broker_down_resilience_test.py to support
KIP-848’s group protocol config
Key: KAFKA-16441
URL: https://issues.apache.org/jira/browse/KAFKA-16441
Pr
[
https://issues.apache.org/jira/browse/KAFKA-16440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16440:
--
Description:
This task is to update the test method(s) in {{security_test.py}} to support
the {{group
Kirk True created KAFKA-16440:
-
Summary: Update security_test.py to support KIP-848’s group
protocol config
Key: KAFKA-16440
URL: https://issues.apache.org/jira/browse/KAFKA-16440
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16439:
--
Reviewer: (was: Lucas Brutschy)
> Update replication_replica_failure_test.py to support KIP-848’s gr
[
https://issues.apache.org/jira/browse/KAFKA-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16439:
--
Description:
This task is to update the test method(s) in
{{replication_replica_failure_test.py}} to
chia7712 commented on code in PR #15618:
URL: https://github.com/apache/kafka/pull/15618#discussion_r1543390343
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1320,10 +1320,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// constant time access whil
Kirk True created KAFKA-16439:
-
Summary: Update replication_replica_failure_test.py to support
KIP-848’s group protocol config
Key: KAFKA-16439
URL: https://issues.apache.org/jira/browse/KAFKA-16439
Proje
[
https://issues.apache.org/jira/browse/KAFKA-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16438:
--
Issue Type: Test (was: Bug)
> Update consumer_test.py’s static tests to support KIP-848’s group proto
[
https://issues.apache.org/jira/browse/KAFKA-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16438:
--
Fix Version/s: 3.8.0
> Update consumer_test.py’s static tests to support KIP-848’s group protocol
> c
Kirk True created KAFKA-16438:
-
Summary: Update consumer_test.py’s static tests to support
KIP-848’s group protocol config
Key: KAFKA-16438
URL: https://issues.apache.org/jira/browse/KAFKA-16438
Project:
[
https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16275:
--
Fix Version/s: 3.8.0
(was: 4.0.0)
> Update kraft_upgrade_test.py to support KIP
[
https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16275:
-
Assignee: Kirk True
> Update kraft_upgrade_test.py to support KIP-848’s group protocol config
>
[
https://issues.apache.org/jira/browse/KAFKA-16271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-16271.
---
Reviewer: Lucas Brutschy
Resolution: Fixed
> Update consumer_rolling_upgrade_test.py to suppor
kirktrue commented on PR #15594:
URL: https://github.com/apache/kafka/pull/15594#issuecomment-2025765078
@lucasbru—can you take a look at this system test change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16275:
--
Fix Version/s: 4.0.0
(was: 3.8.0)
> Update kraft_upgrade_test.py to support KIP
fvaleri commented on PR #15273:
URL: https://github.com/apache/kafka/pull/15273#issuecomment-2025743216
Closing this one in favor of the work done for KAFKA-15853.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
fvaleri closed pull request #15273: KAFKA-14585: Refactoring for moving the
storage tool
URL: https://github.com/apache/kafka/pull/15273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
junrao commented on code in PR #15618:
URL: https://github.com/apache/kafka/pull/15618#discussion_r1543349555
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1320,10 +1320,8 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// constant time access while
mimaison commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1543199493
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2025540351
Okay, enjoy your time off!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
wcarlson5 opened a new pull request, #15619:
URL: https://github.com/apache/kafka/pull/15619
Implementation of Kip 1024. We change the `addGlobalStateStore` to be able
to configure the way which restoring takes place or we let them use the default
processor rather than a custom one.
chia7712 opened a new pull request, #15618:
URL: https://github.com/apache/kafka/pull/15618
- add default implementation to Batch to return offset of max timestamp
- copy ListOffsetsIntegrationTest from trunk branch
### Committer Checklist (excluded from commit message)
- [ ] Ver
philipnee commented on PR #15525:
URL: https://github.com/apache/kafka/pull/15525#issuecomment-2025522451
hi @lucasbru - Let me address Lianets comment in this PR and have a
separated PR for the behavior inconsistency as it does require some changes to
the unit test
--
This is an automat
nizhikov commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1543177295
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
wcarlson5 merged PR #15414:
URL: https://github.com/apache/kafka/pull/15414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
mimaison commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1543174303
##
core/src/main/scala/kafka/controller/PartitionStateMachine.scala:
##
@@ -486,7 +486,7 @@ class ZkPartitionStateMachine(config: KafkaConfig,
} else {
val
jolshan commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1543175309
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last heartbea
wcarlson5 commented on PR #15414:
URL: https://github.com/apache/kafka/pull/15414#issuecomment-2025500658
Test configuration issues in the build is in `core:test' and not related to
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
chia7712 commented on code in PR #15572:
URL: https://github.com/apache/kafka/pull/15572#discussion_r1543172408
##
server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java:
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
aiven-anton commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1543168871
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last hear
jolshan commented on code in PR #14469:
URL: https://github.com/apache/kafka/pull/14469#discussion_r1543165416
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json:
##
@@ -43,21 +43,6 @@
"about": "null if it didn't change since the last heartbea
1 - 100 of 177 matches
Mail list logo
