brandboat commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1554537353
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Excepti
showuon commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040993296
LGTM! Thanks @FrankYang0529 ! Really nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
showuon commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1554536274
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Exception
[
https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16234.
---
Resolution: Fixed
> Log directory failure re-creates partitions in another logdir automatically
> --
showuon merged PR #15335:
URL: https://github.com/apache/kafka/pull/15335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-2040991135
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
wernerdv commented on PR #15672:
URL: https://github.com/apache/kafka/pull/15672#issuecomment-2040983038
@cmccabe @chia7712 Hello, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
clolov opened a new pull request, #15673:
URL: https://github.com/apache/kafka/pull/15673
### Summary
This is a follow-up of https://github.com/apache/kafka/pull/15213 where I
missed updating the API version and the IBP version. I chose to mark the latest
version of the ListOffsets A
Christo Lolov created KAFKA-16480:
-
Summary: ListOffsets change should have an associated API/IBP
version update
Key: KAFKA-16480
URL: https://issues.apache.org/jira/browse/KAFKA-16480
Project: Kafka
omkreddy commented on code in PR #15651:
URL: https://github.com/apache/kafka/pull/15651#discussion_r1554531283
##
release.py:
##
@@ -348,6 +348,9 @@ def command_release_announcement_email():
+An overview of the release and its notable changes can be found in the
+release
wernerdv opened a new pull request, #15672:
URL: https://github.com/apache/kafka/pull/15672
Removed unnecessary exceptions from the throw list.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build s
brandboat commented on PR #15668:
URL: https://github.com/apache/kafka/pull/15668#issuecomment-2040977883
> @brandboat nice finding! Should we add the thread prefix to
https://github.com/apache/kafka/blob/a2ee0855ee5e73f3a74555d52294bb4acfd28945/core/src/test/scala/unit/kafka/utils/TestUtils
brandboat commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1554519247
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -654,6 +654,13 @@ static Map>
getReplicaAssignmentForPartitions(Admi
chia7712 commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1554518847
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
github-actions[bot] commented on PR #15078:
URL: https://github.com/apache/kafka/pull/15078#issuecomment-2040935039
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2040912811
@nizhikov Could you please rebase code to see the display name of tools test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16472.
Resolution: Fixed
> Integration tests in Java don't really run kraft case
> --
[
https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16472:
---
Fix Version/s: 3.8.0
3.7.1
> Integration tests in Java don't really run k
chia7712 merged PR #15663:
URL: https://github.com/apache/kafka/pull/15663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040889410
I'm going to merge this PR in order to make other tool tests can run with
KRaft. We can address all late reviews in other PRs.
--
This is an automated message from the Apache Git Servi
Phuc-Hong-Tran commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1554474003
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa
Phuc-Hong-Tran commented on code in PR #15585:
URL: https://github.com/apache/kafka/pull/15585#discussion_r1554466415
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa
showuon commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Exception
showuon commented on code in PR #15659:
URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Exception
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16474:
--
Labels: kip-848-client-support (was: )
> AsyncKafkaConsumer might send out heartbeat request without
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16474:
--
Component/s: clients
> AsyncKafkaConsumer might send out heartbeat request without waiting for its
>
[
https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16474:
--
Fix Version/s: 3.8.0
> AsyncKafkaConsumer might send out heartbeat request without waiting for its
>
[
https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834456#comment-17834456
]
Matthias J. Sax commented on KAFKA-16478:
-
\cc [~mimaison] – seems you remove so
[ https://issues.apache.org/jira/browse/KAFKA-16478 ]
Matthias J. Sax deleted comment on KAFKA-16478:
-
was (Author: mjsax):
\cc [~omkreddy] [~stanislavkozlovski] as last RMs – did any of you move
artifacts and forgot to update the links?
>
[
https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834452#comment-17834452
]
Matthias J. Sax commented on KAFKA-16478:
-
\cc [~omkreddy] [~stanislavkozlovski]
[
https://issues.apache.org/jira/browse/KAFKA-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834451#comment-17834451
]
Matthias J. Sax commented on KAFKA-16478:
-
[~der_eismann] – Thanks for reporting
gharris1727 commented on PR #15527:
URL: https://github.com/apache/kafka/pull/15527#issuecomment-2040626161
> I don't think that's a good idea. Usually IDEs help in figuring out the
usages of fields/classes anyway. Should we remove that tag?
I agree, let's remove that. RemoteStorageMe
gaurav-narula commented on PR #15527:
URL: https://github.com/apache/kafka/pull/15527#issuecomment-2040616724
@gharris1727 Thanks for pointing that out.
The warning below
```
kafka/storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java:31:
chia7712 commented on code in PR #15670:
URL: https://github.com/apache/kafka/pull/15670#discussion_r1554282432
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1136,18 +1137,18 @@ class DynamicListenerConfig(server: KafkaBroker)
extends BrokerReconfigurabl
gharris1727 commented on PR #15527:
URL: https://github.com/apache/kafka/pull/15527#issuecomment-2040586001
Hi @gaurav-narula I see some other javadoc warnings, do you think we should
address these?
```
> Task :storage:storage-api:javadoc
kafka/storage/api/src/main/java/org/apa
jsancio opened a new pull request, #15671:
URL: https://github.com/apache/kafka/pull/15671
DRAFT
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
lianetm commented on PR #15613:
URL: https://github.com/apache/kafka/pull/15613#issuecomment-2040495611
Thanks for the changes @lucasbru, looks good to me overall. This is tidying
up the whole async commit callbacks execution story. Left some comments, mostly
minor, and to make sure we're o
gharris1727 commented on code in PR #15642:
URL: https://github.com/apache/kafka/pull/15642#discussion_r1554188423
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java:
##
@@ -69,6 +69,9 @@ public static void setup() {
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554177925
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554165141
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554162586
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
chia7712 commented on code in PR #15651:
URL: https://github.com/apache/kafka/pull/15651#discussion_r1554150631
##
release.py:
##
@@ -348,6 +348,9 @@ def command_release_announcement_email():
+An overview of the release and its notable changes can be found in the
+release
chia7712 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040402625
@ijuma Could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
vamossagar12 closed pull request #11592: KAFKA-13501: Avoid state restore via
rebalance if standbys are enabled
URL: https://github.com/apache/kafka/pull/11592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vamossagar12 closed pull request #10278: KAFKA-10526: leader fsync deferral on
write
URL: https://github.com/apache/kafka/pull/10278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
vamossagar12 closed pull request #10468: Kafka 12373:Improve KafkaRaftClient
handling of graceful shutdown
URL: https://github.com/apache/kafka/pull/10468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
OmniaGM opened a new pull request, #15670:
URL: https://github.com/apache/kafka/pull/15670
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgra
vamossagar12 closed pull request #10842: KAFKA-12848: kafka streams jmh
benchmarks
URL: https://github.com/apache/kafka/pull/10842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
gharris1727 commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1554016667
##
streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedKeyAndJoinSide.java:
##
@@ -33,28 +34,36 @@
public class TimestampedKeyAndJoinSide {
philipnee commented on PR #15661:
URL: https://github.com/apache/kafka/pull/15661#issuecomment-2040290159
@cadonna @lucasbru - Is it possible for me to ask for a review on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554025678
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554024796
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554024079
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554020736
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -229,7 +229,11 @@ private GroupRebalanceConfig
buildRebalanceC
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1554011665
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -654,6 +654,64 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertEqua
chia7712 commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2040270805
> Regarding the previous failed tests, one possibility is that the data on
the server passed the retention time and is garbage collected. The default
retention time is 7 days, which shou
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543492385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -984,6 +984,8 @@ public void close(final Timer timer) {
junrao commented on PR #15621:
URL: https://github.com/apache/kafka/pull/15621#issuecomment-2040231361
@chia7712 : Thanks for the updated PR. Regarding the previous failed tests,
one possibility is that the data on the server passed the retention time and is
garbage collected. The default r
CalvinConfluent commented on PR #15470:
URL: https://github.com/apache/kafka/pull/15470#issuecomment-2040217099
@mumrah Thanks for the review. Ticket filed.
https://issues.apache.org/jira/browse/KAFKA-15579
--
This is an automated message from the Apache Git Service.
To respond to the m
Calvin Liu created KAFKA-16479:
--
Summary: Add pagination supported describeTopic interface
Key: KAFKA-16479
URL: https://issues.apache.org/jira/browse/KAFKA-16479
Project: Kafka
Issue Type: Sub
[
https://issues.apache.org/jira/browse/KAFKA-15583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu resolved KAFKA-15583.
Resolution: Fixed
> High watermark can only advance if ISR size is larger than min ISR
> -
junrao commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1553959430
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
*
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long now
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long now
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1543454136
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1164,7 +1176,8 @@ public void maybeAutoCommitOffsetsAsync(long now
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1553899936
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1360,6 +1362,9 @@ public void commitSync(Map offsets, Duration
lianetm commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1553899936
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1360,6 +1362,9 @@ public void commitSync(Map offsets, Duration
lianetm commented on PR #15669:
URL: https://github.com/apache/kafka/pull/15669#issuecomment-2039970916
Hey @lucasbru, could you take a look at this when you have a chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
lianetm opened a new pull request, #15669:
URL: https://github.com/apache/kafka/pull/15669
Minor changes for improving the logging and docs related to the auto-commit
inflight logic, also adding tests to ensure the expected behaviour:
- auto-commit on the interval does not send a requ
divijvaidya closed pull request #15099: MINOR: Increase parallelism for Jenkins
URL: https://github.com/apache/kafka/pull/15099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
omkreddy merged PR #15665:
URL: https://github.com/apache/kafka/pull/15665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
omkreddy commented on PR #15665:
URL: https://github.com/apache/kafka/pull/15665#issuecomment-2039898497
Thanks for the Review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
viktorsomogyi commented on PR #15605:
URL: https://github.com/apache/kafka/pull/15605#issuecomment-2039754554
Aslo, thank you @akatona84 for the contribution, @soarez and @urbandan for
the reviews. Fixing flaky tests is always very welcomed, keep it up! 🙂
--
This is an automated message
FrankYang0529 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039753742
> > I think the class file size increasing is indeed a direct drawback after
adding -parameter option because we'll include all the parameters into .class
files. I'd like to know if
viktorsomogyi merged PR #15605:
URL: https://github.com/apache/kafka/pull/15605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
Philipp Trulson created KAFKA-16478:
---
Summary: Links for Kafka 3.5.2 release are broken
Key: KAFKA-16478
URL: https://issues.apache.org/jira/browse/KAFKA-16478
Project: Kafka
Issue Type: Bu
dajac commented on code in PR #15662:
URL: https://github.com/apache/kafka/pull/15662#discussion_r1553514811
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -761,6 +777,31 @@ public ClassicGroup classicGroup(
}
johnnychhsu commented on PR #15556:
URL: https://github.com/apache/kafka/pull/15556#issuecomment-2039670307
@vamossagar12 thanks for the comment.
sure! let's wait and monitor more builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dajac commented on code in PR #15587:
URL: https://github.com/apache/kafka/pull/15587#discussion_r1553499653
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2415,6 +2415,20 @@ private CoordinatorResult
classicGroupJoinExis
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553481594
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ConsumerGroupMigrationPolicy.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Found
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553480909
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -677,6 +679,7 @@ object KafkaConfig {
val ConsumerGroupMaxHeartbeatIntervalMsDoc = "The maximum heartbeat
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553477271
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -248,9 +249,10 @@ object KafkaConfig {
val ConsumerGroupMaxSessionTimeoutMsProp =
"group.consumer.max.ses
qinghui-xu commented on PR #7139:
URL: https://github.com/apache/kafka/pull/7139#issuecomment-2039564348
For me this should be merged even just for the sake of the codebase sanity.
I can try to rebase it and resolve the conflict to update the PR.
--
This is an automated message from the
chia7712 merged PR #15638:
URL: https://github.com/apache/kafka/pull/15638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834261#comment-17834261
]
Johnny Hsu commented on KAFKA-16475:
hi [~cmccabe]
I am willing to work on this tic
[
https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu reassigned KAFKA-16475:
--
Assignee: Johnny Hsu
> Create unit test for TopicImageNode
>
chia7712 commented on PR #15668:
URL: https://github.com/apache/kafka/pull/15668#issuecomment-2039540752
@brandboat nice finding! Should we add the thread prefix to
https://github.com/apache/kafka/blob/a2ee0855ee5e73f3a74555d52294bb4acfd28945/core/src/test/scala/unit/kafka/utils/TestUtils.sc
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1553431953
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -289,10 +300,11 @@ class Partition(val topicPartition: TopicPartition,
delayedOperations: D
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1553431953
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -289,10 +300,11 @@ class Partition(val topicPartition: TopicPartition,
delayedOperations: D
OmniaGM commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1553428780
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -104,9 +104,19 @@ class DelayedOperations(topicPartition: TopicPartition,
object Partition {
private val
chia7712 commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1552954260
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -104,9 +104,19 @@ class DelayedOperations(topicPartition: TopicPartition,
object Partition {
private va
brandboat opened a new pull request, #15668:
URL: https://github.com/apache/kafka/pull/15668
related to KAFKA-16477,
After profiling the kafka tests, tons of `client-metrics-reaper` thread not
cleanup after BrokerServer shutdown.
The thread `client-metrics-reaper` comes from
[Cli
OmniaGM commented on PR #15335:
URL: https://github.com/apache/kafka/pull/15335#issuecomment-2039474182
> @OmniaGM , there is compilation error in jdk8_scala2.12 job. Could you
have a look?
>
> ```
> [2024-04-04T09:19:51.266Z] [Error]
/home/jenkins/jenkins-agent/workspace/Kafka_ka
Kuan Po Tseng created KAFKA-16477:
-
Summary: Detect thread leaked client-metrics-reaper in tests
Key: KAFKA-16477
URL: https://issues.apache.org/jira/browse/KAFKA-16477
Project: Kafka
Issue T
clolov commented on code in PR #15213:
URL: https://github.com/apache/kafka/pull/15213#discussion_r1553357069
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -47,6 +47,8 @@ public class ListOffsetsRequest extends AbstractRequest {
*
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2039443091
Heya @cadonna! I have rebased and hopefully addressed all of the first batch
of comments. The verifications which are missing are reported as
unnecessary/uncalled by Mockito, but if you th
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553349919
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1652,81 +1598,64 @@ public void shouldReInitializeTopologyWhenResuming(
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553347186
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -312,55 +302,40 @@ public void
shouldThrowLockExceptionIfFailedToLockSt
1 - 100 of 125 matches
Mail list logo
