Re: [PR] Kafka-16668: Add tags support in ClusterTestExtension [kafka]

2024-05-12 Thread via GitHub
chia7712 commented on PR #15861: URL: https://github.com/apache/kafka/pull/15861#issuecomment-2106748277 @johnnychhsu Please fix the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-16677) Replace ClusterType#ALL and ClusterType#DEFAULT by Array

2024-05-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16677. Fix Version/s: 3.8.0 Resolution: Fixed > Replace ClusterType#ALL and ClusterType#DE

Re: [PR] KAFKA-16654:Refactor kafka.test.annotation.Type and ClusterTestExtensions [kafka]

2024-05-12 Thread via GitHub
chia7712 commented on PR #15916: URL: https://github.com/apache/kafka/pull/15916#issuecomment-2106746824 @TaiJuWu please fix the conflicts :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-16677: Replace ClusterType#ALL and ClusterType#DEFAULT by Array [kafka]

2024-05-12 Thread via GitHub
chia7712 merged PR #15897: URL: https://github.com/apache/kafka/pull/15897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] fix KAFKA-16705:the flag "started" of RaftClusterInstance is false even though the cluster is started [kafka]

2024-05-12 Thread via GitHub
chia7712 commented on code in PR #15928: URL: https://github.com/apache/kafka/pull/15928#discussion_r1597930023 ## core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java: ## @@ -111,6 +111,9 @@ public List getAdditionalExtensions() { cluster.forma

Re: [PR] KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest [kafka]

2024-05-12 Thread via GitHub
kamalcph commented on code in PR #15885: URL: https://github.com/apache/kafka/pull/15885#discussion_r1597914357 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -153,6 +173,7 @@ public void run() { private void processC

[jira] [Assigned] (KAFKA-16705) the flag "started" of RaftClusterInstance is false even though the cluster is started

2024-05-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16705: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > the flag "started" of RaftClusterIn

Re: [PR] KAFKA-12216; Improve flaky test reporting [kafka]

2024-05-12 Thread via GitHub
github-actions[bot] commented on PR #14862: URL: https://github.com/apache/kafka/pull/14862#issuecomment-2106570754 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[jira] [Updated] (KAFKA-16709) alter logDir within broker might cause log cleanup hanging

2024-05-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16709: -- Summary: alter logDir within broker might cause log cleanup hanging (was: move logDir within broker m

[jira] [Created] (KAFKA-16709) move logDir within broker might cause log cleanup hanging

2024-05-12 Thread Luke Chen (Jira)
Luke Chen created KAFKA-16709: - Summary: move logDir within broker might cause log cleanup hanging Key: KAFKA-16709 URL: https://issues.apache.org/jira/browse/KAFKA-16709 Project: Kafka Issue Typ

[jira] [Commented] (KAFKA-16705) the flag "started" of RaftClusterInstance is false even though the cluster is started

2024-05-12 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845775#comment-17845775 ] xuanzhang gong commented on KAFKA-16705: I will fix the bug. please ticketd me

[PR] fix KAFKA-16705:the flag "started" of RaftClusterInstance is false even though the cluster is started [kafka]

2024-05-12 Thread via GitHub
gongxuanzhang opened a new pull request, #15928: URL: https://github.com/apache/kafka/pull/15928 the flag "started" of RaftClusterInstance is false even though the cluster is started -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-16654:Refactor kafka.test.annotation.Type and ClusterTestExtensions [kafka]

2024-05-12 Thread via GitHub
chia7712 commented on code in PR #15916: URL: https://github.com/apache/kafka/pull/15916#discussion_r1597801203 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -140,8 +141,38 @@ private void generateClusterConfigurations(ExtensionContext context, String

[jira] [Commented] (KAFKA-16603) Data loss when kafka connect sending data to Kafka

2024-05-12 Thread Anil Dasari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845765#comment-17845765 ] Anil Dasari commented on KAFKA-16603: - [~ChrisEgerton] The data loss problem in the

Re: [PR] KAFKA-16654:Refactor kafka.test.annotation.Type and ClusterTestExtensions [kafka]

2024-05-12 Thread via GitHub
TaiJuWu commented on code in PR #15916: URL: https://github.com/apache/kafka/pull/15916#discussion_r1597748792 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -93,24 +92,19 @@ public Stream provideTestTemplateInvocationContex // Process the @Cl

Re: [PR] KAFKA-16654:Refactor kafka.test.annotation.Type and ClusterTestExtensions [kafka]

2024-05-12 Thread via GitHub
TaiJuWu commented on code in PR #15916: URL: https://github.com/apache/kafka/pull/15916#discussion_r1597748550 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -140,8 +141,38 @@ private void generateClusterConfigurations(ExtensionContext context, String

[jira] [Updated] (KAFKA-16708) Allow dynamic port for advertised listeners in Docker image

2024-05-12 Thread Chris Bono (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Bono updated KAFKA-16708: --- Description: First of all, thank you all for adding the official Kafka Docker image (I know it is a

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-12 Thread via GitHub
emitskevich-blp commented on PR #15889: URL: https://github.com/apache/kafka/pull/15889#issuecomment-2106339696 @chia7712 @junrao maybe you can take a look here? Not invasive change, test failures are not related to PR changes -- This is an automated message from the Apache Git Service. T

[jira] [Created] (KAFKA-16708) Allow dynamic port for advertised listeners in Docker image

2024-05-12 Thread Chris Bono (Jira)
Chris Bono created KAFKA-16708: -- Summary: Allow dynamic port for advertised listeners in Docker image Key: KAFKA-16708 URL: https://issues.apache.org/jira/browse/KAFKA-16708 Project: Kafka Issu

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597682003 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -181,7 +189,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,

[jira] [Updated] (KAFKA-16707) Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of connected client in order to defined ACL with a notion of group

2024-05-12 Thread Franck LEDAY (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Franck LEDAY updated KAFKA-16707: - Summary: Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of

[jira] [Updated] (KAFKA-16707) Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of connected client

2024-05-12 Thread Franck LEDAY (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Franck LEDAY updated KAFKA-16707: - Description: Default StandardAuthorizer in Kraft mode is defining a KafkaPrincpal as type=User

[jira] [Updated] (KAFKA-16707) Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of connected client

2024-05-12 Thread Franck LEDAY (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Franck LEDAY updated KAFKA-16707: - Issue Type: Improvement (was: New Feature) > Kafka Kraft : adding Principal Type in StandardACL

[jira] [Updated] (KAFKA-16707) Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of connected client

2024-05-12 Thread Franck L. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Franck L. updated KAFKA-16707: -- Remaining Estimate: 168h Original Estimate: 168h I would like to be assignee to this issue as I a

[jira] [Created] (KAFKA-16707) Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of connected client

2024-05-12 Thread Franck L. (Jira)
Franck L. created KAFKA-16707: - Summary: Kafka Kraft : adding Principal Type in StandardACL for matching with KafkaPrincipal of connected client Key: KAFKA-16707 URL: https://issues.apache.org/jira/browse/KAFKA-16707

Re: [PR] KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest [kafka]

2024-05-12 Thread via GitHub
gaurav-narula commented on code in PR #15885: URL: https://github.com/apache/kafka/pull/15885#discussion_r1597672575 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -153,6 +173,7 @@ public void run() { private void pro

[jira] [Created] (KAFKA-16706) Refactor ReplicationQuotaManager/RLMQuotaManager to eliminate code duplication

2024-05-12 Thread Abhijeet Kumar (Jira)
Abhijeet Kumar created KAFKA-16706: -- Summary: Refactor ReplicationQuotaManager/RLMQuotaManager to eliminate code duplication Key: KAFKA-16706 URL: https://issues.apache.org/jira/browse/KAFKA-16706 Pr

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597667627 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597667613 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597666914 ## core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-05-12 Thread via GitHub
abhijeetk88 commented on code in PR #15625: URL: https://github.com/apache/kafka/pull/15625#discussion_r1597664809 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -143,6 +143,38 @@ public final class RemoteLogManagerConfig {

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-12 Thread via GitHub
apoorvmittal10 commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2106239456 Thanks @gaurav-narula for fixing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-12 Thread via GitHub
m1a2st commented on code in PR #15779: URL: https://github.com/apache/kafka/pull/15779#discussion_r1597629743 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -62,506 +91,787 @@ * - scope=topics+partitions, scenario=to-earli

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-12 Thread via GitHub
FrankYang0529 commented on code in PR #15779: URL: https://github.com/apache/kafka/pull/15779#discussion_r1597626926 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -62,506 +91,787 @@ * - scope=topics+partitions, scenario=t

Re: [PR] KAFKA-16574: The metrics of LogCleaner disappear after reconfiguration [kafka]

2024-05-12 Thread via GitHub
chiacyu commented on code in PR #15863: URL: https://github.com/apache/kafka/pull/15863#discussion_r1597619075 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig, time: Time = Time.SYSTEM) ext

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-12 Thread via GitHub
m1a2st commented on code in PR #15779: URL: https://github.com/apache/kafka/pull/15779#discussion_r1597596564 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -62,506 +91,787 @@ * - scope=topics+partitions, scenario=to-earli

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-12 Thread via GitHub
m1a2st commented on code in PR #15779: URL: https://github.com/apache/kafka/pull/15779#discussion_r1597596564 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -62,506 +91,787 @@ * - scope=topics+partitions, scenario=to-earli

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-12 Thread via GitHub
m1a2st commented on code in PR #15779: URL: https://github.com/apache/kafka/pull/15779#discussion_r1597596564 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -62,506 +91,787 @@ * - scope=topics+partitions, scenario=to-earli

Re: [PR] Update subscriptions at the end. [kafka]

2024-05-12 Thread via GitHub
michaldo commented on PR #14720: URL: https://github.com/apache/kafka/pull/14720#issuecomment-2106149767 please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un