Re: [PR] KAFKA-14509: [4/4] Handle includeAuthorizedOperations [kafka]

2024-06-03 Thread via GitHub
riedelmax commented on code in PR #16158: URL: https://github.com/apache/kafka/pull/16158#discussion_r1625394359 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -7086,6 +7086,7 @@ class KafkaApisTest extends Logging { def testConsumerGroupDescribe(): Unit

Re: [PR] KAFKA-14509: [4/4] Handle includeAuthorizedOperations [kafka]

2024-06-03 Thread via GitHub
riedelmax commented on PR #16158: URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146678085 @chia7712 im not sure if I understand you correctlu. We have some integration tests in `ConsumerGroupDescribeRequestTest` -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-16880 : Update equals and hashcode methods for two attributes [kafka]

2024-06-03 Thread via GitHub
chia7712 merged PR #16173: URL: https://github.com/apache/kafka/pull/16173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-14509: [4/4] Handle includeAuthorizedOperations [kafka]

2024-06-03 Thread via GitHub
chia7712 commented on PR #16158: URL: https://github.com/apache/kafka/pull/16158#issuecomment-2146691340 > We have some integration tests in ConsumerGroupDescribeRequestTest thanks for this reminder. I neglect that before :( -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-16664: Re-add EventAccumulator.poll(long, TimeUnit) [kafka]

2024-06-03 Thread via GitHub
dajac merged PR #16144: URL: https://github.com/apache/kafka/pull/16144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16664: Re-add EventAccumulator.poll(long, TimeUnit) [kafka]

2024-06-03 Thread via GitHub
dajac commented on PR #16144: URL: https://github.com/apache/kafka/pull/16144#issuecomment-2146713066 Merged to trunk and to 3.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-16821: Member Subscription Spec Interface [kafka]

2024-06-03 Thread via GitHub
dajac commented on code in PR #16068: URL: https://github.com/apache/kafka/pull/16068#discussion_r1625434453 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -271,18 +277,17 @@ public void testCreateAssignment

[jira] [Resolved] (KAFKA-16715) Create KafkaShareConsumer interface

2024-06-03 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-16715. -- Resolution: Fixed > Create KafkaShareConsumer interface >

Re: [PR] KAFKA-16583: Handle PartitionChangeRecord without directory IDs [kafka]

2024-06-03 Thread via GitHub
showuon commented on PR #16118: URL: https://github.com/apache/kafka/pull/16118#issuecomment-2146749642 I was trying to know the root cause of this problem, that why does it fail after upgrade, but not fail without upgrade. My understanding is that because before upgrade, the topic image do

[PR] MINOR: Log time taken to compute the target assignment [kafka]

2024-06-03 Thread via GitHub
dajac opened a new pull request, #16185: URL: https://github.com/apache/kafka/pull/16185 The time taken to compute a new assignment is critical. This patches extending the existing logging to log it too. This is very useful information to have. ### Committer Checklist (excluded from

<    1   2   3   4