showuon commented on PR #16260:
URL: https://github.com/apache/kafka/pull/16260#issuecomment-2157472921
I confirmed if we ran the distribution (i.e. `./gradlew clean
releaseTarGz`), everything still works well. This issue only impact users using
`./gradlew clean jar` to run kafka.
--
Thi
omkreddy merged PR #16226:
URL: https://github.com/apache/kafka/pull/16226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16260:
URL: https://github.com/apache/kafka/pull/16260#issuecomment-2157439747
The reload4j is introduced by streams example, and that works in
distribution.
However, "./gradlew jar" does not work since we don't include dependent-libs
of stream example.
VedarthConfluent commented on code in PR #16224:
URL: https://github.com/apache/kafka/pull/16224#discussion_r1632644776
##
docker/docker_official_images/3.7.0/jvm/Dockerfile:
##
@@ -0,0 +1,95 @@
+###
+#
dajac commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2157411292
Merged trunk to include https://github.com/apache/kafka/pull/16249.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
omkreddy closed pull request #14556: [WIP]KAFKA-15444: Native docker image
URL: https://github.com/apache/kafka/pull/14556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
omkreddy commented on PR #16212:
URL: https://github.com/apache/kafka/pull/16212#issuecomment-2157321710
There are few test failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
[
https://issues.apache.org/jira/browse/KAFKA-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853549#comment-17853549
]
Ksolves commented on KAFKA-16803:
-
Sure, [~gharris1727]. Will create PR and update you.
[
https://issues.apache.org/jira/browse/KAFKA-16803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ksolves reassigned KAFKA-16803:
---
Assignee: Ksolves
> Upgrade to a version of ShadowJavaPlugin which doesn't use ConfigureUtil
>
[
https://issues.apache.org/jira/browse/KAFKA-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16924:
--
Description:
In [https://github.com/apache/kafka/pull/12148] , we removed log4jAppender
dependency, a
chia7712 commented on code in PR #16260:
URL: https://github.com/apache/kafka/pull/16260#discussion_r1632550895
##
build.gradle:
##
@@ -2178,6 +2177,7 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
implemen
github-actions[bot] commented on PR #15172:
URL: https://github.com/apache/kafka/pull/15172#issuecomment-2157136679
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15421:
URL: https://github.com/apache/kafka/pull/15421#issuecomment-2157136573
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15451:
URL: https://github.com/apache/kafka/pull/15451#issuecomment-2157136549
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
frankvicky commented on PR #16227:
URL: https://github.com/apache/kafka/pull/16227#issuecomment-2157060477
Hi @chia7712 , I have do some changes and add a test case, PTAL 🐧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-16913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Sadanala reassigned KAFKA-16913:
---
Assignee: Ganesh Sadanala
> Support external schemas in JSONConverter
> ---
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632484396
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
i
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632484236
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
i
frankvicky commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632481576
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
i
frankvicky commented on PR #16250:
URL: https://github.com/apache/kafka/pull/16250#issuecomment-2157010773
Hi @chia7712, I have do a simple change based on your feedback, PTAL 😸
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
frankvicky commented on code in PR #16250:
URL: https://github.com/apache/kafka/pull/16250#discussion_r1632479332
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2760,9 +2760,12 @@ void handleFailure(Throwable throwable) {
}, no
showuon commented on PR #16260:
URL: https://github.com/apache/kafka/pull/16260#issuecomment-2156996030
@chia7712 , could you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/KAFKA-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16924:
--
Description:
In [https://github.com/apache/kafka/pull/12148] , we removed log4jAppender
dependency, a
[
https://issues.apache.org/jira/browse/KAFKA-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16924:
--
Description:
In https://github.com/apache/kafka/pull/12148 , we removed log4jAppender
dependency, and
showuon opened a new pull request, #16260:
URL: https://github.com/apache/kafka/pull/16260
In https://github.com/apache/kafka/pull/12148 , we removed log4jAppender
dependency, and add testImplementation dependency for `slf4jlog4j` lib.
However, we need this runtime dependency in tools modul
Luke Chen created KAFKA-16924:
-
Summary: No log output when running kafka
Key: KAFKA-16924
URL: https://issues.apache.org/jira/browse/KAFKA-16924
Project: Kafka
Issue Type: Bug
Repor
[
https://issues.apache.org/jira/browse/KAFKA-16923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853543#comment-17853543
]
Arnav Dadarya commented on KAFKA-16923:
---
I have submitted a pull request
([https:
[
https://issues.apache.org/jira/browse/KAFKA-16923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arnav Dadarya updated KAFKA-16923:
--
Description:
I have written 1 new unit test and modified another unit test.
Created new test:
[
https://issues.apache.org/jira/browse/KAFKA-16923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arnav Dadarya updated KAFKA-16923:
--
Description:
I have written 1 new unit test
Created new test: *testStripDotPathComponents*
*
[ https://issues.apache.org/jira/browse/KAFKA-16923 ]
Arnav Dadarya deleted comment on KAFKA-16923:
---
was (Author: JIRAUSER303990):
https://github.com/apache/kafka/pull/16258
> New Unit Test for stripDotPathComponents method
>
[
https://issues.apache.org/jira/browse/KAFKA-16923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arnav Dadarya updated KAFKA-16923:
--
Description:
I have written 1 new unit test and modified another unit test.
Created new test:
[
https://issues.apache.org/jira/browse/KAFKA-16923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arnav Dadarya updated KAFKA-16923:
--
External issue URL: https://github.com/apache/kafka/pull/16259 (was:
https://github.com/apach
ardada2468 commented on PR #16259:
URL: https://github.com/apache/kafka/pull/16259#issuecomment-2156909921
only
shell/src/test/java/org/apache/kafka/shell/command/CommandUtilsTest.java file
has been changed to incorporate 1 more unit test
--
This is an automated message from the Apache G
ardada2468 opened a new pull request, #16259:
URL: https://github.com/apache/kafka/pull/16259
I have written 1 new unit test and modified another unit test.
Created new test: **testStripDotPathComponents**
- Tests the stripDotPathComponents found in CommandUtils
- Ensures tha
ardada2468 closed pull request #16258: Created a new unit test for
stripDotPathComponents method and updated…
URL: https://github.com/apache/kafka/pull/16258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
Arnav Dadarya created KAFKA-16923:
-
Summary: New Unit Test for stripDotPathComponents method
Key: KAFKA-16923
URL: https://issues.apache.org/jira/browse/KAFKA-16923
Project: Kafka
Issue Type:
ardada2468 opened a new pull request, #16258:
URL: https://github.com/apache/kafka/pull/16258
I have written 1 new unit test and modified another unit test.
Created new test: **testStripDotPathComponents**
- Tests the stripDotPathComponents found in CommandUtils
- Ensure
chia7712 commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632396978
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
OmniaGM commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632391480
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853535#comment-17853535
]
Muralidhar Basani edited comment on KAFKA-16855 at 6/9/24 8:30 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853535#comment-17853535
]
Muralidhar Basani commented on KAFKA-16855:
---
[~christo_lolov] I tried to work
muralibasani opened a new pull request, #16257:
URL: https://github.com/apache/kafka/pull/16257
Resolves : https://issues.apache.org/jira/browse/KAFKA-16855
- Add field tieredEpoch to RemoteLogSegmentMetadata
- Update relevant tests
- Add two fields tieredEpoch and tieredState t
chia7712 commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632376721
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {
co
jeremyvdw commented on PR #15615:
URL: https://github.com/apache/kafka/pull/15615#issuecomment-2156746613
@mjsax According to the [release
plan](https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+3.8.0)
code freeze nis on 12th June: any chance this one and
https://github.com/ap
muralibasani commented on code in PR #16255:
URL: https://github.com/apache/kafka/pull/16255#discussion_r1632371896
##
clients/src/test/java/org/apache/kafka/clients/admin/NewTopicTest.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
muralibasani commented on code in PR #16255:
URL: https://github.com/apache/kafka/pull/16255#discussion_r1632371830
##
clients/src/test/java/org/apache/kafka/clients/admin/NewTopicTest.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
muralibasani commented on code in PR #16255:
URL: https://github.com/apache/kafka/pull/16255#discussion_r1632371782
##
clients/src/test/java/org/apache/kafka/clients/admin/NewTopicTest.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
TaiJuWu commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632369365
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {
con
dopuskh3 commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632367056
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2038,6 +2038,69 @@ public void testDeletionOnRetentionBreachedSegments(long
retentionSize,
dopuskh3 commented on code in PR #16237:
URL: https://github.com/apache/kafka/pull/16237#discussion_r1632367056
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2038,6 +2038,69 @@ public void testDeletionOnRetentionBreachedSegments(long
retentionSize,
chia7712 commented on code in PR #16255:
URL: https://github.com/apache/kafka/pull/16255#discussion_r1632366297
##
clients/src/test/java/org/apache/kafka/clients/admin/NewTopicTest.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
chia7712 commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632364409
##
storage/src/test/java/org/apache/kafka/storage/internals/log/OffsetIndexTest.java:
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
[
https://issues.apache.org/jira/browse/KAFKA-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16885.
Fix Version/s: 3.9.0
Resolution: Fixed
> Consider renaming RemoteLogManagerConfig#e
chia7712 merged PR #16256:
URL: https://github.com/apache/kafka/pull/16256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #16250:
URL: https://github.com/apache/kafka/pull/16250#discussion_r1632361233
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2760,9 +2760,12 @@ void handleFailure(Throwable throwable) {
}, now)
chia7712 commented on PR #16253:
URL: https://github.com/apache/kafka/pull/16253#issuecomment-2156719721
@m1a2st Could you please split this PR into small PRs (similar to #16253)?
It is hard to complete the migration (and review) at once.
--
This is an automated message from the Apache Gi
chia7712 commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632360489
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
chia7712 commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632358879
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
chia7712 commented on code in PR #16231:
URL: https://github.com/apache/kafka/pull/16231#discussion_r1632358803
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ConcurrentMapBenchmark.java:
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
chia7712 commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632358372
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory,
private final Te
chia7712 commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632358211
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {
co
chia7712 commented on code in PR #16227:
URL: https://github.com/apache/kafka/pull/16227#discussion_r1632355536
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerRecordsTest.java:
##
@@ -31,32 +31,129 @@
import org.apache.kafka.common.record.TimestampType;
imp
dopuskh3 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2156701940
@kamalcph updated test case. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/KAFKA-16919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853511#comment-17853511
]
Muralidhar Basani commented on KAFKA-16919:
---
[~soarez] I suspect there could b
dopuskh3 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2156696910
> @dopuskh3
>
> Any updates on this?
Should be able to give it a try tomorrow. Pulling the fix on our internal
branch right now.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-15166:
-
Fix Version/s: (was: 3.8.0)
> Add deletePartition API to the RemoteStorageMa
[
https://issues.apache.org/jira/browse/KAFKA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash resolved KAFKA-15777.
--
Resolution: Won't Fix
> Configurable remote fetch bytes per partition from Con
OmniaGM commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632251507
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
m1a2st commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632348365
##
storage/src/test/java/org/apache/kafka/storage/internals/log/OffsetIndexTest.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156662574
I prefer to check all failed tests before merging. And the last commit of
this PR does not have completed CI. That is why I suggest to rebase code to
trigger QA again.
--
This is an a
brandboat commented on code in PR #16231:
URL: https://github.com/apache/kafka/pull/16231#discussion_r1632327595
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/util/ConcurrentMapBenchmark.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
chia7712 commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156661854
@riedelmax #16249 fix the blocked tests. Without that fix, the CI will get
timeout when running your PR
--
This is an automated message from the Apache Git Service.
To respond to the m
OmniaGM commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632251507
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632316732
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -817,6 +817,119 @@ class DynamicBrokerConfigTest {
Mockito.verifyNoMoreInteractions(
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632316363
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -817,6 +817,119 @@ class DynamicBrokerConfigTest {
Mockito.verifyNoMoreInteractions(
kamalcph commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2156632862
@dopuskh3
Any updates on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-16401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gendong1 updated KAFKA-16401:
-
Description:
The cluster consists of 3 nodes. When the storeOffsets is delay due to
fail-slow disk, the
chiacyu opened a new pull request, #16256:
URL: https://github.com/apache/kafka/pull/16256
This PR is based on
[KAFKA-16885](https://issues.apache.org/jira/browse/KAFKA-16885). See the
[discussion](https://github.com/apache/kafka/pull/16153#issuecomment-2144269279)
for further details.
riedelmax commented on PR #16158:
URL: https://github.com/apache/kafka/pull/16158#issuecomment-2156601592
@chia7712 would you mind to explain how #16249 effects this PR? if there are
no conflicts with trunk i dont need to rebase or merge manually right?
--
This is an automated message fro
[
https://issues.apache.org/jira/browse/KAFKA-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853493#comment-17853493
]
Chia Chuan Yu commented on KAFKA-16885:
---
Hi, [~ckamal]
Yes, I'm working on this
[
https://issues.apache.org/jira/browse/KAFKA-16885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853492#comment-17853492
]
Kamal Chandraprakash commented on KAFKA-16885:
--
[~chiacyu]
Are you workin
OmniaGM commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632251507
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
OmniaGM commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1632251507
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,420 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
muralibasani commented on PR #16255:
URL: https://github.com/apache/kafka/pull/16255#issuecomment-2156419270
@chia7712 can you pls take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632220708
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1165,43 +1165,66 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurab
kamalcph commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1632220708
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1165,43 +1165,66 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurab
muralibasani opened a new pull request, #16255:
URL: https://github.com/apache/kafka/pull/16255
Resolves https://issues.apache.org/jira/browse/KAFKA-16922
Adding unit tests for org.apache.kafka.clients.admin.NewTopic
### Committer Checklist (excluded from commit message)
- [X
kamalcph commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1632218079
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2730,6 +2742,206 @@ public void testEpochEntriesAsByteBuffer() throws
Exception {
}
FrankYang0529 opened a new pull request, #16254:
URL: https://github.com/apache/kafka/pull/16254
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of t
kamalcph commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1632218079
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2730,6 +2742,206 @@ public void testEpochEntriesAsByteBuffer() throws
Exception {
}
TaiJuWu commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632215976
##
storage/src/test/java/org/apache/kafka/storage/internals/log/OffsetIndexTest.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
TaiJuWu commented on code in PR #16244:
URL: https://github.com/apache/kafka/pull/16244#discussion_r1632215976
##
storage/src/test/java/org/apache/kafka/storage/internals/log/OffsetIndexTest.java:
##
@@ -0,0 +1,268 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
[
https://issues.apache.org/jira/browse/KAFKA-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Muralidhar Basani reassigned KAFKA-16922:
-
Assignee: Muralidhar Basani (was: Chia-Ping Tsai)
> add unit test for NewTopic
TaiJuWu commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632204289
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory,
private final Tes
TaiJuWu commented on code in PR #16127:
URL: https://github.com/apache/kafka/pull/16127#discussion_r1632203912
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {
con
chickenchickenlove commented on code in PR #15926:
URL: https://github.com/apache/kafka/pull/15926#discussion_r1632188911
##
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##
@@ -165,6 +165,8 @@ static ControllerResult recordsForNonEmptyLog(
96 matches
Mail list logo
