Re: [PR] KAFKA-16946: Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port [kafka]

2024-06-12 Thread via GitHub
frankvicky commented on PR #16319: URL: https://github.com/apache/kafka/pull/16319#issuecomment-2164695371 Hi @showuon, I have refactor the test case by utilizing `@CsvSource`, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-15623: Migrate streams tests (part 1) module to JUnit 5 [kafka]

2024-06-12 Thread via GitHub
FrankYang0529 commented on PR #16254: URL: https://github.com/apache/kafka/pull/16254#issuecomment-2164633695 Hi @chia7712, I addressed all comments. May you take a look? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-15623: Migrate streams tests (part 1) module to JUnit 5 [kafka]

2024-06-12 Thread via GitHub
FrankYang0529 commented on code in PR #16254: URL: https://github.com/apache/kafka/pull/16254#discussion_r1637632275 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java: ## @@ -87,48 +85,45 @@ import static org.hamcrest.Cor

[jira] [Resolved] (KAFKA-16901) add unit tests for ConsumerRecords#records(String)

2024-06-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16901. Fix Version/s: 3.9.0 Resolution: Fixed > add unit tests for ConsumerRecords#records

Re: [PR] KAFKA-16901: Add unit tests for ConsumerRecords#records(String) [kafka]

2024-06-12 Thread via GitHub
chia7712 merged PR #16227: URL: https://github.com/apache/kafka/pull/16227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-10787: Apply spotless to `group-coordinator` and `group-coordinator-api` [kafka]

2024-06-12 Thread via GitHub
gongxuanzhang commented on PR #16298: URL: https://github.com/apache/kafka/pull/16298#issuecomment-2164609081 > @gongxuanzhang please add `spotlessJava.dependsOn 'processMessages'` to the module having `processMessages` task. Otherwise, spotless may ignore those generated code I upda

Re: [PR] MINOR: Improving log for outstanding requests on close and cleanup [kafka]

2024-06-12 Thread via GitHub
chia7712 merged PR #16304: URL: https://github.com/apache/kafka/pull/16304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16803: Update ShadowJavaPlugin [kafka]

2024-06-12 Thread via GitHub
Nancy-ksolves commented on code in PR #16295: URL: https://github.com/apache/kafka/pull/16295#discussion_r1637621152 ## build.gradle: ## @@ -46,7 +46,7 @@ plugins { id 'org.scoverage' version '8.0.3' apply false // Updating the shadow plugin version to 8.1.1 causes issue w

Re: [PR] KAFKA-16772: Introduce kraft.version to support KIP-853 [kafka]

2024-06-12 Thread via GitHub
dengziming commented on code in PR #16230: URL: https://github.com/apache/kafka/pull/16230#discussion_r1637473020 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java: ## @@ -116,6 +139,34 @@ public BootstrapMetadata copyWithOnlyVersion() {

Re: [PR] KAFKA-16946: Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port [kafka]

2024-06-12 Thread via GitHub
frankvicky commented on code in PR #16319: URL: https://github.com/apache/kafka/pull/16319#discussion_r1637598927 ## clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java: ## @@ -113,16 +113,26 @@ public void testGetHost() { assertEquals("mydomain.com", get

Re: [PR] KAFKA-16892: fix TopicsDelta generated from snapshot #localChanges return empty deletes [kafka]

2024-06-12 Thread via GitHub
superhx commented on PR #16206: URL: https://github.com/apache/kafka/pull/16206#issuecomment-2164505170 @showuon Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-16946: Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port [kafka]

2024-06-12 Thread via GitHub
showuon commented on code in PR #16319: URL: https://github.com/apache/kafka/pull/16319#discussion_r1637590625 ## clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java: ## @@ -113,16 +113,26 @@ public void testGetHost() { assertEquals("mydomain.com", getHos

Re: [PR] KAFKA-16946: Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port [kafka]

2024-06-12 Thread via GitHub
showuon commented on code in PR #16319: URL: https://github.com/apache/kafka/pull/16319#discussion_r1637590625 ## clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java: ## @@ -113,16 +113,26 @@ public void testGetHost() { assertEquals("mydomain.com", getHos

Re: [PR] KAFKA-16752: Implemented acquire functionality for Fetch (KIP-932) [kafka]

2024-06-12 Thread via GitHub
adixitconfluent commented on code in PR #16274: URL: https://github.com/apache/kafka/pull/16274#discussion_r1637579381 ## core/src/main/java/kafka/server/SharePartition.java: ## @@ -310,126 +485,361 @@ private void initialize() { // TODO: Provide implementation to initi

Re: [PR] KAFKA-16752: Implemented acquire functionality for Fetch (KIP-932) [kafka]

2024-06-12 Thread via GitHub
adixitconfluent commented on code in PR #16274: URL: https://github.com/apache/kafka/pull/16274#discussion_r1637574165 ## core/src/main/java/kafka/server/SharePartition.java: ## @@ -54,6 +60,7 @@ public class SharePartition { * The state of the records determines if the re

Re: [PR] KAFKA-16948: Reset tier lag metrics on becoming follower [kafka]

2024-06-12 Thread via GitHub
kamalcph commented on PR #16321: URL: https://github.com/apache/kafka/pull/16321#issuecomment-2164410837 @dopuskh3 Call for review. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] KAFKA-16948: Reset tier lag metrics on becoming follower [kafka]

2024-06-12 Thread via GitHub
kamalcph opened a new pull request, #16321: URL: https://github.com/apache/kafka/pull/16321 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade note

[jira] [Created] (KAFKA-16948) Reset tier lag metrics on becoming follower

2024-06-12 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-16948: Summary: Reset tier lag metrics on becoming follower Key: KAFKA-16948 URL: https://issues.apache.org/jira/browse/KAFKA-16948 Project: Kafka I

Re: [PR] KAFKA-16747: Implemented share sessions and contexts for share fetch requests [kafka]

2024-06-12 Thread via GitHub
adixitconfluent commented on code in PR #16263: URL: https://github.com/apache/kafka/pull/16263#discussion_r1637556905 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -0,0 +1,916 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16747: Implemented share sessions and contexts for share fetch requests [kafka]

2024-06-12 Thread via GitHub
adixitconfluent commented on code in PR #16263: URL: https://github.com/apache/kafka/pull/16263#discussion_r1637549886 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -0,0 +1,418 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16862: Refactor ConsumerTaskTest to be deterministic and avoid tight loops [kafka]

2024-06-12 Thread via GitHub
xiaoqingwanga commented on PR #16303: URL: https://github.com/apache/kafka/pull/16303#issuecomment-2164374450 @gharris1727 Thank you very much for your suggestion! I have made another commit, resolving the issue mentioned above. -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-15045: (KIP-924 pt. 24) Correct stateful task flagging [kafka]

2024-06-12 Thread via GitHub
apourchet closed pull request #16314: KAFKA-15045: (KIP-924 pt. 24) Correct stateful task flagging URL: https://github.com/apache/kafka/pull/16314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [WIP] Delayed remote list offsets [kafka]

2024-06-12 Thread via GitHub
kamalcph opened a new pull request, #16320: URL: https://github.com/apache/kafka/pull/16320 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

Re: [PR] MINOR: Add readiness check for connector and separate Kafka cluster in ExactlyOnceSourceIntegrationTest::testSeparateOffsetsTopic [kafka]

2024-06-12 Thread via GitHub
C0urante merged PR #16306: URL: https://github.com/apache/kafka/pull/16306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-06-12 Thread via GitHub
github-actions[bot] commented on PR #15188: URL: https://github.com/apache/kafka/pull/15188#issuecomment-2164295049 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-16531: calculate check-quorum when leader is not in voter set [kafka]

2024-06-12 Thread via GitHub
showuon commented on PR #16211: URL: https://github.com/apache/kafka/pull/16211#issuecomment-2164292176 @chia7712 , thanks for the review. PR updated in this commit: https://github.com/apache/kafka/pull/16211/commits/7db45c2e8f08b4a381717b4c6b7f466bd116cd4e . Thanks. -- This is an automa

Re: [PR] KAFKA-16531: calculate check-quorum when leader is not in voter set [kafka]

2024-06-12 Thread via GitHub
showuon commented on code in PR #16211: URL: https://github.com/apache/kafka/pull/16211#discussion_r1637455856 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -126,8 +127,13 @@ public long timeUntilCheckQuorumExpires(long currentTimeMs) { */ publi

Re: [PR] KAFKA-16531: calculate check-quorum when leader is not in voter set [kafka]

2024-06-12 Thread via GitHub
showuon commented on code in PR #16211: URL: https://github.com/apache/kafka/pull/16211#discussion_r1637455387 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -111,9 +111,10 @@ public long timeUntilCheckQuorumExpires(long currentTimeMs) { long remai

[jira] [Commented] (KAFKA-12480) Reuse bootstrap servers in clients when last alive broker in cluster metadata is unavailable

2024-06-12 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854611#comment-17854611 ] Ivan Yurchenko commented on KAFKA-12480: With [KIP-899|https://cwiki.apache.org

[jira] [Commented] (KAFKA-13467) Clients never refresh cached bootstrap IPs

2024-06-12 Thread Ivan Yurchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854612#comment-17854612 ] Ivan Yurchenko commented on KAFKA-13467: With [KIP-899|https://cwiki.apache.org

[jira] [Commented] (KAFKA-16781) Expose advertised.listeners in controller node

2024-06-12 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854610#comment-17854610 ] TengYao Chi commented on KAFKA-16781: - Hi [~tinaselenge] feel free to take this if y

[jira] [Assigned] (KAFKA-14507) Add ConsumerGroupPrepareAssignment API

2024-06-12 Thread dujian0068 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian0068 reassigned KAFKA-14507: -- Assignee: dujian0068 > Add ConsumerGroupPrepareAssignment API > -

[jira] [Assigned] (KAFKA-14705) Remove deprecated options and redirections

2024-06-12 Thread dujian0068 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian0068 reassigned KAFKA-14705: -- Assignee: dujian0068 > Remove deprecated options and redirections > -

[jira] [Commented] (KAFKA-16941) Flaky test - testDynamicBrokerConfigUpdateUsingKraft [1] Type=Raft-Combined, MetadataVersion=4.0-IV0,Security=PLAINTEXT – kafka.admin.ConfigCommandIntegrationTest

2024-06-12 Thread Lin Siyuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854604#comment-17854604 ] Lin Siyuan commented on KAFKA-16941: I'm a newbie and I will do my best to find the

Re: [PR] KAFKA-16946: Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port [kafka]

2024-06-12 Thread via GitHub
frankvicky commented on PR #16319: URL: https://github.com/apache/kafka/pull/16319#issuecomment-2164259901 Hi @zhaochun-ma, @showuon I have fix the bug that regex can't correctly parse that connection string starting with `SASL_PLAINTEXT`. PTAL 😄 Special thanks to @zhaochun-ma findin

[PR] KAFKA-16946: Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port [kafka]

2024-06-12 Thread via GitHub
frankvicky opened a new pull request, #16319: URL: https://github.com/apache/kafka/pull/16319 In previous PR(#16048), I mistakenly excluded the underscore (_) from the set of valid characters for the protocol, resulting in the inability to correctly parse the connection string for SASL_PLAI

[jira] [Commented] (KAFKA-16913) Support external schemas in JSONConverter

2024-06-12 Thread Ganesh Sadanala (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854601#comment-17854601 ] Ganesh Sadanala commented on KAFKA-16913: - is there any documentation to be upda

[jira] [Commented] (KAFKA-16913) Support external schemas in JSONConverter

2024-06-12 Thread Ganesh Sadanala (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854600#comment-17854600 ] Ganesh Sadanala commented on KAFKA-16913: - PR is ready to review > Support exte

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-12 Thread via GitHub
kirktrue commented on PR #16310: URL: https://github.com/apache/kafka/pull/16310#issuecomment-2164238647 @AndrewJSchofield @cadonna @lianetm @philipnee—please review this PR. It's an alternative take on #16241 that seems simpler and not fraught with peril. Thanks! -- This is an aut

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-12 Thread via GitHub
kirktrue commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1637405808 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1983,6 +2009,10 @@ SubscriptionState subscriptions() { re

[PR] KAFKA-15045: (KIP-924 pt. 24) internal TaskAssignor rename to LegacyTaskAssignor [kafka]

2024-06-12 Thread via GitHub
apourchet opened a new pull request, #16318: URL: https://github.com/apache/kafka/pull/16318 Since the new public API for TaskAssignor shared a name, this rename will prevent users from confusing the internal definition with the public one. ### Committer Checklist (excluded from commi

Re: [PR] KAFKA-10787: Apply spotless to `raft` module [kafka]

2024-06-12 Thread via GitHub
gongxuanzhang commented on PR #16278: URL: https://github.com/apache/kafka/pull/16278#issuecomment-2164215470 > @gongxuanzhang you need to fix it again :) Ok,I'll fix it periodically before merging -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-16689: Move LogValidatorTest to storage module [kafka]

2024-06-12 Thread via GitHub
chia7712 commented on code in PR #16167: URL: https://github.com/apache/kafka/pull/16167#discussion_r1637373367 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java: ## @@ -0,0 +1,2100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [MINOR]:Update visibility from public to protected and adjust the order in BuiltInPartitioner [kafka]

2024-06-12 Thread via GitHub
gongxuanzhang commented on code in PR #16277: URL: https://github.com/apache/kafka/pull/16277#discussion_r1637379530 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -1033,10 +1033,18 @@ public Deque getDeque(TopicPartition tp)

[jira] [Commented] (KAFKA-16946) Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port

2024-06-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854595#comment-17854595 ] Luke Chen commented on KAFKA-16946: --- [~frankvicky] , this is a blocker for v3.8.0. Hop

[jira] [Updated] (KAFKA-16946) Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port

2024-06-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-16946: -- Fix Version/s: 3.8.0 > Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port > ---

[PR] KAFKA-16939: Revisit ConfigCommandIntegrationTest [kafka]

2024-06-12 Thread via GitHub
m1a2st opened a new pull request, #16317: URL: https://github.com/apache/kafka/pull/16317 https://issues.apache.org/jira/browse/KAFKA-16939 some secnario is wrong, so fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-16942 Use ConcurrentHashMap in RecordAccumulator#nodeStats [kafka]

2024-06-12 Thread via GitHub
gongxuanzhang commented on PR #16305: URL: https://github.com/apache/kafka/pull/16305#issuecomment-2164206281 I agree, with the development of Java, the performance of ConcurrentHashMap has indeed significantly improved -- This is an automated message from the Apache Git Service. To respo

Re: [PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-12 Thread via GitHub
mjsax commented on code in PR #16316: URL: https://github.com/apache/kafka/pull/16316#discussion_r1637372406 ## docs/streams/upgrade-guide.html: ## @@ -303,6 +303,62 @@ Streams API adds a new config default.client.supplier that allows to use a custom KafkaClientSupplier

[PR] MINOR: update Kafka Streams docs with 3.3 KIP information [kafka]

2024-06-12 Thread via GitHub
mjsax opened a new pull request, #16316: URL: https://github.com/apache/kafka/pull/16316 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

Re: [PR] KAFKA-12708 Rewrite org.apache.kafka.test.Microbenchmarks by JMH [kafka]

2024-06-12 Thread via GitHub
chia7712 commented on PR #16231: URL: https://github.com/apache/kafka/pull/16231#issuecomment-2164203749 @brandboat could you please remove `Microbenchmarks` from suppression file? https://github.com/apache/kafka/blob/6d1f8f8727e8f9c7071b83b7dd9feb840d8d661f/checkstyle/suppressions.xm

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-12 Thread via GitHub
philipnee commented on code in PR #16310: URL: https://github.com/apache/kafka/pull/16310#discussion_r1637370335 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1983,6 +2009,10 @@ SubscriptionState subscriptions() { r

[jira] [Resolved] (KAFKA-16938) non-dynamic props gets corrupted due to circular reference between DynamicBrokerConfig and DynamicConfig

2024-06-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16938. Resolution: Fixed > non-dynamic props gets corrupted due to circular reference between >

[jira] [Commented] (KAFKA-16944) Range assignor doesn't co-partition with stickiness

2024-06-12 Thread dujian0068 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854593#comment-17854593 ] dujian0068 commented on KAFKA-16944: Hello, does this problem need to be fixed quick

Re: [PR] KAFKA-16938: non-dynamic props gets corrupted due to circular reference between DynamicBrokerConfig and DynamicConfig. [kafka]

2024-06-12 Thread via GitHub
chia7712 merged PR #16302: URL: https://github.com/apache/kafka/pull/16302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-16946) Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port

2024-06-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854591#comment-17854591 ] Luke Chen commented on KAFKA-16946: --- Go ahead to fix it, [~frankvicky] ! > Utils.getH

[jira] [Assigned] (KAFKA-16946) Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port

2024-06-12 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-16946: - Assignee: TengYao Chi > Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port > ---

Re: [PR] MINOR: Clean up for KafkaAdminClientTest [kafka]

2024-06-12 Thread via GitHub
chia7712 merged PR #16285: URL: https://github.com/apache/kafka/pull/16285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16824: Utils.getHost and Utils.getPort do not catch a lot of invalid host and ports. [kafka]

2024-06-12 Thread via GitHub
cmccabe commented on PR #16048: URL: https://github.com/apache/kafka/pull/16048#issuecomment-2164187718 > @frankvicky looks like with this change, SASL_PLAINTEXT://localhost:50132 becomes invalid url because of _ in the protocol, and it's a breaking change, is this expected? definite

Re: [PR] KAFKA-16689: Move LogValidatorTest to storage module [kafka]

2024-06-12 Thread via GitHub
TaiJuWu commented on PR #16167: URL: https://github.com/apache/kafka/pull/16167#issuecomment-2164170657 @chia7712 Please take look! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINOR: Update 3.8 documentation for Kafka Streams [kafka]

2024-06-12 Thread via GitHub
ableegoldman commented on code in PR #16265: URL: https://github.com/apache/kafka/pull/16265#discussion_r1637334663 ## docs/streams/developer-guide/config-streams.html: ## @@ -441,8 +441,8 @@ num.standby.replicastask.assignor.class Medium -A task assigno

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-06-12 Thread via GitHub
kirktrue commented on PR #16241: URL: https://github.com/apache/kafka/pull/16241#issuecomment-2164161606 @lianetm @cadonna @AndrewJSchofield—PTAL at an alternate implementation of this Jira: #16310. Thanks! -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Updated] (KAFKA-13560) Load indexes and data in async manner in the critical path of replica fetcher threads.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-13560: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Load indexes and data in async ma

[jira] [Updated] (KAFKA-15300) Include remotelog size in complete log size and also add local log size and remote log size separately in kafka-log-dirs tool.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15300: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Include remotelog size in complet

[jira] [Updated] (KAFKA-15480) Add RemoteStorageInterruptedException

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15480: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Add RemoteStorageInterruptedExcep

[jira] [Updated] (KAFKA-15214) Add metrics for OffsetOutOfRangeException when tiered storage is enabled

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15214: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Add metrics for OffsetOutOfRangeE

[jira] [Updated] (KAFKA-15529) Flaky test ReassignReplicaShrinkTest.executeTieredStorageTest

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15529: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Flaky test ReassignReplicaShrinkT

[jira] [Updated] (KAFKA-15038) Use topic id/name mapping from the Metadata cache in the RemoteLogManager

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15038: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Use topic id/name mapping from th

[jira] [Commented] (KAFKA-16946) Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port

2024-06-12 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854582#comment-17854582 ] TengYao Chi commented on KAFKA-16946: - Hi [~showuon] , if the issue finder is not wi

[jira] [Updated] (KAFKA-9578) Kafka Tiered Storage - System Tests

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-9578: -- Fix Version/s: 3.9.0 (was: 3.8.0) > Kafka Tiered Storage - System Tests

[jira] [Updated] (KAFKA-15132) Implement disable & re-enablement for Tiered Storage

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15132: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Implement disable & re-enablement

[jira] [Updated] (KAFKA-15376) Explore options of removing data earlier to the current leader's leader epoch lineage for topics enabled with tiered storage.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15376: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Explore options of removing data

[jira] [Updated] (KAFKA-15864) Add more tests asserting the log-start-offset, local-log-start-offset, and HW/LSO/LEO in rolling over segments with tiered storage.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15864: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Add more tests asserting the log-

[jira] [Updated] (KAFKA-15094) Add RemoteIndexCache metrics like misses/evictions/load-failures.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15094: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Add RemoteIndexCache metrics like

[jira] [Updated] (KAFKA-14915) Option to consume multiple partitions that have their data in remote storage for the target offsets.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-14915: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Option to consume multiple partit

[jira] [Updated] (KAFKA-15195) Regenerate segment-aligned producer snapshots when upgrading to a Kafka version supporting Tiered Storage

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15195: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Regenerate segment-aligned produc

[jira] [Updated] (KAFKA-15301) [Tiered Storage] Historically compacted topics send request to remote for active segment during consume

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15301: --- Fix Version/s: 3.9.0 (was: 3.8.0) > [Tiered Storage] Historically com

[jira] [Updated] (KAFKA-15341) Enabling TS for a topic during rolling restart causes problems

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15341: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Enabling TS for a topic during ro

[jira] [Updated] (KAFKA-13355) Shutdown broker eventually when unrecoverable exceptions like IOException encountered in RLMM.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-13355: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Shutdown broker eventually when u

[jira] [Updated] (KAFKA-15969) Align RemoteStorageThreadPool metrics name with KIP-405

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15969: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Align RemoteStorageThreadPool met

[jira] [Updated] (KAFKA-15331) Handle remote log enabled topic deletion when leader is not available

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15331: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Handle remote log enabled topic d

[jira] [Updated] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15388: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Handle topics that were having co

Re: [PR] KAFKA-16917: Align the returned Map type of KafkaAdminClient [kafka]

2024-06-12 Thread via GitHub
frankvicky commented on code in PR #16250: URL: https://github.com/apache/kafka/pull/16250#discussion_r1637320049 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -1988,6 +1989,15 @@ public void testDescribeClientMetricsConfigs() throws E

Re: [PR] KAFKA-16824: Utils.getHost and Utils.getPort do not catch a lot of invalid host and ports. [kafka]

2024-06-12 Thread via GitHub
frankvicky commented on PR #16048: URL: https://github.com/apache/kafka/pull/16048#issuecomment-2164151022 Hi @zhaochun-ma Thanks for your remind 😄 If you have free cycle, it would be nice you could have a PR to fix it -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16824: Utils.getHost and Utils.getPort do not catch a lot of invalid host and ports. [kafka]

2024-06-12 Thread via GitHub
zhaochun-ma commented on PR #16048: URL: https://github.com/apache/kafka/pull/16048#issuecomment-2164138119 > @zhaochun-ma , nice find! I've created [KAFKA-16946](https://issues.apache.org/jira/browse/KAFKA-16946) for this issue. Are you interested in opening a PR to fix it? i haven'

Re: [PR] KAFKA-16862: Refactor ConsumerTaskTest to be deterministic and avoid tight loops [kafka]

2024-06-12 Thread via GitHub
xiaoqingwanga commented on PR #16303: URL: https://github.com/apache/kafka/pull/16303#issuecomment-2164138080 @gharris1727 Thanks for the tip! I'll look into it and tweak the code a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (KAFKA-14877) refactor InMemoryLeaderEpochCheckpoint

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854579#comment-17854579 ] Satish Duggana commented on KAFKA-14877: InMemoryLeaderEpochCheckpoint seems to

[jira] [Resolved] (KAFKA-14877) refactor InMemoryLeaderEpochCheckpoint

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana resolved KAFKA-14877. Resolution: Invalid > refactor InMemoryLeaderEpochCheckpoint > ---

[jira] [Resolved] (KAFKA-16935) Automatically wait for cluster startup in embedded Connect integration tests

2024-06-12 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-16935. --- Resolution: Fixed > Automatically wait for cluster startup in embedded Connect integration t

[jira] [Reopened] (KAFKA-16935) Automatically wait for cluster startup in embedded Connect integration tests

2024-06-12 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reopened KAFKA-16935: --- > Automatically wait for cluster startup in embedded Connect integration tests > ---

[jira] [Updated] (KAFKA-16935) Automatically wait for cluster startup in embedded Connect integration tests

2024-06-12 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-16935: -- Fix Version/s: 3.8.0 > Automatically wait for cluster startup in embedded Connect integration

Re: [PR] KAFKA-16935: Automatically wait for cluster startup in embedded Connect integration tests [kafka]

2024-06-12 Thread via GitHub
C0urante merged PR #16288: URL: https://github.com/apache/kafka/pull/16288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-16947) Kafka Tiered Storage V2

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-16947: --- Fix Version/s: 3.9.0 (was: 3.8.0) > Kafka Tiered Storage V2 > ---

[jira] [Resolved] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2024-06-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-13561. - Resolution: Duplicate > Consider deprecating `StreamsBuilder#build(props)` function > --

[jira] [Updated] (KAFKA-16947) Kafka Tiered Storage V2

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-16947: --- Affects Version/s: (was: 3.6.0) > Kafka Tiered Storage V2 > --- > >

[jira] [Created] (KAFKA-16947) Kafka Tiered Storage V2

2024-06-12 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-16947: -- Summary: Kafka Tiered Storage V2 Key: KAFKA-16947 URL: https://issues.apache.org/jira/browse/KAFKA-16947 Project: Kafka Issue Type: Improvement Affec

[jira] [Commented] (KAFKA-16945) Cleanup StreamsBuilder and TopologyConfig

2024-06-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854578#comment-17854578 ] Matthias J. Sax commented on KAFKA-16945: - I did not look... :P Found https://i

[jira] [Resolved] (KAFKA-16890) Failing to build aux state on broker failover

2024-06-12 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana resolved KAFKA-16890. Resolution: Fixed > Failing to build aux state on broker failover > --

[jira] [Commented] (KAFKA-16925) stream-table join does not immediately forward expired records on restart

2024-06-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17854577#comment-17854577 ] Matthias J. Sax commented on KAFKA-16925: - {quote}My understanding is that the p

Re: [PR] KAFKA-16824: Utils.getHost and Utils.getPort do not catch a lot of invalid host and ports. [kafka]

2024-06-12 Thread via GitHub
showuon commented on PR #16048: URL: https://github.com/apache/kafka/pull/16048#issuecomment-2164106388 @zhaochun-ma , nice find! I've created [KAFKA-16946](https://issues.apache.org/jira/browse/KAFKA-16946) for this issue. Are you interested in opening a PR to fix it? -- This is an auto

  1   2   3   4   >