[jira] [Commented] (KAFKA-17093) KafkaConsumer.seekToEnd should return LSO

2024-07-07 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863672#comment-17863672 ] kangning.li commented on KAFKA-17093: - Another possibility is {{{}apiVersion{}}}. If

Re: [PR] KAFKA-17090: Add reminder to CreateTopicsResult#config for null values of type and documentation [kafka]

2024-07-07 Thread via GitHub
mingyen066 commented on code in PR #16539: URL: https://github.com/apache/kafka/pull/16539#discussion_r1667973081 ## clients/src/main/java/org/apache/kafka/clients/admin/CreateTopicsResult.java: ## @@ -64,6 +64,7 @@ public KafkaFuture all() { * If broker returned an error

[jira] [Commented] (KAFKA-17093) KafkaConsumer.seekToEnd should return LSO

2024-07-07 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863664#comment-17863664 ] kangning.li commented on KAFKA-17093: - I have run it on both the trunk branch and th

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1667968408 ## tools/src/main/java/org/apache/kafka/tools/consumer/TransactionLogMessageFormatter.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] MINOR: Move related getters to RemoteLogManagerConfig [kafka]

2024-07-07 Thread via GitHub
kamalcph commented on PR #16538: URL: https://github.com/apache/kafka/pull/16538#issuecomment-2212967033 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-07 Thread via GitHub
m1a2st commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1667926640 ## tools/src/main/java/org/apache/kafka/tools/consumer/TransactionLogMessageFormatter.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-17061 Improve the performance of isReplicaOnline [kafka]

2024-07-07 Thread via GitHub
ocadaruma commented on PR #16529: URL: https://github.com/apache/kafka/pull/16529#issuecomment-2212926390 @chia7712 Sounds good. The flame graph was taken on our production env, so applying the patch and retest might take time. Let me try reproducing on test env -- This is an automa

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-07 Thread via GitHub
m1a2st commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1667909229 ## build.gradle: ## @@ -2106,6 +2106,8 @@ project(':tools') { implementation project(':server-common') implementation project(':connect:runtime') implemen

Re: [PR] KAFKA-17061 Improve the performance of isReplicaOnline [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on PR #16529: URL: https://github.com/apache/kafka/pull/16529#issuecomment-2212920344 @ocadaruma Could you please update flame graph according to latest commit? It would be nice to see the difference (benefit) introduced by this patch. -- This is an automated message fr

Re: [PR] KAFKA-17090: Add reminder to CreateTopicsResult#config for null values of type and documentation [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on code in PR #16539: URL: https://github.com/apache/kafka/pull/16539#discussion_r1667901856 ## clients/src/main/java/org/apache/kafka/clients/admin/CreateTopicsResult.java: ## @@ -64,6 +64,7 @@ public KafkaFuture all() { * If broker returned an error fo

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1667895877 ## tools/src/main/java/org/apache/kafka/tools/consumer/TransactionLogMessageFormatter.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Minor: Consumer group response should set error msg [kafka]

2024-07-07 Thread via GitHub
ulysses-you commented on PR #16497: URL: https://github.com/apache/kafka/pull/16497#issuecomment-2212785942 thank you @lianetm , addressed comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16955: fix synchronization of streams threadState [kafka]

2024-07-07 Thread via GitHub
mjsax commented on PR #16337: URL: https://github.com/apache/kafka/pull/16337#issuecomment-2212782921 > Oh nevermind, 3.8 release is still ongoing duh. Need to wait for it to finish before backporting this. Yes. Also not sure how severe this one is? Might also be not the end of the w

[jira] [Commented] (KAFKA-13499) Avoid restoring outdated records

2024-07-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863639#comment-17863639 ] Matthias J. Sax commented on KAFKA-13499: - It's been a while since I filed these

[jira] [Assigned] (KAFKA-17085) Streams Cooperative Rebalance Upgrade Test fails in System Tests

2024-07-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-17085: --- Assignee: Matthias J. Sax > Streams Cooperative Rebalance Upgrade Test fails in Sys

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on PR #16019: URL: https://github.com/apache/kafka/pull/16019#issuecomment-2212670744 @m1a2st please take a look at build error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-17092: Revisit `KafkaConsumerTest#testBeginningOffsetsTimeout` for AsyncConsumer [kafka]

2024-07-07 Thread via GitHub
m1a2st commented on PR #16541: URL: https://github.com/apache/kafka/pull/16541#issuecomment-2212635839 It's a good idea, I will do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-07 Thread via GitHub
m1a2st commented on PR #16532: URL: https://github.com/apache/kafka/pull/16532#issuecomment-2212596673 @chia7712, Thanks for your comments, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1667735984 ## tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java: ## @@ -86,652 +85,952 @@ @Tag("integration") @SuppressWarnings("deprecation") // Ad

Re: [PR] KAFKA-16791: Add thread detection to ClusterTestExtensions [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on code in PR #16499: URL: https://github.com/apache/kafka/pull/16499#discussion_r1667734868 ## core/src/test/java/kafka/test/junit/DetectThreadLeak.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r1667732886 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,16 @@ public void testWhenFetchResponseReturnsALeaderShipCh

[jira] [Resolved] (KAFKA-17081) Tweak GroupCoordinatorConfig: re-introduce local attributes and validation

2024-07-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17081. Fix Version/s: 3.9.0 Resolution: Fixed > Tweak GroupCoordinatorConfig: re-introduce

Re: [PR] KAFKA-17081 Tweak GroupCoordinatorConfig: re-introduce local attributes and validation [kafka]

2024-07-07 Thread via GitHub
chia7712 merged PR #16524: URL: https://github.com/apache/kafka/pull/16524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-15773) Group protocol configuration should be validated

2024-07-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-15773: -- Assignee: PoAn Yang > Group protocol configuration should be validated >

Re: [PR] MINOR: Move related getters to RemoteLogManagerConfig [kafka]

2024-07-07 Thread via GitHub
chia7712 merged PR #16538: URL: https://github.com/apache/kafka/pull/16538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Wait all brokers to start running [kafka]

2024-07-07 Thread via GitHub
chia7712 merged PR #16537: URL: https://github.com/apache/kafka/pull/16537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17092: Revisit `KafkaConsumerTest#testBeginningOffsetsTimeout` for AsyncConsumer [kafka]

2024-07-07 Thread via GitHub
chia7712 commented on PR #16541: URL: https://github.com/apache/kafka/pull/16541#issuecomment-2212494290 @m1a2st Thanks for this patch. I know this patch is based on my comments on the jira. However, this patch can has a side effect: the mock time can get advanced even though the response i

Re: [PR] [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool [kafka]

2024-07-07 Thread via GitHub
dongjinleekr closed pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool URL: https://github.com/apache/kafka/pull/10827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool [kafka]

2024-07-07 Thread via GitHub
dongjinleekr commented on PR #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-2212445900 Closes this PR, since [KAFKA-12899](https://issues.apache.org/jira/browse/KAFKA-12899) has been replaced by [KAFKA-17073](https://issues.apache.org/jira/browse/KAFKA-17073). T

[jira] [Resolved] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

2024-07-07 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee resolved KAFKA-12899. - Resolution: Won't Fix Replaced by KAFKA-17073 > Support --bootstrap-server in ReplicaVerificati

[jira] [Commented] (KAFKA-17073) Deprecate ReplicaVerificationTool in 3.9

2024-07-07 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863568#comment-17863568 ] Dongjin Lee commented on KAFKA-17073: - KIP: https://cwiki.apache.org/confluence/page

Re: [PR] KAFKA-16731: Added share group metrics class. [kafka]

2024-07-07 Thread via GitHub
omkreddy merged PR #16488: URL: https://github.com/apache/kafka/pull/16488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Comment Edited] (KAFKA-17044) Connector deletion can lead to resource leak during a long running connector startup

2024-07-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863559#comment-17863559 ] Chris Egerton edited comment on KAFKA-17044 at 7/7/24 11:31 AM: --

[jira] [Comment Edited] (KAFKA-17044) Connector deletion can lead to resource leak during a long running connector startup

2024-07-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863559#comment-17863559 ] Chris Egerton edited comment on KAFKA-17044 at 7/7/24 11:31 AM: --

[jira] [Commented] (KAFKA-17044) Connector deletion can lead to resource leak during a long running connector startup

2024-07-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863559#comment-17863559 ] Chris Egerton commented on KAFKA-17044: --- [~bgoyal] I think you should reconsider t

Re: [PR] KAFKA-10199: Close pending active tasks to init on partitions lost [kafka]

2024-07-07 Thread via GitHub
cadonna commented on code in PR #16545: URL: https://github.com/apache/kafka/pull/16545#discussion_r1667658628 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1233,11 +1233,11 @@ private void closeRunningTasksDirty() { mayb

Re: [PR] KAFKA-10199: Close pending active tasks to init on partitions lost [kafka]

2024-07-07 Thread via GitHub
cadonna commented on code in PR #16545: URL: https://github.com/apache/kafka/pull/16545#discussion_r1667658734 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java: ## @@ -107,6 +108,20 @@ public Set drainPendingTasksToInit() { return result;

[PR] KAFKA-10199: Close pending active tasks to init on partitions lost [kafka]

2024-07-07 Thread via GitHub
cadonna opened a new pull request, #16545: URL: https://github.com/apache/kafka/pull/16545 With enabled state updater tasks that are created but not initialized are stored in a set. In each poll iteration the stream thread drains that set, intializes the tasks, and adds them to the state up

Re: [PR] KAFKA-16943: Synchronously verify Connect worker startup failure in InternalTopicsIntegrationTest [kafka]

2024-07-07 Thread via GitHub
C0urante commented on code in PR #16451: URL: https://github.com/apache/kafka/pull/16451#discussion_r1667658373 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -231,6 +232,8 @@ public class DistributedHerder extends Abs

[PR] KAFKA-17091: Add @FunctionalInterface to Streams interfaces [kafka]

2024-07-07 Thread via GitHub
raymcdermott opened a new pull request, #16544: URL: https://github.com/apache/kafka/pull/16544 ### Goal Add @FunctionalInterface to Streams interfaces to enable Clojure 1.12 (and any other JVM language) to have the correct hints for these SAM interfaces. The Clojure issue is [

[jira] [Commented] (KAFKA-15773) Group protocol configuration should be validated

2024-07-07 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863546#comment-17863546 ] PoAn Yang commented on KAFKA-15773: --- Hi [~pnee], I just created a draft PR [https://g

[PR] KAFKA-15773: Group protocol configuration should be validated [kafka]

2024-07-07 Thread via GitHub
FrankYang0529 opened a new pull request, #16543: URL: https://github.com/apache/kafka/pull/16543 * Add `group.local.assignors` to `ConsumerConfig`. * If `group.protocol` is not `consumer`, set `group.remote.assignor` and `group.local.assignors` as default value. * If both `group.remote

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-07-07 Thread via GitHub
DL1231 commented on PR #15067: URL: https://github.com/apache/kafka/pull/15067#issuecomment-2212355209 @dajac Sorry for the delay, I've updated the PR, PTAL when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-07-07 Thread via GitHub
DL1231 commented on code in PR #15067: URL: https://github.com/apache/kafka/pull/15067#discussion_r1667624742 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-14511: extend AlterIncrementalConfigs API to support group config [kafka]

2024-07-07 Thread via GitHub
DL1231 commented on code in PR #15067: URL: https://github.com/apache/kafka/pull/15067#discussion_r1667624420 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] (KAFKA-17089) Incorrect JWT parsing in OAuthBearerUnsecuredJws

2024-07-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17089 ] 黃竣陽 deleted comment on KAFKA-17089: - was (Author: JIRAUSER305187): Im interesting in this issue, Could you assign to me? > Incorrect JWT parsing in OAuthBearerUnsecuredJws >

[PR] KAFKA-10199: Disable state updater [kafka]

2024-07-07 Thread via GitHub
cadonna opened a new pull request, #16542: URL: https://github.com/apache/kafka/pull/16542 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra