cadonna merged PR #16555:
URL: https://github.com/apache/kafka/pull/16555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2219686370
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
chia7712 commented on code in PR #16559:
URL: https://github.com/apache/kafka/pull/16559#discussion_r1671701623
##
build.gradle:
##
@@ -933,6 +933,8 @@ project(':core') {
implementation project(':raft')
implementation project(':storage')
implementation project(':s
mjsax commented on code in PR #15740:
URL: https://github.com/apache/kafka/pull/15740#discussion_r1671646367
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -796,7 +797,6 @@ public KGroupedStream groupBy(final
KeyValueMapper groupedI
mjsax commented on PR #15740:
URL: https://github.com/apache/kafka/pull/15740#issuecomment-2219658049
Btw: you should rebase your PR. The build failed with `Execution failed for
task ':streams:spotlessJavaCheck'.` due to changes in `trunk` that you should
pickup and fix your PR to make it p
mjsax commented on PR #15740:
URL: https://github.com/apache/kafka/pull/15740#issuecomment-2219637356
One more thing: we should also update `docs/streams/upgrade.html` (just
listing the KIP in the 3.9 upgrade section -- this section might not yet
existing, so just add it for this case) and
mjsax commented on code in PR #15740:
URL: https://github.com/apache/kafka/pull/15740#discussion_r1671666407
##
streams/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java:
##
@@ -439,6 +439,87 @@ public void
shouldPerformSelectKeyWithRepar
mjsax commented on PR #16509:
URL: https://github.com/apache/kafka/pull/16509#issuecomment-2219585448
No. The doc changes just go into `kafka.git` as part of this PR ->
https://github.com/apache/kafka/tree/trunk/docs/streams
`kafka-site.git` will only be updated during the next releas
frankvicky commented on code in PR #16540:
URL: https://github.com/apache/kafka/pull/16540#discussion_r1671577922
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -259,6 +259,7 @@ class KafkaServer(
/* generate brokerId */
config.brokerId = getOrG
frankvicky commented on PR #16540:
URL: https://github.com/apache/kafka/pull/16540#issuecomment-2219496650
Hi @chia7712
I have add some comments to explain why we need to make `nodeId`
synchronizes` with `brokerId`, PTAL 😄
--
This is an automated message from the Apache Git Service.
dujian0068 commented on PR #16509:
URL: https://github.com/apache/kafka/pull/16509#issuecomment-2219468971
> Please don't forget to update the docs (upgrade guide and configs
sections).
Thank you review:
Do you mean the documentation that needs to be updated is in the
https://gith
showuon merged PR #16475:
URL: https://github.com/apache/kafka/pull/16475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #16475:
URL: https://github.com/apache/kafka/pull/16475#issuecomment-2219466595
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon merged PR #16132:
URL: https://github.com/apache/kafka/pull/16132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #16132:
URL: https://github.com/apache/kafka/pull/16132#issuecomment-2219463773
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
[
https://issues.apache.org/jira/browse/KAFKA-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Badai Aqrandista resolved KAFKA-10872.
--
Resolution: Fixed
> Log broker configuration prefixed with "listener.name.*"
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864445#comment-17864445
]
Badai Aqrandista commented on KAFKA-10872:
--
[~ksolves.kafka] Yes, I think we ca
FrankYang0529 commented on code in PR #16543:
URL: https://github.com/apache/kafka/pull/16543#discussion_r1671427972
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -720,6 +721,12 @@ private void maybeOverrideEnableAutoCommit(Map configs) {
FrankYang0529 commented on code in PR #16543:
URL: https://github.com/apache/kafka/pull/16543#discussion_r1671427654
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -720,6 +721,12 @@ private void maybeOverrideEnableAutoCommit(Map configs) {
[
https://issues.apache.org/jira/browse/KAFKA-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-17097:
-
Assignee: PoAn Yang
> Add replace.null.with.default configuration to ValueToKey and ReplaceFiel
FrankYang0529 commented on code in PR #16499:
URL: https://github.com/apache/kafka/pull/16499#discussion_r1671369797
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -119,7 +124,24 @@ public Stream
provideTestTemplateInvocationContex
return gene
FrankYang0529 commented on PR #16426:
URL: https://github.com/apache/kafka/pull/16426#issuecomment-2219033349
> @FrankYang0529 could you please rebase code to trigger CI again? the
hanging is traced by #16541
Yes, rebase it. Thank you.
--
This is an automated message from the Apach
jolshan commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671348779
##
core/src/main/scala/kafka/server/BrokerFeatures.scala:
##
@@ -93,6 +93,9 @@ object BrokerFeatures extends Logging {
feature.latestProduction
TaiJuWu opened a new pull request, #16558:
URL: https://github.com/apache/kafka/pull/16558
…yRecord
*More detailed description of your change,
*Summary of testing strategy (including rationale)
Uint test
### Committer Checklist (excluded from commit message)
- [
cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671320185
##
core/src/main/scala/kafka/server/BrokerFeatures.scala:
##
@@ -93,6 +93,9 @@ object BrokerFeatures extends Logging {
feature.latestProduction
[
https://issues.apache.org/jira/browse/KAFKA-17105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864415#comment-17864415
]
Chris Egerton commented on KAFKA-17105:
---
This likely goes back much further than 3
[
https://issues.apache.org/jira/browse/KAFKA-17105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-17105:
--
Description:
When a connector is created, it may be restarted unnecessarily immediately
after
Chris Egerton created KAFKA-17105:
-
Summary: Unnecessary connector restarts after being newly created
Key: KAFKA-17105
URL: https://issues.apache.org/jira/browse/KAFKA-17105
Project: Kafka
Is
TaiJuWu commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671307567
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -574,7 +574,7 @@ private static Optional
validateRecord(RecordBatch batch,
TaiJuWu commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671301935
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -574,7 +574,7 @@ private static Optional
validateRecord(RecordBatch batch,
chia7712 commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671304389
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -574,7 +574,7 @@ private static Optional
validateRecord(RecordBatch batch,
Chia-Ping Tsai created KAFKA-17104:
--
Summary: InvalidMessageCrcRecordsPerSec is not updated in
validating LegacyRecord
Key: KAFKA-17104
URL: https://issues.apache.org/jira/browse/KAFKA-17104
Project:
[
https://issues.apache.org/jira/browse/KAFKA-17104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17104:
--
Assignee: TaiJuWu (was: Chia-Ping Tsai)
> InvalidMessageCrcRecordsPerSec is not upda
ahuang98 commented on PR #16518:
URL: https://github.com/apache/kafka/pull/16518#issuecomment-2218823079
@jsancio these are the open comments I haven't addressed yet -
https://github.com/apache/kafka/pull/16518#discussion_r1669073620
https://github.com/apache/kafka/pull/16518#discussio
ahuang98 commented on code in PR #16518:
URL: https://github.com/apache/kafka/pull/16518#discussion_r1671302607
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java:
##
@@ -0,0 +1,271 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
chia7712 commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671302401
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -574,7 +574,7 @@ private static Optional
validateRecord(RecordBatch batch,
chia7712 commented on code in PR #16506:
URL: https://github.com/apache/kafka/pull/16506#discussion_r1671289997
##
server/src/main/java/org/apache/kafka/server/config/ShareGroupConfig.java:
##
@@ -100,4 +102,124 @@ public class ShareGroupConfigs {
.define(SHARE_GROU
[
https://issues.apache.org/jira/browse/KAFKA-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864409#comment-17864409
]
Matthias J. Sax commented on KAFKA-17091:
-
I don't now how quickly INFRA team wi
chia7712 commented on code in PR #16543:
URL: https://github.com/apache/kafka/pull/16543#discussion_r1671280195
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -720,6 +721,12 @@ private void maybeOverrideEnableAutoCommit(Map configs) {
[
https://issues.apache.org/jira/browse/KAFKA-17091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864406#comment-17864406
]
Ray McDermott commented on KAFKA-17091:
---
Not to nag (well, OK, to nag) ... will th
TaiJuWu commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671275380
##
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##
@@ -0,0 +1,2228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
TaiJuWu commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671275380
##
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##
@@ -0,0 +1,2228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
chia7712 commented on code in PR #16541:
URL: https://github.com/apache/kafka/pull/16541#discussion_r1671274688
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -3319,11 +3319,20 @@ private KafkaConsumer
consumerForCheckingTimeoutExceptio
chia7712 commented on PR #16426:
URL: https://github.com/apache/kafka/pull/16426#issuecomment-2218765242
@FrankYang0529 could you please rebase code to trigger CI again? the hanging
is traced by #16541
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-17092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864396#comment-17864396
]
Chia-Ping Tsai commented on KAFKA-17092:
our CI is hanging due to this issue
(h
chia7712 commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671259078
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -574,7 +574,7 @@ private static Optional
validateRecord(RecordBatch batch,
chia7712 commented on code in PR #16499:
URL: https://github.com/apache/kafka/pull/16499#discussion_r1671258172
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -119,7 +124,24 @@ public Stream
provideTestTemplateInvocationContex
return generated
TaiJuWu commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671258103
##
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##
@@ -0,0 +1,2177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
TaiJuWu commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1671257869
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -574,7 +574,7 @@ private static Optional
validateRecord(RecordBatch batch,
[
https://issues.apache.org/jira/browse/KAFKA-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sathvik K Basavaraju reassigned KAFKA-17103:
Assignee: (was: Sathvik K Basavaraju)
> MockClient tight loops when n
[
https://issues.apache.org/jira/browse/KAFKA-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sathvik K Basavaraju reassigned KAFKA-17103:
Assignee: Sathvik K Basavaraju
> MockClient tight loops when no metadata
[
https://issues.apache.org/jira/browse/KAFKA-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864387#comment-17864387
]
Sathvik K Basavaraju commented on KAFKA-17103:
--
Hey [~gharris1727], I'd Lik
[
https://issues.apache.org/jira/browse/KAFKA-17103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864380#comment-17864380
]
Greg Harris commented on KAFKA-17103:
-
Also it's possible that there's an existing m
Greg Harris created KAFKA-17103:
---
Summary: MockClient tight loops when no metadata is present in
KafkaProducerTest
Key: KAFKA-17103
URL: https://issues.apache.org/jira/browse/KAFKA-17103
Project: Kafka
junrao commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671054328
##
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##
@@ -49,6 +50,71 @@ public class ApiVersionsResponse extends AbstractResponse {
dongnuo123 commented on code in PR #16511:
URL: https://github.com/apache/kafka/pull/16511#discussion_r1671038322
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java:
##
@@ -993,13 +998,50 @@ public void testCleanupGroupMetadata()
dongnuo123 commented on code in PR #16511:
URL: https://github.com/apache/kafka/pull/16511#discussion_r1671032308
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -575,18 +581,32 @@ public CoordinatorResult deleteOffs
p
cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671032176
##
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##
@@ -45,7 +48,7 @@
]
},
{ "name": "Features", "type": "[]Feature",
-
cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671031307
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overri
cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671030778
##
core/src/test/scala/unit/kafka/server/ApiVersionsResponseIntegrationTest.scala:
##
@@ -0,0 +1,83 @@
+/**
+ * Licensed under the Apache License, Version 2.0 (the "Lic
cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671022232
##
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Overri
cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671020455
##
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##
@@ -45,7 +47,7 @@
"about": "The duration in milliseconds for which the request was
thr
mjsax commented on PR #16556:
URL: https://github.com/apache/kafka/pull/16556#issuecomment-2218390892
Thanks for the PR. Merged to `trunk` and cherry-picked to `3.8` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mjsax merged PR #16556:
URL: https://github.com/apache/kafka/pull/16556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
clolov commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1670963737
##
metadata/src/main/java/org/apache/kafka/metadata/KafkaConfigSchema.java:
##
@@ -166,9 +166,11 @@ public Map
resolveEffectiveTopicConfigs(
ConfigDef configDe
[
https://issues.apache.org/jira/browse/KAFKA-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864318#comment-17864318
]
Chia-Ping Tsai commented on KAFKA-16390:
It seems current issue is that we don't
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864316#comment-17864316
]
Tom Kalmijn edited comment on KAFKA-17093 at 7/9/24 5:53 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864316#comment-17864316
]
Tom Kalmijn commented on KAFKA-17093:
-
By the way, with the addtion of your fix for
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864315#comment-17864315
]
Tom Kalmijn edited comment on KAFKA-17093 at 7/9/24 5:49 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864315#comment-17864315
]
Tom Kalmijn edited comment on KAFKA-17093 at 7/9/24 5:48 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864315#comment-17864315
]
Tom Kalmijn edited comment on KAFKA-17093 at 7/9/24 5:47 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864315#comment-17864315
]
Tom Kalmijn edited comment on KAFKA-17093 at 7/9/24 5:46 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864315#comment-17864315
]
Tom Kalmijn commented on KAFKA-17093:
-
Hi Andrew,Â
Great efforts.Â
My service star
chia7712 commented on PR #16402:
URL: https://github.com/apache/kafka/pull/16402#issuecomment-2218270820
@Nancy-ksolves thanks for this patch. I will take a look later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
[
https://issues.apache.org/jira/browse/KAFKA-13898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864302#comment-17864302
]
Ksolves India Limited commented on KAFKA-13898:
---
[~tombentley] Created PR
cadonna commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2218244902
I will cherry-pick it to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
jlprat commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2218242364
Should this change be done against trunk as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jlprat commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2218239863
Great thanks @cadonna and @mjsax for running the system tests!
This seems to be theatest blocker preventing me to start with the 3.8.0-rc0
generation
--
This is an automated messag
cadonna commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2218234015
Also @mjsax run without failures:
http://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-07-09--001.e7518bfe-1be5-400b-be66-ffb396709f9
mimaison commented on PR #15475:
URL: https://github.com/apache/kafka/pull/15475#issuecomment-2218226588
None of the test failures seem related, merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison merged PR #15475:
URL: https://github.com/apache/kafka/pull/15475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864284#comment-17864284
]
Andrew Schofield commented on KAFKA-17093:
--
[~tkalmijn] I think there's a path
[
https://issues.apache.org/jira/browse/KAFKA-17093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield updated KAFKA-17093:
-
Attachment: Kafka17093-v3.java
> KafkaConsumer.seekToEnd should return LSO
> --
cadonna commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2218155911
No failures:
http://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2024-07-09--001.cd2afbd1-a698-4a7d-9fb1-43d3522bcb60--1720542637--cadonn
m1a2st opened a new pull request, #16557:
URL: https://github.com/apache/kafka/pull/16557
Jira: https://issues.apache.org/jira/browse/KAFKA-17102
The Cache data will return incorrect data, hence we should remove the cache
### Committer Checklist (excluded from commit message)
-
apoorvmittal10 commented on code in PR #16461:
URL: https://github.com/apache/kafka/pull/16461#discussion_r1670739497
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AcknowledgementBatch.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foun
jsancio commented on code in PR #16230:
URL: https://github.com/apache/kafka/pull/16230#discussion_r1670726026
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -192,7 +192,7 @@ class BrokerServer(
logDirFailureChannel = new LogDirFailureChannel(config.logDi
cadonna commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2218109447
> Triggered a system test run for the failing test which exposed this bug:
https://semaphore.ci.confluent.io/workflows/a62d6c5b-e520-46ea-ad52-30fdba03bbd8
Actually, I have already
vinnybod opened a new pull request, #16556:
URL: https://github.com/apache/kafka/pull/16556
When streams/test-utils was added, the javadocs were given an inclusion
filter:
https://github.com/apache/kafka/pull/4402/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R9
mjsax commented on PR #16555:
URL: https://github.com/apache/kafka/pull/16555#issuecomment-2218090799
Triggered a system test run for the failing test which exposed this bug:
https://semaphore.ci.confluent.io/workflows/a62d6c5b-e520-46ea-ad52-30fdba03bbd8
--
This is an automated message f
FrankYang0529 commented on code in PR #16449:
URL: https://github.com/apache/kafka/pull/16449#discussion_r1670789098
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java:
##
@@ -25,62 +25,98 @@
import org.apache.kafka.cl
FrankYang0529 commented on code in PR #16449:
URL: https://github.com/apache/kafka/pull/16449#discussion_r1670787996
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1499,14 +1499,16 @@ public void unsubscribe() {
}
[
https://issues.apache.org/jira/browse/KAFKA-17074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-17074:
---
Fix Version/s: 5.0.0
(was: 4.0.0)
> Remove ReplicaVerificationTool
>
[
https://issues.apache.org/jira/browse/KAFKA-17101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864259#comment-17864259
]
Greg Harris commented on KAFKA-17101:
-
[~kaushik srinivas] Do you have a custom topi
C0urante commented on code in PR #16519:
URL: https://github.com/apache/kafka/pull/16519#discussion_r1670766833
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -927,6 +955,53 @@ private Map baseSourceConnectorConfigs()
[
https://issues.apache.org/jira/browse/KAFKA-17102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17102:
--
Assignee: 黃竣陽 (was: Chia-Ping Tsai)
> FetchRequest#forgottenTopics would return inco
lianetm commented on PR #16449:
URL: https://github.com/apache/kafka/pull/16449#issuecomment-2218046299
Thanks for the updates @FrankYang0529 , left a suggestion for consideration.
Also could you please rebase to trigger the build? Thanks!
--
This is an automated message from the A
lianetm commented on code in PR #16449:
URL: https://github.com/apache/kafka/pull/16449#discussion_r1670733263
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java:
##
@@ -25,62 +25,98 @@
import org.apache.kafka.clients.
[
https://issues.apache.org/jira/browse/KAFKA-17102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864256#comment-17864256
]
黃竣陽 commented on KAFKA-17102:
-
Im interesting in this issue, Could you assign to me, Thanks
lianetm commented on code in PR #16449:
URL: https://github.com/apache/kafka/pull/16449#discussion_r1670733263
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java:
##
@@ -25,62 +25,98 @@
import org.apache.kafka.clients.
1 - 100 of 173 matches
Mail list logo