Shivsundar R created KAFKA-17217:
Summary: Clients : Optimise batching of requests per node in
ShareConsumeRequestManager
Key: KAFKA-17217
URL: https://issues.apache.org/jira/browse/KAFKA-17217
Projec
jlprat commented on PR #16714:
URL: https://github.com/apache/kafka/pull/16714#issuecomment-2257606575
Packages are now in https://kafka-packages.s3.us-west-2.amazonaws.com/
Thanks @cmccabe
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/KAFKA-17137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Chang updated KAFKA-17137:
---
Description:
A number of Admin client APIs don't have integration tests. While testing 3.8.0
RC0 we
[
https://issues.apache.org/jira/browse/KAFKA-17137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Chang updated KAFKA-17137:
---
Description:
A number of Admin client APIs don't have integration tests. While testing 3.8.0
RC0 we
[
https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869536#comment-17869536
]
TengYao Chi commented on KAFKA-17116:
-
Hello folks,
This is a very interesting disc
mjsax commented on code in PR #16725:
URL: https://github.com/apache/kafka/pull/16725#discussion_r1696297327
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##
@@ -203,7 +203,7 @@ public void process(final Record record) {
} cat
mjsax commented on code in PR #16675:
URL: https://github.com/apache/kafka/pull/16675#discussion_r1696289377
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##
@@ -214,9 +214,13 @@ public void process(final Record record) {
mjsax commented on code in PR #16675:
URL: https://github.com/apache/kafka/pull/16675#discussion_r1696289377
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##
@@ -214,9 +214,13 @@ public void process(final Record record) {
mjsax commented on code in PR #16675:
URL: https://github.com/apache/kafka/pull/16675#discussion_r1696289377
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##
@@ -214,9 +214,13 @@ public void process(final Record record) {
mjsax commented on code in PR #16300:
URL: https://github.com/apache/kafka/pull/16300#discussion_r1696286131
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -916,7 +920,17 @@ public void punctuate(final ProcessorNode node,
}
mjsax commented on PR #16433:
URL: https://github.com/apache/kafka/pull/16433#issuecomment-2257434274
Thanks for the PR.
Merged to `trunk` and cherry-picked to `3.9` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
mjsax commented on PR #16432:
URL: https://github.com/apache/kafka/pull/16432#issuecomment-2257434209
Thanks for the PR.
Merged to `trunk` and cherry-picked to `3.9` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
mjsax commented on PR #16716:
URL: https://github.com/apache/kafka/pull/16716#issuecomment-2257425665
Just seeing this PR now. Seems it was already included in the other two PRs
which I just merged. I believe we can close this one?
--
This is an automated message from the Apache Git Servi
mjsax commented on code in PR #16300:
URL: https://github.com/apache/kafka/pull/16300#discussion_r1696256477
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##
@@ -916,7 +920,17 @@ public void punctuate(final ProcessorNode node,
}
highluck commented on PR #15277:
URL: https://github.com/apache/kafka/pull/15277#issuecomment-2257418930
@mimaison
I fixed the conflict thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Nancy-ksolves commented on PR #16402:
URL: https://github.com/apache/kafka/pull/16402#issuecomment-2257413970
Hi @chia7712,
Can you please review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Nancy-ksolves commented on PR #16548:
URL: https://github.com/apache/kafka/pull/16548#issuecomment-2257410972
Hi @mimaison ,
I wanted to inform you that our Confluence account has not been created yet.
we are currently unable to create the KIP (Kafka Improvement Proposal) for
this ticke
philipnee commented on PR #16724:
URL: https://github.com/apache/kafka/pull/16724#issuecomment-2257402065
Hello @rajinisivaram - Here is the PR for the issue for not closing the
login and handler upon LoginException. If you get time, would you be kindly
reviewing this? Thanks!
--
This i
philipnee commented on code in PR #16724:
URL: https://github.com/apache/kafka/pull/16724#discussion_r1696234213
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java:
##
@@ -168,6 +172,11 @@ public String toString() {
", refC
philipnee opened a new pull request, #16724:
URL: https://github.com/apache/kafka/pull/16724
Adding a try-catch in the LoginManager constructor to ensure `Login` and
`AuthenticateCallbackHandler` are closed when login.login() throws an
exception.
--
This is an automated message from the
mjsax commented on PR #16684:
URL: https://github.com/apache/kafka/pull/16684#issuecomment-2257392840
> Got it, should we update KIP-1033 to remove any link with sourceRawKey and
sourceRawValue?
Yes, we should update the KIP accordingly.
> We'll update existing PRs, and open a
mjsax commented on PR #16675:
URL: https://github.com/apache/kafka/pull/16675#issuecomment-2257391601
@sebastienviale -- The PR has merge conflicts and needs to be rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
mjsax commented on code in PR #16432:
URL: https://github.com/apache/kafka/pull/16432#discussion_r1696221005
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java:
##
@@ -80,12 +81,29 @@ public static void handleDeserializationFailure(fina
mjsax merged PR #16432:
URL: https://github.com/apache/kafka/pull/16432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #16433:
URL: https://github.com/apache/kafka/pull/16433#discussion_r1696213764
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##
@@ -285,15 +280,95 @@ public void send(final String topic,
frankvicky opened a new pull request, #16723:
URL: https://github.com/apache/kafka/pull/16723
Currently, the sockets and threads created in
`testInboundConnectionsCountInConnectionCreationMetric` have not been closed,
and this issue needs to be fixed.
### Committer Checklist (exclude
mjsax merged PR #16433:
URL: https://github.com/apache/kafka/pull/16433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
raphaelauv created KAFKA-17216:
--
Summary: StreamsConfig STATE_DIR_CONFIG
Key: KAFKA-17216
URL: https://issues.apache.org/jira/browse/KAFKA-17216
Project: Kafka
Issue Type: Bug
Affects Versio
mjsax commented on code in PR #16433:
URL: https://github.com/apache/kafka/pull/16433#discussion_r1696207479
##
streams/src/test/java/org/apache/kafka/streams/errors/AlwaysContinueProductionExceptionHandler.java:
##
@@ -1,44 +0,0 @@
-/*
- * Licensed to the Apache Software Founda
raphaelauv commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1696207016
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -839,7 +839,8 @@ public class StreamsConfig extends AbstractConfig {
frankvicky commented on PR #1:
URL: https://github.com/apache/kafka/pull/1#issuecomment-2257364095
Hello @chia7712
I have redefine the scope of method, PTAL 😺
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
frankvicky commented on code in PR #16715:
URL: https://github.com/apache/kafka/pull/16715#discussion_r1696187170
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -782,7 +782,8 @@ def prop_file(self, node):
if self.use_new_coordinator:
override_configs[c
[
https://issues.apache.org/jira/browse/KAFKA-17214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869487#comment-17869487
]
Matthias J. Sax commented on KAFKA-17214:
-
As we already have a 3.9 branch, PR f
[
https://issues.apache.org/jira/browse/KAFKA-17214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17214:
Component/s: clients
consumer
core
produ
mjsax opened a new pull request, #16722:
URL: https://github.com/apache/kafka/pull/16722
Browsing through the code base to file
https://issues.apache.org/jira/browse/KAFKA-17215, I saw that these methods
also use `get` prefix, and though might be worth to clean it up.
This is only a
[
https://issues.apache.org/jira/browse/KAFKA-17215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17215:
Description:
Kafka traditionally does not use a `get` prefix for getter methods. However,
[
https://issues.apache.org/jira/browse/KAFKA-17186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
George Yang resolved KAFKA-17186.
-
Resolution: Not A Problem
configuration issues, fixed
> Cannot receive message after stopping S
[
https://issues.apache.org/jira/browse/KAFKA-17186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869474#comment-17869474
]
George Yang commented on KAFKA-17186:
-
OK，[~gharris1727] Thank you for your explana
junrao commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1696094681
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4406,6 +4414,2341 @@ class KafkaApisTest extends Logging {
assertEquals("broker2", node.host)
junrao commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1696066333
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -4406,6 +4414,2341 @@ class KafkaApisTest extends Logging {
assertEquals("broker2", node.host)
junrao commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r169611
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3955,11 +3948,484 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ /**
+ * Handle a
gharris1727 commented on code in PR #16604:
URL: https://github.com/apache/kafka/pull/16604#discussion_r1696102323
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##
@@ -453,4 +457,58 @@ private static class DirectoryEntry {
[
https://issues.apache.org/jira/browse/KAFKA-17215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17215:
Description:
Kafka traditionally does not use a `get` prefix for getter methods. However,
[
https://issues.apache.org/jira/browse/KAFKA-17215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17215:
Description:
Kafka traditionally does not use a `get` prefix for getter methods. However,
[
https://issues.apache.org/jira/browse/KAFKA-17186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869468#comment-17869468
]
Greg Harris commented on KAFKA-17186:
-
I don't think i've ever thought about it like
Matthias J. Sax created KAFKA-17215:
---
Summary: Remove get-prefix for all getters
Key: KAFKA-17215
URL: https://issues.apache.org/jira/browse/KAFKA-17215
Project: Kafka
Issue Type: Improveme
[
https://issues.apache.org/jira/browse/KAFKA-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17211:
--
Component/s: producer
> kafka producer get stuck by Uncaught error in kafka producer I/O thread
> ---
[
https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869467#comment-17869467
]
Kirk True commented on KAFKA-17116:
---
My understanding is:
# This is an edge case
# T
kirktrue commented on code in PR #16703:
URL: https://github.com/apache/kafka/pull/16703#discussion_r1696033289
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2491,7 +2508,8 @@ public void testCurrentLag(GroupProtocol groupProtocol) {
k0b3rIT commented on PR #16678:
URL: https://github.com/apache/kafka/pull/16678#issuecomment-2257117723
> Thanks @k0b3rIT! Looks good for the most part, just one small comment
request. Can you also add a description for the changes to your PR (where the
"_More detailed description of your c
k0b3rIT commented on code in PR #16678:
URL: https://github.com/apache/kafka/pull/16678#discussion_r1696031526
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1648,9 +1648,13 @@ public static Map
entriesWithPrefix(Map map, String pr
* @param th
[
https://issues.apache.org/jira/browse/KAFKA-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16390:
--
Component/s: clients
> consume_bench_test.py failed using AsyncKafkaConsumer
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869464#comment-17869464
]
Kirk True commented on KAFKA-16390:
---
[~frankvicky] transferring the Jira to you and ma
[
https://issues.apache.org/jira/browse/KAFKA-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16390:
-
Assignee: TengYao Chi (was: Kirk True)
> consume_bench_test.py failed using AsyncKafkaConsumer
kirktrue commented on code in PR #16334:
URL: https://github.com/apache/kafka/pull/16334#discussion_r1696026161
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -138,11 +138,11 @@ public class MembershipManagerImpl implements
bbejeck opened a new pull request, #16721:
URL: https://github.com/apache/kafka/pull/16721
Flaky test - seems there could be a race condition with timeouts in this
test, I've reduced the pauses at various points in the test to speed it up and
see if that helps with flakyness
gharris1727 commented on code in PR #15598:
URL: https://github.com/apache/kafka/pull/15598#discussion_r1695952150
##
clients/src/test/java/org/apache/kafka/common/utils/MockExit.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
gharris1727 commented on PR #15598:
URL: https://github.com/apache/kafka/pull/15598#issuecomment-2257077548
> One higher-level thought I had: is it better to keep all of this new logic
in the existing Exit class, or would it make sense to separate the two? IMO the
final state we work toward
gharris1727 commented on code in PR #15598:
URL: https://github.com/apache/kafka/pull/15598#discussion_r1695995911
##
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##
@@ -119,4 +134,138 @@ public static void resetHaltProcedure() {
public static void resetSh
gharris1727 commented on code in PR #15598:
URL: https://github.com/apache/kafka/pull/15598#discussion_r1695952150
##
clients/src/test/java/org/apache/kafka/common/utils/MockExit.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
cmccabe commented on code in PR #16672:
URL: https://github.com/apache/kafka/pull/16672#discussion_r1695820312
##
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##
@@ -14,451 +14,506 @@
* See the License for the specific language governing permission
cmccabe commented on code in PR #16672:
URL: https://github.com/apache/kafka/pull/16672#discussion_r1695816959
##
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##
@@ -14,451 +14,506 @@
* See the License for the specific language governing permission
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1695813884
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -568,7 +570,11 @@ public void transitionToFenced() {
public
[
https://issues.apache.org/jira/browse/KAFKA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17209:
--
Labels: kip-848-client-support (was: )
> Revisit testCurrentLag for AsyncKafkaConsumer
>
[
https://issues.apache.org/jira/browse/KAFKA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-17209:
--
Component/s: clients
unit tests
> Revisit testCurrentLag for AsyncKafkaConsumer
> ---
lianetm commented on PR #16720:
URL: https://github.com/apache/kafka/pull/16720#issuecomment-2256827278
Hey @chia7712 , here's the fix for the log with/without member ID on
`transitionToFatal` (applied generally to cover us in all logs). Could you take
a look when you have a chance? Thanks!
jolshan opened a new pull request, #16719:
URL: https://github.com/apache/kafka/pull/16719
WIP
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including up
jolshan commented on PR #16443:
URL: https://github.com/apache/kafka/pull/16443#issuecomment-2256803549
I will probably just include this in 4.0 so we can drop the ZK support as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
omkreddy merged PR #16711:
URL: https://github.com/apache/kafka/pull/16711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mjsax merged PR #16701:
URL: https://github.com/apache/kafka/pull/16701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869447#comment-17869447
]
David Arthur commented on KAFKA-16883:
--
Thanks for confirming your success hre [~ni
[
https://issues.apache.org/jira/browse/KAFKA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur closed KAFKA-16883.
> Zookeeper-Kraft failing migration - RPC got timed out before it could be sent
>
mjsax commented on PR #16710:
URL: https://github.com/apache/kafka/pull/16710#issuecomment-2256762537
Re-triggered Jenkins to make sure...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/KAFKA-17146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869445#comment-17869445
]
David Arthur commented on KAFKA-17146:
--
[~saimon46] thanks for the report.
> More
jsancio merged PR #16637:
URL: https://github.com/apache/kafka/pull/16637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-15522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-15522.
---
Resolution: Fixed
> Flaky test
> org.apache.kafka.connect.mirror.integration.MirrorConnecto
[
https://issues.apache.org/jira/browse/KAFKA-15522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869429#comment-17869429
]
Chris Egerton commented on KAFKA-15522:
---
We haven't seen this failure in a while a
Josep Prat created KAFKA-17214:
--
Summary: Add 3.8.0 Streams and Core to system tests
Key: KAFKA-17214
URL: https://issues.apache.org/jira/browse/KAFKA-17214
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-17213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat updated KAFKA-17213:
---
Fix Version/s: (was: 3.8.0)
> Change ControllerMovedException from ApiException to InvalidMetada
chia7712 commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1695624583
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -568,7 +570,11 @@ public void transitionToFenced() {
public
lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1695597540
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -568,7 +570,11 @@ public void transitionToFenced() {
public
chia7712 commented on code in PR #16646:
URL: https://github.com/apache/kafka/pull/16646#discussion_r1695591590
##
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##
@@ -494,4 +473,60 @@ public void onCompletion(RecordMetadata metadata,
Exception exception)
[
https://issues.apache.org/jira/browse/KAFKA-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-17202.
Fix Version/s: 3.9.0
Resolution: Fixed
> EosIntegrationTest.verifyChangelogMaxRecor
chia7712 merged PR #16702:
URL: https://github.com/apache/kafka/pull/16702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
bbejeck commented on PR #16710:
URL: https://github.com/apache/kafka/pull/16710#issuecomment-2256448024
Test failures are unrelated, but it seems build 21 didn't run - so it may be
worth running again, but it's up to you.
--
This is an automated message from the Apache Git Service.
To res
chia7712 commented on code in PR #16661:
URL: https://github.com/apache/kafka/pull/16661#discussion_r1695547956
##
core/src/test/java/kafka/testkit/KafkaClusterThreadFactory.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869406#comment-17869406
]
Volk Huang commented on KAFKA-4928:
---
[~chia7712] No problem, thank you for the tips!
>
chia7712 commented on PR #16661:
URL: https://github.com/apache/kafka/pull/16661#issuecomment-2256415831
@FrankYang0529 please update related jiras if you try to fix them in this
single PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
chia7712 commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1695540825
##
core/src/test/java/kafka/testkit/TestKitNodes.java:
##
@@ -216,4 +218,90 @@ public ListenerName externalListenerName() {
public ListenerName controllerListener
chia7712 commented on PR #16712:
URL: https://github.com/apache/kafka/pull/16712#issuecomment-2256403019
@popsunlake thanks for this patch. I will take a look tomorrow :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869400#comment-17869400
]
Chia-Ping Tsai commented on KAFKA-4928:
---
[~soravolk] I have assigned this jira to y
[
https://issues.apache.org/jira/browse/KAFKA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-4928:
-
Assignee: Volk Huang
> Add integration test for DumpLogSegments
> --
[
https://issues.apache.org/jira/browse/KAFKA-17201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17201:
--
Assignee: TengYao Chi
> SelectorTest.testInboundConnectionsCountInConnectionCreationM
[
https://issues.apache.org/jira/browse/KAFKA-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869399#comment-17869399
]
Volk Huang commented on KAFKA-4928:
---
Hi [~ijuma], can I try this one? Thank you so much
[
https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869396#comment-17869396
]
Chia-Ping Tsai commented on KAFKA-17116:
[~dajac] thanks for sharing the idea an
gharris1727 commented on code in PR #15598:
URL: https://github.com/apache/kafka/pull/15598#discussion_r1695512242
##
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##
@@ -55,22 +55,37 @@ public interface ShutdownHookAdder {
private static volatile Procedure
gharris1727 commented on code in PR #15598:
URL: https://github.com/apache/kafka/pull/15598#discussion_r1695510458
##
clients/src/test/java/org/apache/kafka/common/utils/MockExit.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
C0urante commented on code in PR #15598:
URL: https://github.com/apache/kafka/pull/15598#discussion_r1695447336
##
clients/src/test/java/org/apache/kafka/common/utils/MockExit.java:
##
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
lianetm commented on code in PR #16715:
URL: https://github.com/apache/kafka/pull/16715#discussion_r1695486461
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -782,7 +782,8 @@ def prop_file(self, node):
if self.use_new_coordinator:
override_configs[conf
chia7712 commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1695461084
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -568,7 +570,11 @@ public void transitionToFenced() {
public
1 - 100 of 170 matches
Mail list logo
