chia7712 commented on PR #16753:
URL: https://github.com/apache/kafka/pull/16753#issuecomment-2267355346
overall LGTM. hope CI love this PR :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chia7712 commented on code in PR #16753:
URL: https://github.com/apache/kafka/pull/16753#discussion_r1703070893
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -1196,16 +1196,31 @@ private long maybeDrainPendingCalls(long now) {
FrankYang0529 commented on code in PR #16753:
URL: https://github.com/apache/kafka/pull/16753#discussion_r1703070720
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -1196,16 +1196,31 @@ private long maybeDrainPendingCalls(long now) {
FrankYang0529 commented on code in PR #16753:
URL: https://github.com/apache/kafka/pull/16753#discussion_r1703070639
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -1196,16 +1196,31 @@ private long maybeDrainPendingCalls(long now) {
[
https://issues.apache.org/jira/browse/KAFKA-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870804#comment-17870804
]
Chia-Ping Tsai commented on KAFKA-17224:
for another, please update the index pa
[
https://issues.apache.org/jira/browse/KAFKA-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870803#comment-17870803
]
Chia-Ping Tsai commented on KAFKA-17224:
[~brandboat] Please feel free to start
[
https://issues.apache.org/jira/browse/KAFKA-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870802#comment-17870802
]
Kuan Po Tseng commented on KAFKA-17224:
---
gentle ping [~mjsax] , I just filed KIP-1
chia7712 commented on code in PR #16687:
URL: https://github.com/apache/kafka/pull/16687#discussion_r1703061733
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -94,6 +95,26 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrati
chia7712 commented on code in PR #16753:
URL: https://github.com/apache/kafka/pull/16753#discussion_r1703058596
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -1196,16 +1196,31 @@ private long maybeDrainPendingCalls(long now) {
frankvicky commented on code in PR #16767:
URL: https://github.com/apache/kafka/pull/16767#discussion_r1703056882
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -136,10 +137,14 @@ public List> taskConfigs(int
maxTasks) {
[
https://issues.apache.org/jira/browse/KAFKA-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870801#comment-17870801
]
Chia-Ping Tsai commented on KAFKA-17256:
nice finding!
> KRAFT should honor the
Hongten commented on code in PR #16767:
URL: https://github.com/apache/kafka/pull/16767#discussion_r1703049918
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -136,10 +137,14 @@ public List> taskConfigs(int
maxTasks) {
unknowntpo commented on code in PR #16687:
URL: https://github.com/apache/kafka/pull/16687#discussion_r1703045072
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -94,6 +94,59 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegra
FrankYang0529 commented on PR #16783:
URL: https://github.com/apache/kafka/pull/16783#issuecomment-2267326163
@brandboat, I think we also need to update L296-297 in GetOffsetShell
```
throw new TerseException("Malformed time argument " + listOffsetsTimestamp +
". " +
[
https://issues.apache.org/jira/browse/KAFKA-17258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870800#comment-17870800
]
PoAn Yang commented on KAFKA-17258:
---
Yes, assign to you. Thanks.
> Migrate AdminFence
[
https://issues.apache.org/jira/browse/KAFKA-17258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-17258:
-
Assignee: Ming-Yen Chung (was: PoAn Yang)
> Migrate AdminFenceProducersIntegrationTest to Clus
[
https://issues.apache.org/jira/browse/KAFKA-17258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870799#comment-17870799
]
Ming-Yen Chung commented on KAFKA-17258:
Hi PoAn could you assign this ticket to
[
https://issues.apache.org/jira/browse/KAFKA-17258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-17258:
-
Assignee: PoAn Yang
> Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions frame
PoAn Yang created KAFKA-17258:
-
Summary: Migrate AdminFenceProducersIntegrationTest to
ClusterTestExtensions framework
Key: KAFKA-17258
URL: https://issues.apache.org/jira/browse/KAFKA-17258
Project: Kafk
PoAn Yang created KAFKA-17257:
-
Summary: Migrate BrokerApiVersionsCommandTest to
ClusterTestExtensions
Key: KAFKA-17257
URL: https://issues.apache.org/jira/browse/KAFKA-17257
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng updated KAFKA-17256:
--
Description:
see [https://github.com/apache/kafka/pull/16783#discussion_r1702847984m]
if we se
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1703026420
##
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java:
##
@@ -73,18 +73,20 @@ public static OffsetSpec maxTimestamp() {
}
/**
- * Us
FrankYang0529 commented on PR #16752:
URL: https://github.com/apache/kafka/pull/16752#issuecomment-2267289794
Yes, please update in this PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Kuan Po Tseng created KAFKA-17256:
-
Summary: KRAFT should honor the listener name and security
protocol from ClusterConfig
Key: KAFKA-17256
URL: https://issues.apache.org/jira/browse/KAFKA-17256
Proje
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1703013614
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,75 @@ private String getTopicName(int i) {
return "topic" + i;
}
bboyleonp666 commented on PR #16752:
URL: https://github.com/apache/kafka/pull/16752#issuecomment-2267277272
@FrankYang0529 That looks like a great idea. Shall we open a new issue and
PR for this one?
I'd like it to be done in this one since it seems they are highly related.
WDYT?
--
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1703000666
##
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java:
##
@@ -73,18 +73,20 @@ public static OffsetSpec maxTimestamp() {
}
/**
- * Us
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1703000636
##
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java:
##
@@ -73,18 +73,20 @@ public static OffsetSpec maxTimestamp() {
}
/**
- * Us
FrankYang0529 commented on code in PR #16753:
URL: https://github.com/apache/kafka/pull/16753#discussion_r1703000565
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -1196,16 +1196,24 @@ private long maybeDrainPendingCalls(long now) {
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702999054
##
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java:
##
@@ -73,18 +73,20 @@ public static OffsetSpec maxTimestamp() {
}
/**
- * Us
bboyleonp666 commented on PR #16752:
URL: https://github.com/apache/kafka/pull/16752#issuecomment-2267273503
> Hi @bboyleonp666, I found some packages are still using
`KafkaMetricsGroup#explicitMetricName`. I think we can refactor them and maybe
update the function as private. WDYT? cc @chi
bboyleonp666 closed pull request #16752: KAFKA-17222: Remove the subclass of
KafkaMetricsGroup
URL: https://github.com/apache/kafka/pull/16752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/KAFKA-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870785#comment-17870785
]
Matthias J. Sax commented on KAFKA-17253:
-
Sure. No need to asked :)
> Remove l
[
https://issues.apache.org/jira/browse/KAFKA-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-17253:
---
Assignee: TengYao Chi
> Remove leaking getter methods in Joined helper class
>
PoAn Yang created KAFKA-17255:
-
Summary: Migrate ListOffsetsIntegrationTest to
ClusterTestExtensions framework
Key: KAFKA-17255
URL: https://issues.apache.org/jira/browse/KAFKA-17255
Project: Kafka
frankvicky commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2267228317
Cool
I will resolve the conflict after 3.9 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
FrankYang0529 commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702947419
##
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java:
##
@@ -73,18 +73,20 @@ public static OffsetSpec maxTimestamp() {
}
/**
-
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Component/s: admin
> Kafka Server/CLI no longer respects log4j.properties/tools-log4j.prop
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Component/s: logging
> Kafka Server/CLI no longer respects log4j.properties/tools-log4j.pr
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Description:
Kafka CLI tools and Kafka server for that matter no longer seem to respect
*
Krishna V Reddy created KAFKA-17254:
---
Summary: Kafka Server/CLI no longer respects
tools-log4j.properties file
Key: KAFKA-17254
URL: https://issues.apache.org/jira/browse/KAFKA-17254
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Summary: Kafka Server/CLI no longer respects
log4j.properties/tools-log4j.properties file
[
https://issues.apache.org/jira/browse/KAFKA-17254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna V Reddy updated KAFKA-17254:
Affects Version/s: 3.8.0
> Kafka Server/CLI no longer respects log4j.properties/tools-log4
[
https://issues.apache.org/jira/browse/KAFKA-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870777#comment-17870777
]
TengYao Chi commented on KAFKA-17253:
-
Hello [~mjsax]
I would like to have this is
chia7712 commented on code in PR #16753:
URL: https://github.com/apache/kafka/pull/16753#discussion_r1702879494
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -1196,16 +1196,24 @@ private long maybeDrainPendingCalls(long now) {
mjsax commented on PR #16745:
URL: https://github.com/apache/kafka/pull/16745#issuecomment-2267129634
Merged to `trunk` and cherry-picked to `3.9` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chia7712 commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702865629
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,80 @@ private String getTopicName(int i) {
return "topic" + i;
}
mjsax merged PR #16745:
URL: https://github.com/apache/kafka/pull/16745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702865347
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,75 @@ private String getTopicName(int i) {
return "topic" + i;
}
[
https://issues.apache.org/jira/browse/KAFKA-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17253:
Description:
The helper class `Joined` has four getter methods `gracePeriod()`,
`keySerde
[
https://issues.apache.org/jira/browse/KAFKA-17253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-17253:
Description:
The helper class `Joined` has three getter methods `keySerde()`, `valueSerde(
Matthias J. Sax created KAFKA-17253:
---
Summary: Remove leaking getter methods in Joined helper class
Key: KAFKA-17253
URL: https://issues.apache.org/jira/browse/KAFKA-17253
Project: Kafka
Is
chia7712 merged PR #16627:
URL: https://github.com/apache/kafka/pull/16627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16390:
---
Fix Version/s: 3.9.0
> consume_bench_test.py failed using AsyncKafkaConsumer
> -
[
https://issues.apache.org/jira/browse/KAFKA-17238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870767#comment-17870767
]
Chia-Ping Tsai commented on KAFKA-17238:
[~frankvicky] I will take a look at thi
chia7712 commented on PR #16775:
URL: https://github.com/apache/kafka/pull/16775#issuecomment-2267095271
@frankvicky see the comment on the jira, and I will take a look at this PR
after 3.9.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chia7712 commented on PR #16691:
URL: https://github.com/apache/kafka/pull/16691#issuecomment-2267093161
@brenden20 Could you please fix the import order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chia7712 merged PR #16720:
URL: https://github.com/apache/kafka/pull/16720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702847984
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,75 @@ private String getTopicName(int i) {
return "topic" + i;
}
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702848944
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -274,6 +333,45 @@ public void testGetOffsetsByMaxTimestamp() {
}
}
+@
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702848769
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,75 @@ private String getTopicName(int i) {
return "topic" + i;
}
C0urante opened a new pull request, #16788:
URL: https://github.com/apache/kafka/pull/16788
[Jira](https://issues.apache.org/jira/browse/KAFKA-17252)
With the current session key tracking logic on trunk, there's a small chance
that a herder may not updated its [sessionKey
field](http
C0urante commented on PR #16788:
URL: https://github.com/apache/kafka/pull/16788#issuecomment-2267065241
Opening as a draft for now to see what CI thinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702847984
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,75 @@ private String getTopicName(int i) {
return "topic" + i;
}
[
https://issues.apache.org/jira/browse/KAFKA-17252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870747#comment-17870747
]
Chris Egerton commented on KAFKA-17252:
---
Note that this same issue (failure to for
[
https://issues.apache.org/jira/browse/KAFKA-17246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870735#comment-17870735
]
PoAn Yang commented on KAFKA-17246:
---
Hi [~mimaison], I have an idea for this:
# If
FrankYang0529 commented on PR #16752:
URL: https://github.com/apache/kafka/pull/16752#issuecomment-2266750492
Hi @bboyleonp666, I found some packages are still using
`KafkaMetricsGroup#explicitMetricName`. I think we can refactor them and maybe
update the function as private. WDYT? cc @chia
kamalcph commented on PR #16602:
URL: https://github.com/apache/kafka/pull/16602#issuecomment-2266719358
@showuon @clolov
Is it possible to give this PR an early review to keep it in good shape?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
kamalcph commented on code in PR #16765:
URL: https://github.com/apache/kafka/pull/16765#discussion_r1702764279
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -4188,11 +4188,77 @@ class UnifiedLogTest {
assertEquals(1, log.logSegments.size)
}
+ @Tes
kamalcph commented on code in PR #16765:
URL: https://github.com/apache/kafka/pull/16765#discussion_r1702764279
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -4188,11 +4188,77 @@ class UnifiedLogTest {
assertEquals(1, log.logSegments.size)
}
+ @Tes
kamalcph commented on code in PR #16765:
URL: https://github.com/apache/kafka/pull/16765#discussion_r1702764279
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -4188,11 +4188,77 @@ class UnifiedLogTest {
assertEquals(1, log.logSegments.size)
}
+ @Tes
kamalcph commented on code in PR #16765:
URL: https://github.com/apache/kafka/pull/16765#discussion_r1702764279
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -4188,11 +4188,77 @@ class UnifiedLogTest {
assertEquals(1, log.logSegments.size)
}
+ @Tes
kamalcph commented on code in PR #16765:
URL: https://github.com/apache/kafka/pull/16765#discussion_r1702757466
##
core/src/test/scala/unit/kafka/log/LogTestUtils.scala:
##
@@ -68,7 +69,9 @@ object LogTestUtils {
indexIntervalBytes: Int =
ServerLogConfigs
showuon commented on PR #16765:
URL: https://github.com/apache/kafka/pull/16765#issuecomment-2266700401
@kamalcph @clolov @satishd , please help take a look for this final piece of
KIP-950 KRaft part. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to th
[
https://issues.apache.org/jira/browse/KAFKA-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16855.
---
Fix Version/s: 3.9.0
Resolution: Fixed
> KRaft - Wire replaying a TopicRecord
> -
[
https://issues.apache.org/jira/browse/KAFKA-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16855:
-
Assignee: Luke Chen (was: Muralidhar Basani)
> KRaft - Wire replaying a TopicRecord
>
[
https://issues.apache.org/jira/browse/KAFKA-17245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-17245.
---
Fix Version/s: 3.9.0
Resolution: Fixed
> revert topicRecord changes
> ---
showuon merged PR #16780:
URL: https://github.com/apache/kafka/pull/16780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702701568
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,75 @@ private String getTopicName(int i) {
return "topic" + i;
}
brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702631822
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -416,7 +514,7 @@ private List expectedOffsetsForTopic(int i) {
private List execut
showuon commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702631437
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -416,7 +514,7 @@ private List expectedOffsetsForTopic(int i) {
private List executeA
showuon commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1702632108
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -70,31 +85,75 @@ private String getTopicName(int i) {
return "topic" + i;
}
brandboat commented on PR #16783:
URL: https://github.com/apache/kafka/pull/16783#issuecomment-2266642180
>Overall LGTM! We need integration tests for it. We should add some test
like DeleteTopicTest using ExpectListOffsetsAction. I expected it should work
like this (I didn't try):
T
clolov merged PR #16653:
URL: https://github.com/apache/kafka/pull/16653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17870677#comment-17870677
]
Chia-Ping Tsai commented on KAFKA-17250:
KAFKA-16390 should fix a lot of them.
[
https://issues.apache.org/jira/browse/KAFKA-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-17250:
--
Assignee: Chia-Ping Tsai
> Many system tests failing with
> org.apache.kafka.common.
93 matches
Mail list logo
